zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix presubmit check for webrtc/base.

Browse Source 
Show a warning only when there's something to warn about.

TBR=kjellander@webrtc.org
NOTRY=True
BUG=webrtc:7634

Review-Url: https://codereview.webrtc.org/2974093002
Cr-Commit-Position: refs/heads/master@{#18952}
This commit is contained in:
ehmaldonado
2017-07-10 07:04:10 -07:00
committed by Commit Bot
parent ea0e08400c
commit fe53355dcb
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
PRESUBMIT.py
View File

@ -522,10 +522,12 @@ def _CheckNoChangesToWebRTCBase(input_api, output_api):
if 'webrtc/base' in line: if 'webrtc/base' in line:
problems.append(' %s: %s' % (f.LocalPath(), line_num)) problems.append(' %s: %s' % (f.LocalPath(), line_num))
return [output_api.PresubmitPromptWarning( if problems:
'webrtc/base is being moved to webrtc/rtc_base (See ' return [output_api.PresubmitPromptWarning(
'bugs.webrtc.org/7634). Please refer to webrtc/rtc_base instead in the ' 'webrtc/base is being moved to webrtc/rtc_base (See '
'following files:\n' + '\n'.join(problems))] 'bugs.webrtc.org/7634). Please refer to webrtc/rtc_base instead in the '
'following files:\n' + '\n'.join(problems))]
return []
def _CommonChecks(input_api, output_api): def _CommonChecks(input_api, output_api):