zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prevent sender RTCP signals for receive-only channels.

Browse Source 
Since RTCP packets are delivered to both senders and receivers that
correspond the receivers currently log that NACKed packets are missing,
since they have no direct connection to the sending side or the RTP
packet history. Also preventing triggering on SR requests and PLI/FIR.

BUG=
R=asapersson@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/45249004

Cr-Commit-Position: refs/heads/master@{#9071}
This commit is contained in:
Peter Boström
2015-04-23 17:53:17 +02:00
parent 7f287cca67
commit fe7a80c38c
8 changed files with 29 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
webrtc/modules/rtp_rtcp/source/rtcp_receiver.h
View File

@ -31,6 +31,7 @@ class RTCPReceiver : public TMMBRHelp
public:
RTCPReceiver(int32_t id,
Clock* clock,
bool receiver_only,
RtcpPacketTypeCounterObserver* packet_type_counter_observer,
RtcpBandwidthObserver* rtcp_bandwidth_observer,
RtcpIntraFrameObserver* rtcp_intra_frame_observer,
@ -231,7 +232,8 @@ protected:
uint32_t remote_ssrc, uint32_t source_ssrc) const
EXCLUSIVE_LOCKS_REQUIRED(_criticalSectionRTCPReceiver);
Clock* _clock;
Clock* const _clock;
const bool receiver_only_;
RTCPMethod _method;
int64_t _lastReceived;
ModuleRtpRtcpImpl& _rtpRtcp;