zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete the "initialize" method of PeerConnectionFactory

Browse Source 
Also remove the "initialized" concept from ConnectionContext.

This CL also always creates the objects on the signaling thread.
Makes the initialization code slightly more readable.

Bug: webrtc:11967
Change-Id: I5e451a3c5225c29c30d32bb4843df8c107ec30c0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/188626
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32453}
This commit is contained in:
Harald Alvestrand
2020-10-20 15:35:31 +00:00
committed by Commit Bot
parent 42aab25b7f
commit ffd5dc70eb
7 changed files with 162 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pc/peer_connection_interface_unittest.cc
View File

@ -699,7 +699,6 @@ class PeerConnectionInterfaceBaseTest : public ::testing::Test {
ASSERT_TRUE(pc_factory_);
pc_factory_for_test_ =
PeerConnectionFactoryForTest::CreatePeerConnectionFactoryForTest();
pc_factory_for_test_->Initialize();
}
void CreatePeerConnection() {
@ -3923,7 +3922,6 @@ class PeerConnectionMediaConfigTest : public ::testing::Test {
protected:
void SetUp() override {
pcf_ = PeerConnectionFactoryForTest::CreatePeerConnectionFactoryForTest();
pcf_->Initialize();
}
const cricket::MediaConfig TestCreatePeerConnection(
const RTCConfiguration& config) {