Commit Graph

35 Commits

Author SHA1 Message Date
e81b62be04 Add OWNERS file for webrtc
Also remove OWNERS in third_party/abseil-cpp

Test: Review
Change-Id: Idef225d3fe2159cb28b28f8eff500807d2ec82d5
2020-10-29 11:47:16 -07:00
d1c647242a Merge branch 'upstream-master'
Bug: 153469641
Test: none
Change-Id: Ic33e363deb0d1ac4bb4d57c3c239eb2e45370802
Merged-In: Ic33e363deb0d1ac4bb4d57c3c239eb2e45370802
2020-07-20 17:28:31 -07:00
7bd282acce Remove phoglund as root owner.
Patrik is leaving the company.

Bug: None
Change-Id: I38bd5b524c16f0ea7ff3f2686b255b725ea5d676
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172080
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30939}
2020-03-30 12:15:56 +00:00
d46d1e9a2f Add #COMPONENT to WebRTC.
This associates WebRTC with the right bug component in Chromium.

No-Try: True
Bug: chromium:977050
Change-Id: I0ab5707fbd70558b08c69cbf1200f16898038d07
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156080
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29402}
2019-10-08 12:20:39 +00:00
b50d995a5b Add juberti@ to webrtc root owners
It's useful to have someone in PST timezone with root approval.

Bug: webrtc:10638
Change-Id: I9453c6bca3b77879c0c893bff8ca1abb6db5ab2a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137182
Reviewed-by: Justin Uberti <juberti@google.com>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Magnus Flodman <mflodman@webrtc.org>
Commit-Queue: Anton Sukhanov <sukhanov@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27977}
2019-05-17 18:11:58 +00:00
870d85c305 Removing niklas.enbom@webrtc.org from WATCHLIST and OWNERS
Change-Id: Ie6740e5eac95ccd358cd558a106b166e7bd15d49

BUG=None
TBR=tommi@webrtc.org

Change-Id: Ie6740e5eac95ccd358cd558a106b166e7bd15d49
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133802
Commit-Queue: Niklas Enbom <niklas.enbom@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Reviewed-by: Niklas Enbom <niklas.enbom@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27720}
2019-04-23 14:51:24 +00:00
72467209a8 Clean up root OWNERS.
Remove some redundant lines and Tina who has left the project :(

Bug: None
Change-Id: I8a8cba3c2b13d93e668754fbe6b06daa09095534
Notry: true
Reviewed-on: https://webrtc-review.googlesource.com/c/110503
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25583}
2018-11-09 14:23:59 +00:00
c3af97d68c Add a list of allowed and disallowed Abseil things
Bug: webrtc:8821
Change-Id: Ifb3bacd3403bbf823c78fff47571a83159f1da73
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/95880
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24437}
2018-08-27 08:37:20 +00:00
b23db026d7 Add mbonadei@ to build configs OWNERS.
Bug: None
Change-Id: I40f312fd57c210e68e2cd74e99c63e4a01a4268f
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/84282
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23684}
2018-06-20 12:39:11 +00:00
78b0a60223 Add phoglund as root owner.
It seems convenient since the EngProd team make repo-wide changes
every now and then.

Bug: None
Change-Id: If429fc8ed503a3c24c912ac2e8d120f93edc4823
Reviewed-on: https://webrtc-review.googlesource.com/77760
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Magnus Flodman <mflodman@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Niklas Enbom <niklas.enbom@webrtc.org>
Commit-Queue: Niklas Enbom <niklas.enbom@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23312}
2018-05-18 15:57:56 +00:00
3fe981adbf Update documentation for THIRD_PARTY_DEPS; add pymock.
This should fix our python presubmit tests.

Also make Artem and Patrik own the deps file.

Bug: webrtc:9264
Change-Id: I430c56e0b12c4feac7d7cbf766eea9e304cd9a20
Reviewed-on: https://webrtc-review.googlesource.com/76421
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23217}
2018-05-14 15:13:29 +00:00
f9fbce9cc4 Add back OWNERS entris that went missing
The OWNERS entries for style-guide.md were removed in
https://webrtc-review.googlesource.com/1560, apparently by accident;
add them back.

And while we're at it, add an entry for native-api.md as well.

Bug: none
Change-Id: I924b9e8dab297e668055af3042ac70123e4c00dc
Notry: true
Reviewed-on: https://webrtc-review.googlesource.com/60001
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22306}
2018-03-06 10:31:11 +00:00
90d46c472d Add phoglund@ to various OWNERS and remove kjellander@
TBR=henrika@webrtc.org

Bug: webrtc:8363
Change-Id: Ibcb3e8d40a93542ea0825faf92a6db11dc5a0c13
Notry: True
Reviewed-on: https://webrtc-review.googlesource.com/7606
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20344}
2017-10-19 09:21:12 +00:00
bb547203bf Moving src/webrtc into src/.
In order to eliminate the WebRTC Subtree mirror in Chromium, 
WebRTC is moving the content of the src/webrtc directory up
to the src/ directory.

NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=tommi@webrtc.org

Bug: chromium:611808
Change-Id: Iac59c5b51b950f174119565bac87955a7994bc38
Reviewed-on: https://webrtc-review.googlesource.com/1560
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19845}
2017-09-15 04:25:06 +00:00
678636bf7c Add psutil to vpython dependencies (used on builder bots)
This is copied from https://chromium-review.googlesource.com/639357

BUG=chromium:761720
NOTRY=True
R=kjellander@webrtc.org
TBR=kwiberg@webrtc.org

Review-Url: https://codereview.webrtc.org/3008063002
Cr-Commit-Position: refs/heads/master@{#19646}
2017-09-04 08:04:16 +00:00
bb821e28b1 Add a bare-bones C++ style guide
BUG=none
NOTRY=true

Change-Id: I4488aff47db2b9220985156c5112db6d5a79a18e
Reviewed-on: https://chromium-review.googlesource.com/641872
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19645}
2017-09-03 16:43:41 +00:00
38c65c8fb4 Update pylintrc to catch more style violations.
The current PyLint configuration doesn't catch violations
to the Chromium Python Style Guide in a good way.

This change adds mostly the correct style regex for functions
and methods, with most content copied from
https://cs.chromium.org/chromium/tools/depot_tools/pylintrc
and (since the former disables invalid-name)
https://cs.chromium.org/chromium/src/third_party/chromite/pylintrc

Many settings are the defaults, but are now more explicit to make it
easier to find them for our users.

Also convert the previous one-line list of disabled lint check into
a one-per-line list instead.

Add import-error to the list of disabled lint checks.

This CL depends on https://codereview.webrtc.org/2812273002/
to be landed first in order to not produce a lot of errors.

BUG=webrtc:7303
NOTRY=True
TESTED=git cl presubmit passing when tested in
combination with https://codereview.webrtc.org/2812273002/
TBR=niklas.enbom@webrtc.org

Review-Url: https://codereview.webrtc.org/2737963003
Cr-Commit-Position: refs/heads/master@{#17685}
2017-04-13 05:43:38 +00:00
a17ec85b5f OWNERS: Cleanup root owners file
Remove no-longer present files.
Expand kjellaner@ to own *.py in the root.

BUG=None
NOTRY=True

Review-Url: https://codereview.webrtc.org/2738993004
Cr-Commit-Position: refs/heads/master@{#17134}
2017-03-09 10:04:57 +00:00
2622ea73e3 Leave only an empty top level OWNERS file.
We should not copy OWNERS files from upstream,
or the owners should be registered in Gerrit Code Review.

Bug: 33166666
Test: default build targets
Change-Id: Ibfd47e643f03678bb65880653383adb84809169d
2017-02-23 22:25:35 -08:00
87abc289a9 Add kwiberg@webrtc.org as root owner.
NOTRY=true

Review-Url: https://codereview.webrtc.org/2060923003
Cr-Commit-Position: refs/heads/master@{#13125}
2016-06-14 09:39:40 +00:00
86600246ca Remove webrtc_all target
Move all its configuration to all.gyp instead, which is
not processed by Chromium builds (webrtc.gyp is).

BUG=webrtc:5949
NOTRY=True

Review-Url: https://codereview.webrtc.org/2060873002
Cr-Commit-Position: refs/heads/master@{#13124}
2016-06-14 09:09:24 +00:00
f70568c04b So long and thanks for all the code reviews!
- Remove myself from OWNERS.
- Add myself to AUTHORS (I signed a CLA).
- Add minyue to audio_conference_mixer which would otherwise be empty.
- Add missing comma in WATCHLISTS.

Review URL: https://codereview.webrtc.org/1458763002

Cr-Commit-Position: refs/heads/master@{#10686}
2015-11-18 11:07:45 +00:00
411777584c Roll chromium_revision 5333e14..d8f8dc8 (323410:324211)
We used to symlink the .gn file from Chromium but it's now
replaced by our own copy (needed for recent GN changes in
https://codereview.chromium.org/988563002).

Relevant changes:
* src/third_party/boringssl/src: e2e1326..40acdae
* src/third_party/icu: 46be516..10834e8
* src/third_party/nss: bb4e75a..d1edb68
* src/tools/gyp: d174d75..2889664

The entries for
* src/third_party/jsoncpp/source/include
* src/third_party/jsoncpp/source/src/lib_json
are removed and replaced by:
* src/third_party/jsoncpp/source @ab1e40f
(which doesn't matter for us since we symlink third_party/jsoncpp

Details: 5333e14..d8f8dc8/DEPS

Clang version was not updated in this roll.

R=henrika@webrtc.org, pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/48919004

Cr-Commit-Position: refs/heads/master@{#8959}
2015-04-09 13:36:33 +00:00
d367321a3f Add kjellander as PRESUBMIT.py OWNER
BUG=
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/31949005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7618 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-04 17:06:31 +00:00
79ad37eac2 Update root OWNERS file
Add kjellander to owner for the new way of
syncing Chromium deps.
Remove redundant webrtc_examples.gyp entry.
Convert the file from Win to Unix line endings.

BUG=
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19119004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6969 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-25 14:41:41 +00:00
1227ab89a7 GN: Add BUILD.gn files + kjellander to OWNERS
This should work as a foundation for all the work that is
left to do to make the parts of WebRTC that Chromium uses
to build with GN.

I implemented some the smaller modules myself in this CL.
The remaining work (TODO's in the .gn files) will be distributed
to various team members.

I'm adding myself to OWNERS files for BUILD.gn files in all the
directories where I'm adding a BUILD.gn file.

BUG=3441
TEST=
Successful compilation of WebRTC as standalone:
gn gen out/Default --args="build_with_chromium=false" && ninja -C out/Default
gn gen out/Default --args="build_with_chromium=false is_clang=true clang_use_chrome_plugins=false" && ninja -C out/Default

I built successfully from a Chromium checkout (with
https://codereview.chromium.org/321313006/ applied) using:
gn gen out/Default && ninja -C out/Default webrtc

R=brettw@chromium.org, niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/13749004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6523 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-23 19:21:07 +00:00
7b82c18979 Add kjellander@webrtc.org as OWNER for *.isolate
This should make project-wide changes for isolate files
easier and make it more obvious who's a suitable reviewer
for them.

BUG=
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19689004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6379 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-10 05:42:53 +00:00
32c26eb90b Android, OpenSlDemo: moved to webrtc/examples/android/opensl_loopback
BUG=N/A
R=andrew@webrtc.org, fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7269004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5400 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-17 23:12:51 +00:00
83b9e5b328 Add owners to [webrtc,talk]/build and *.isolate
BUG=none
R=andrew@webrtc.org, wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2347006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4923 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-04 17:35:26 +00:00
ecd3c800c4 Add Magnus to root owners.
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1752005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4289 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-03 08:21:41 +00:00
18a21a03c6 Android NDK build tools
This CL enables building with Android NDK in the way that Chromium buildbots do it.

== Overview ==
* Add Android dependencies to DEPS (SDK, NDK, Android test runner). This also makes it possible to use Android's build/android/run_tests.py script to execute tests on Android devices.
* Add a Python script to build the WebRTC Video demo for Android using ndk-build and Ant. This is designed as an annotation script for Buildbots but is also fine to run locally.
* Update Android.mk so it works with the compiler output from a build performed by build/android/buildbot/bb_run_bot.py (which is how Chrome buildbots build).

== Syncing Android dependencies ==
To get the dependencies added in DEPS synced out, you must change the last line
of your .gclient file to look like this:
];target_os = ["android"]

That will append another variable to the .gclient file that causes these
dependencies to be synced during gclient sync.
If you want to get additional platform-specific dependencies in the same
checkout, add them to the list too, e.g. target_os = ["android", "unix"].

== Android.mk ==
The fix in Android.mk is needed since Chrome is building using build/android/buildbot/bb_run_bot.py, which only output the libraries into out/Debug. With the change it works for both that and a normal build (which copies the library files from out/Debug/obj.target/subpath to out/Debug anyway as a part of the build).

== svn:ignore ==
NOTICE: Before submitting, the following directories should be added to svn:ignore in third_party to avoid them from being removed and re-synced for every build:
* android_testrunner
* android_tools
* WebKit
This has to be done in a manual SVN commit since it's not possible to include in a git-svn CL (and I don't want to migrate this to a SVN CL).

BUG=none
TEST=local builds

Review URL: https://webrtc-codereview.appspot.com/1024009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3497 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-11 17:43:19 +00:00
e129ae944e Review URL: http://webrtc-codereview.appspot.com/137002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@448 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-25 16:52:34 +00:00
8910f278c5 Switch to webrtc.org accounts (for those which exist).
Review URL: http://webrtc-codereview.appspot.com/97010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@342 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-10 05:16:31 +00:00
33bb406f22 Global OWNERS.
Review URL: http://webrtc-codereview.appspot.com/44006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@110 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-21 08:09:52 +00:00
da159d6be6 git-svn-id: http://webrtc.googlecode.com/svn/trunk@11 4adac7df-926f-26a2-2b94-8c16560cd09d 2011-05-30 11:51:34 +00:00