a15_larch
20 Commits
Author | SHA1 | Message | Date | |
---|---|---|---|---|
2c6f373a27 |
Remove legacy EchoControlFactory::Create
Bug: webrtc:10913 Change-Id: I34af9abe76f5b08d7dc5c3e0281fafc14a71eed8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159031 Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29741} |
|||
4e5c709ed4 |
Reland "Correct AEC3 multichannel functionality activation"
This is a reland of 9dda1b3a484ebeef921e419406402039f3852427 Original change's description: > Correct AEC3 multichannel functionality activation > > This CL corrects the AEC3 multichannel activation > to also work for the case when a factory is used > for the activation. > > Bug: webrtc:10913 > Change-Id: Ic2807d8bcef759261fde14447cff30633ba248dc > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158794 > Commit-Queue: Per Åhgren <peah@webrtc.org> > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29676} Bug: webrtc:10913 Change-Id: I1cb3d0de61ea0b299158ca85433f2442c65c196f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158886 Reviewed-by: Sam Zackrisson <saza@webrtc.org> Commit-Queue: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29690} |
|||
1983458981 |
Revert "Reland "Correct AEC3 multichannel functionality activation""
This reverts commit d5a7838926b839469db1072d72a92e6814f2faeb. Reason for revert: Causing errors in downstream tests. Original change's description: > Reland "Correct AEC3 multichannel functionality activation" > > This is a reland of 9dda1b3a484ebeef921e419406402039f3852427 > > Original change's description: > > Correct AEC3 multichannel functionality activation > > > > This CL corrects the AEC3 multichannel activation > > to also work for the case when a factory is used > > for the activation. > > > > Bug: webrtc:10913 > > Change-Id: Ic2807d8bcef759261fde14447cff30633ba248dc > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158794 > > Commit-Queue: Per Åhgren <peah@webrtc.org> > > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#29676} > > Bug: webrtc:10913 > Change-Id: Ibfe4e8a51183390a4054514bb294c89c2ea201e9 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158880 > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > Commit-Queue: Per Åhgren <peah@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29685} TBR=saza@webrtc.org,peah@webrtc.org Change-Id: I6e27bc7fd1c9d4d5550fdc6ae14c39ca84fb03f8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:10913 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158883 Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29687} |
|||
d5a7838926 |
Reland "Correct AEC3 multichannel functionality activation"
This is a reland of 9dda1b3a484ebeef921e419406402039f3852427 Original change's description: > Correct AEC3 multichannel functionality activation > > This CL corrects the AEC3 multichannel activation > to also work for the case when a factory is used > for the activation. > > Bug: webrtc:10913 > Change-Id: Ic2807d8bcef759261fde14447cff30633ba248dc > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158794 > Commit-Queue: Per Åhgren <peah@webrtc.org> > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29676} Bug: webrtc:10913 Change-Id: Ibfe4e8a51183390a4054514bb294c89c2ea201e9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158880 Reviewed-by: Sam Zackrisson <saza@webrtc.org> Commit-Queue: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29685} |
|||
cc9bf6398c |
Revert "Correct AEC3 multichannel functionality activation"
This reverts commit 9dda1b3a484ebeef921e419406402039f3852427. Reason for revert: The CL is causing downstream issues Original change's description: > Correct AEC3 multichannel functionality activation > > This CL corrects the AEC3 multichannel activation > to also work for the case when a factory is used > for the activation. > > Bug: webrtc:10913 > Change-Id: Ic2807d8bcef759261fde14447cff30633ba248dc > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158794 > Commit-Queue: Per Åhgren <peah@webrtc.org> > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29676} TBR=saza@webrtc.org,peah@webrtc.org Change-Id: Ic487f77f5c11485a0f25a2a1d3797d0ec956f913 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:10913 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158797 Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29678} |
|||
9dda1b3a48 |
Correct AEC3 multichannel functionality activation
This CL corrects the AEC3 multichannel activation to also work for the case when a factory is used for the activation. Bug: webrtc:10913 Change-Id: Ic2807d8bcef759261fde14447cff30633ba248dc Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158794 Commit-Queue: Per Åhgren <peah@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29676} |
|||
ce202a0f98 |
Reland "Reland "Add core multi-channel pipeline in AEC3 This CL adds basic the basic pipeline to support multi-channel processing in AEC3.""
This is a reland of a66395e72f9fc86873bf443579ec73c3d78af240 Original change's description: > Reland "Add core multi-channel pipeline in AEC3 This CL adds basic the basic pipeline to support multi-channel processing in AEC3." > > This is a reland of f3a197e55323aee974a932c52dd19fa88e5d4e38 > > Original change's description: > > Add core multi-channel pipeline in AEC3 > > This CL adds basic the basic pipeline to support multi-channel > > processing in AEC3. > > > > Apart from that, it removes the 8 kHz processing support in several > > places of the AEC3 code. > > > > Bug: webrtc:10913 > > Change-Id: If5b75fa325ed0071deea94a7546cb4a7adf22137 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150332 > > Commit-Queue: Per Åhgren <peah@webrtc.org> > > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#29017} > > Bug: webrtc:10913 > Change-Id: Ifc4b13bd994cfd22dca8f8755fa5700617cc379d > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151124 > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > Commit-Queue: Per Åhgren <peah@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29034} Bug: webrtc:10913 Change-Id: Id8da5666df8c86f290c73ad5dc9958199f1a7ebe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151127 Commit-Queue: Sam Zackrisson <saza@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29042} |
|||
d112c75801 |
Revert "Reland "Add core multi-channel pipeline in AEC3 This CL adds basic the basic pipeline to support multi-channel processing in AEC3.""
This reverts commit a66395e72f9fc86873bf443579ec73c3d78af240. Reason for revert: Breaking downstream tests Original change's description: > Reland "Add core multi-channel pipeline in AEC3 This CL adds basic the basic pipeline to support multi-channel processing in AEC3." > > This is a reland of f3a197e55323aee974a932c52dd19fa88e5d4e38 > > Original change's description: > > Add core multi-channel pipeline in AEC3 > > This CL adds basic the basic pipeline to support multi-channel > > processing in AEC3. > > > > Apart from that, it removes the 8 kHz processing support in several > > places of the AEC3 code. > > > > Bug: webrtc:10913 > > Change-Id: If5b75fa325ed0071deea94a7546cb4a7adf22137 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150332 > > Commit-Queue: Per Åhgren <peah@webrtc.org> > > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#29017} > > Bug: webrtc:10913 > Change-Id: Ifc4b13bd994cfd22dca8f8755fa5700617cc379d > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151124 > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > Commit-Queue: Per Åhgren <peah@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29034} TBR=saza@webrtc.org,peah@webrtc.org Change-Id: I0e9fd154da5910d73b7a4c82e4e588f3220fd39d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:10913 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151126 Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29038} |
|||
a66395e72f |
Reland "Add core multi-channel pipeline in AEC3 This CL adds basic the basic pipeline to support multi-channel processing in AEC3."
This is a reland of f3a197e55323aee974a932c52dd19fa88e5d4e38 Original change's description: > Add core multi-channel pipeline in AEC3 > This CL adds basic the basic pipeline to support multi-channel > processing in AEC3. > > Apart from that, it removes the 8 kHz processing support in several > places of the AEC3 code. > > Bug: webrtc:10913 > Change-Id: If5b75fa325ed0071deea94a7546cb4a7adf22137 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150332 > Commit-Queue: Per Åhgren <peah@webrtc.org> > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29017} Bug: webrtc:10913 Change-Id: Ifc4b13bd994cfd22dca8f8755fa5700617cc379d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151124 Reviewed-by: Sam Zackrisson <saza@webrtc.org> Commit-Queue: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29034} |
|||
e3e30ae5c5 |
Revert "Add core multi-channel pipeline in AEC3"
This reverts commit f3a197e55323aee974a932c52dd19fa88e5d4e38. Reason for revert: Speculative revert, as this may'be broken some build bots Original change's description: > Add core multi-channel pipeline in AEC3 > This CL adds basic the basic pipeline to support multi-channel > processing in AEC3. > > Apart from that, it removes the 8 kHz processing support in several > places of the AEC3 code. > > Bug: webrtc:10913 > Change-Id: If5b75fa325ed0071deea94a7546cb4a7adf22137 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150332 > Commit-Queue: Per Åhgren <peah@webrtc.org> > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29017} TBR=saza@webrtc.org,peah@webrtc.org Change-Id: I877d2993b9ccf024bd1d57bca1513c3e24d0bed3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:10913 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150940 Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29022} |
|||
f3a197e553 |
Add core multi-channel pipeline in AEC3
This CL adds basic the basic pipeline to support multi-channel processing in AEC3. Apart from that, it removes the 8 kHz processing support in several places of the AEC3 code. Bug: webrtc:10913 Change-Id: If5b75fa325ed0071deea94a7546cb4a7adf22137 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150332 Commit-Queue: Per Åhgren <peah@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29017} |
|||
3d255309e9 |
Reland "Export symbols needed by the Chromium component build (part 1)."
This reverts commit 16fe3f290a524a136f71660a114d0b03ef501f10. Reason for revert: After discussing this problem with nisse@ and yvesg@, we decided to modify how RTC_EXPORT works and avoid to depend on the macro COMPONENT_BUILD. RTC_EXPORT will instead depend on a macro WEBRTC_COMPONENT_BUILD (which can be set as a GN argument which defaults to false). When all the symbols needed by Chromium will be marked with RTC_EXPORT we will flip the GN arg in Chromium, setting to to `component_build` and from that moment, Chromium will depend on a WebRTC shared library when `component_build=true`. Original change's description: > Revert "Export symbols needed by the Chromium component build (part 1)." > > This reverts commit 99eea42fc1fe0be0ebed13c5eba7e1e42059bc5a. > > Reason for revert: > lld-link: error: undefined symbol: "__declspec(dllimport) bool __cdecl cricket::UnwrapTurnPacket(unsigned char const *, unsigned int, unsigned int *, unsigned int *)" (__imp_?UnwrapTurnPacket@cricket@@YA_NPBEIPAI1@Z) > >>> referenced by obj/services/network/network_service/socket_manager.obj:("virtual void __thiscall network::P2PSocketManager::DumpPacket(class base::span<unsigned char const, 4294967295>, bool)" (?DumpPacket@P2PSocketManager@network@@EAEXV?$span@$$CBE$0PPPPPPPP@@base@@_N@Z)) > lld-link: error: undefined symbol: "__declspec(dllimport) bool __cdecl cricket::ValidateRtpHeader(unsigned char const *, unsigned int, unsigned int *)" (__imp_?ValidateRtpHeader@cricket@@YA_NPBEIPAI@Z) > >>> referenced by obj/services/network/network_service/socket_manager.obj:("virtual void __thiscall network::P2PSocketManager::DumpPacket(class base::span<unsigned char const, 4294967295>, bool)" (?DumpPacket@P2PSocketManager@network@@EAEXV?$span@$$CBE$0PPPPPPPP@@base@@_N@Z)) > lld-link: error: undefined symbol: "__declspec(dllimport) bool __cdecl cricket::ApplyPacketOptions(unsigned char *, unsigned int, struct rtc::PacketTimeUpdateParams const &, unsigned __int64)" (__imp_?ApplyPacketOptions@cricket@@YA_NPAEIABUPacketTimeUpdateParams@rtc@@_K@Z) > >>> referenced by obj/services/network/network_service/socket_tcp.obj:("virtual void __thiscall network::P2PSocketTcp::DoSend(class net::IPEndPoint const &, class std::vector<signed char, class std::allocator<signed char>> const &, struct rtc::PacketOptions const &, struct net::NetworkTrafficAnnotationTag)" (?DoSend@P2PSocketTcp@network@@MAEXABVIPEndPoint@net@@ABV?$vector@CV?$allocator@C@std@@@std@@ABUPacketOptions@rtc@@UNetworkTrafficAnnotationTag@4@@Z)) > >>> referenced by obj/services/network/network_service/socket_tcp.obj:("virtual void __thiscall network::P2PSocketStunTcp::DoSend(class net::IPEndPoint const &, class std::vector<signed char, class std::allocator<signed char>> const &, struct rtc::PacketOptions const &, struct net::NetworkTrafficAnnotationTag)" (?DoSend@P2PSocketStunTcp@network@@MAEXABVIPEndPoint@net@@ABV?$vector@CV?$allocator@C@std@@@std@@ABUPacketOptions@rtc@@UNetworkTrafficAnnotationTag@4@@Z)) > lld-link: error: undefined symbol: "__declspec(dllimport) bool __cdecl cricket::ApplyPacketOptions(unsigned char *, unsigned int, struct rtc::PacketTimeUpdateParams const &, unsigned __int64)" (__imp_?ApplyPacketOptions@cricket@@YA_NPAEIABUPacketTimeUpdateParams@rtc@@_K@Z) > >>> referenced by obj/services/network/network_service/socket_udp.obj:("bool __thiscall network::P2PSocketUdp::DoSend(struct network::P2PSocketUdp::PendingPacket const &)" (?DoSend@P2PSocketUdp@network@@AAE_NABUPendingPacket@12@@Z)) > > Original change's description: > > Reland "Reland "Export symbols needed by the Chromium component build (part 1)."" > > > > This reverts commit b49520bfc08f5c5832dda1d642125f0bb898f974. > > > > Reason for revert: Problem fixed in https://chromium-review.googlesource.com/c/chromium/src/+/1261398. > > > > Original change's description: > > > Revert "Reland "Export symbols needed by the Chromium component build (part 1)."" > > > > > > This reverts commit 588f4642d1a29f7beaf28265dbd08728191b4c52. > > > > > > Reason for revert: Breaks WebRTC Chromium FYI Win Builder (dbg). > > > lld-link: error: undefined symbol: "__declspec(dllimport) __thiscall webrtc::Config::Config(void)" (__imp_??0Config@webrtc@@QAE@XZ) > > > [...] > > > > > > Original change's description: > > > > Reland "Export symbols needed by the Chromium component build (part 1)." > > > > > > > > This reverts commit 2ea9af227517556136fd629dd2663c0d75d77c7b. > > > > > > > > Reason for revert: The problem will be fixed by > > > > https://chromium-review.googlesource.com/c/chromium/src/+/1261122. > > > > > > > > Original change's description: > > > > > Revert "Export symbols needed by the Chromium component build (part 1)." > > > > > > > > > > This reverts commit 9e24dcff167c4eb3555bf0ce6eaba090c10fbe53. > > > > > > > > > > Reason for revert: Breaks chromium.webrtc.fyi bots. > > > > > > > > > > Original change's description: > > > > > > Export symbols needed by the Chromium component build (part 1). > > > > > > > > > > > > This CL uses RTC_EXPORT (defined in rtc_base/system/rtc_export.h) > > > > > > to mark WebRTC symbols as visible from a shared library, this doesn't > > > > > > mean these symbols are part of the public API (please continue to refer > > > > > > to [1] for info about what is considered public WebRTC API). > > > > > > > > > > > > [1] - https://webrtc.googlesource.com/src/+/HEAD/native-api.md > > > > > > > > > > > > Bug: webrtc:9419 > > > > > > Change-Id: I802abd32874d42d3aa5ecd3c8022e7cf5e043d99 > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/103505 > > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > Reviewed-by: Niels Moller <nisse@webrtc.org> > > > > > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > > > > > Cr-Commit-Position: refs/heads/master@{#24969} > > > > > > > > > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org > > > > > > > > > > Change-Id: I01f6e18f0d2c0f0309cdaa6c943c3927e1f1f49f > > > > > No-Presubmit: true > > > > > No-Tree-Checks: true > > > > > No-Try: true > > > > > Bug: webrtc:9419 > > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/103720 > > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > Cr-Commit-Position: refs/heads/master@{#24974} > > > > > > > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org > > > > > > > > Change-Id: I83bbc7f550fc23e823c4d055e0a6f60c828960dd > > > > No-Presubmit: true > > > > No-Tree-Checks: true > > > > No-Try: true > > > > Bug: webrtc:9419 > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/103740 > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#24980} > > > > > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org > > > > > > Change-Id: I4b7cfe492f2c8eeda5c8ac52520e0cfc95ade9b0 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:9419 > > > Reviewed-on: https://webrtc-review.googlesource.com/c/103801 > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#24983} > > > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: webrtc:9419 > > Change-Id: Id986a0a03cdc2818690337784396882af067f7fa > > Reviewed-on: https://webrtc-review.googlesource.com/c/104602 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Reviewed-by: Niels Moller <nisse@webrtc.org> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#25049} > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org > > Change-Id: I6f58b9c90defccdb160307783fb55271ab424fa1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:9419 > Reviewed-on: https://webrtc-review.googlesource.com/c/104623 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#25050} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org Change-Id: I4d01ed96ae40a8f9ca42c466be5c87653d75d7c1 Bug: webrtc:9419 Reviewed-on: https://webrtc-review.googlesource.com/c/104641 Reviewed-by: Yves Gerey <yvesg@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25108} |
|||
16fe3f290a |
Revert "Export symbols needed by the Chromium component build (part 1)."
This reverts commit 99eea42fc1fe0be0ebed13c5eba7e1e42059bc5a. Reason for revert: lld-link: error: undefined symbol: "__declspec(dllimport) bool __cdecl cricket::UnwrapTurnPacket(unsigned char const *, unsigned int, unsigned int *, unsigned int *)" (__imp_?UnwrapTurnPacket@cricket@@YA_NPBEIPAI1@Z) >>> referenced by obj/services/network/network_service/socket_manager.obj:("virtual void __thiscall network::P2PSocketManager::DumpPacket(class base::span<unsigned char const, 4294967295>, bool)" (?DumpPacket@P2PSocketManager@network@@EAEXV?$span@$$CBE$0PPPPPPPP@@base@@_N@Z)) lld-link: error: undefined symbol: "__declspec(dllimport) bool __cdecl cricket::ValidateRtpHeader(unsigned char const *, unsigned int, unsigned int *)" (__imp_?ValidateRtpHeader@cricket@@YA_NPBEIPAI@Z) >>> referenced by obj/services/network/network_service/socket_manager.obj:("virtual void __thiscall network::P2PSocketManager::DumpPacket(class base::span<unsigned char const, 4294967295>, bool)" (?DumpPacket@P2PSocketManager@network@@EAEXV?$span@$$CBE$0PPPPPPPP@@base@@_N@Z)) lld-link: error: undefined symbol: "__declspec(dllimport) bool __cdecl cricket::ApplyPacketOptions(unsigned char *, unsigned int, struct rtc::PacketTimeUpdateParams const &, unsigned __int64)" (__imp_?ApplyPacketOptions@cricket@@YA_NPAEIABUPacketTimeUpdateParams@rtc@@_K@Z) >>> referenced by obj/services/network/network_service/socket_tcp.obj:("virtual void __thiscall network::P2PSocketTcp::DoSend(class net::IPEndPoint const &, class std::vector<signed char, class std::allocator<signed char>> const &, struct rtc::PacketOptions const &, struct net::NetworkTrafficAnnotationTag)" (?DoSend@P2PSocketTcp@network@@MAEXABVIPEndPoint@net@@ABV?$vector@CV?$allocator@C@std@@@std@@ABUPacketOptions@rtc@@UNetworkTrafficAnnotationTag@4@@Z)) >>> referenced by obj/services/network/network_service/socket_tcp.obj:("virtual void __thiscall network::P2PSocketStunTcp::DoSend(class net::IPEndPoint const &, class std::vector<signed char, class std::allocator<signed char>> const &, struct rtc::PacketOptions const &, struct net::NetworkTrafficAnnotationTag)" (?DoSend@P2PSocketStunTcp@network@@MAEXABVIPEndPoint@net@@ABV?$vector@CV?$allocator@C@std@@@std@@ABUPacketOptions@rtc@@UNetworkTrafficAnnotationTag@4@@Z)) lld-link: error: undefined symbol: "__declspec(dllimport) bool __cdecl cricket::ApplyPacketOptions(unsigned char *, unsigned int, struct rtc::PacketTimeUpdateParams const &, unsigned __int64)" (__imp_?ApplyPacketOptions@cricket@@YA_NPAEIABUPacketTimeUpdateParams@rtc@@_K@Z) >>> referenced by obj/services/network/network_service/socket_udp.obj:("bool __thiscall network::P2PSocketUdp::DoSend(struct network::P2PSocketUdp::PendingPacket const &)" (?DoSend@P2PSocketUdp@network@@AAE_NABUPendingPacket@12@@Z)) Original change's description: > Reland "Reland "Export symbols needed by the Chromium component build (part 1)."" > > This reverts commit b49520bfc08f5c5832dda1d642125f0bb898f974. > > Reason for revert: Problem fixed in https://chromium-review.googlesource.com/c/chromium/src/+/1261398. > > Original change's description: > > Revert "Reland "Export symbols needed by the Chromium component build (part 1)."" > > > > This reverts commit 588f4642d1a29f7beaf28265dbd08728191b4c52. > > > > Reason for revert: Breaks WebRTC Chromium FYI Win Builder (dbg). > > lld-link: error: undefined symbol: "__declspec(dllimport) __thiscall webrtc::Config::Config(void)" (__imp_??0Config@webrtc@@QAE@XZ) > > [...] > > > > Original change's description: > > > Reland "Export symbols needed by the Chromium component build (part 1)." > > > > > > This reverts commit 2ea9af227517556136fd629dd2663c0d75d77c7b. > > > > > > Reason for revert: The problem will be fixed by > > > https://chromium-review.googlesource.com/c/chromium/src/+/1261122. > > > > > > Original change's description: > > > > Revert "Export symbols needed by the Chromium component build (part 1)." > > > > > > > > This reverts commit 9e24dcff167c4eb3555bf0ce6eaba090c10fbe53. > > > > > > > > Reason for revert: Breaks chromium.webrtc.fyi bots. > > > > > > > > Original change's description: > > > > > Export symbols needed by the Chromium component build (part 1). > > > > > > > > > > This CL uses RTC_EXPORT (defined in rtc_base/system/rtc_export.h) > > > > > to mark WebRTC symbols as visible from a shared library, this doesn't > > > > > mean these symbols are part of the public API (please continue to refer > > > > > to [1] for info about what is considered public WebRTC API). > > > > > > > > > > [1] - https://webrtc.googlesource.com/src/+/HEAD/native-api.md > > > > > > > > > > Bug: webrtc:9419 > > > > > Change-Id: I802abd32874d42d3aa5ecd3c8022e7cf5e043d99 > > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/103505 > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > Reviewed-by: Niels Moller <nisse@webrtc.org> > > > > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > > > > Cr-Commit-Position: refs/heads/master@{#24969} > > > > > > > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org > > > > > > > > Change-Id: I01f6e18f0d2c0f0309cdaa6c943c3927e1f1f49f > > > > No-Presubmit: true > > > > No-Tree-Checks: true > > > > No-Try: true > > > > Bug: webrtc:9419 > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/103720 > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#24974} > > > > > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org > > > > > > Change-Id: I83bbc7f550fc23e823c4d055e0a6f60c828960dd > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:9419 > > > Reviewed-on: https://webrtc-review.googlesource.com/c/103740 > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#24980} > > > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org > > > > Change-Id: I4b7cfe492f2c8eeda5c8ac52520e0cfc95ade9b0 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:9419 > > Reviewed-on: https://webrtc-review.googlesource.com/c/103801 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#24983} > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: webrtc:9419 > Change-Id: Id986a0a03cdc2818690337784396882af067f7fa > Reviewed-on: https://webrtc-review.googlesource.com/c/104602 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Niels Moller <nisse@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#25049} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org Change-Id: I6f58b9c90defccdb160307783fb55271ab424fa1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9419 Reviewed-on: https://webrtc-review.googlesource.com/c/104623 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25050} |
|||
99eea42fc1 |
Reland "Reland "Export symbols needed by the Chromium component build (part 1).""
This reverts commit b49520bfc08f5c5832dda1d642125f0bb898f974. Reason for revert: Problem fixed in https://chromium-review.googlesource.com/c/chromium/src/+/1261398. Original change's description: > Revert "Reland "Export symbols needed by the Chromium component build (part 1)."" > > This reverts commit 588f4642d1a29f7beaf28265dbd08728191b4c52. > > Reason for revert: Breaks WebRTC Chromium FYI Win Builder (dbg). > lld-link: error: undefined symbol: "__declspec(dllimport) __thiscall webrtc::Config::Config(void)" (__imp_??0Config@webrtc@@QAE@XZ) > [...] > > Original change's description: > > Reland "Export symbols needed by the Chromium component build (part 1)." > > > > This reverts commit 2ea9af227517556136fd629dd2663c0d75d77c7b. > > > > Reason for revert: The problem will be fixed by > > https://chromium-review.googlesource.com/c/chromium/src/+/1261122. > > > > Original change's description: > > > Revert "Export symbols needed by the Chromium component build (part 1)." > > > > > > This reverts commit 9e24dcff167c4eb3555bf0ce6eaba090c10fbe53. > > > > > > Reason for revert: Breaks chromium.webrtc.fyi bots. > > > > > > Original change's description: > > > > Export symbols needed by the Chromium component build (part 1). > > > > > > > > This CL uses RTC_EXPORT (defined in rtc_base/system/rtc_export.h) > > > > to mark WebRTC symbols as visible from a shared library, this doesn't > > > > mean these symbols are part of the public API (please continue to refer > > > > to [1] for info about what is considered public WebRTC API). > > > > > > > > [1] - https://webrtc.googlesource.com/src/+/HEAD/native-api.md > > > > > > > > Bug: webrtc:9419 > > > > Change-Id: I802abd32874d42d3aa5ecd3c8022e7cf5e043d99 > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/103505 > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > Reviewed-by: Niels Moller <nisse@webrtc.org> > > > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#24969} > > > > > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org > > > > > > Change-Id: I01f6e18f0d2c0f0309cdaa6c943c3927e1f1f49f > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:9419 > > > Reviewed-on: https://webrtc-review.googlesource.com/c/103720 > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#24974} > > > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org > > > > Change-Id: I83bbc7f550fc23e823c4d055e0a6f60c828960dd > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:9419 > > Reviewed-on: https://webrtc-review.googlesource.com/c/103740 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#24980} > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org > > Change-Id: I4b7cfe492f2c8eeda5c8ac52520e0cfc95ade9b0 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:9419 > Reviewed-on: https://webrtc-review.googlesource.com/c/103801 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#24983} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:9419 Change-Id: Id986a0a03cdc2818690337784396882af067f7fa Reviewed-on: https://webrtc-review.googlesource.com/c/104602 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25049} |
|||
b49520bfc0 |
Revert "Reland "Export symbols needed by the Chromium component build (part 1).""
This reverts commit 588f4642d1a29f7beaf28265dbd08728191b4c52. Reason for revert: Breaks WebRTC Chromium FYI Win Builder (dbg). lld-link: error: undefined symbol: "__declspec(dllimport) __thiscall webrtc::Config::Config(void)" (__imp_??0Config@webrtc@@QAE@XZ) [...] Original change's description: > Reland "Export symbols needed by the Chromium component build (part 1)." > > This reverts commit 2ea9af227517556136fd629dd2663c0d75d77c7b. > > Reason for revert: The problem will be fixed by > https://chromium-review.googlesource.com/c/chromium/src/+/1261122. > > Original change's description: > > Revert "Export symbols needed by the Chromium component build (part 1)." > > > > This reverts commit 9e24dcff167c4eb3555bf0ce6eaba090c10fbe53. > > > > Reason for revert: Breaks chromium.webrtc.fyi bots. > > > > Original change's description: > > > Export symbols needed by the Chromium component build (part 1). > > > > > > This CL uses RTC_EXPORT (defined in rtc_base/system/rtc_export.h) > > > to mark WebRTC symbols as visible from a shared library, this doesn't > > > mean these symbols are part of the public API (please continue to refer > > > to [1] for info about what is considered public WebRTC API). > > > > > > [1] - https://webrtc.googlesource.com/src/+/HEAD/native-api.md > > > > > > Bug: webrtc:9419 > > > Change-Id: I802abd32874d42d3aa5ecd3c8022e7cf5e043d99 > > > Reviewed-on: https://webrtc-review.googlesource.com/c/103505 > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > Reviewed-by: Niels Moller <nisse@webrtc.org> > > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#24969} > > > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org > > > > Change-Id: I01f6e18f0d2c0f0309cdaa6c943c3927e1f1f49f > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:9419 > > Reviewed-on: https://webrtc-review.googlesource.com/c/103720 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#24974} > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org > > Change-Id: I83bbc7f550fc23e823c4d055e0a6f60c828960dd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:9419 > Reviewed-on: https://webrtc-review.googlesource.com/c/103740 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#24980} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org Change-Id: I4b7cfe492f2c8eeda5c8ac52520e0cfc95ade9b0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9419 Reviewed-on: https://webrtc-review.googlesource.com/c/103801 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24983} |
|||
588f4642d1 |
Reland "Export symbols needed by the Chromium component build (part 1)."
This reverts commit 2ea9af227517556136fd629dd2663c0d75d77c7b. Reason for revert: The problem will be fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1261122. Original change's description: > Revert "Export symbols needed by the Chromium component build (part 1)." > > This reverts commit 9e24dcff167c4eb3555bf0ce6eaba090c10fbe53. > > Reason for revert: Breaks chromium.webrtc.fyi bots. > > Original change's description: > > Export symbols needed by the Chromium component build (part 1). > > > > This CL uses RTC_EXPORT (defined in rtc_base/system/rtc_export.h) > > to mark WebRTC symbols as visible from a shared library, this doesn't > > mean these symbols are part of the public API (please continue to refer > > to [1] for info about what is considered public WebRTC API). > > > > [1] - https://webrtc.googlesource.com/src/+/HEAD/native-api.md > > > > Bug: webrtc:9419 > > Change-Id: I802abd32874d42d3aa5ecd3c8022e7cf5e043d99 > > Reviewed-on: https://webrtc-review.googlesource.com/c/103505 > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Reviewed-by: Niels Moller <nisse@webrtc.org> > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#24969} > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org > > Change-Id: I01f6e18f0d2c0f0309cdaa6c943c3927e1f1f49f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:9419 > Reviewed-on: https://webrtc-review.googlesource.com/c/103720 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#24974} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org Change-Id: I83bbc7f550fc23e823c4d055e0a6f60c828960dd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9419 Reviewed-on: https://webrtc-review.googlesource.com/c/103740 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24980} |
|||
2ea9af2275 |
Revert "Export symbols needed by the Chromium component build (part 1)."
This reverts commit 9e24dcff167c4eb3555bf0ce6eaba090c10fbe53. Reason for revert: Breaks chromium.webrtc.fyi bots. Original change's description: > Export symbols needed by the Chromium component build (part 1). > > This CL uses RTC_EXPORT (defined in rtc_base/system/rtc_export.h) > to mark WebRTC symbols as visible from a shared library, this doesn't > mean these symbols are part of the public API (please continue to refer > to [1] for info about what is considered public WebRTC API). > > [1] - https://webrtc.googlesource.com/src/+/HEAD/native-api.md > > Bug: webrtc:9419 > Change-Id: I802abd32874d42d3aa5ecd3c8022e7cf5e043d99 > Reviewed-on: https://webrtc-review.googlesource.com/c/103505 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Niels Moller <nisse@webrtc.org> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#24969} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org Change-Id: I01f6e18f0d2c0f0309cdaa6c943c3927e1f1f49f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9419 Reviewed-on: https://webrtc-review.googlesource.com/c/103720 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24974} |
|||
9e24dcff16 |
Export symbols needed by the Chromium component build (part 1).
This CL uses RTC_EXPORT (defined in rtc_base/system/rtc_export.h) to mark WebRTC symbols as visible from a shared library, this doesn't mean these symbols are part of the public API (please continue to refer to [1] for info about what is considered public WebRTC API). [1] - https://webrtc.googlesource.com/src/+/HEAD/native-api.md Bug: webrtc:9419 Change-Id: I802abd32874d42d3aa5ecd3c8022e7cf5e043d99 Reviewed-on: https://webrtc-review.googlesource.com/c/103505 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24969} |
|||
0efa941d2f |
Move EchoCanceller3Factory to api/auido
The AEC3 factory is now part of the WebRTC API. Bug: webrtc:8844 Change-Id: If6f419b4ca0354e2d346c0e6474086e456ba747e Reviewed-on: https://webrtc-review.googlesource.com/57141 Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22204} |
|||
c453c16dbe |
Add stubs for AEC3 factory.
This CL creates empty placeholders for EchoCanceller3Factory. This allows for moving the factory of AEC3 as soon as downstream has been updated to include echo_canceller3_factory.h. Bug: webrtc:8844 Change-Id: I77c53d8257291f189c637e1c9ed76c4e74be1858 Reviewed-on: https://webrtc-review.googlesource.com/53862 Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22050} |