bfcfe034f4
Move ownership of PacketSequencer from RTPSender to RtpRtcp module.
...
This prepares for deferred sequence numbering, and is (sort of)
extracted from
https://webrtc-review.googlesource.com/c/src/+/208584
Bug: webrtc:11340, webrtc:12470
Change-Id: I2f3695309e1591b9f7a1ee98556f4f0758de7f69
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227352
Commit-Queue: Erik Språng <sprang@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34643}
2021-08-04 13:44:51 +00:00
06bb4649dc
packethistory: s/kMaxPaddingtHistory/kMaxPaddingHistory
...
BUG=None
Change-Id: I554ff068c2350b9f14c12d935d7bfdd466dc5186
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227351
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Philipp Hancke <phancke@nvidia.com >
Cr-Commit-Position: refs/heads/master@{#34642}
2021-08-04 12:35:02 +00:00
287f377b86
Roll chromium_revision dfa60e93ef..da805a7931 (908227:908346)
...
Change log: dfa60e93ef..da805a7931dfa60e93ef..da805a7931b5cbb04cf4..f889b7f74d9c92226566..f8bccc2739f9cfa9b6ca..06e707f4ae9cfe0412ac..33faa936e38fdffd19e3..27b617d5a4e2c330ace6..d082599cf0dfa60e93ef..da805a7931TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I9b7900dbc856e7e6a3d4ef024103af176f87dfee
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227582
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34641}
2021-08-04 06:34:49 +00:00
bdaf0a9933
Update WebRTC code version (2021-08-04T04:05:26).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: Ib711707bee52086782143740018219b4c25e6a16
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227565
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34640}
2021-08-04 05:53:39 +00:00
5654a13950
Roll chromium_revision 8d0030420f..dfa60e93ef (908046:908227)
...
Change log: 8d0030420f..dfa60e93ef8d0030420f..dfa60e93ef3fc6a72257..b5cbb04cf492bad2c4f8..9c92226566caaa91f4cb..f9cfa9b6caa0845c923a..9cfe0412ac8e757c0628..8fdffd19e3a806594b95..a992238bf0a6966e3445..b846a827abac1ed0b484..e2c330ace68d0030420f..dfa60e93efTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I9c7c63bbf0aed709c2ac1cb87ac6bb3be1a826f9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227580
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34639}
2021-08-04 01:20:57 +00:00
18c0cc2bbd
Refactor PacketSequencer in preparation for deferred sequencing.
...
This CL is extracted from
https://webrtc-review.googlesource.com/c/src/+/208584
PacketSequencer now has its own unit tests. They are maybe somewhat
redundant with a few RtpSender unit tests, but will defer cleanup to
a later CL.
Bug: webrtc:11340, webrtc:12470
Change-Id: I1c31004b85ae075ddc696bdf1100d2a5044d4ef5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227343
Commit-Queue: Erik Språng <sprang@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34638}
2021-08-03 20:00:39 +00:00
49c9b4ec37
Roll chromium_revision b13faabc16..8d0030420f (907936:908046)
...
Change log: b13faabc16..8d0030420fb13faabc16..8d0030420fd4afa31a55..3fc6a722579d173680cf..92bad2c4f8fd46733c3d..caaa91f4cbd45cbed7b2..8e757c0628https://chromium.googlesource.com/catapult.git/+log/3c7d4d8aae..56c45f54de
* src/third_party/perfetto: f94e497acc..a6966e3445d351264027..ac1ed0b484b13faabc16..8d0030420fTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ie5b6eab8af0f0e86b319a68b9308bdd863fcf6f5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227561
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34637}
2021-08-03 18:44:59 +00:00
9cd4d4953f
Remove duplicated implementations of Mock classes
...
Bug: None
Change-Id: Ifc163d26c798cfeb511951ea4ee7bd1b5e82d81b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227349
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34636}
2021-08-03 14:50:52 +00:00
deac4dea4f
red: copy audio level from main packet for recovery packet
...
fill the audio level of the recovery packets from the main packet.
While not exact, this should be close enough. Without this,
the audio level in getStats() will be filled but the audio level
in getSynchronizationSources() will be empty.
In chrome this is easy to test, the audio level graph on
https://webrtc.github.io/samples/src/content/peerconnection/audio/
will be empty all the time prior to this fix.
BUG=webrtc:11640
Change-Id: Ia1e61fd1852445239021a76d08032120a92d83aa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226840
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34635}
2021-08-03 14:26:02 +00:00
8d564722d7
Fix for encoded framerate stats per layer.
...
Update framerate for top spatial layer instead of per timestamp (to ensure all simulcast layers are updated).
Bug: webrtc:13037
Change-Id: I4fa423dee40d74aee22a87855207b885f0536e25
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227344
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34634}
2021-08-03 14:12:52 +00:00
df7156965b
Roll chromium_revision 0ca0127e7e..b13faabc16 (907808:907936)
...
Change log: 0ca0127e7e..b13faabc160ca0127e7e..b13faabc1626b8ff80cd..d4afa31a55cff8a2670f..9d173680cff5f641d16a..fd46733c3dd3b2ab4c1e..a0845c923aedb5888353..d45cbed7b2https://chromium.googlesource.com/catapult.git/+log/61f0e50fb9..3c7d4d8aae
* src/third_party/icu: 2a822c5626..75e34bccce171e281775..f94e497acc498a3becd3..d3512640270ca0127e7e..b13faabc16TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ie4cfb22d468c93c439a7793b68088dbc45480678
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227521
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34633}
2021-08-03 13:06:12 +00:00
9ff450d0c4
[sigslot] - Remove sigslot from MediaStreamObserver.
...
Bug: webrtc:11943
Change-Id: Icf91ce850913c26e45dbca1940cafd600c235ad4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227340
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34632}
2021-08-03 06:53:59 +00:00
57c2bbd661
Update WebRTC code version (2021-08-03T04:03:48).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: Ieb89d7727f85cde7e885f0e7f3cb427c437579ab
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227480
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34631}
2021-08-03 05:35:07 +00:00
381e6471ad
Roll chromium_revision aebcd4ea0e..0ca0127e7e (907672:907808)
...
Change log: aebcd4ea0e..0ca0127e7eaebcd4ea0e..0ca0127e7e238e3cb481..26b8ff80cd6304890c4c..cff8a2670f29a0676755..f5f641d16acdd1b8acb5..d3b2ab4c1e59ace242a0..edb5888353https://chromium.googlesource.com/catapult.git/+log/4360d3a81d..61f0e50fb9
* src/third_party/perfetto: 70e408c9bc..171e281775cb384afa7c..498a3becd3aebcd4ea0e..0ca0127e7eTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I5be8bcee53a26a1b5930190dc348633868cc2ddf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227478
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34630}
2021-08-03 02:37:34 +00:00
bdf35afa39
Roll chromium_revision 1d5e4d014d..aebcd4ea0e (907488:907672)
...
Change log: 1d5e4d014d..aebcd4ea0e1d5e4d014d..aebcd4ea0e63be33a013..238e3cb4819ee6ac6515..6304890c4ccdb04dc77c..b79b97c1f6cd27053eca..29a06767558872b6cf61..cdd1b8acb51f8dac2588..59ace242a0https://chromium.googlesource.com/catapult.git/+log/4505381167..4360d3a81d
* src/third_party/freetype/src: 47b1a541cb..09195a82a45d5769f0b5..70e408c9bca25f134532..cb384afa7c1d5e4d014d..aebcd4ea0eTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I7b04ad979d8118232d823ef94ce84cefb6f4cb6e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227475
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34629}
2021-08-02 20:40:00 +00:00
d7ec635d82
Add unit tests for rtp state.
...
This CL is extracted from
https://webrtc-review.googlesource.com/c/src/+/208584
Bug: webrtc:11340, webrtc:12470
Change-Id: I322c271b02bc3577fe8aad57fe97364a76d83f4f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227342
Commit-Queue: Erik Språng <sprang@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34628}
2021-08-02 17:33:24 +00:00
b54cfdebfe
Add optional is_qp_trusted property for EncoderInfo.
...
Some hardware H.264 encoders does not place average QP delta in
slice_qp_delta field. Adding an optional flag in EncoderInfo to notify
quality scaler about this.
Bug: webrtc:12942
Change-Id: I3ee29c5ae9bd7bb34d26eba7e6bede3798ca44b4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226921
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34627}
2021-08-02 13:49:21 +00:00
f137b75a4d
Add a bandwidth estimator based on loss statistics and maximum likelihood modelling.
...
Bug: webrtc:12707
Change-Id: Ia221d0b7aee6edb5ae7b0f3b0ad08ac610b3340e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/224300
Commit-Queue: Christoffer Rodbro <crodbro@webrtc.org >
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34626}
2021-08-02 11:26:00 +00:00
bc88b54d91
Use backticks not vertical bars to denote variables in comments for /modules/async_audio_processing
...
Bug: webrtc:12338
Change-Id: I6500650a1bb327f7a6b3b1dcffd2b861377da647
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227092
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34625}
2021-08-02 11:16:59 +00:00
270306d6bb
Roll chromium_revision 00b9b01074..1d5e4d014d (907377:907488)
...
Change log: 00b9b01074..1d5e4d014d00b9b01074..1d5e4d014dcb528dbc1b..63be33a013aa58d6e0b4..9ee6ac6515fefefd558a..cd27053ecad2075ad0af..8872b6cf61c836757207..1f8dac2588dfbc81e9bd..a25f13453200b9b01074..1d5e4d014dTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I249dde8909b9fe9efe12bd85c71496e243565c5b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227471
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34624}
2021-08-02 11:15:09 +00:00
10a0bd6b9a
Use backticks not vertical bars to denote variables in comments for /modules/audio_mixer
...
Bug: webrtc:12338
Change-Id: I88c0824451f1448590df0f57bb094d39dffece66
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227093
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34623}
2021-08-02 11:10:59 +00:00
6f4b4fa18b
Use backticks not vertical bars to denote variables in comments for /modules/congestion_controller
...
Bug: webrtc:12338
Change-Id: Id46786886f13266177dd7fa8f1fb30c097df1373
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227094
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34622}
2021-08-02 11:09:20 +00:00
d00ce747c7
Use backticks not vertical bars to denote variables in comments for /modules/audio_coding
...
Bug: webrtc:12338
Change-Id: I02613d9fca45d00e2477f334b7a0416e7912e26b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227037
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34621}
2021-08-02 10:45:40 +00:00
0146a34b3f
Use backticks not vertical bars to denote variables in comments for /modules/audio_device
...
Bug: webrtc:12338
Change-Id: I27ad3a5fe6e765379e4e4f42783558c5522bab38
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227091
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34620}
2021-08-02 10:24:10 +00:00
53adc7b1c8
Revert "Enable WebRTC-Vp9DependencyDescriptor by default"
...
This reverts commit 472707150662bc4e174072e445938e5c405aa884.
Reason for revert: Suspected cause for crashes in perf tests.
Original change's description:
> Enable WebRTC-Vp9DependencyDescriptor by default
>
> Bug: chromium:1178444
> Change-Id: I420e1e9b3c557b8b186cb08c15b962a779e1ca17
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226941
> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Commit-Queue: Emil Lundmark <lndmrk@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#34584}
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:1178444
Change-Id: I582d6d1c9d2091ca37b0943235b5cea8d4e2790d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227282
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Emil Lundmark <lndmrk@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34619}
2021-08-02 09:52:24 +00:00
ff0378485c
Update WebRTC code version (2021-08-02T04:01:56).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I86385a8c360d5e7e553f941dbadc8809d2bf6d19
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227467
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34618}
2021-08-02 05:36:49 +00:00
2fbcfa0900
Update WebRTC code version (2021-08-01T04:01:52).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I5e039b099784552b7144b5c51e3bf7ef4179966a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227461
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34617}
2021-08-01 05:21:16 +00:00
57539fb6f2
Roll chromium_revision cb675cfb24..00b9b01074 (907171:907377)
...
Change log: cb675cfb24..00b9b01074cb675cfb24..00b9b010745cf4814696..cb528dbc1b1ae483ee7f..aa58d6e0b4e900e8f81d..fefefd558a9ffe36175a..d2075ad0af0d0bcd5510..c836757207https://chromium.googlesource.com/catapult.git/+log/10f6e4b89b..4505381167
* src/tools: a883907ef6..dfbc81e9bdcb675cfb24..00b9b01074TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I89e98b1dcf297f14ffd39b3916b543fb2338853f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227327
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34616}
2021-07-31 12:26:45 +00:00
f48d3cfbab
Revert "An RTCSessionDescription will now return nil from its initializer if the SDP passed to it is invalid."
...
This reverts commit 48cd9dbc5067f266b07541d2eebfb4b88fe455d4.
Reason for revert: Breaks downstream project.
Original change's description:
> An RTCSessionDescription will now return nil from its initializer if the SDP passed to it is invalid.
>
> Bug: webrtc:13022
> Change-Id: I2f2ad96884cf2f43f5ea95c1210470dd6aa5c919
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226980
> Commit-Queue: Jake Bromberg <jakebromberg@google.com >
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#34607}
TBR=peah@webrtc.org ,hta@webrtc.org ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com ,jakebromberg@google.com
Change-Id: Iee05f747e472208f8776944df15d9206485b167e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:13022
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227341
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34615}
2021-07-31 09:53:46 +00:00
e0df4314ac
Update WebRTC code version (2021-07-31T04:02:20).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I91bc6ea0acc08cf9a24fb7bf01e4035470054f39
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227322
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34614}
2021-07-31 05:11:53 +00:00
5f0784563c
Allow export of Obj-C symbols without C++ ones.
...
This is useful when building the .framework which doesn't need to
export C++ symbols.
Bug: webrtc:12408
Change-Id: Ied775811a72a06b9ad678c9fb549bca286dd7f37
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227089
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34613}
2021-07-30 22:54:59 +00:00
8e70299dd9
Use backticks not vertical bars to denote variables in comments for /modules/include
...
Bug: webrtc:12338
Change-Id: I66ef388e0582fc7b0250d8f2605288f0d652b66a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227095
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34612}
2021-07-30 22:40:29 +00:00
880fa8169b
Reland "Use backticks not vertical bars to denote variables in comments for /pc"
...
Original change's description:
> Revert "Use backticks not vertical bars to denote variables in comments for /pc"
>
> This reverts commit 37ee0f5e594dd772ec6d620b5e5ea8a751b684f0.
>
> Reason for revert: Revert in order to be able to revert https://webrtc-review.googlesource.com/c/src/+/225642
>
> Original change's description:
> > Use backticks not vertical bars to denote variables in comments for /pc
> >
> > Bug: webrtc:12338
> > Change-Id: I88cf10afa5fc810b95d2a585ab2e895dcc163b63
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226953
> > Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> > Commit-Queue: Artem Titov <titovartem@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#34575}
>
> TBR=hta@webrtc.org ,titovartem@webrtc.org ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
>
> Change-Id: I5eddd3a14e1f664bf831e5c294fbc4de5f6a88af
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:12338
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227082
> Reviewed-by: Björn Terelius <terelius@webrtc.org >
> Commit-Queue: Björn Terelius <terelius@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#34577}
Bug: webrtc:12338
Change-Id: I96bd229b73613c162d11d75fa4f5934e1b4295c7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227087
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34611}
2021-07-30 22:13:59 +00:00
c219a53c80
Don't try to send REMB or VideoBitrateAllocation when RTCP is off.
...
Bug: webrtc:12978
Change-Id: I0bd9cb239c9d74695c1408dde985c92b2834ba2d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/225961
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Philipp Hancke <phancke@nvidia.com >
Cr-Commit-Position: refs/heads/master@{#34610}
2021-07-30 20:28:24 +00:00
af9a3c6676
Use backticks not vertical bars to denote variables in comments for /logging
...
Bug: webrtc:12338
Change-Id: I87d33f201d4acfb26ca1d2da8a52cc188ff2c791
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226948
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34609}
2021-07-30 19:19:34 +00:00
0afbae130d
Roll chromium_revision 0549de0c2d..cb675cfb24 (907032:907171)
...
Change log: 0549de0c2d..cb675cfb240549de0c2d..cb675cfb24fe7fd7b2be..5cf48146968aa210e09b..1ae483ee7fdafd1d1517..e900e8f81d45ed21d9c9..9ffe36175abe994fedb5..0d0bcd55109edd589321..5d5769f0b5f7be2d25c7..a883907ef60549de0c2d..cb675cfb24TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I24fc22cf86ad16537f9b97f68003c85fafb4d25c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227263
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34608}
2021-07-30 18:44:17 +00:00
48cd9dbc50
An RTCSessionDescription will now return nil from its initializer if the SDP passed to it is invalid.
...
Bug: webrtc:13022
Change-Id: I2f2ad96884cf2f43f5ea95c1210470dd6aa5c919
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226980
Commit-Queue: Jake Bromberg <jakebromberg@google.com >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34607}
2021-07-30 18:11:18 +00:00
f36492e452
Enable size_t truncation warnings in webrtc.
...
Bug: chromium:167187
Change-Id: I57bc5609eade890520292697d2b033a485dd3234
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227180
Commit-Queue: Peter Kasting <pkasting@chromium.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34606}
2021-07-30 17:05:13 +00:00
03df29c100
Add -render_width and -render_height arguments to video_replay.
...
Bug: webrtc:12975
Change-Id: Ice8d704980a374378a1e20f526d5d8fb60e4db3f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/225960
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34605}
2021-07-30 16:56:12 +00:00
34517f9d96
Remove deprecated constants.
...
Follow-up of https://webrtc-review.googlesource.com/c/src/+/226564 .
No-Try: True
Bug: webrtc:12997
Change-Id: Iaff54124fe0d009aa0fa6887b29685268cd55f1e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227035
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34604}
2021-07-30 14:22:30 +00:00
481e3451d1
Revert rtc_dcheck_always_on.
...
This CL reverts:
https://webrtc-review.googlesource.com/c/src/+/226864
https://webrtc-review.googlesource.com/c/src/+/226563
Reason for revert:
See also V8 equivalent: crrev.com/c/3055294.
This has been properly fixed by crrev.com/c/3053740.
Now dcheck_always_on already defaults to false for subprojects
like WebRTC and no other switch is required. The switch didn't fully
work anyways due to https://crbug.com/1231890 .
No-Try: True
Bug: chromium:1225701, webrtc:12988
Change-Id: I9888d7ac02ef2ba4fdc372de20f1d2d71f6d0299
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227021
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Andrey Logvin <landrey@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34603}
2021-07-30 13:47:50 +00:00
2e6323e153
Fix OWNERS according to recent changes to path expressions.
...
See https://crbug.com/1231999#c7 and
https://chromium-review.googlesource.com/plugins/code-owners/Documentation/path-expressions.html#simplePathExpressions .
Bug: chromium:1231999
Change-Id: I8bce4f6e6bf53bf56b53b5bad54145727fd32389
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227090
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34602}
2021-07-30 13:36:20 +00:00
f80ea7a5f4
Add a link to template to create a ticket to become WebRTC committer.
...
Bug: webrtc:12298
Change-Id: I273d37f139b5d24ec9f26dac04e2b2ca5c6a6196
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227283
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34601}
2021-07-30 12:19:09 +00:00
386b5c3f4e
Switch from GTEST_FLAG to GTEST_FLAG_SET.
...
::testing::GTEST_FLAG is deprecated and it will be removed in future
versions of gtest.
Bug: None
Change-Id: Icb2ad2a7607073cf9ad63753a4de34f37bda411c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227083
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34600}
2021-07-30 12:08:38 +00:00
56c2406f8c
Roll chromium_revision 03a29cf406..0549de0c2d (904346:907032)
...
This CL also includes the changes required to fix build errors on
Android builds.
Change log: 03a29cf406..0549de0c2d03a29cf406..0549de0c2d58887e6f2a..fe7fd7b2be4638e26758..8aa210e09be8bf577fbf..24e92c2beed7b11d7989..cdb04dc77cc172f6d55d..dafd1d1517e6a8848e04..45ed21d9c943300033c5..be994fedb5https://boringssl.googlesource.com/boringssl.git/+log/a10017c548..519c2986c7
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/9ac1fdf373..10f6e4b89b
* src/third_party/freetype/src: 801cd842e2..47b1a541cb4ec4cd23f4..2d924d7a97https://aomedia.googlesource.com/aom.git/+log/aba245dde3..d80b8cecab
* src/third_party/libvpx/source/libvpx: eebc5cd487..977e77006e13482fe8f9..9edd5893212f3bb89f4e..f7be2d25c703a29cf406..0549de0c2d03a29cf406..0549de0c2dTBR=xalep@webrtc.org ,marpan@webrtc.org , jianj@chromium.org ,
BUG=None
No-Try: True
Change-Id: Iceca2600ab3aeff37d325ec68565c06f9db5b0fd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227280
Reviewed-by: Andrey Logvin <landrey@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34599}
2021-07-30 09:56:45 +00:00
adfc700008
Default initialize RtpPayloadParams::chain_last_frame_id_
...
This ensures the chain calculation will start out with all chains reset.
Bug: b/194980850
Change-Id: I8a9edf8ecaee961cdbaa51968917a2d829045575
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227281
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Emil Lundmark <lndmrk@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34598}
2021-07-30 09:34:45 +00:00
c3efa0031a
Update WebRTC code version (2021-07-30T04:04:57).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: Ia86fe23c768139791766aef399b0c427b7d3fe0b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227260
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34597}
2021-07-30 05:52:53 +00:00
704a834f68
Reland "Fix bug where we assume new m= sections will always be bundled."
...
This is a reland of d2b885fd91909f1b17fb11292a8c989d5d883b22, after
making sure transports that are just being kept alive in case of
rollback don't contribute to connection state, which broke a WPT.
Original change's description:
> Fix bug where we assume new m= sections will always be bundled.
>
> A recent change [1] assumes that all new m= sections will share the
> first BUNDLE group (if one already exists), which avoids generating
> ICE candidates that are ultimately unnecessary. This is fine for JSEP
> endpoints, but it breaks the following scenarios for non-JSEP endpoints:
>
> * Remote offer adding a new m= section that's not part of any BUNDLE
> group.
> * Remote offer adding an m= section to the second BUNDLE group.
>
> The latter is specifically problematic for any application that wants
> to bundle all audio streams in one group and all video streams in
> another group when using Unified Plan SDP, to replicate the behavior of
> using Plan B without bundling. It may try to add a video stream only
> for WebRTC to bundle it with audio.
>
> This is fixed by doing some minor re-factoring, having BundleManager
> update the bundle groups at offer time.
>
> Also:
> * Added some additional validation for multiple bundle groups in a
> subsequent offer, since that now becomes relevant.
> * Improved rollback support, because now rolling back an offer may need
> to not only remove mid->transport mappings but alter them.
>
> [1]: https://webrtc-review.googlesource.com/c/src/+/221601
>
> Bug: webrtc:12906, webrtc:12999
> Change-Id: I4c6e7020c0be33a782d3608dee88e4e2fceb1be1
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/225642
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Reviewed-by: Henrik Boström <hbos@webrtc.org >
> Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#34544}
Bug: webrtc:12906, webrtc:12999
Change-Id: I68bf988b1918dd2d51de76e53e4fd696fea5a09b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227120
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34596}
2021-07-30 00:02:53 +00:00
024200483d
Make VideoFrameTrackingIdInjector implement EncodedImageDataPropagator
...
Bug: b/194993473
Change-Id: I722788f64067a5317707f4752e1667b9a9e7cdc7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227223
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34595}
2021-07-29 20:14:22 +00:00
fbca6b426e
Introduce a single interface for data injector and extractor in PCLF
...
Bug: b/194993473
Change-Id: I59e2ea6aa232cd1399aa76753df1f90094340b8a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227222
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34594}
2021-07-29 17:55:13 +00:00
