34fe0153b9
Reland "Stop using ACM factory in VoiceEngine"
...
This change was originally landed as r5954, but had to be reverted in
r5955 due to bots failing. The failures should be fixed in r5956,
so the original change is now relanded.
BUG=2996
TBR=henrika@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12339004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5958 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-22 19:04:34 +00:00
0c108d0b4d
Revert "Stop using ACM factory in VoiceEngine"
...
Some of the bots where breaking.
TBR=henrika@webrtc.org
BUG=2996
Review URL: https://webrtc-codereview.appspot.com/12319004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5955 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-22 09:44:00 +00:00
139706ec0b
Stop using ACM factory in VoiceEngine
...
The factory injection was introduces in order to facilitate switching
between ACM1 and ACM2. Now, ACM1 is being deprecated, and this switching
mechanism is no longer needed.
BUG=2996
R=henrika@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12259005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5954 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-22 08:51:21 +00:00
372ae83228
Reland "Make VoiceEngine choose ACM2 by default""
...
This cl was originally committed as r5923, but was reverted in r5926
due to a blocking bug (issue 3143). The blocking bug was resolved in
r5936.
BUG=2996
TBR=henrika@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12279004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5950 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-22 07:21:03 +00:00
e2e9abb3bc
Revert "Make VoiceEngine choose ACM2 by default"
...
The reason for reverting is that Issue 3143 should be resolved
first.
TBR=henrika@webrtc.org
BUG=3143
Review URL: https://webrtc-codereview.appspot.com/12119005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5926 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-17 10:12:27 +00:00
6cec07f6a7
Make VoiceEngine choose ACM2 by default
...
The use of a factory for ACM will be removed in later CLs.
BUG=2996
R=henrika@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12069004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5923 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-17 08:07:18 +00:00
8883a0f47f
(landing) Exclude VoiceEngine::SetAndroidObjects in WebRTC chrome builds
...
Landing https://webrtc-codereview.appspot.com/11419004/ manually.
TBR=niklase
BUG=none
Review URL: https://webrtc-codereview.appspot.com/11439005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5872 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-09 13:04:12 +00:00
944cbeb292
Resolves TSan v2 warnings in voe_auto_test.
...
See bug report for details.
BUG=1590
R=tommi@webrtc.org , xians@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/9859004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5714 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-18 10:32:33 +00:00
573a1b45b5
Android: Fixes crash when exiting WebRTCDemo.
...
BUG=2738
R=fischman@webrtc.org , niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6179004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5365 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-10 22:58:06 +00:00
9ee75e9c77
Enables mixing and matching Java and native audio. It is used for getting best of both worlds capabilities (AEC and low latency).
...
BUG=N/A
R=fischman@webrtc.org , niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4189004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5270 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-11 21:42:44 +00:00
a750044396
Fixes a crash in VoE when unregistering JNI hooks.
...
BUG=11695087
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3939004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5144 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-20 22:32:12 +00:00
e509f943ed
This issue is related to
...
https://chromereviews.googleplex.com/9908014/
I was thinking about shipping ACM2 from the signal repository. There seems to be too many changes in one CL.
BUG=
R=andrew@webrtc.org , turaj@webrtc.org , xians@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2171004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4733 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-12 17:03:00 +00:00
82f014aa0b
OpenSL (not default): Enables low latency audio on Android.
...
BUG=1669
R=andrew@webrtc.org , fischman@webrtc.org , niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2032004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4719 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-10 18:24:07 +00:00
9080518a39
Restore severity precondition to logging.h.
...
I mistakenly ommitted the checks when logging.h was ported from
libjingle to webrtc. This caused a significant CPU cost for logs which
were later filtered out anyway.
Verified with LS_VERBOSE logging in neteq4, running:
$ out/Release/modules_unittests \
--gtest_filter=NetEqDecodingTest.TestBitExactness \
--gtest_repeat=50 > time.txt
$ grep "case ran" time.txt | grep "[0-9]* ms" -o | sort
Results on a MacBook Retina, averaged over 5 runs:
Verbose logs disabled: 666 ms
Exisiting implementation, verbose logs enabled: 944 ms (1.42x)
New implementation, verbose logs enabled: 673 ms (1.01x)
BUG=2314
R=henrik.lundin@webrtc.org , henrike@webrtc.org , kjellander@webrtc.org , turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2160005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4682 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-05 16:40:43 +00:00
d900e8bea8
Proper spacing for end-of-namespace comments.
...
BUG=
R=mflodman@webrtc.org , tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1760006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4293 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-03 15:12:26 +00:00
956aa7e087
Include files from webrtc/.. paths in voice_engine/
...
BUG=1662
R=henrikg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1434005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4079 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-21 13:52:32 +00:00
9213521ea9
Remove const for plain data types in voice_engine/
...
BUG=1644
R=henrikg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1463004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4018 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-14 08:31:39 +00:00
6141e13873
WebRtc_Word32 -> int32_t in voice_engine/
...
BUG=314
Review URL: https://webrtc-codereview.appspot.com/1305004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3792 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-09 10:09:10 +00:00
0989fb7bfa
Make VoiceEngineImpl inherit from VoiceEngine.
...
This associates the two types instead of incorrectly reinterpret casting
VoiceEngineImpl* to VoiceEngine* (since these types were previously unrelated).
Please see more details in the bug for how this is currently causing problems
with security tools.
BUG=38612
Review URL: https://webrtc-codereview.appspot.com/1099013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3520 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-15 15:07:32 +00:00
14b43beb7c
Move src/ -> webrtc/
...
TBR=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/915006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2963 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-22 18:19:23 +00:00
