02ed57bf9d
Fix CVO in androidvideocapturer.
...
This add bool apply_rotation to WebrtcVideoFrame::Init and removes the need for WebrtcVideoFrame::SetRotation.
BUG=4145
R=guoweis@webrtc.org , pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/40759004
Cr-Commit-Position: refs/heads/master@{#8536}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8536 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-27 19:10:45 +00:00
f09e7b8a4f
WebRtcVideoFrame: DCHECK exclusive ownership for non-const pixel access
...
Add some const safety by DCHECK(HasOneRef()) in non-const GetYPlane. This CL also replaces all incorrect non-const calls with const calls for pixel data access in cricket::VideoFrame. It's easy to call the non-const version of e.g. GetYPlane by mistake, even if only const-access is needed. For example:
const scoped_ptr<cricket::VideoFrame> foo;
const uint8_t* y = foo->GetYPlane();
will actually call the non-const version of GetYPlane.
R=mflodman@webrtc.org , perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39079004
Cr-Commit-Position: refs/heads/master@{#8507}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8507 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-25 14:50:19 +00:00
3864363e2c
cricket::VideoFrame: Refactor CopyToBuffer into base class
...
It’s possible to implement cricket::VideoFrame::CopyToBuffer using the virtual interface. This removes the need for subclasses to implement their own versions. This CL also fixes a bug in cricket::VideoFrame::CopyToPlanes which currently assumes that GetUPitch() == GetVPitch(), otherwise it may segfault.
I think this CL should land regardless, but the main purpose is to pave the way for for planned changes to I420VideoFrame. See https://review.webrtc.org/38879004 .
R=fbarchard@google.com , perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39889004
Cr-Commit-Position: refs/heads/master@{#8403}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8403 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-18 09:19:45 +00:00
1226e926e6
CVO capturer feature: allow unrotated frame flows through the capture pipeline.
...
split from https://webrtc-codereview.appspot.com/37029004/
This is based on clean up code change at https://webrtc-codereview.appspot.com/37129004
BUG=4145
R=perkj@webrtc.org , pthatcher@webrtc.org , stefan@webrtc.org , tommi@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=8337
Committed: https://code.google.com/p/webrtc/source/detail?r=8338
Review URL: https://webrtc-codereview.appspot.com/39799004
Cr-Commit-Position: refs/heads/master@{#8339}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8339 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-11 18:38:53 +00:00
dc7b02277c
CVO capturer feature: allow unrotated frame flows through the capture pipeline.
...
split from https://webrtc-codereview.appspot.com/37029004/
This is based on clean up code change at https://webrtc-codereview.appspot.com/37129004
BUG=4145
R=perkj@webrtc.org , pthatcher@webrtc.org , stefan@webrtc.org , tommi@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=8337
Review URL: https://webrtc-codereview.appspot.com/39799004
Cr-Commit-Position: refs/heads/master@{#8338}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8338 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-11 18:06:10 +00:00
20e8f22766
CVO capturer feature: allow unrotated frame flows through the capture pipeline.
...
split from https://webrtc-codereview.appspot.com/37029004/
This is based on clean up code change at https://webrtc-codereview.appspot.com/37129004
BUG=4145
R=perkj@webrtc.org , pthatcher@webrtc.org , stefan@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39799004
Cr-Commit-Position: refs/heads/master@{#8337}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8337 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-11 17:51:46 +00:00
7cc92aaf37
Use WebRtcVideoRenderFrame for texture frames.
...
Removes buffer/texture path separation inside WebRtcVideoEngine and
DeliverTextureFrame(). This unifies frame delivery with
WebRtcVideoEngine2 which is expected to automagically work with texture
frames after this change.
BUG=1788
R=magjed@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/38069005
Cr-Commit-Position: refs/heads/master@{#8326}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8326 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-11 09:03:44 +00:00
6c930c7183
Cleanup: unify rotation to be enum based instead of int for degree.
...
Split from https://webrtc-codereview.appspot.com/37029004/
BUG=4145
R=pthatcher@webrtc.org , stefan@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=8257
Committed: https://code.google.com/p/webrtc/source/detail?r=8276
Committed: https://code.google.com/p/webrtc/source/detail?r=8277
Review URL: https://webrtc-codereview.appspot.com/37129004
Cr-Commit-Position: refs/heads/master@{#8288}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8288 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-09 01:29:45 +00:00
0c7ec770ff
Cleanup: unify rotation to be enum based instead of int for degree.
...
Split from https://webrtc-codereview.appspot.com/37029004/
BUG=4145
R=pthatcher@webrtc.org , stefan@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=8257
Committed: https://code.google.com/p/webrtc/source/detail?r=8276
Review URL: https://webrtc-codereview.appspot.com/37129004
Cr-Commit-Position: refs/heads/master@{#8277}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8277 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-06 21:01:47 +00:00
110443aaac
Cleanup: unify rotation to be enum based instead of int for degree.
...
Split from https://webrtc-codereview.appspot.com/37029004/
BUG=4145
R=pthatcher@webrtc.org , stefan@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=8257
Review URL: https://webrtc-codereview.appspot.com/37129004
Cr-Commit-Position: refs/heads/master@{#8276}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8276 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-06 20:00:46 +00:00
4b320cf214
Revert "Cleanup: unify rotation to be enum based instead of int for degree."
...
Reason for revert:
Compile error on bots - A subclass of cricket::VideoFrame still uses old GetRotation return type.
BUG=4145
TBR=guoweis,stefan,pthatcher
This reverts commit 3e733a43f5a1a2c170e1064d0ee0af38d710a64a.
Review URL: https://webrtc-codereview.appspot.com/34159004
Cr-Commit-Position: refs/heads/master@{#8265}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8265 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-06 12:58:46 +00:00
3e733a43f5
Cleanup: unify rotation to be enum based instead of int for degree.
...
Split from https://webrtc-codereview.appspot.com/37029004/
BUG=4145
R=pthatcher@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37129004
Cr-Commit-Position: refs/heads/master@{#8257}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8257 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-05 23:40:43 +00:00
a26f511dd2
Remove frame copy in ViEExternalRendererImpl::RenderFrame
...
Add new interface for delivering frames to ExternalRenderer. The purpose is to avoid having to extract a packed buffer from I420VideoFrame, which will cause a deep frame copy.
BUG=1128,4227
R=mflodman@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=8136
Review URL: https://webrtc-codereview.appspot.com/36489004
Cr-Commit-Position: refs/heads/master@{#8199}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8199 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-29 11:45:43 +00:00
fc5ad95fec
Reland of: "Implement elapsed time and capture start NTP time estimation." revision @8139
...
Link to original CL: https://review.webrtc.org/36909004/
R=pbos@webrtc.org
TBR=pthatcher@webrtc.org
BUG=4227
Review URL: https://webrtc-codereview.appspot.com/39669004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8162 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-27 09:57:01 +00:00
7519de519e
Revert 8136 "Remove frame copy in ViEExternalRendererImpl::Rende..."
...
> Remove frame copy in ViEExternalRendererImpl::RenderFrame
>
> Add new interface for delivering frames to ExternalRenderer. The purpose is to avoid having to extract a packed buffer from I420VideoFrame, which will cause a deep frame copy.
>
> BUG=1128
> R=mflodman@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/36489004
TBR=magjed@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37749004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8144 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-23 21:20:41 +00:00
0f98844749
Revert 8139 "Implement elapsed time and capture start NTP time e..."
...
> Implement elapsed time and capture start NTP time estimation.
>
> These two elements are required for end-to-end delay estimation.
>
> BUG=1788
> R=stefan@webrtc.org
> TBR=pthatcher@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/36909004
TBR=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/41619004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8143 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-23 21:17:38 +00:00
ad3ee2c46b
Implement elapsed time and capture start NTP time estimation.
...
These two elements are required for end-to-end delay estimation.
BUG=1788
R=stefan@webrtc.org
TBR=pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/36909004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8139 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-23 14:55:00 +00:00
182ea46fac
Remove frame copy in ViEExternalRendererImpl::RenderFrame
...
Add new interface for delivering frames to ExternalRenderer. The purpose is to avoid having to extract a packed buffer from I420VideoFrame, which will cause a deep frame copy.
BUG=1128
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/36489004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8136 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-23 11:50:13 +00:00
e575e9c40f
Move WebRtcVideoRenderFrame from webrtcvideoengine2.cc to webrtcvideoframe.h
...
The purpose of this CL is to be able to reuse the class WebRtcVideoRenderFrame in webrtcvideoengine.cc.
R=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/32799004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7888 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-14 11:09:23 +00:00
599e299b9d
cricket::VideoFrame int64 to int64_t.
...
Needed for successful compile of ios arm64.
BUG=3898
R=pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/30359004
Patch from Zeke Chin <tkchin@webrtc.org >.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7817 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-05 09:42:57 +00:00
88d14f483b
Remove expensive and unnecessary memory alloc for sending black frames on video
...
mute.
Remove old crusty is_black_ member var in webrtcvideoengine which was not adding value.
R=henrike@webrtc.org , tpsiaki@google.com
Review URL: https://webrtc-codereview.appspot.com/26229004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7731 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-22 01:04:26 +00:00
bdcf38c894
cricket::VideoFrame: Refactor ConvertToRgbBuffer into base class
...
There is also an implementation in Chromium that can be removed if/when this lands:
content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc
R=fbarchard@google.com , pbos@webrtc.org , perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/32059004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7728 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-21 10:53:00 +00:00
4591fbd09f
Use size_t more consistently for packet/payload lengths.
...
See design doc at https://docs.google.com/a/chromium.org/document/d/1I6nmE9D_BmCY-IoV6MDPY2V6WYpEI-dg2apWXTfZyUI/edit?usp=sharing for more information.
This CL was reviewed and approved in pieces in the following CLs:
https://webrtc-codereview.appspot.com/24209004/
https://webrtc-codereview.appspot.com/24229004/
https://webrtc-codereview.appspot.com/24259004/
https://webrtc-codereview.appspot.com/25109004/
https://webrtc-codereview.appspot.com/26099004/
https://webrtc-codereview.appspot.com/27069004/
https://webrtc-codereview.appspot.com/27969004/
https://webrtc-codereview.appspot.com/27989004/
https://webrtc-codereview.appspot.com/29009004/
https://webrtc-codereview.appspot.com/30929004/
https://webrtc-codereview.appspot.com/30939004/
https://webrtc-codereview.appspot.com/31999004/
Committing as TBR to the original reviewers.
BUG=chromium:81439
TEST=none
TBR=pthatcher,henrik.lundin,tina.legrand,stefan,tkchin,glaznev,kjellander,perkj,mflodman,henrika,asapersson,niklas.enbom
Review URL: https://webrtc-codereview.appspot.com/23129004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7726 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-20 22:28:14 +00:00
a09a99950e
(Auto)update libjingle 73222930-> 73226398
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6891 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-13 17:26:08 +00:00
d4e598d57a
(Auto)update libjingle 72097588-> 72159069
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6799 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-29 17:36:52 +00:00
e9793ab8b8
(Auto)update libjingle 63111035-> 63293120
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5717 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-18 14:36:23 +00:00
16d6254e8c
Update talk to 56183333.
...
TEST=try bots
R=sheu@chromium.org
Review URL: https://webrtc-codereview.appspot.com/3469004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5087 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-05 23:45:14 +00:00
de305014c6
Update talk to 55906045.
...
Review URL: https://webrtc-codereview.appspot.com/3159005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5065 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-31 15:40:38 +00:00
28654cbc22
Update talk folder to revision=49713299.
...
TBR=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1848004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4380 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-22 21:07:49 +00:00
28e2075280
Adds trunk/talk folder of revision 359 from libjingles google code to
...
trunk/talk
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4318 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-10 00:45:36 +00:00