zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
29,094 Commits 1 Branch 0 Tags
038fd997806230cdcc23137e9c2c2e46fef74873
Commit Graph

29094 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Sebastian Jansson
86314cfb5d Cleaning up C++14 move into lambda TODOs. 
Bug: webrtc:10945
Change-Id: I4d2f358b0e33b37e4b4f7bfcf3f6cd55e8d46bf9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153240
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29212}
 2019-09-17 19:18:26 +00:00
chromium-webrtc-autoroll
368d002e48 Roll chromium_revision dbd1569418..31d9542abc (697157:697288) 
Change log: dbd1569418..31d9542abc
Full diff: dbd1569418..31d9542abc

Changed dependencies
* src/base: c4f644b627..9d1bb9a333
* src/build: 3bf1aad87c..48ea8b8e18
* src/ios: e5e3e08174..fb0b52197c
* src/testing: 79f8c8e672..24e33d5203
* src/third_party: d482089f63..cf41eae8a8
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/b19a360c12..b4e53c4a99
* src/third_party/freetype/src: cc17f852d5..99f23d6ff2
* src/tools: da9f4cfafe..f7c3756749
DEPS diff: dbd1569418..31d9542abc/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I00231a7c0097659fd6bed17b00299957f80d8715
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153403
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#29211}
 2019-09-17 18:36:01 +00:00
Mirko Bonadei
9fa8ef1f4f absl::make_unique presubmit check. 
Starting from [1], WebRTC has been migrated to std::make_unique, in
order to keep the codebase consistent, absl::make_unique is now
banned.

Output example:
** Presubmit ERRORS **
Please use std::make_unique instead of absl::make_unique.
Affected files:
  call/rtp_demuxer.cc

[1] - https://webrtc-review.googlesource.com/c/src/+/153221

Bug: webrtc:10945
Change-Id: I5b727ecc5ea8ac2ecd89cbd5fba866baf6de9012
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153355
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29210}
 2019-09-17 17:47:31 +00:00
Mirko Bonadei
317a1f09ed Use std::make_unique instead of absl::make_unique. 
WebRTC is now using C++14 so there is no need to use the Abseil version
of std::make_unique.

This CL has been created with the following steps:

git grep -l absl::make_unique | sort | uniq > /tmp/make_unique.txt
git grep -l absl::WrapUnique | sort | uniq > /tmp/wrap_unique.txt
git grep -l "#include <memory>" | sort | uniq > /tmp/memory.txt

diff --new-line-format="" --unchanged-line-format="" \
  /tmp/make_unique.txt /tmp/wrap_unique.txt | sort | \
  uniq > /tmp/only_make_unique.txt
diff --new-line-format="" --unchanged-line-format="" \
  /tmp/only_make_unique.txt /tmp/memory.txt | \
  xargs grep -l "absl/memory" > /tmp/add-memory.txt

git grep -l "\babsl::make_unique\b" | \
  xargs sed -i "s/\babsl::make_unique\b/std::make_unique/g"

git checkout PRESUBMIT.py abseil-in-webrtc.md

cat /tmp/add-memory.txt | \
  xargs sed -i \
  's/#include "absl\/memory\/memory.h"/#include <memory>/g'
git cl format
# Manual fix order of the new inserted #include <memory>

cat /tmp/only_make_unique | xargs grep -l "#include <memory>" | \
  xargs sed -i '/#include "absl\/memory\/memory.h"/d'

git ls-files | grep BUILD.gn | \
  xargs sed -i '/\/\/third_party\/abseil-cpp\/absl\/memory/d'

python tools_webrtc/gn_check_autofix.py \
  -m tryserver.webrtc -b linux_rel

# Repead the gn_check_autofix step for other platforms

git ls-files | grep BUILD.gn | \
  xargs sed -i 's/absl\/memory:memory/absl\/memory/g'
git cl format

Bug: webrtc:10945
Change-Id: I3fe28ea80f4dd3ba3cf28effd151d5e1f19aff89
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153221
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29209}
 2019-09-17 15:47:29 +00:00
Evan Shrubsole
809198edff Fix minor regression caused by a8336d3 
VideoEncoder::SetRates was being called unnessesarily when the fields
appended to RateControlParameters were changed. Since SetRates only
cares about RateControlParameters, it should have only been called if
the RateControlParameters themselves were actually changed.

Bug: webrtc:10126
Change-Id: Ic47d67e642a3043307fec950e5fba970d9f95167
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152829
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Evan Shrubsole <eshr@google.com>
Cr-Commit-Position: refs/heads/master@{#29208}
 2019-09-17 13:34:18 +00:00
Patrik Höglund
7d00342f66 Remove old packet socket factory header. 
Bug: webrtc:7447
Change-Id: I367e624070561349a2e98c00d1ce97ad8d12edeb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153347
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29207}
 2019-09-17 11:21:45 +00:00
Sebastian Jansson
e1b777717b Removing deprecated min_pacing_rate alias in StreamsConfig. 
Bug: webrtc:9883
Change-Id: I8ca9f51b60b5fc24233f14404c13b411a5f2c253
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153343
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29206}
 2019-09-17 11:20:34 +00:00
chromium-webrtc-autoroll
4a822f4b3c Roll chromium_revision 2e4ccff8a8..dbd1569418 (696956:697157) 
Change log: 2e4ccff8a8..dbd1569418
Full diff: 2e4ccff8a8..dbd1569418

Changed dependencies
* src/base: 6815595428..c4f644b627
* src/build: f44258b883..3bf1aad87c
* src/ios: 7178c1b623..e5e3e08174
* src/testing: e4bf8aa501..79f8c8e672
* src/third_party: ff1e5ce5a6..d482089f63
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d835968072..b19a360c12
* src/third_party/depot_tools: 4a60db4c3e..2c210a4908
* src/tools: eb67b7ca40..da9f4cfafe
DEPS diff: 2e4ccff8a8..dbd1569418/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I81acf7232d9e43c92f6bafbdae686ff7dc4cc6ee
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153380
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#29205}
 2019-09-17 10:35:11 +00:00
Danil Chapovalov
2c6ea52369 In TaskQueueTest::PostDelayedAfterDesctruct increase timeout 
from 2x expected time to 10x.
To decrease flakiness for task queue implemntations that destroy tasks
after destruction of the task queue.

Bug: chromium:1000531
Change-Id: Ieb37ff782ead585e0aa2c84472e3993107c5c072
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152830
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29204}
 2019-09-17 09:36:47 +00:00
Niels Möller
c1c6284cd1 New (empty) build target api:media_stream_interface 
Will be populated in a later cl.

Bug: webrtc:8733
Change-Id: I7e136645380d2264697c72f2d49403b3b9f0f044
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153341
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29203}
 2019-09-17 08:59:15 +00:00
chromium-webrtc-autoroll
172218295b Roll chromium_revision 3cf04dec00..2e4ccff8a8 (696812:696956) 
Change log: 3cf04dec00..2e4ccff8a8
Full diff: 3cf04dec00..2e4ccff8a8

Changed dependencies
* src/base: 03bceb0723..6815595428
* src/build: 36c63090ad..f44258b883
* src/ios: 06351f1c5f..7178c1b623
* src/testing: 13f4bfd01e..e4bf8aa501
* src/third_party: a624039fb7..ff1e5ce5a6
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/914862e8ec..d835968072
* src/third_party/depot_tools: 73ec83f0fe..4a60db4c3e
* src/third_party/googletest/src: cad3bc46c2..f2fb48c3b3
* src/tools: 1133315201..eb67b7ca40
DEPS diff: 3cf04dec00..2e4ccff8a8/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ic1c98d90d4490c149594c3cfb716acf582208840
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153280
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#29202}
 2019-09-16 22:34:28 +00:00
Saurav Das
7262fc29a0 Refactor Rtp Receivers to accept SSRC 0. 
Changes Rtp Receivers to use a null value of ssrc to mean a default
receive stream.

Bug: webrtc:8694
Change-Id: I835199345f7add993b9078c8b0e7988d5cdd6646
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152425
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Commit-Queue: Saurav Das <dinosaurav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#29201}
 2019-09-16 21:29:58 +00:00
Danil Chapovalov
3d1647412c in RtcpTransciever use lambdas with move capture. 
Now that c++14 allows that.

Bug: webrtc:10945
Change-Id: I218bebeb549b66c9ad3760762f2783c76d30143d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153200
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29200}
 2019-09-16 17:30:48 +00:00
chromium-webrtc-autoroll
3462793296 Roll chromium_revision 1d12ff693d..3cf04dec00 (696696:696812) 
Change log: 1d12ff693d..3cf04dec00
Full diff: 1d12ff693d..3cf04dec00

Changed dependencies
* src/base: 4e24f6c092..03bceb0723
* src/build: e7f81b6504..36c63090ad
* src/ios: d8a0bae322..06351f1c5f
* src/testing: 15e0bc2f47..13f4bfd01e
* src/third_party: 3355b26c6e..a624039fb7
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ecd10922ee..914862e8ec
* src/third_party/freetype/src: 3de1b8d0b0..cc17f852d5
* src/tools: 3692d5fe84..1133315201
DEPS diff: 1d12ff693d..3cf04dec00/DEPS

Clang version changed 8455294f2ac13d587b13d728038a9bffa7185f2b:b4160cb94c54f0b31d0ce14694950dac7b6cd83f
Details: 1d12ff693d..3cf04dec00/tools/clang/scripts/update.py

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ia39d25cc4bb0666ae08bb94763f79e07de2849e8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153030
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#29199}
 2019-09-16 16:34:50 +00:00
Danil Chapovalov
68ef259c30 Delete deprecated rtc_event.h file 
Bug: webrtc:10206
Change-Id: I6fe19bfb0b6dbef5ce73711b22fd903432f87810
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152485
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29198}
 2019-09-16 15:59:54 +00:00
Danil Chapovalov
f5dec1c6af Implement Dependency Descriptor reader 
Bug: webrtc:10342
Change-Id: I671bf57368016b633546966cc994646095433519
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152823
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29197}
 2019-09-16 15:55:54 +00:00
philipel
d9cc8c08dc Encoder switching based on network and/or resolution conditions. 
In this CL:
 - Renamed EncoderFailureCallback to EncoderSwitchRequestCallback. An encoder
   switch request can now also be made with a configuration that specifies which
   codec/implementation to switch to.
 - Added "WebRTC-NetworkCondition-EncoderSwitch" field trial that specifies
   switching conditions and desired codec to switch to.
 - Added checks to trigger the switch based on these conditions.

Bug: webrtc:10795
Change-Id: I9d3a9a39a7c4827915a40bdceed10b581d70b90a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151900
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29196}
 2019-09-16 13:43:29 +00:00
Ilya Nikolaevskiy
73ceed58f8 Update simulcast bitrate calculations for non-standard resolutions. 
* Increase 540p bitrate to 1.2mbps from 0.9mpbs.
960x540 bitrate was by far smallest in terms of bits per pixel. This change
brings it closer to other resolutions.

* Interpolate max/target/min bitrates for non-standard resolutions based
on number of pixels.

Bug: webrtc:10965
Change-Id: If0aa56bb4c614ca09ee39d3a2b700aab2ffa1a2c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152828
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29195}
 2019-09-16 13:40:59 +00:00
Mirko Bonadei
1b6a30ddcc Update WebRTC's C++ style guide to reflect the switch to C++14. 
No-Try: True
Bug: webrtc:10945
Change-Id: Ife5d5c12144e00aeefd5ccfe8470c8741ad8eb54
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151460
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29194}
 2019-09-16 11:45:35 +00:00
Niels Möller
a740142398 Refactor LossNotificationController to not use VCMPacket 
Bug: None
Change-Id: I15e1b3405c6538dd22aaeb125751c158c069478a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152384
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29193}
 2019-09-16 11:25:45 +00:00
Niels Möller
7bf7a427bf Delete flag VideoReceiveStream::Config::Rtp::remb 
This flag became unused in https://codereview.webrtc.org/2789843002;
it was set, but the setting had no effect.

Bug: webrtc:7135
Change-Id: I012a7c3600bc7a371c7a589695823b30ed5647a5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152661
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29192}
 2019-09-16 11:20:55 +00:00
Niels Möller
c4e80ad3bb Delete forward declarations from peer_connection_interface.h 
Bug: None
Change-Id: I011b5c8ae81055ae5b4941438af226665dcbd075
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152825
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29191}
 2019-09-16 09:59:56 +00:00
chromium-webrtc-autoroll
7af1bb3f90 Roll chromium_revision 9f15168729..1d12ff693d (696593:696696) 
Change log: 9f15168729..1d12ff693d
Full diff: 9f15168729..1d12ff693d

Changed dependencies
* src/base: 65481d8873..4e24f6c092
* src/build: 5106936dbf..e7f81b6504
* src/ios: 359b4b9a60..d8a0bae322
* src/testing: 344bfcdcab..15e0bc2f47
* src/third_party: 25fa157413..3355b26c6e
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/05cd93068b..5ce7022394
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/5966abc15e..ecd10922ee
* src/third_party/depot_tools: 9d25ad4192..73ec83f0fe
* src/tools: 5563770d3a..3692d5fe84
DEPS diff: 9f15168729..1d12ff693d/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I613023e3f3f8f03920e6b75eb47b947ee148ac83
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153142
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#29190}
 2019-09-16 02:40:04 +00:00
Per Åhgren
fcbe4071ce Adding more refined control over choice of band-splitting 
This CL allows the user to have more refined control over what band
splitting-scheme is used inside the audio processing module.


Bug: webrtc:6181
Change-Id: I236c3b1f96ab80cc4ffb8c39c045c034764567a1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152480
Commit-Queue: Per Åhgren <peah@webrtc.org>
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29189}
 2019-09-14 23:14:17 +00:00
chromium-webrtc-autoroll
ec06ebd25b Roll chromium_revision 9004bcf36a..9f15168729 (696490:696593) 
Change log: 9004bcf36a..9f15168729
Full diff: 9004bcf36a..9f15168729

Changed dependencies
* src/build: b9d0c17590..5106936dbf
* src/ios: af360eb286..359b4b9a60
* src/testing: 55bc86187a..344bfcdcab
* src/third_party: 6384a06c96..25fa157413
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/460542f3c0..5966abc15e
* src/third_party/depot_tools: 125d60a103..9d25ad4192
* src/third_party/googletest/src: c7a03daa99..cad3bc46c2
* src/tools: acc5a690f1..5563770d3a
DEPS diff: 9004bcf36a..9f15168729/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ica14513b054a81e132380b2e902221e457e9f52e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152960
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#29188}
 2019-09-14 00:32:45 +00:00
chromium-webrtc-autoroll
0dd37ce029 Roll chromium_revision 4740202690..9004bcf36a (696373:696490) 
Change log: 4740202690..9004bcf36a
Full diff: 4740202690..9004bcf36a

Changed dependencies
* src/base: 7160066e1b..65481d8873
* src/build: a18977d423..b9d0c17590
* src/ios: 305e63e6cb..af360eb286
* src/testing: 7330518182..55bc86187a
* src/third_party: f88173d564..6384a06c96
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/3732ed115b..460542f3c0
* src/third_party/depot_tools: 5b6ae8bc74..125d60a103
* src/tools: fbcd554ebd..acc5a690f1
DEPS diff: 4740202690..9004bcf36a/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I29aabe817c6f3d45aaef037428bedee18bbd7ab9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152920
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#29187}
 2019-09-13 20:35:11 +00:00
Mirko Bonadei
eaaaf41298 Introduce api/crypto/BUILD.gn. 
No-Try: True
Bug: webrtc:8733
Change-Id: I8679735be1e5069e371a9f1115a54e897e09964b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152622
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29186}
 2019-09-13 17:21:47 +00:00
chromium-webrtc-autoroll
6a6eb61baa Roll chromium_revision f7cd88eb51..4740202690 (696270:696373) 
Change log: f7cd88eb51..4740202690
Full diff: f7cd88eb51..4740202690

Changed dependencies
* src/base: 4e0f45b08e..7160066e1b
* src/build: 9feeba1e09..a18977d423
* src/ios: d26da0c53d..305e63e6cb
* src/testing: 3eeaff6f9f..7330518182
* src/third_party: 88bce8c16d..f88173d564
* src/third_party/depot_tools: 2d75cf6238..5b6ae8bc74
* src/tools: c698ad2923..fbcd554ebd
DEPS diff: f7cd88eb51..4740202690/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ic733b84b05902a2877a9fefc6385420b0e07b509
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152880
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#29185}
 2019-09-13 14:31:02 +00:00
Niels Möller
e78fd80cc2 New class DummyPeerConnection 
Intended as a utility base class for tests, to make it easier to
delete default implementations of PeerConnectionInterface methods.

Bug: webrtc:10716
Change-Id: Ie125747ad88d209c4797cc13253aef61275ed7b5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152820
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29184}
 2019-09-13 13:23:34 +00:00
Artem Titov
38739278ab Fix time units in plotted charts 
Bug: webrtc:10138
Change-Id: I057caa8fadb41ff09733b2bf435cee2a1f2c70c7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152822
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29183}
 2019-09-13 13:04:32 +00:00
Niels Möller
70dd16509d Delete CoreAudio include from media_engine.h 
Bug: None
Change-Id: I96f91fb64e647afc28a160700a71f1836f878ad0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150536
Commit-Queue: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29182}
 2019-09-13 12:27:19 +00:00
Kimmo Kinnunen
0a7d5d8408 Set console window NOTOPMOST flag after WindowFinderTest.FindDrawerWindow on Windows 
Otherwise it's inconvenient to run the test interactively, since
it leaves the interactive console window topmost preventing any other
window visibility even when the console window is deactivated.

Bug: webrtc:7950
Change-Id: I80a19509f1518550fe93b26feea9e8964b0e405d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150943
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Kimmo Kinnunen FI <kkinnunen@nvidia.com>
Cr-Commit-Position: refs/heads/master@{#29181}
 2019-09-13 12:02:38 +00:00
Sebastian Jansson
01be33b35e Using lambdas instead of rtc::Bind in BaseChannel. 
This makes it easier to follow the flow in a debugger and reduces
the number of methods.

Bug: webrtc:9883
Change-Id: If485ff08a223a3986ff24b29ebf4d37c325f0f26
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152669
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29180}
 2019-09-13 12:01:36 +00:00
Henrik Boström
262bbaee61 Fix rare audioLevel flake in RTCStatsIntegrationTest. 
The integration test sets up a loopback call, verifies media is flowing,
and then asserts which metrics should be available.

One of the things it asserted was that audioLevel is positive. This
could flake in rare circumstances because audioLevel requires a certain
number of samples to have been received before it is updated or else it
would have its default value zero.

This test is a broad asserting things about 150+ metrics; it's not worth
adding a dependency on the "implementation detail" about how long you
have to wait before this specific metric is non-zero. The fix for the
flake is to only require the metric to have been set, but zero is also
an acceptable value.

We don't lose much test coverage; we're still asserting that other
audio metrics originating from the same class have positive values.

Bug: webrtc:10962
Change-Id: I5def9193da7150492d89ea62031858bac5c41646
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152821
Reviewed-by: Yves Gerey <yvesg@google.com>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29179}
 2019-09-13 11:35:22 +00:00
Niels Möller
65f17ca6b4 Move MediaTransportInterface out of the libjingle_peerconnection_api target 
And move related files into api/transport/ and api/transport/media/.
The moved files are unchanged, except that
congestion_control_interface.h and datagram_transport_interface.h
no longer include media_transport_interface.h, instead, they forward
declare the few MediaTransport* types they reference.

Bug: webrtc:8733
Change-Id: I4f4000d0d111f10d15a54c99af27ec26c46ae652
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152482
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Bjorn Mellem <mellem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29178}
 2019-09-13 10:49:56 +00:00
Artem Titov
5f15f86f7c Add plotter script to plot internal test's stats 
Bug: webrtc:10138
Change-Id: I2b9d55559cf6a123914e5a597a5bf6ea6e2aa4d7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152721
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29177}
 2019-09-13 09:05:03 +00:00
Sam Zackrisson
3f17221d98 AEC3: Make RenderSignalAnalyzer multi-channel 
In this CL:
 - Render signal analyzer considers a frequency bin a narrow band
(peak) if any channel exhibits narrowband (-peak) behavior.
 - The unit tests have to fill frames with noise because small
inaccuracies in the FFT spectrum lead to consistent "narrow bands"
despite spectrum being essentially flat.

Bug: webrtc:10913
Change-Id: I8fa181412c0ee1beeacfda37ffef18251d5f0cd7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151912
Reviewed-by: Per Åhgren <peah@webrtc.org>
Commit-Queue: Sam Zackrisson <saza@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29176}
 2019-09-13 06:07:09 +00:00
chromium-webrtc-autoroll
b5a4ae8a57 Roll chromium_revision f34aba1c4b..f7cd88eb51 (696142:696270) 
Change log: f34aba1c4b..f7cd88eb51
Full diff: f34aba1c4b..f7cd88eb51

Changed dependencies
* src/base: f4abcfef40..4e0f45b08e
* src/build: 84f457cd3a..9feeba1e09
* src/buildtools: cd73d21598..cf454b247c
* src/ios: daccfbb8f2..d26da0c53d
* src/testing: f10bc9f2a6..3eeaff6f9f
* src/third_party: ade1bb5565..88bce8c16d
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/18bc4ae25c..3732ed115b
* src/third_party/depot_tools: 0910f787eb..2d75cf6238
* src/tools: de937bd3ad..c698ad2923
DEPS diff: f34aba1c4b..f7cd88eb51/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ic1f17a6586f5197b209491edfea8114c45460180
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152781
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#29175}
 2019-09-13 02:34:08 +00:00
chromium-webrtc-autoroll
1e6c415703 Roll chromium_revision 783ccff90c..f34aba1c4b (696001:696142) 
Change log: 783ccff90c..f34aba1c4b
Full diff: 783ccff90c..f34aba1c4b

Changed dependencies
* src/base: 93be3297f6..f4abcfef40
* src/build: bc4f8d5f5c..84f457cd3a
* src/ios: def494d616..daccfbb8f2
* src/testing: a892674cce..f10bc9f2a6
* src/third_party: aa98b6f250..ade1bb5565
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c979465c52..18bc4ae25c
* src/third_party/googletest/src: 33a0d4f6d7..c7a03daa99
* src/third_party/libvpx/source/libvpx: 5a0242ba5c..c094391e95
* src/tools: d0b466c553..de937bd3ad
DEPS diff: 783ccff90c..f34aba1c4b/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,marpan@webrtc.org, jianj@chromium.org,
BUG=None

Change-Id: I6a425bc4c3f105f023f167b25dcdcd5a1b52f0ef
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152703
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#29174}
 2019-09-12 20:36:06 +00:00
Artem Titov
087be5cfd4 Add ability to export internal state of SamplesStatsCounter. 
Add ability to export internal state of SamplesStatsCounter to be able
then to plot that data.

Bug: webrtc:10138
Change-Id: I5aae5b7dea2989e9f82820933a9ab6f21db17556
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152542
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29173}
 2019-09-12 19:04:58 +00:00
Qingsi Wang
cc46b10cd0 Add a usage pattern bit for host-host connections. 
Bug: None
Change-Id: I66dee594295212fcc40a7706f688c9ab15967775
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149341
Commit-Queue: Qingsi Wang <qingsi@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29172}
 2019-09-12 18:55:48 +00:00
Mirko Bonadei
352b5d836a Stop explicitly setting use_prebuilt_instrumented_libraries on msan bots. 
After https://chromium-review.googlesource.com/c/chromium/src/+/1797468
(rolled in https://webrtc-review.googlesource.com/c/src/+/152601) it's set by
default in is_msan=true builds.

Bug: webrtc:10967
Change-Id: I380ef3bf1cfdc2aba983c8506e27e3a6b2868e6d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152720
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#29171}
 2019-09-12 18:21:38 +00:00
Danil Chapovalov
a74e47759e Deprecate legacy RtpHeaderExtensionMap::Register function 
Bug: None
Change-Id: Ia27ecf4d316563c5f7693162aedff535855c403b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152667
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29170}
 2019-09-12 17:04:01 +00:00
Ruslan Burakov
aa5a75d5e3 Embed Deceleration Target Level Offset Field Trial. 
Bug: webrtc:10619
Change-Id: I4ef75ae03d6071bf84d2c1b6e50290ea26e83496
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152663
Commit-Queue: Ruslan Burakov <kuddai@google.com>
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org>
Reviewed-by: Minyue Li <minyue@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29169}
 2019-09-12 14:55:13 +00:00
Erik Språng
ef85f2bdb8 Clean away unused enum RtpPacketSendResult 
Also updates outdated comment.

Bug: webrtc:8052
Change-Id: Ib88c2894bdda5efcf36d8d7dfbacbe96edf1b549
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152180
Commit-Queue: Erik Språng <sprang@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29168}
 2019-09-12 13:52:22 +00:00
Niels Möller
ca79dc6779 Delete VideoReceiver2::TriggerDecoderShutdown. 
This method used to be wired down to VCMReceiver and to
VCMJitterBuffer::Stop, but has become a nop. Also delete some
obsoleted comments.

Bug: webrtc:7408
Change-Id: I4c1e67272b1ffda786cc0ff358fa38e594aff304
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152620
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29167}
 2019-09-12 13:44:13 +00:00
Danil Chapovalov
d8ac383bba Delete temporary accessors in RtpDepacketizer::ParsedPayload 
Bug: webrtc:10397
Change-Id: I86f4623b12e2a92ca541c0c22680fa6ab1ea7f44
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152665
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29166}
 2019-09-12 12:57:34 +00:00
chromium-webrtc-autoroll
3d5825eead Roll chromium_revision 0d1efbbba4..783ccff90c (695897:696001) 
Change log: 0d1efbbba4..783ccff90c
Full diff: 0d1efbbba4..783ccff90c

Changed dependencies
* src/build: f92855e31b..bc4f8d5f5c
* src/ios: a75b2b7bd2..def494d616
* src/testing: f61324781d..a892674cce
* src/third_party: 2250890ea2..aa98b6f250
* src/third_party/depot_tools: 0e85f633c7..0910f787eb
* src/tools: 3555a687ba..d0b466c553
DEPS diff: 0d1efbbba4..783ccff90c/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: If1f92b40f960dc91848fd6aa6b7ac380a2a97236
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152681
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#29165}
 2019-09-12 12:35:10 +00:00
henrika
69f8c42d2c [RELAND] Add support of AudioRecord.Builder in the ADM for Android 
Now fixed issue which caused http://b/140707892

First version was reverted in https://webrtc-review.googlesource.com/c/src/+/152526.
The mistake I had done in the original version was that I missed that the new
builder could throw a different type of exception and it was never caught.

TBR: glaznev@webrtc.org
Bug: webrtc:10942
Change-Id: I0e11511936d2d25681a1ffae3bbd367095fee7a1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152664
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Commit-Queue: Henrik Andreassson <henrika@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29164}
 2019-09-12 11:44:20 +00:00
Per Kjellander
dc7d2c6fd7 Backoff to acked bitrate during first overuse detection 
In DelayBasedBwe, in experiment WebRTC-Bwe-AlrLimitedBackoff, back off relative the BWE only after the first detected overuse. The first time overuse is detected, back down to the acked bitrate.

The idea is to faster drop BWE in the beginning of the call when the initial BWE guess may be too high. Withouth this, it may take a too long time to initially back down.

BUG=webrtc:10542

Change-Id: I2a11457d2391ad25658e7c13d9cae02a38973ecb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152541
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29163}
 2019-09-12 10:51:45 +00:00