c3e6fb15fc
Roll chromium_revision 6d60176510..6b07a87fa1 (743892:744028)
...
Change log: 6d60176510..6b07a87fa16d60176510..6b07a87fa10794106942..ca1cf531543e271e1ba5..44419b6dacfeb2d0c562..ef2f1b3249d999d54f4b..43bb9f8722c5aa761a80..a7417a1ed8f07276793c..3b56c91e44f4d9303129..6f0f4e40c1e64334fd9c..f03d48d55a6d60176510..6b07a87fa1TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ie2f02bef70c9bb314c5eb888dd0c1b65998b9bde
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169024
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30597}
2020-02-24 20:34:48 +00:00
98d5bbba58
loosen ice-ufrag/ice-pwd ice-char restrictions further
...
Loosen the restrictions for ice-char by also allowing
'#' (known to break) and '_' (urlsafe base64) in addition
to the existing exceptions for '-' and '='.
Also fixes typo in log message.
BUG=chromium:1053756
Change-Id: I8f254a7c25f780276452fa3e27245b6b7ad1a3ce
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168943
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30596}
2020-02-24 20:07:48 +00:00
ce515f7625
Add an integration test frame encryption works with DependencyDescriptor
...
Bug: webrtc:10342
Change-Id: I3a18c1fbe222eada7a484f8f62a0b5bad76eb073
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168888
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30595}
2020-02-24 16:01:04 +00:00
c63bf10790
VoIP interface headers in api/voip directory. This separates the implementation that will come in audio/voip.
...
Bug: webrtc:11251
Change-Id: I26b6915d3ad6bb5a50f9898a6866889867fd53f5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169000
Commit-Queue: Tim Na <natim@webrtc.org >
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30594}
2020-02-24 15:23:19 +00:00
49734dc0fa
Reland "Refactors UlpFec and FlexFec to use a common interface."
...
This is a reland of 11af1d7444fd7438766b7bc52cbd64752d72e32e
Original change's description:
> Refactors UlpFec and FlexFec to use a common interface.
>
> The new VideoFecGenerator is now injected into RtpSenderVideo,
> and generalizes the usage.
> This also prepares for being able to genera FEC in the RTP egress
> module.
>
> Bug: webrtc:11340
> Change-Id: I8aa873129b2fb4131eb3399ee88f6ea2747155a3
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168347
> Reviewed-by: Stefan Holmer <stefan@webrtc.org >
> Reviewed-by: Sebastian Jansson <srte@webrtc.org >
> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
> Commit-Queue: Erik Språng <sprang@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30515}
Bug: webrtc:11340, chromium:1052323
Change-Id: Id646047365f1c46cca9e6f3e8eefa5151207b4a0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168608
Commit-Queue: Erik Språng <sprang@webrtc.org >
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30593}
2020-02-24 14:20:27 +00:00
1883d3e231
Optimizations and refactoring of the APM 3-band split filter
...
This CL refactors and optimizes the 3-band split-filter in APM, which
is a very computationally complex component.
Beyond optimizing the code, the filter coefficients are also quantized
to avoid denormals.
The changes reduces the complexity of the split filter by about 30-50%.
The CL has been tested for bitexactness on a number of aecdump
recordings.
(the CL also removes the now unused code for the sparse_fir_filter)
Bug: webrtc:6181
Change-Id: If45f8d1f189c6812ccb03721156c77eb68181211
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168189
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Per Åhgren <peah@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30592}
2020-02-24 13:19:14 +00:00
0e089db913
Roll chromium_revision ce459ab383..6d60176510 (742528:743892)
...
Manual changes:
- Changed git repos for libcxx, libcxxabi and libunwind since they
changed in Chromium.
- Suppressed failing test on MSAN.
Change log: ce459ab383..6d60176510ce459ab383..6d601765101d6cd336dc..0794106942188f078b2d..3e271e1ba5afc5b798c7..feb2d0c56278d6a7767e..d9040c75cf0d529660e3..196ba1aaa869d9b84cca..d999d54f4b084a00adec..c5aa761a80688f493e49..f07276793cc6a4254b5e..f4d9303129https://boringssl.googlesource.com/boringssl.git/+log/7e43e2e8ee..6432bb46ab
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/9508452e18..d5a5c48017
* src/third_party/depot_tools: 10e0e6d6c1..1773f37de6bcc5d9fec0..545152f302d09e831559..fa147af4a536133b04c0..55f2e4a0a8af708e0676..e64334fd9cce459ab383..6d60176510TBR=phoglund@webrtc.org ,marpan@webrtc.org , jianj@chromium.org ,
BUG=webrtc:11376
Change-Id: I5c45376e397c4ce6f9c151626b2280c750ca420c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168946
Commit-Queue: Patrik Höglund <phoglund@webrtc.org >
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30591}
2020-02-24 13:08:34 +00:00
c1cf4b5491
Improve comment in perf_test.h.
...
I think these functions are so hard to understand, so I tried to
make an as grounded example as possible.
Bug: chromium:1029452
Change-Id: I5d4284bc15b39cb94ba42d2c483a619ecf42fb91
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168945
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: Patrik Höglund <phoglund@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30590}
2020-02-24 11:47:28 +00:00
1db70d5c7b
Reland "Delete legacy DataSize and DataRate factories"
...
This reverts commit 74c5b0ac239141606b3c09022088d440941bfe3b.
Reason for revert: downstream code adjusted
Original change's description:
> Revert "Delete legacy DataSize and DataRate factories"
>
> This reverts commit 70490aa3a0b08c9342ea9a12d5ac1fa9666fb7fb.
>
> Reason for revert: Breaks downstream project.
>
> Original change's description:
> > Delete legacy DataSize and DataRate factories
> >
> > Bug: webrtc:9709
> > Change-Id: Ia9464893ec9868c51d72eedaee8efc82b0c17b28
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168722
> > Reviewed-by: Sebastian Jansson <srte@webrtc.org >
> > Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30564}
>
> TBR=danilchap@webrtc.org ,srte@webrtc.org
>
> Change-Id: I3f5a8b4ec473bd2af80ca3acfe0e9c82f25a12ba
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:9709
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168940
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30574}
TBR=danilchap@webrtc.org ,mbonadei@webrtc.org ,srte@webrtc.org
Change-Id: If05a6b2aa3d4c50caac52f50c13ba56c1e2c810d
Bug: webrtc:9709
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168960
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30589}
2020-02-24 09:50:35 +00:00
ecbdbf6ee8
Reland "Update RTCEncodedImage to not use deprecated mutable_data call."
...
This reverts commit 966bcc4bd5cc7aee5963e784ddf0caf668b2d6e6.
Reason for revert: Fixing upstream issues.
Original change's description:
> Revert "Update RTCEncodedImage to not use deprecated mutable_data call."
>
> This reverts commit 677e62785dd39cbc730edcbb7ef99909dd292b11.
>
> Reason for revert:
> The RTC_DCHECK_EQ(self.buffer.bytes, self.encodedData->data()) line is triggering for every call
>
> Original change's description:
> > Update RTCEncodedImage to not use deprecated mutable_data call.
> >
> > Bug: webrtc:9378
> > Change-Id: If1e6284e2d11009097c87d15b98a2768a1d71521
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168524
> > Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
> > Reviewed-by: Niels Moller <nisse@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30518}
>
> TBR=nisse@webrtc.org ,kthelgason@webrtc.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: webrtc:9378
> Change-Id: I91b6df1148224785c209a7306ec186a952f5e289
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168620
> Reviewed-by: Zeke Chin <tkchin@webrtc.org >
> Commit-Queue: Zeke Chin <tkchin@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30527}
TBR=nisse@webrtc.org ,kthelgason@webrtc.org ,tkchin@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:9378
Change-Id: I1c0e61d8a390a5999f8dbbbda6f094d71f9b0678
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168740
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30588}
2020-02-24 09:46:35 +00:00
d6e8e80883
Revert "Reland "Reland "Reland "Reland "Implemented screen enumeration and selection for desktop capture under X11 using the X Resize and Rotate extension version 1.5."""""
...
This reverts commit c8496e9814ad2681b372946f143d1acb45475c7e.
Reason for revert: This broke Chrome Remote Desktop, please see http://crbug.com/1049804 .
Original change's description:
> Reland "Reland "Reland "Reland "Implemented screen enumeration and selection for desktop capture under X11 using the X Resize and Rotate extension version 1.5.""""
>
> This is a reland of 703a5d76d9ba8e7984509cc7bf70fb4ed84ef6be
>
> Original change's description:
> > Reland "Reland "Reland "Implemented screen enumeration and selection for desktop capture under X11 using the X Resize and Rotate extension version 1.5."""
> >
> > This is a reland of af51be7869994a299451e22e6382ae641767b26d
> >
> > Original change's description:
> > > Reland "Reland "Implemented screen enumeration and selection for desktop capture under X11 using the X Resize and Rotate extension version 1.5.""
> > >
> > > This is a reland of a0adf3d4409036d095480e9bfa0fc06990362f84
> > >
> > > Original change's description:
> > > > Reland "Implemented screen enumeration and selection for desktop capture under X11 using the X Resize and Rotate extension version 1.5."
> > > >
> > > > This is a reland of e7153012682ccd3d1eacc18f802cab7820e3bad3
> > > >
> > > > Original change's description:
> > > > > Implemented screen enumeration and selection for desktop capture under X11 using the X Resize and Rotate entension version 1.5.
> > > > >
> > > > > Bug: chromium:396091
> > > > > Change-Id: Ia1b36c771632c536bb8d15322461b479fabc409e
> > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148768
> > > > > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org >
> > > > > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org >
> > > > > Cr-Commit-Position: refs/heads/master@{#29083}
> > > >
> > > > Bug: chromium:396091
> > > > Change-Id: I0d9171ae5f340e0489e4b45ce5d97bc52b0a4904
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156067
> > > > Commit-Queue: Tommi <tommi@webrtc.org >
> > > > Reviewed-by: Tommi <tommi@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#29655}
> > >
> > > Bug: chromium:396091
> > > Change-Id: I47525911095fabc6cee613d03b0d83134b95b084
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158900
> > > Reviewed-by: Tomas Gunnarsson <tommi@chromium.org >
> > > Reviewed-by: Tommi <tommi@webrtc.org >
> > > Commit-Queue: Tommi <tommi@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30032}
> >
> > Bug: chromium:396091
> > Change-Id: I03702c8ea935bb5fe1797defda1ba6b279b95217
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165724
> > Reviewed-by: Jamie Walch <jamiewalch@chromium.org >
> > Commit-Queue: Jamie Walch <jamiewalch@chromium.org >
> > Cr-Commit-Position: refs/heads/master@{#30461}
>
> TBR=jamiewalch@chromium.org ,tommi@webrtc.org
>
> Bug: chromium:396091
> Change-Id: If9bd5e7b35240acc4dd528397926ba663fe2affc
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168760
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30548}
TBR=zijiehe@chromium.org ,mbonadei@webrtc.org ,jamiewalch@chromium.org ,tommi@webrtc.org ,julien.isorce@chromium.org ,sergeyu@chromium.org ,tommi@chromium.org ,trevor.axiom@gmail.com ,jonringle@gmail.com ,justin.franco@arterys.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:396091
Change-Id: I39617376ac4fe028131336d2148801b7733183f5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169001
Reviewed-by: Jamie Walch <jamiewalch@chromium.org >
Commit-Queue: Jamie Walch <jamiewalch@chromium.org >
Cr-Commit-Position: refs/heads/master@{#30587}
2020-02-22 03:31:36 +00:00
4a06666325
Only set vp9 config when it's changed.
...
~3-5% speed up on webrtc_perf_tests of vp9 on linux desktop.
Avoid going thru a lot of unnecessary code checks.
Change-Id: I2cb0d794bcf239c5057dfc04cd07a496f89a5016
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167640
Commit-Queue: Jerome Jiang <jianj@google.com >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30586}
2020-02-21 20:09:31 +00:00
5ed40cfa2e
Do not request encoder switch when the video is suspended.
...
Bug: None
Change-Id: I0ecd4db4ee53e1eb6682a2a98b684fcdf5c2e93b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168924
Commit-Queue: Mirta Dvornicic <mirtad@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30585}
2020-02-21 17:54:52 +00:00
9526c557be
Refactoring mock_transport to be used separately
...
Bug: webrtc:11251
Change-Id: I0a494c34c8d5c458b4d9b1b3616ae360d04df0d4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168980
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Commit-Queue: Tim Na <natim@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30584}
2020-02-21 17:02:52 +00:00
11146cdfea
Reland "Remove old-style OnFailure callbacks"
...
This is a reland of 1a290e4495c8132e7ff2c44d78de5e1d7eefdb9e
after fixing the downstream projects.
Original change's description:
> Remove old-style OnFailure callbacks
>
> Also delete default implementation of new-style OnFailure,
> since it can't call the deprecated function.
>
> Deprecating the old-style OnFailure callback turned out to be impossible,
> since one can't have the new-style callback call the old-style one.
>
> Bug: chromium:589455
> Change-Id: Icf529ddb02d99ad9e205095d5a1fbeb0da91dd0e
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146219
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Commit-Queue: Harald Alvestrand <hta@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30570}
Bug: chromium:589455
Change-Id: I7227e3c6886c504043b019b621e45658cbd6fd53
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168941
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30583}
2020-02-21 14:07:57 +00:00
a5943ea50e
Roll chromium_revision dd5a54c29b..ce459ab383 (736224:742528)
...
Change log: dd5a54c29b..ce459ab383dd5a54c29b..ce459ab383ce806f00e6..1d6cd336dc2f17606c25..188f078b2d31829ea7dd..084a00adec403d2930e5..688f493e4918f4ad54fc..c6a4254b5ehttps://boringssl.googlesource.com/boringssl.git/+log/1cc95ac07c..7e43e2e8ee
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2e0a0cb9ad..9508452e18
* src/third_party/depot_tools: ea8b58b970..10e0e6d6c1e5038be704..d09e831559306f3754a7..10b1902d895440313924..63b8190db8dbd3825b31..9f4020916e4254ecaa07..36133b04c03d6dcabf55..f2df0efb0339d70a2950..af708e0676885b3febcc..0ac28472d0dd5a54c29b..ce459ab383dd5a54c29b..ce459ab383TBR=phoglund@webrtc.org ,marpan@webrtc.org , jianj@chromium.org ,
BUG=None
Change-Id: Ifd7b8be046320123a0dd0a4c782c57e704ab6bb6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168763
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Commit-Queue: Patrik Höglund <phoglund@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30582}
2020-02-21 12:42:55 +00:00
1dea1ea412
[VP9 encoder] Set temporal id also on disabled spatial layers
...
Bug: chromium:1051476
Change-Id: Iaf2b6ab6640cd314a620dbdf1547d8f1b2f40693
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168921
Reviewed-by: Evan Shrubsole <eshr@google.com >
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30581}
2020-02-21 12:03:09 +00:00
694b74b826
Fix export of plottable metrics on iOS
...
Bug: None
Change-Id: I12c3cecb92e5f163f9451d6f90de3bce9b15bca1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168942
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30580}
2020-02-21 10:48:35 +00:00
3cc6e05243
Whitespace change to kick bots.
...
Testing recipe change.
Change-Id: I3945972fa843fbc014fd4a6fdcb0c567b5aff93c
Tbr: mbonadei@webrtc.org
Bug: webrtc:11349
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168963
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Commit-Queue: Patrik Höglund <phoglund@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30579}
2020-02-21 10:30:05 +00:00
95800f6298
Authenticate video header when dependency descriptor is sent
...
same way as generic frame descriptor is authenticated.
Bug: webrtc:10342
Change-Id: I50bb3ab343d66f1f628083183444da6e338f7db9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168681
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Markus Handell <handellm@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30578}
2020-02-20 15:57:39 +00:00
f5c1909b54
Make pc level smoke tests faster.
...
They go from 7 seconds each to 2 seconds each with this change, and
I belive they will catch correctness bugs just as well.
With this and https://webrtc-review.googlesource.com/c/src/+/168884 ,
test_support_unittests now runs in 14 seconds instead of 65 (in
sequential mode).
Bug: None
Change-Id: Ic04e3937bbff54f33dcd062f422dada176f1c3cb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168885
Commit-Queue: Patrik Höglund <phoglund@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30577}
2020-02-20 15:41:09 +00:00
dbf5416a80
Delete header file rtc_base/memory/aligned_array.h
...
Move definition of AlignedArray to the only code using it, the
test-only LappedTransform class, and delete unused methods.
Bug: webrtc:6424, webrtc:9577
Change-Id: I1bb5f57400f7217345b7ec7376235ad4c4bae858
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168701
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30576}
2020-02-20 14:55:25 +00:00
9a4eb32477
Change the AudioDeiviceDataObserver to be passed as a unique_ptr.
...
Bug: webrtc:11356
Change-Id: If89305f257fd966d83f37dbd03922c4d030b6d8f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168771
Commit-Queue: Fabian Bergmark <fabianbergmark@google.com >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30575}
2020-02-20 14:45:15 +00:00
74c5b0ac23
Revert "Delete legacy DataSize and DataRate factories"
...
This reverts commit 70490aa3a0b08c9342ea9a12d5ac1fa9666fb7fb.
Reason for revert: Breaks downstream project.
Original change's description:
> Delete legacy DataSize and DataRate factories
>
> Bug: webrtc:9709
> Change-Id: Ia9464893ec9868c51d72eedaee8efc82b0c17b28
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168722
> Reviewed-by: Sebastian Jansson <srte@webrtc.org >
> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30564}
TBR=danilchap@webrtc.org ,srte@webrtc.org
Change-Id: I3f5a8b4ec473bd2af80ca3acfe0e9c82f25a12ba
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9709
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168940
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30574}
2020-02-20 14:42:26 +00:00
4805a480fe
Revert "Remove old-style OnFailure callbacks"
...
This reverts commit 1a290e4495c8132e7ff2c44d78de5e1d7eefdb9e.
Reason for revert: Breaks downstream project.
Original change's description:
> Remove old-style OnFailure callbacks
>
> Also delete default implementation of new-style OnFailure,
> since it can't call the deprecated function.
>
> Deprecating the old-style OnFailure callback turned out to be impossible,
> since one can't have the new-style callback call the old-style one.
>
> Bug: chromium:589455
> Change-Id: Icf529ddb02d99ad9e205095d5a1fbeb0da91dd0e
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146219
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Commit-Queue: Harald Alvestrand <hta@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30570}
TBR=steveanton@webrtc.org ,kwiberg@webrtc.org ,hta@webrtc.org
Change-Id: Ibc46b7a7294fb906f848e4528a85c09cbb62b913
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:589455
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168920
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30573}
2020-02-20 14:39:36 +00:00
d881983a38
Change faq.md titles.
...
TBR=phoglund@webrtc.org
No-Try: True
Bug: None
Change-Id: I9d12ed705674826fd9ac0718e09fbb3302c996bd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168900
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30572}
2020-02-20 14:24:29 +00:00
97ba4be4b7
Add FAQ page for git repo.
...
No-Try: True
Bug: None
Change-Id: I6737b5adee6e3db45b5825a01460b66690eec896
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168883
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30571}
2020-02-20 14:09:49 +00:00
1a290e4495
Remove old-style OnFailure callbacks
...
Also delete default implementation of new-style OnFailure,
since it can't call the deprecated function.
Deprecating the old-style OnFailure callback turned out to be impossible,
since one can't have the new-style callback call the old-style one.
Bug: chromium:589455
Change-Id: Icf529ddb02d99ad9e205095d5a1fbeb0da91dd0e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146219
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30570}
2020-02-20 13:21:54 +00:00
cdda76d1c8
Make scenario unittests faster.
...
They now run in 3 seconds rather than 45 or whatever it was before.
The tests still pass (and I tried with gtest_repeat=25), so I think
the shorter time is sufficient to prove the code works and doesn't
crash. Unit tests need to be fast. I think it's unlikely a longer
runtime would make this test a better correctness test, but let me
know if there's something in particular with this code that needs
the longer runtime.
Bug: None
Change-Id: I3f4213718870a1772f7a19e3c418634031c46de3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168884
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Patrik Höglund <phoglund@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30569}
2020-02-20 12:34:15 +00:00
2e161c4dd6
Revert "Remove ResourceAdaptationModule::OnMaybeEncodeFrame"
...
This reverts commit 93d9ae8a17f2e7b90641cbac28e740afc67d383a.
Reason for revert: Perf regression.
Original change's description:
> Remove ResourceAdaptationModule::OnMaybeEncodeFrame
>
> We can react just as well at OnEncodeVideoFrame, which is the same
> behaviour except after checking if the Encoder is paused and the frame
> dropper.
>
> For the initial frame drop, the frame dropper is irrelevant as the frame
> can not be dropped until we are accepting frames. If we didn't drop the
> frame, the encoder can't be paused as the data rate
> is over 0.
>
> For the quality rampup experiment, similar for encoder paused - we can't
> rampup if we are paused anyways since the data rate needs to be non-zero.
> If we are dropping frames we likely don't want to do quality rampup
> anyways.
>
> Bug: webrtc:11222
> Change-Id: Ie3e09d9d8d509dc17ba7a1443cf4747f61c04f6a
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168601
> Reviewed-by: Henrik Boström <hbos@webrtc.org >
> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
> Commit-Queue: Evan Shrubsole <eshr@google.com >
> Cr-Commit-Position: refs/heads/master@{#30539}
TBR=ilnik@webrtc.org ,hbos@webrtc.org ,eshr@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
No-Try: True
Bug: webrtc:11222
Change-Id: Ifb2fc74eb7572568fb0ee1b53a09e4180f87b30c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168880
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30568}
2020-02-20 11:03:25 +00:00
b5ffd47156
Fix required property for iOS tests.
...
Turns out that MacOS 10.14.6 requires CFBundleShortVersionString (it
refuses to install the app if the string isn't there).
This should fix the iOS 64-bit bots.
Bug: chromium:1053891
Change-Id: I3278502eff9813fed9a2d8e442c940dfb70377cb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168882
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Patrik Höglund <phoglund@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30567}
2020-02-20 11:01:45 +00:00
e7fe3a5086
Update target rates if stable target has changed.
...
Bug: None
Change-Id: I93572290a41f44582b84cee8aec511a4b10a09da
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168765
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30566}
2020-02-20 10:51:20 +00:00
f0276c5d0f
Lazy conversion to i420 buffer in SimulcastEncoderAdapter
...
This CL makes native the preferred buffer type, and if any of the
encoders in the adapter do not support native, the input frame will
be converted to I420 and used as input to encoders that require it,
along with any needed downscaling.
Bug: chromium:1052352
Change-Id: Iff43d6dc56793037a6164729b9e6c69797b6f8cd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168609
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30565}
2020-02-20 10:50:15 +00:00
70490aa3a0
Delete legacy DataSize and DataRate factories
...
Bug: webrtc:9709
Change-Id: Ia9464893ec9868c51d72eedaee8efc82b0c17b28
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168722
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30564}
2020-02-20 09:35:48 +00:00
e8f4e09be9
Parse DependencyDescriptor rtp header extension
...
Bug: webrtc:10342
Change-Id: I1b5914232f73803774523fae215cf719c92da305
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168481
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30563}
2020-02-20 09:09:27 +00:00
ee9da5e2c0
Whitespace change to kick bots.
...
Testing recipe change.
Tbr: mbonadei@webrtc.org
Bug: chromium:1053891
Change-Id: I36f344c6356296246b70320eeaf7c205af9e8341
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168821
Commit-Queue: Patrik Höglund <phoglund@webrtc.org >
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30562}
2020-02-20 06:45:24 +00:00
d85ea75cbd
Rollback transport created by data channel
...
No-Try: True
Bug: chromium:1032987
Change-Id: I2c0dbd6a19e71a391dc2e0d30676d4efa26a9525
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168306
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30561}
2020-02-20 01:24:55 +00:00
48e849f569
loosen ice-ufrag/ice-pwd ice-char restrictions
...
Loosen the restrictions for ice-char by allowing
'-' and '='. Being spec-compliant breaks interoperability.
The spec-behaviour will be restored with a notice period.
BUG=chromium:1053756,chromium:1044521
No-Try: True
Change-Id: I880babd0869302bd713912ddfcfa48866fad32c1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168820
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30560}
2020-02-19 22:51:58 +00:00
8041b651a3
Add YUV to IVF video converter util
...
Bug: webrtc:10138
Change-Id: I79ca08c45a664c66b15a1ed0c1322719c9f5574d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161449
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30559}
2020-02-19 14:44:21 +00:00
4a14f4997c
Remove wildcard ownership for build files.
...
No-Try: True
Bug: webrtc:10381
Change-Id: I852d9a2da7e0c5c12f508a1c788b0b5753503aba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168769
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30558}
2020-02-19 14:05:46 +00:00
b42c54f949
Refactor parsing generic descriptor extension into own function
...
Before making it even more complicated that it is right now.
Bug: webrtc:10342
Change-Id: I54f67309b8832cd85b6c5213f9b090908814ebd7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168766
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30557}
2020-02-19 13:50:36 +00:00
e52115a33e
Remove inactive OWNERS.
...
No-Try: True
Bug: webrtc:10381
Change-Id: I3b56c74d913a47e4297518005b0cb19de8fafbff
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168421
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30556}
2020-02-19 13:37:36 +00:00
b6c2ba1f3f
Remove unused compile-dep from sdk/android:base_java target
...
Bug: None
Change-Id: I0b9715464d4428966c5c53cc9fafb6762aae0d86
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168764
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30555}
2020-02-19 12:46:26 +00:00
f84cf9edff
Fix dead link.
...
I also improved the text on the site (separate CL).
No-Try: True
Bug: None
Change-Id: I04de0c34663f7e13004403170506eb337dc4d5bd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168127
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Patrik Höglund <phoglund@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30554}
2020-02-19 10:35:14 +00:00
9d3626d15d
Make error message more actionable.
...
When the assertion triggers, manual action is likely needed. This
CL changes the error message to make it more clear.
No-Try: True
Bug: webrtc:11369
Change-Id: I7d8b04deef7638e715b12e6dceeee9cc2ce2cc66
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168761
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30553}
2020-02-19 10:34:09 +00:00
4256df09bf
Make CNAME optional.
...
Before this change, lack of a CNAME results in losing all SSRC
information. This isn't necessary; we don't even use the CNAME for
anything on the receiving side.
Note that lack of a CNAME is technically a violation of
https://tools.ietf.org/html/rfc5576#section-6.1 .
Bug: webrtc:10385
Change-Id: If9836b6c518367b29ffa1fb00752e52d51915d37
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168581
Commit-Queue: Taylor <deadbeef@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30552}
2020-02-18 23:09:05 +00:00
567f03f7a0
Add constants for allowed network_priority values
...
After chromium switches to using these, they'll be changed to an enum.
Bug: webrtc:5658
Change-Id: Ic5d7d4651d204c31822194bd02c587e5b887ee17
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168562
Commit-Queue: Taylor <deadbeef@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30551}
2020-02-18 22:52:45 +00:00
e6ca3b8c38
Add missing interface methods.
...
DesktopCapturer includes a few methods that are not pure virtual because
they were added after implementions existed in Chromium. The intent was
to implement them in Chromium and then make them pure virtual, but that
never happened, which caused a bug when DesktopAndCursorComposer did not
delegate source-selection methods to the underlying capturer.
This CL adds the missing methods to a couple of simple pass-through
capturers; I will follow up with the necessary implementations for other
capturers once I've fixed the underlying remoting bug.
Change-Id: Icb3914a3cb3116878f57a9f685163c7670c1f89b
Bug: webrtc:11370
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168780
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org >
Commit-Queue: Jamie Walch <jamiewalch@chromium.org >
Cr-Commit-Position: refs/heads/master@{#30550}
2020-02-18 22:36:00 +00:00
1282babe66
Fix tests in RTCMetalVideoView.
...
RTCMTLVideoViewTests is currently broken, because RTCMTLVideoView
doesn't render into an empty view.
Bug: webrtc:11322
Change-Id: I84f9216024c277ddafd4d2e6416d7e7c818aa16d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168580
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30549}
2020-02-18 20:42:10 +00:00
c8496e9814
Reland "Reland "Reland "Reland "Implemented screen enumeration and selection for desktop capture under X11 using the X Resize and Rotate extension version 1.5.""""
...
This is a reland of 703a5d76d9ba8e7984509cc7bf70fb4ed84ef6be
Original change's description:
> Reland "Reland "Reland "Implemented screen enumeration and selection for desktop capture under X11 using the X Resize and Rotate extension version 1.5."""
>
> This is a reland of af51be7869994a299451e22e6382ae641767b26d
>
> Original change's description:
> > Reland "Reland "Implemented screen enumeration and selection for desktop capture under X11 using the X Resize and Rotate extension version 1.5.""
> >
> > This is a reland of a0adf3d4409036d095480e9bfa0fc06990362f84
> >
> > Original change's description:
> > > Reland "Implemented screen enumeration and selection for desktop capture under X11 using the X Resize and Rotate extension version 1.5."
> > >
> > > This is a reland of e7153012682ccd3d1eacc18f802cab7820e3bad3
> > >
> > > Original change's description:
> > > > Implemented screen enumeration and selection for desktop capture under X11 using the X Resize and Rotate entension version 1.5.
> > > >
> > > > Bug: chromium:396091
> > > > Change-Id: Ia1b36c771632c536bb8d15322461b479fabc409e
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148768
> > > > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org >
> > > > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org >
> > > > Cr-Commit-Position: refs/heads/master@{#29083}
> > >
> > > Bug: chromium:396091
> > > Change-Id: I0d9171ae5f340e0489e4b45ce5d97bc52b0a4904
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156067
> > > Commit-Queue: Tommi <tommi@webrtc.org >
> > > Reviewed-by: Tommi <tommi@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#29655}
> >
> > Bug: chromium:396091
> > Change-Id: I47525911095fabc6cee613d03b0d83134b95b084
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158900
> > Reviewed-by: Tomas Gunnarsson <tommi@chromium.org >
> > Reviewed-by: Tommi <tommi@webrtc.org >
> > Commit-Queue: Tommi <tommi@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30032}
>
> Bug: chromium:396091
> Change-Id: I03702c8ea935bb5fe1797defda1ba6b279b95217
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165724
> Reviewed-by: Jamie Walch <jamiewalch@chromium.org >
> Commit-Queue: Jamie Walch <jamiewalch@chromium.org >
> Cr-Commit-Position: refs/heads/master@{#30461}
TBR=jamiewalch@chromium.org ,tommi@webrtc.org
Bug: chromium:396091
Change-Id: If9bd5e7b35240acc4dd528397926ba663fe2affc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168760
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30548}
2020-02-18 19:05:07 +00:00
