Commit Graph

17 Commits

Author SHA1 Message Date
2b3bf6b7d5 Re-enabling socket tests that were previously flaky.
It's assumed that these tests were flaky because they used a non-virtual
resource (sockets) and were being run in parallel. So this should be
fixed now that these tests are now not being run in parallel, thanks to
this CL: https://codereview.webrtc.org/1426643003

BUG=webrtc:4923
R=pthatcher@webrtc.org

Review URL: https://codereview.webrtc.org/1982733002 .

Cr-Commit-Position: refs/heads/master@{#12817}
2016-05-19 21:57:40 +00:00
555604a746 Replace scoped_ptr with unique_ptr in webrtc/base/
This propagated into various other places. Also had to #include headers that
were implicitly pulled by "scoped_ptr.h".

BUG=webrtc:5520

Review URL: https://codereview.webrtc.org/1920043002

Cr-Commit-Position: refs/heads/master@{#12501}
2016-04-26 10:13:28 +00:00
f2a2bf4ae4 Stay writable after partial socket writes.
This CL fixes an issue where the "writable" flag didn't stay set after
::send or ::sendto only sent a partial buffer.

Also SocketTest::TcpInternal has been updated to use rtc::Buffer instead
of manually allocating data.

BUG=webrtc:4898

Review URL: https://codereview.webrtc.org/1616153007

Cr-Commit-Position: refs/heads/master@{#11480}
2016-02-04 00:45:38 +00:00
e2976c87f7 Remove DISABLED_ON_ macros.
Macro incorrectly displays DISABLED_ON_ANDROID in test names for
parameterized tests under --gtest_list_tests, causing tests to be
disabled on all platforms since they contain the DISABLED_ prefix rather
than their expanded variants.

This expands the macro variants to inline if they're disabled or not,
and removes building some tests under configurations where they should
fail, instead of building them but disabling them by default.

The change also removes gtest_disable.h as an unused include from many
other files.

BUG=webrtc:5387, webrtc:5400
R=kjellander@webrtc.org, phoglund@webrtc.org
TBR=henrik.lundin@webrtc.org

Review URL: https://codereview.webrtc.org/1547343002 .

Cr-Commit-Position: refs/heads/master@{#11150}
2016-01-04 21:44:16 +00:00
095ae15d6b Keep listening if "accept" returns an invalid socket.
There is an issue in PhysicalSocket::Accept where the flag to continue
listening is not set in "enabled_events_" if "accept" returns an error.
This CL fixes this (initial idea by silviu.cpp@gmail.com).

BUG=webrtc:2030

Review URL: https://codereview.webrtc.org/1452903006

Cr-Commit-Position: refs/heads/master@{#11080}
2015-12-18 09:40:03 +00:00
f399f2174c Disable PhysicalSocketTest.TestUdpReadyToSendIPv4 on linux due to flakiness on the Linux64 Debug bot.
NOTRY=true
TBR=kjellander@webrtc.org
BUG=webrtc:5233

Review URL: https://codereview.webrtc.org/1464453002

Cr-Commit-Position: refs/heads/master@{#10712}
2015-11-19 14:44:36 +00:00
0be3e040f6 Disable PhysicalSocketTest.TestUdpReadyToSendIPv4 on Android.
The test didn't previously run on Android bots, but was enabled by
mistake in https://codereview.webrtc.org/1426643003/

It used to be long to the rtc_unittests target, which also don't run
on Android unfortunately. For now, let's just disable this one test
on Android to get the bots go green.

BUG=4364
TBR=pthatcher@webrtc.org

Review URL: https://codereview.webrtc.org/1419033007 .

Cr-Commit-Position: refs/heads/master@{#10464}
2015-10-30 20:21:11 +00:00
df200d1ef7 Suppressing TestUdpReadyToSendIPv4 on ASan.
The test is flaky on Asan.

BUG=webrtc:4958

Review URL: https://codereview.webrtc.org/1388203004

Cr-Commit-Position: refs/heads/master@{#10313}
2015-10-17 20:10:50 +00:00
c97be6a741 Disable TestUdpReadyToSendIPv4 under MSan.
It has become extra flaky lately, and is preventing people from
using the CQ.

BUG=webrtc:4958

Review URL: https://codereview.webrtc.org/1368763002

Cr-Commit-Position: refs/heads/master@{#10080}
2015-09-25 18:00:54 +00:00
5d69648782 Disabling TestUdpIPv6 on Linux
BUG=webrtc:4923, 522036
NOTRY=true

Review URL: https://codereview.webrtc.org/1298363002

Cr-Commit-Position: refs/heads/master@{#9734}
2015-08-19 11:42:07 +00:00
c732a3e511 Re-enable allmost all base tests.
BUG=3836
R=marpan@google.com

Review URL: https://webrtc-codereview.appspot.com/22989004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7416 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-09 22:08:15 +00:00
536eb98408 Re-enables a bunch of base unittests.
BUG=3836
R=turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/22889004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7399 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-08 22:17:02 +00:00
fded02c164 base: disabled several base tests on Mac so that rtc_unittests can be turned back on
BUG=N/A
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/30449004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7240 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-19 13:10:10 +00:00
6f833c332c Rebase webrtc/base with r6555 version of talk/base:
cd webrtc/base
svn diff -r 6521:6555 http://webrtc.googlecode.com/svn/trunk/talk/base >
6555.diff
patch -p0 -i 6555.diff

BUG=3379
TBR=aluebs@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/18629004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6556 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-27 16:21:49 +00:00
f048872e91 Adds a modified copy of talk/base to webrtc/base. It is the first step in
migrating talk/base to webrtc/base.

BUG=N/A
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/17479005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
e9a604accd Revert 6107 "Adds a modified copy of talk/base to webrtc/base. I..."
This breaks Chromium FYI builds and prevent roll of webrtc/libjingle to Chrome.

http://chromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win%20Builder/builds/457


> Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base.
> 
> BUG=N/A
> R=andrew@webrtc.org, wu@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/12199004

TBR=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14479004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6116 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 08:15:48 +00:00
2c7d1b39b9 Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base.
BUG=N/A
R=andrew@webrtc.org, wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12199004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6107 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-12 18:03:09 +00:00