361981faa8
Use scoped_ptr for ThreadWrapper::CreateThread.
...
BUG=
R=henrika@webrtc.org , pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/45799004
Cr-Commit-Position: refs/heads/master@{#8794}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8794 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-19 14:45:42 +00:00
27c0be9dfe
Remove ThreadObj #define and kThreadMaxNameLength from thread_wrapper.
...
BUG=
R=hbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/47679004
Cr-Commit-Position: refs/heads/master@{#8792}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8792 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-19 14:36:43 +00:00
c7157da599
Use atomic operations for setting/reading the trace filter.
...
The filter is currently being set and read by a number of threads and tripping up tsan.
Original review: https://webrtc-codereview.appspot.com/47609004/
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/47659004
Cr-Commit-Position: refs/heads/master@{#8789}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8789 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-19 09:30:45 +00:00
edd517bca1
Fix FYI build - add a missing include to event_tracer.h in system_wrappers.
...
TBR=magjed@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/48559004
Cr-Commit-Position: refs/heads/master@{#8768}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8768 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-17 22:15:28 +00:00
25819b8294
Revert 8753 "Use atomic operations for setting/reading the trace..."
...
Caused VP9 test to fail on TSAN and doesn't build in some configuration due to
"../webrtc/base/criticalsection.h:181:12: error: cannot compile this atomic library call yet"
:-(
> Use atomic operations for setting/reading the trace filter.
> The filter is currently being set and read by a number of threads and tripping up tsan.
>
> R=mflodman@webrtc.org
> BUG=
>
> Review URL: https://webrtc-codereview.appspot.com/47609004
TBR=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/51369004
Cr-Commit-Position: refs/heads/master@{#8759}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8759 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-17 15:35:41 +00:00
7c64ed2e0c
Move trace_event and associated files to webrtc/base.
...
Also starting to use TRACE_EVENT from thread.cc in webrtc/base, to track Invoke() calls.
BUG=
R=magjed@webrtc.org , tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/42769004
Cr-Commit-Position: refs/heads/master@{#8755}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8755 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-17 14:26:15 +00:00
c383c24c2b
Use atomic operations for setting/reading the trace filter.
...
The filter is currently being set and read by a number of threads and tripping up tsan.
R=mflodman@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/47609004
Cr-Commit-Position: refs/heads/master@{#8753}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8753 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-17 13:47:16 +00:00
a846371ace
Modify EventPosix to prevent spurious wakeups.
...
pthread_cond_{timedwait,wait} are allowed to spuriously wake up as if
they were signaled. To prevent this being interpreted as a "real"
signaling of the event (ThreadWrapper for instance depends on it being
an actual signal) we need to check whether the event was actually
signalled or not.
BUG=4413
R=andresp@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/49369004
Cr-Commit-Position: refs/heads/master@{#8752}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8752 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-17 13:14:46 +00:00
aba9219e5c
Change ThreadPosix to use an auto-reset event instead of manual reset now that we know the problem we had with EventWrapper::Wait was simply a bug in the EventWrapper. Also removing |started_| since we can just check the thread_ instead.
...
R=pbos@webrtc.org
BUG=4413
Review URL: https://webrtc-codereview.appspot.com/47539004
Cr-Commit-Position: refs/heads/master@{#8738}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8738 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-16 16:06:16 +00:00
86639737b8
Remove thread id from ThreadWrapper::Start().
...
Removes ThreadPosix::InitParams and a corresponding wait for an event.
This unblocks ThreadPosix::Start which had to wait for thread scheduling
for an event to trigger on the spawned thread, giving faster Start()
calls.
BUG=4413
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/43699004
Cr-Commit-Position: refs/heads/master@{#8709}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8709 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-13 00:07:45 +00:00
a3823e29a2
Hide assembly symbols.
...
Prevent symbols defined in assembly sources from being exported in
libraries which include them by marking them hidden, as they are
implementation details.
BUG=webrtc:4183
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/36759004
Patch from Richard Coles <torne@chromium.org >.
Cr-Commit-Position: refs/heads/master@{#8658}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8658 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-09 23:21:42 +00:00
14665ff7d4
Roll chromium_revision e144d30..6fdb142 (318658:318841) + remove OVERRIDE macro
...
Clang version changed 223108:230914
Details: e144d30..6fdb142R=pbos@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/41069004
Cr-Commit-Position: refs/heads/master@{#8596}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8596 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-04 13:04:54 +00:00
9e5f941ff1
Remove webrtc/system_wrappers/interface/scoped_ptr.h
...
No one uses it anymore; they've all switched to the cooler
webrtc/base/scoped_ptr.h instead.
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/42129004
Cr-Commit-Position: refs/heads/master@{#8569}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8569 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-03 10:17:49 +00:00
d31250518a
Test to try to track down the alignment problem on Mac 10.9.
...
There's no code change here, I'm rearranging member variables of the
trace class and adding a sizeof check to the CriticalSection
class + alignment attribute for the mutex, on Mac only.
TBR=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/38339004
Cr-Commit-Position: refs/heads/master@{#8540}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8540 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-28 00:01:56 +00:00
4b3618c7f3
Remove TraceImpl logging thread.
...
Simplifies TraceImpl significantly. Chromium uses trace callbacks and
logs directly through the trace callback interface. Added slowdowns when
logging to file are expected to only affect test targets.
BUG=
R=andresp@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/34329004
Cr-Commit-Position: refs/heads/master@{#8529}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8529 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-27 15:05:50 +00:00
00b8f6b364
Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away
...
BUG=
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/36229004
Cr-Commit-Position: refs/heads/master@{#8517}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8517 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-26 14:43:50 +00:00
ac2d27d9ae
Fix style violations in common_types.h and config.h
...
Mostly, it's about moving constructors and descructors to the .cc
files, so that they won't be inlined everywhere.
The reason this CL is so big is that a lot of code was using
common_types.h without declaring a dependency on webrtc_common, which
broke the build once common_types.h started to depend on
common_types.cc.
BUG=163
R=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/26089004
Cr-Commit-Position: refs/heads/master@{#8516}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8516 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-26 14:01:28 +00:00
d3d3baaa8e
Copy SetThreadName from webrtc/base/thread.cc into thread_win.cc
...
(webrtc/system_wrappers/source/thread_win.cc).
It would be good to consolidate these helpers at some point.
BUG=
Review URL: https://webrtc-codereview.appspot.com/37349004
Cr-Commit-Position: refs/heads/master@{#8439}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8439 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-19 19:18:54 +00:00
ce22f13f0e
GN: Changes for vp9, opus and direct trace
...
Corresponding GN changes for
https://webrtc-codereview.appspot.com/34099004/
BUG=4185
R=brettw@chromium.org
Review URL: https://webrtc-codereview.appspot.com/40669004
Cr-Commit-Position: refs/heads/master@{#8377}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8377 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-16 12:47:45 +00:00
0200f70792
Set webrtc_rtp category to be disabled by default.
...
Should not affect webrtc standalone. For chromium, disabling helps
mitigate viewing performance problems.
BUG=chromium:441440
R=mflodman@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/41909004
Cr-Commit-Position: refs/heads/master@{#8375}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8375 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-16 12:06:48 +00:00
d5ce2e63df
Remove EventWrapper::Reset().
...
This simplifies the event wrapper which we've recently found issues in.
Also refactoring EndToEndTest.RespectsNetworkState to not depend on it.
BUG=
R=stefan@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/41939004
Cr-Commit-Position: refs/heads/master@{#8366}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8366 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-13 14:58:38 +00:00
a6e8cebbd5
Fix false positive DHECK in event_posix.cc
...
It's OK that state is kDown when a thread is woken after being
signalled; another tread might also have woken and already set the state
to kDown.
Even if this waking and aquiring lock has been delayed until other
threads have set state to kDown and then subsequently to kUp again with
a new Set() call, it's OK to just set kDown and return since this thread
is returning kEventSignaled after the (new) Set() has ben called.
R=pbos@webrtc.org
TBR=tommi@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/36109004
Cr-Commit-Position: refs/heads/master@{#8334}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8334 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-11 15:19:22 +00:00
9d94a0c736
Switch to QueueUserAPC for shutting down the thread (no event needed).
...
Also actually specifying the reserve stack size.
BUG=
R=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37179004
Cr-Commit-Position: refs/heads/master@{#8331}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8331 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-11 14:16:44 +00:00
30015e3180
Fix bug in EventPosix where we'd miss a set event.
...
In cases of timeout or error, we could change the state of the event to 'down' (unset) and subsequently never satisfy a Wait() for a given Set().
BUG=4284
R=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/38049004
Cr-Commit-Position: refs/heads/master@{#8310}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8310 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-10 09:34:02 +00:00
f7e6cfd3a0
Add CHECK to EventWrapper to see if there's a subtle bug there or not.
...
R=pbos@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/38039005
Cr-Commit-Position: refs/heads/master@{#8302}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8302 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-09 18:25:56 +00:00
669bc7ee43
Modify default field trial implementation to allow
...
WebRTC client to turn on feature code.
R=andresp@webrtc.org , henrika@webrtc.org , mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39729004
Cr-Commit-Position: refs/heads/master@{#8301}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8301 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-09 18:18:19 +00:00
11c5db01af
Revert 8273 "Temporarily change ThreadPosix to CHECK (crash) if ..."
...
> Temporarily change ThreadPosix to CHECK (crash) if we ever spend more than 30 seconds waiting for thread shutdown. There are cases on build bots where it looks like we're hitting this problem, but reproducing locally has been a struggle.
>
> TBR=pbos@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/41799004
TBR=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/38039004
Cr-Commit-Position: refs/heads/master@{#8300}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8300 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-09 16:31:54 +00:00
d0165c62b5
Use a manual reset event in PosixThread.
...
This fixes occasional hangs we've been seeing in the past few days. I'm using rtc::Event instead of the EventWrapper, so I'll wait with landing this cl until I've made that change in a separate cl.
BUG=2822,4282
R=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/38009004
Cr-Commit-Position: refs/heads/master@{#8293}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8293 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-09 11:48:13 +00:00
2b69eab077
Restructure GYP for vp9, opus and direct trace
...
This is needed to make the build more flexible for some use cases.
BUG=4185
R=andresp@webrtc.org , stefan@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/34099004
Cr-Commit-Position: refs/heads/master@{#8290}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8290 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-09 10:01:40 +00:00
fe19699a20
Revert 8260 "Base RWLockWrapper on rtc::SharedExclusiveLock."
...
Unfortunately this caused channel teardown to hang.
More details in email(s).
> Base RWLockWrapper on rtc::SharedExclusiveLock.
>
> Also moves rtc::Event and rtc::SharedExclusiveLock to rtc_base_approved.
>
> R=tommi@webrtc.org
> BUG=
>
> Review URL: https://webrtc-codereview.appspot.com/38889004
TBR=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/34999005
Cr-Commit-Position: refs/heads/master@{#8284}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8284 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-07 22:36:19 +00:00
ccd7e99f0a
Temporarily change ThreadPosix to CHECK (crash) if we ever spend more than 30 seconds waiting for thread shutdown. There are cases on build bots where it looks like we're hitting this problem, but reproducing locally has been a struggle.
...
TBR=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/41799004
Cr-Commit-Position: refs/heads/master@{#8273}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8273 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-06 19:27:12 +00:00
75025434bf
Base RWLockWrapper on rtc::SharedExclusiveLock.
...
Also moves rtc::Event and rtc::SharedExclusiveLock to rtc_base_approved.
R=tommi@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/38889004
Cr-Commit-Position: refs/heads/master@{#8260}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8260 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-06 08:33:15 +00:00
5d32f43219
Disable CondVarTest.InitFunctionsWork.
...
The order of Sleep/Wake calls doesn't seem to be guaranteed, so this test
is flaky.
BUG=4262
TBR=bjornv@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37189004
Cr-Commit-Position: refs/heads/master@{#8247}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8247 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-05 06:26:35 +00:00
875c97ed9d
Remove SetNotAlive method from the thread class.
...
Also cleaning up methods with the same name in other classes that are derived from the above method.
R=perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/41759004
Cr-Commit-Position: refs/heads/master@{#8242}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8242 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-04 11:12:39 +00:00
dc096f2c7e
system_wrappers: Disabled flaky test CondVarTest.PassBatonMultipleTimes
...
Has been flaky on Win since r8220.
Disabling for now.
BUG=4262
TBR=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37149004
Cr-Commit-Position: refs/heads/master@{#8240}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8240 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-04 09:14:42 +00:00
d43bdf50c5
Rewrite ThreadPosix.
...
This is the same change as already made for Windows:
https://webrtc-codereview.appspot.com/37069004/
* Remove "dead" and "alive" variables.
* Remove critical section
* Remove implementation of SetNotAlive()
* Always set thread name
* Add thread checks for correct usage.
* Changed AudioDeviceMac to create/start/stop/delete thread objects for playout and recording, inside the respective start and stop method. The reason for this is because the AudioDeviceMac instance is currently being created on one thread and the above Start/Stop methods are being called on a different thread. So, my change makes creation, start/stop, deletion of the thread objects always happen on the same thread.
I'm making CurrentThreadId() in rtc_base_approved more visible so that it can be used from there instead of inside webrtc. Down the line we will have more thread concepts in rtc_base_approved, so I put a TODO for myself to move this functionality to there once we do.
R=henrika@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/40599004
Cr-Commit-Position: refs/heads/master@{#8235}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8235 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-03 16:30:21 +00:00
aef0779dab
Rewrite ThreadWindows.
...
* Remove "dead" and "alive" variables.
* Remove critical section
* Skip synchronizing with the worker thread to verify startup (no need).
* Remove implementation of SetNotAlive()
* Always set thread name
* Add thread checks for correct usage.
Also added some TODOs for myself for the ThreadWrapper interface.
I'm removing the HasNoMonitorThread test since it is no longer relevant and ends up checking the wrong thing (ProcessThread - a generic thread type) in the wrong way (parsing a debug log) :) I think it served a purpose some years ago, but things have changed since.
BUG=2902
R=henrika@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37069004
Cr-Commit-Position: refs/heads/master@{#8220}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8220 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-30 15:06:44 +00:00
2bbc35d896
Remove unused method, SetAffinity, from the ThreadWrapper class.
...
The method was also not consistently implemented across all platforms.
R=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/33169004
Cr-Commit-Position: refs/heads/master@{#8212}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8212 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-30 09:43:20 +00:00
8919cfe9ce
Change a GYP reference to cpufeatures.gypi
...
This will allow us to move the remaining GYP file in android_tools
to the chromium repository by removing the direct reference to it.
BUG=webrtc:4115
R=andrew@webrtc.org , kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/35849004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8140 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-23 16:35:17 +00:00
f938922c5c
Simplify and guard access to WindowsRealTimeClock.
...
Addresses data race in get_time() causing incorrect timer roll-over
detection. This roll-over caused NTP timers to jump by 2^32
milliseconds affecting A/V sync and end-to-end delay calculations.
BUG=4206
R=dvyukov@google.com , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/33959004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8112 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-21 12:51:13 +00:00
9ce01e6416
Clean unnecessary workaround for chromium import.
...
BUG=4185
R=kjellander@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/40419004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8073 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-15 09:12:45 +00:00
2ebfac5649
Remove COMPILE_ASSERT and use static_assert everywhere
...
COMPILE_ASSERT is no longer needed now that we have C++11's
static_assert.
R=aluebs@webrtc.org , andrew@webrtc.org , hellner@chromium.org , henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39469004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8058 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-14 10:51:54 +00:00
86e1e487e7
Move system_wrappers.gyp files to the proper directory.
...
Build targets should not refer to non-subpaths as was happening before when
source/system_wrappers.gyp refers to ../interface/ files.
R=kjellander@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37609004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8057 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-14 09:30:52 +00:00
af9d56f38c
Unify the two copies of template_util.h
...
This patch basically deletes webrtc/base/template_util.h (which is the
more outdated copy, although there are only cosmetical differences)
and moves webrtc/system_wrappers/source/template_util.h to take its
place.
The reunified header uses the rtc namespace like the old
webrtc/base/template_util.h, rather than the webrtc namespace like
webrtc/system_wrappers/source/template_util.h.
R=aluebs@webrtc.org , andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/38579004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8050 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-13 20:32:04 +00:00
3df38b442f
Unify the two copies of compile_assert.h
...
This patch basically deletes webrtc/base/compile_assert.h (which is
the more outdated copy) and moves
webrtc/system_wrappers/source/compile_assert.h to take its place.
R=aluebs@webrtc.org , andrew@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/36719004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8048 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-13 11:37:48 +00:00
a37bf2c4fe
Hack clock_unittest fix for parallel execution.
...
It's a bad idea to depend on timing constraints in unit tests, but
moving this from 5 -> 100 ms should allow it to fail only very rarely.
TBR=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/35659004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7999 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-05 19:08:58 +00:00
aa21f2765b
Unify the two copies of move.h
...
This patch basically deletes webrtc/base/move.h (which is the more
outdated copy) and moves webrtc/system_wrappers/source/move.h to take
its place.
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/35549004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7963 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-19 14:35:57 +00:00
97d0489058
Add video send bitrates to histogram stats:
...
- total bitrate ("WebRTC.Video.BitrateSentInKbps")
- media bitrate ("WebRTC.Video.MediaBitrateSentInKbps")
- rtx bitrate ("WebRTC.Video.RtxBitrateSentInKbps")
- padding bitrate ("WebRTC.Video.PaddingBitrateSentInKbps")
- retransmitted bitrate ("WebRTC.Video.RetransmittedBitrateInKbps")
Add retransmitted bytes to StreamDataCounters.
Change in UpdateRtpStats to also update counters for retransmitted packet.
BUG=crbug/419657
R=mflodman@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/30199004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7838 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-09 09:47:53 +00:00
83b5200f95
Add framerate for complete received frames to histogram stats:
...
"WebRTC.Video.CompleteFramesReceivedPerSecond".
BUG=crbug/419657
R=mflodman@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/32089004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7762 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-28 10:17:13 +00:00
4591fbd09f
Use size_t more consistently for packet/payload lengths.
...
See design doc at https://docs.google.com/a/chromium.org/document/d/1I6nmE9D_BmCY-IoV6MDPY2V6WYpEI-dg2apWXTfZyUI/edit?usp=sharing for more information.
This CL was reviewed and approved in pieces in the following CLs:
https://webrtc-codereview.appspot.com/24209004/
https://webrtc-codereview.appspot.com/24229004/
https://webrtc-codereview.appspot.com/24259004/
https://webrtc-codereview.appspot.com/25109004/
https://webrtc-codereview.appspot.com/26099004/
https://webrtc-codereview.appspot.com/27069004/
https://webrtc-codereview.appspot.com/27969004/
https://webrtc-codereview.appspot.com/27989004/
https://webrtc-codereview.appspot.com/29009004/
https://webrtc-codereview.appspot.com/30929004/
https://webrtc-codereview.appspot.com/30939004/
https://webrtc-codereview.appspot.com/31999004/
Committing as TBR to the original reviewers.
BUG=chromium:81439
TEST=none
TBR=pthatcher,henrik.lundin,tina.legrand,stefan,tkchin,glaznev,kjellander,perkj,mflodman,henrika,asapersson,niklas.enbom
Review URL: https://webrtc-codereview.appspot.com/23129004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7726 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-20 22:28:14 +00:00
