0f2e939a92
Enable cpplint for more webrtc subfolders and fix all uncovered cpplint errors.
...
This CL enableds cpplint for webrtc/common_video, webrtc/sound and webrtc/tools.
BUG=webrtc:5273
TESTED=Fixed issues reported by:
find webrtc/common_video webrtc/sound webrtc/tools -type f -name *.cc -o -name *.h | xargs cpplint.py
followed by 'git cl presubmit'.
Review URL: https://codereview.webrtc.org/1511603004
Cr-Commit-Position: refs/heads/master@{#10967}
2015-12-10 11:11:48 +00:00
0c4e06b4c6
Use suffixed {uint,int}{8,16,32,64}_t types.
...
Removes the use of uint8, etc. in favor of uint8_t.
BUG=webrtc:5024
R=henrik.lundin@webrtc.org , henrikg@webrtc.org , perkj@webrtc.org , solenberg@webrtc.org , stefan@webrtc.org , tina.legrand@webrtc.org
Review URL: https://codereview.webrtc.org/1362503003 .
Cr-Commit-Position: refs/heads/master@{#10196}
2015-10-07 10:23:32 +00:00
67bcb609a3
GN: Port frame_analyzer and rgba_to_i420_converter targets
...
Original patch by tfarina@chromium.org at
https://webrtc-codereview.appspot.com/42999004/
BUG=chromium:461019, webrtc:4504
TESTED=Tested on Linux with the following command lines:
$ gn gen/out/Debug --args='is_debug=true build_with_chromium=false'
$ ninja -C out/Debug frame_analyzer rgba_to_i420_converter
Also successfully compiled from a Chromium checkout using the steps in webrtc:4504.
R=tfarina@chromium.org
Review URL: https://codereview.webrtc.org/1387243002 .
Cr-Commit-Position: refs/heads/master@{#10193}
2015-10-07 06:43:07 +00:00
3a93986fd5
Exit after printing usage message.
...
We should not continue the program if the user asked for help.
Tested on Linux with the following command line:
$ out/Debug/frame_analyzer --help
BUG=None
TEST=see above
R=kjellander@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/44069004
Patch from Thiago Farina <tfarina@chromium.org >.
Cr-Commit-Position: refs/heads/master@{#8961}
2015-04-09 13:45:17 +00:00
fa16dda238
Revert "Port frame_analyzer and rgba_to_i420_converter targets to GN build."
...
This reverts commit 6ac53b2b37c36d4e09f4252c91cada0462adf741.
Reason: breaks compile on Win GN:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20GN/builds/131
TBR=tfarina@chromium.org
Review URL: https://webrtc-codereview.appspot.com/45919004
Cr-Commit-Position: refs/heads/master@{#8915}
2015-04-01 20:54:08 +00:00
6ac53b2b37
Port frame_analyzer and rgba_to_i420_converter targets to GN build.
...
Tested on Linux with the following command lines:
$ gn gen //out/Debug --args='is_debug=true target_cpu="x64" build_with_chromium=false'
$ ninja -C out/Debug frame_analyzer rgba_to_i420_converter
BUG=chromium:461019
TEST=see above
R=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/42999004
Cr-Commit-Position: refs/heads/master@{#8914}
2015-04-01 15:29:51 +00:00
22c2f0572b
Add "score" unit to SSIM perf score output.
...
Currently, the SSIM values don't have a unit, which makes
them default to lower being better rather than the opposite
(which is the case for SSIM).
R=phoglund@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/41709004
Cr-Commit-Position: refs/heads/master@{#8183}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8183 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-28 13:52:37 +00:00
d7e34e1086
Make it easier to use external libyuv + cleanup GYP files.
...
It is now easier to use an external libyuv library.
Fix some GYP errors.
Remove the temporary webrtc_base target (depends on
https://codereview.chromium.org/865603002/ being landed
first).
BUG=4185
R=andresp@webrtc.org , andrew@webrtc.org , perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39579004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8154 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-26 19:17:26 +00:00
4375e1acbb
Add support for YUV4MPEG file reading to tools files. (Minor fix).
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5703 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-14 12:51:02 +00:00
6e2d012b58
Add support for YUV4MPEG file reading to tools files.
...
This CL adds support for reading .y4m files to the infra in
video_quality_analysis.cc, adding new functions
ExtractFrameFromYuvFile() and ExtractFrameFromY4mFile(),
instad of the previous ExtractFrameFromI420(). The decision
as to which one to use is taken from the file extension,
if it is .y4m then is considered a YUV4MPEG file, otherwise
is taken as a raw .yuv file.
It also removes the pseudo duplicated function
GetNextI420Frame(), that is used from psnr_ssim_analyzer.c,
and adds support for y4m files there.
Tested/validated via local compile-run.
YUV4MPEG is a trivial container with a file header
and a per-frame header, see [1]
[1]
http://wiki.multimedia.cx/index.php?title=YUV4MPEG2
BUG=https://code.google.com/p/chromium/issues/detail?id=343504
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5702 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-14 12:45:45 +00:00
e2df8b7f01
Make video quality analysis unittests print to log instead of stdout.
...
I think it's best to avoid printing these perf numbers since
when we turn on perf measurements for Android, it will be for
all tests as far as I understand it works today.
TEST=trybots passing tools_unittests
BUG=none
R=phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3109005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5072 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-03 18:34:51 +00:00
319c98d663
Fix format string in video_quality_analysis.cc.
...
Fixes compilation errors on Android and Linux32 targets.
TBR=kjellander@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/2196005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4717 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-10 15:23:50 +00:00
f880f863dd
Convert printing in video quality tests to Chromium's perf format.
...
Add support for --label flag to the frame_analyzer, that
decides what label shall be used for the perf output.
BUG=none
TEST=
Make sure to have zxing and ffmpeg in the PATH.
Create a captured video (from running vie_auto_test custom call)
webrtc/tools/compare_videos.py --ref_video=reference_video.yuv --test_video=captured_output.yuv --frame_analyzer=out/Release/frame_analyzer --label=TEST_VGA
And then inspecting the output that is prefixed with RESULT.
R=phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2190005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4714 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-10 12:10:01 +00:00
12dc1a38ca
Switch C++-style C headers with their C equivalents.
...
The C++ headers define the C functions within the std:: namespace, but
we mainly don't use the std:: namespace for C functions. Therefore we
should include the C headers.
BUG=1833
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1917004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4486 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-05 16:22:53 +00:00
ba7f6a8614
Include files from webrtc/.. paths in tools/
...
BUG=1662
R=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1547004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4166 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-06-04 08:14:10 +00:00
b2d7497faf
Fix Win64 warnings
...
This change fixes warnings about converting size_t to int.
BUG=webrtc:1323
TEST=trybots passing
Review URL: https://webrtc-codereview.appspot.com/1064004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3419 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-26 16:36:40 +00:00
14b43beb7c
Move src/ -> webrtc/
...
TBR=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/915006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2963 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-22 18:19:23 +00:00
