Before promoting it to the main waterfall I thought it made
sense to ensure it works for a phone that actually is 32-bit
(iPhone 6s isn't). It also makes more sense to run the older
iOS version (9) on the older phone.
BUG=chromium:677385
TBR=ehmaldonado@webrtc.org
Review-Url: https://codereview.webrtc.org/2604203002 .
Cr-Commit-Position: refs/heads/master@{#15837}
The P2PTransportChannel will eventually inherit from IceTransportInternal instead of TransportChannelImpl.
However, the Chromium/remoting depends on TransportChannel and TransportChannelImpl.
The solution to work around this:
Step1:
Make a WebRTC CL to introduce IceTransportInternal and IceTransportInternal2 by type-defining
TransportChannel and TransportChannelImpl.
Step2:
Make a Chromium CL to replace the TransportChannel and TransportChannelImpl with
IceTransportInternal and IceTransportInternal2.
Step3:
Make a WebRTC to redefine IceTransportInternal2 to be IceTransportInternal and switch the base
class of P2PTransportChannel with IceTransportInternal.
Step4"
Make a Chromium CL to remove the IceTransportInternal2.
This CL is the Step1. The real IceTransportInternal implementation
is commented out temporarily.
BUG=none
Review-Url: https://codereview.webrtc.org/2598103003
Cr-Commit-Position: refs/heads/master@{#15824}
Reason for revert:
Trying to re-enable this test as we're now using a newer Clang version (289944-2).
Original issue's description:
> Disable flaky test VideoProcessorIntegrationTest.ProcessNoLossChangeFrameRateFrameDropVP9
>
> This test is flaky on all platforms, not just Android. Disabling it entirely until webrtc:6057 is fixed.
>
> BUG=webrtc:6057
>
> Committed: https://crrev.com/bb66ec35739830847bfb0146cd029ca41421b2d8
> Cr-Commit-Position: refs/heads/master@{#15594}
TBR=marpan@webrtc.org,sprang@webrtc.org,skvlad@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:6057
Review-Url: https://codereview.webrtc.org/2603993002
Cr-Commit-Position: refs/heads/master@{#15821}
Drop frames if incoming frame rate is higher than the configured max
framerate.
BUG=webrtc:6897
Review-Url: https://codereview.webrtc.org/2578993002
Cr-Commit-Position: refs/heads/master@{#15819}
This reverts commit d39e16ac300d7947d22b953898aaef073e553ad3.
This will fix the missing dependency which was causing the failure of many
buildbots.
BUG=webrtc:6828
NOTRY=True
Review-Url: https://codereview.webrtc.org/2597643002
Cr-Commit-Position: refs/heads/master@{#15805}
The now checked target is:
"//webrtc/modules/utility/*"
BUG=webrtc:6828
NOTRY=True
Review-Url: https://codereview.webrtc.org/2606483002
Cr-Commit-Position: refs/heads/master@{#15803}
After moving away from the Chromium checkout and the symlinks, we
no longer need to have our own test_runner.py script for Android tests
BUG=webrtc:5006
TBR=ehmaldonado@webrtc.org
Review-Url: https://codereview.webrtc.org/2600193002 .
Cr-Commit-Position: refs/heads/master@{#15801}
Reason for revert:
Broke chromium FYI bot because the chromium mock PC overrides the method whose signature is changing.
Also broke a downstream internal test, which I need to investigate further.
Original issue's description:
> Adding error output param to SetConfiguration, using new RTCError type.
>
> Most notably, will return "INVALID_MODIFICATION" if a field in the
> configuration was modified and modification of that field isn't supported.
>
> Also changing RTCError to a class that wraps an enum type, because it will
> eventually need to hold other information (like SDP line number), to match
> the RTCError that was recently added to the spec:
> https://github.com/w3c/webrtc-pc/pull/850
>
> BUG=webrtc:6916
>
> Review-Url: https://codereview.webrtc.org/2587133004
> Cr-Commit-Position: refs/heads/master@{#15777}
> Committed: 7a5fa6cd61TBR=pthatcher@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6916
Review-Url: https://codereview.webrtc.org/2600813002
Cr-Commit-Position: refs/heads/master@{#15778}
Most notably, will return "INVALID_MODIFICATION" if a field in the
configuration was modified and modification of that field isn't supported.
Also changing RTCError to a class that wraps an enum type, because it will
eventually need to hold other information (like SDP line number), to match
the RTCError that was recently added to the spec:
https://github.com/w3c/webrtc-pc/pull/850
BUG=webrtc:6916
Review-Url: https://codereview.webrtc.org/2587133004
Cr-Commit-Position: refs/heads/master@{#15777}
This isn't as good as being able to enumerate all networks, but it's better
than doing nothing; it still will provide STUN/TURN candidates for the default
route if one exists.
BUG=webrtc:6932
Review-Url: https://codereview.webrtc.org/2599673003
Cr-Commit-Position: refs/heads/master@{#15766}
This allows building without SCTP support (and even building/running
tests). The "HAVE_SCTP" define has been functional for a while, but there
wasn't any easy way to turn it on/off.
NOTRY=True
BUG=webrtc:6933
Review-Url: https://codereview.webrtc.org/2593313002
Cr-Commit-Position: refs/heads/master@{#15763}
- UpdateRtcpList
- RtpToNtp
class RtpToNtpEstimator
- UpdateMeasurements
- Estimate
List with rtcp measurements is now private.
BUG=none
Review-Url: https://codereview.webrtc.org/2574133003
Cr-Commit-Position: refs/heads/master@{#15762}
This moves some GN check configurations out of .gn to individual
targets.
This commit also removes the source file 'mocks/mock_rtp_rtcp.h' from
the static_library 'rtp_rtcp' because it depends on a 'testonly = true'
target. After a check this seems only included in the unitest code:
$ grep -Rn "mocks/mock_rtp_rtcp.h" webrtc/modules/rtp_rtcp/
webrtc/modules/rtp_rtcp/source/ulpfec_receiver_unittest.cc:18:#include "webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h"
webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc:17:#include "webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h"
This commit also removes the dependency on
'//webrt/modules/video_coding' because it seems that the following
include can be removed:
#include "webrtc/modules/video_coding/include/video_coding_defines.h"
The now checked target is:
"//webrtc/modules/rtp_rtcp/*"
BUG=webrtc:6828
NOTRY=True
Review-Url: https://codereview.webrtc.org/2598963002
Cr-Commit-Position: refs/heads/master@{#15760}
This moves some GN check configurations out of .gn to individual
targets.
The now checked target is:
"//webrtc/modules/audio_conference_mixer/*"
BUG=webrtc:6828
NOTRY=True
Review-Url: https://codereview.webrtc.org/2593003002
Cr-Commit-Position: refs/heads/master@{#15759}
Wait until first frame is decoded to avoid include zeros in stats.
BUG=b/32659204
Review-Url: https://codereview.webrtc.org/2582313002
Cr-Commit-Position: refs/heads/master@{#15752}
Reason for revert:
Breaks Chromium WebRTC FYI bots:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/12337
The error was masked by another breaking change that was committer earlier. This is the first build showing the error.
Original issue's description:
> Make P2PTransportChannel inherit from IceTransportInternal.
>
> Make P2PTransportChannel inherit from IceTransportInternal instead of
> TransportChannelImpl and TransportChannel, so that the DTLS-related methods can
> be separated from P2PTransportChannel.
>
> BUG=none
>
> Review-Url: https://codereview.webrtc.org/2590063002
> Cr-Commit-Position: refs/heads/master@{#15743}
> Committed: 12749d89d9TBR=deadbeef@webrtc.org,zhihuang@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none
Review-Url: https://codereview.webrtc.org/2594343002
Cr-Commit-Position: refs/heads/master@{#15751}
Created a java wrapper for the callback OnAddTrack in this CL since it has been added to native C++ API
The callback function is called when a track is signaled by remote side and a new RtpReceiver is created.
The application can tell when tracks are added to the streams by listening to this callback.
BUG=webrtc:6112
Review-Url: https://codereview.webrtc.org/2513723002
Cr-Commit-Position: refs/heads/master@{#15745}
Make P2PTransportChannel inherit from IceTransportInternal instead of
TransportChannelImpl and TransportChannel, so that the DTLS-related methods can
be separated from P2PTransportChannel.
BUG=none
Review-Url: https://codereview.webrtc.org/2590063002
Cr-Commit-Position: refs/heads/master@{#15743}
Problem fixed: RTP header extensions were not properly set in tests.
BUG=webrtc:5654
Review-Url: https://codereview.webrtc.org/2593963003
Cr-Commit-Position: refs/heads/master@{#15741}
Modify ExpectReportContainsCertificateInfo to use EXPECT_EQ checks of
RTCCertificateStats objects.
BUG=chromium:627816
Review-Url: https://codereview.webrtc.org/2594553003
Cr-Commit-Position: refs/heads/master@{#15738}
Remove ExpectReportContainsCandidate in favor of EXPECT_EQ checks of
RTC[Local/Remote]IceCandidateStats objects.
BUG=chromium:627816
Review-Url: https://codereview.webrtc.org/2594753002
Cr-Commit-Position: refs/heads/master@{#15737}
Prior to this change, the receiver_time metric had huge outliers
whenever FlexFEC was enabled. This was due to a measurement problem,
where the time of the incoming packet was incorrectly set to zero.
This happened for packets that were lost in transit, but recovered
through FEC.
This CL fixes this problem by simply not recording samples where the
incoming packet time is undefined. The CL also removes the possibility
of timestamp collisions in the data structures.
TESTED=Ran './webrtc_perf_tests --gtest_filter="*ForemanCifPlr5H264Flexfec*" | grep receiver_time' locally 10 times, without experiencing any outliers.
BUG=webrtc:5654
Review-Url: https://codereview.webrtc.org/2596793002
Cr-Commit-Position: refs/heads/master@{#15735}
Reason for revert:
This CL broke some buildbots. I will investigate it later.
Original issue's description:
> Refactor webrtc/modules/video_processing for GN check
>
> This moves some GN check configurations out of .gn to individual
> targets.
>
> The now checked target is:
> "//webrtc/modules/video_processing/*"
>
> BUG=webrtc:6828
> NOTRY=True
>
> Review-Url: https://codereview.webrtc.org/2595543002
> Cr-Commit-Position: refs/heads/master@{#15732}
> Committed: 00a810b844TBR=kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6828
Review-Url: https://codereview.webrtc.org/2594973002
Cr-Commit-Position: refs/heads/master@{#15733}
This moves some GN check configurations out of .gn to individual
targets.
The now checked target is:
"//webrtc/modules/video_processing/*"
BUG=webrtc:6828
NOTRY=True
Review-Url: https://codereview.webrtc.org/2595543002
Cr-Commit-Position: refs/heads/master@{#15732}
Remove ExpectReportContainsDataChannel in favor of EXPECT_EQ checks of
RTCDataChannelStats objects.
BUG=chromium:627816
Review-Url: https://codereview.webrtc.org/2597433002
Cr-Commit-Position: refs/heads/master@{#15731}
Previously it was allowed to call AddStats with stats of the same ID
multiple times.
This revealed a few things:
- Local and remote streams can have the same label.
RTCMediaStreamStats's ID is updated to include "local"/"remote".
- The same certificate can show up multiple times (e.g. for local and
remote in a loopback), so we skip creating RTCCertificateStats for the
same certificate multiple times
BUG=chromium:627816
Review-Url: https://codereview.webrtc.org/2593503003
Cr-Commit-Position: refs/heads/master@{#15730}
This moves some GN check configurations out of .gn to individual
targets.
The now checked target is:
"//webrtc/modules/pacing/*"
BUG=webrtc:6828
NOTRY=True
Review-Url: https://codereview.webrtc.org/2594523003
Cr-Commit-Position: refs/heads/master@{#15729}
This moves some GN check configurations out of .gn to individual
targets.
The now checked target is:
"//webrtc/modules/media_file/*"
BUG=webrtc:6828
NOTRY=True
Review-Url: https://codereview.webrtc.org/2593693002
Cr-Commit-Position: refs/heads/master@{#15726}
This moves some GN check configurations out of .gn to individual
targets.
The now checked target is:
"//webrtc/modules/desktop_capture/*"
BUG=webrtc:6828
NOTRY=True
Review-Url: https://codereview.webrtc.org/2593713002
Cr-Commit-Position: refs/heads/master@{#15725}
The CGDisplayStream API returns rects in physical pixel coordinates, not
Density-Independent Pixel coordinates. The code was incorrectly re-applying the
dip_to_pixel scaling.
BUG=chromium:675490
Review-Url: https://codereview.webrtc.org/2588973002
Cr-Commit-Position: refs/heads/master@{#15720}
that the level of the output in the audio processing
module is monitored. This CL adds that.
BUG=webrtc:6181, webrtc:6183, webrtc:6220
Review-Url: https://codereview.webrtc.org/2549143004
Cr-Commit-Position: refs/heads/master@{#15718}
