0a3cbb3906
common_audio/signal_processing: Removes macro WEBRTC_SPL_MUL_32_32_RSFT32
...
The macro is only used at four places in iSAC fixed point and the macro have been replaced at those places.
In addition, it is used in a unit test, but throws a warning treated as error (issue3674).
The macro has both MIPS and armv7 optimizations. Removing them impacts only MIPS platforms without DSP ASE. This may cause a very small increase in complexity when using iSAC fix.
The armv7 optimizations are not used anywhere, since specific ones are used inline in iSAC fix.
BUG=3348,3353,3674
TESTED=locally and trybots
R=ljubomir.papuga@gmail.com , tina.legrand@webrtc.org , turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/16299004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6871 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-12 10:54:50 +00:00
cf8f33a6d6
Removes mismatching signs in signal_processing_unittests
...
Negative inputs was used in WebRtcSpl_NormU32() causing warnings.
BUG=3674
TESTED=locally and trybots
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/17089004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6870 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-12 10:27:21 +00:00
6ac22e6b47
Remove more dependencies on openssl, add dependency on boringssl. Continues on r6798
...
R=andrew@webrtc.org , fbarchard@chromium.org , kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14029004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6867 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-11 21:06:30 +00:00
c0ba4392f1
common_audio: Removes macro WEBRTC_SPL_SHIFT_W16
...
We should avoid macros in general (see style guide). This shift macro is not a severe one, since there is a check for negativity.
BUG=3348,3353
TESTED=trybots and manually
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15799004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6591 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-03 13:38:53 +00:00
721f970cba
common_audio: Removes macro WEBRTC_SPL_LSHIFT_U16
...
We should avoid macros in general (see style guide) and the shift ones are particular dangerous since they assume that the user apply a non-negative shift.
Related CL: https://webrtc-codereview.appspot.com/16669004
BUG=3348,3353
TESTED=trybots and manually on linux
R=turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19719004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6444 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-16 10:30:14 +00:00
18026abd82
common_audio/signal_processing: Removes macro WEBRTC_SPL_RSHIFT_U16
...
This macro is only used at a few places and implies a cast to uint16_t before right shifting. All places already use uint16_t. Further, the amount of shifts applied in the macro has no sanity check for negativity, makes the macro dangerous to use.
BUG=3348,3353
TESTED=trybots and manually
R=kwiberg@webrtc.org , tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/16669004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6393 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-11 06:53:20 +00:00
782978cfcb
common_audio/signal_processing: Moves WEBRTC_SPL_UMUL_16_16_RSFT16 to iSAC fix
...
This macro is only used by the fixed point version of iSAC. Replacing the (five) locations in arith_routines_logist.c, where it is used, with the actual operation.
BUG=3348,3353
TESTED=trybots and manually
R=kwiberg@webrtc.org , tina.legrand@webrtc.org , turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14659004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6392 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-11 06:39:03 +00:00
edbe886a0b
common_audio/signal_processing: Removed macro WEBRTC_SPL_MUL_16_16_RSFT_WITH_FIXROUND
...
This macro was only used at two places in fixed point iSAC, where it has been replaced with the operation.
BUG=3348,3353
TESTED=trybots
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15669004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6336 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-05 08:42:53 +00:00
a3b5673879
common_audio/signal_processing: Removes macro WEBRTC_SPL_UMUL_RSFT16
...
This macro was only used on two lines in iSACfix and I replaced those with the operations the macro performed.
BUG=3348
TESTED=trybots, manual unittests
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14529004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6184 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-16 12:11:20 +00:00
1b21a57902
common_audio/signal_processing: Removed macro WEBRTC_SPL_SUB_SAT_W16
...
Macro was only mapping a function used in one place.
BUG=3348
TESTED=trybots, unittests
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/17499004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6180 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-16 06:40:31 +00:00
d83d607271
common_audio/signal_processing: Removed macro WEBRTC_SPL_MAX_SEED_USED
...
* Moved the macro to randomization_functions and made it static const.
* Made WebRtc_IncreaseSeed() static, since it is not used outside this function.
* Style guide changes.
BUG=3348,3353
TESTED=trybots, common_audio_unittests, modules_unittests, modules_tests
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/21459004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6179 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-16 06:38:47 +00:00
1aae6bf735
common_audio: Removes unused macros
...
* WEBRTC_SPL_MUL_32_32_RSFT32BI
* WEBRTC_SPL_IS_NEG
BUG=3348
TESTED=trybots, common_audio_unittests
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/18449004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6169 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-15 07:22:53 +00:00
8bf755d5c5
MIPS optimizations for the functions WebRtcSpl_SqrtFloor, WebRtcSpl_CrossCorrelation, WebRtcSpl_ScaleAndAddVectorsWithRound and the inline functions from signal_processing spl_inl.h file.
...
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1791004
Patch from Ljubomir Papuga <lpapuga@mips.com >.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4779 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-18 17:40:46 +00:00
aa30bb7ef5
Include files from webrtc/.. paths in common_audio/
...
BUG=1662
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1535005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4107 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-27 09:49:58 +00:00
b09130763b
WebRtc_Word32 -> int32_t in common_audio/
...
BUG=314
Review URL: https://webrtc-codereview.appspot.com/1299004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3803 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-09 16:40:28 +00:00
53a8be20f1
Wraparound distortion in Opus
...
This CL solves the wraparound distortion in Opus.
In the Opus decoder-wrapper we are downsampling the signal from 48 kHz to 32 kHz. This is done in two steps, using the following functions from the signal processing library:
WebRtcSpl_Resample48khzTo32khz() and WebRtcSpl_VectorBitShiftW32ToW16
The latter does not have a saturation check, and the signal can suffer from wraparound. I've added saturation control to the function.
BUG=issue1089
Review URL: https://webrtc-codereview.appspot.com/967004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3103 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-15 08:34:38 +00:00
14b43beb7c
Move src/ -> webrtc/
...
TBR=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/915006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2963 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-22 18:19:23 +00:00
