third_party/nss is no longer used.
third_party/llvm-build and third_party/syzygy links are not be needed;
these dirs are created during 'gclient runhooks' now that we moved
to executing hooks in our own DEPS file instead of the ones in
chromium/src/DEPS as per https://codereview.webrtc.org/2524673002
BUG=webrtc:5006
NOTRY=True
TESTED=Ran all compile trybots with the --clobber flag.
Review-Url: https://codereview.webrtc.org/2570993003
Cr-Commit-Position: refs/heads/master@{#15621}
The tool is no longer needed and will be removed in Chromium.
BUG=chromium:670470
Review-Url: https://codereview.webrtc.org/2548763002
Cr-Commit-Position: refs/heads/master@{#15384}
This removes the need of executing Chromium's runhooks.
A selection of hooks (not all) were picked that should be
sufficient for WebRTC's needs.
New dependencies:
* third_party/espresso
* third_party/javax_inject
* tools/clang_format_merge_driver
BUG=webrtc:5578, webrtc:5006, webrtc:6741
TESTED=
rm -rf third_party/android_tools/sdk/extras/google/m2repository/
gclient runhooks
Verified that third_party/android_tools/sdk/extras/google/m2repository/ is downloaded without any license prompt.
NOTRY=True
Review-Url: https://codereview.webrtc.org/2524673002
Cr-Commit-Position: refs/heads/master@{#15195}
If a checkout has been created but haven't yet executed gclient
runhooks, running setup_links.py --clean-only will fail if
the Chromium checkout isn't yet synced. This can make bots
end up in a bad state since we now clean all links before running
bot_update. Relaxing this error solves that problem.
BUG=chromium:663278
TBR=ehmaldonado@webrtc.org
NOTRY=True
Review URL: https://codereview.webrtc.org/2496323004 .
Cr-Commit-Position: refs/heads/master@{#15097}
Essentially a copy of https://codereview.chromium.org/2299953002/
plus changes to WebRTC's license, changed OWNERS and additional
MB updates up to Chromium revision http://crrev.com/f1e2718a3ff.
The PRESUBMIT.py check was updated to use the existing
webrtc/build/mb_config.pyl to avoid breaking bots (that have
this path hardcoded).
This replaces the previously symlinked MB, which already
runs validation of the WebRTC configs as part of
webrtc/build/PRESUBMIT.py.
BUG=chromium:664425
NOTRY=True
TESTED=Ran:
tools/mb/mb.py gen -m client.webrtc -b 'Mac64 Release' --config-file webrtc/build/mb_config.pyl --isolate-map-file=webrtc/build/gn_isolate_map.pyl --gyp-script=webrtc/build/gyp_webrtc.py //out/Release
Review-Url: https://codereview.webrtc.org/2306163002
Cr-Commit-Position: refs/heads/master@{#15068}
The Dr Memory toolchain is no longer supported by Chromium and
their bots have been removed. WebRTC will now rely on the LLVM
santizers for catching such errors.
BUG=webrtc:6553
NOTRY=True
R=ehmaldonado@webrtc.org
Review URL: https://codereview.webrtc.org/2434563003 .
Cr-Commit-Position: refs/heads/master@{#14703}
Fixes the following error for Android GN bots when trying
to roll Chromium into WebRTC.
Full logs at:
https://build.chromium.org/p/tryserver.webrtc/builders/android_gn_dbg/builds/13405/steps/generate_build_files/logs/stdio
/b/c/b/android_gn_dbg/src/buildtools/linux64/gn gen //out/Debug --check
-> returned 1
ERROR at //build/config/android/internal_rules.gni:140:23: Can't load input file.
deps += [ "${_target_label}__build_config" ]
^-------------------------------
Unable to load:
/b/c/b/android_gn_dbg/src/third_party/byte_buddy/BUILD.gn
I also checked in the secondary tree for:
/b/c/b/android_gn_dbg/src/build/secondary/third_party/byte_buddy/BUILD.gn
GN gen failed: 1
BUG=522043
NOTRY=True
Review-Url: https://codereview.webrtc.org/2268343002
Cr-Commit-Position: refs/heads/master@{#13886}
This is needed for an upcoming task queue implementation.
The location of this folder was recently moved under base/ in Chromium, so I'm wondering if that's really the best way to do this for WebRTC as well.
NOTRY=True
Review URL: https://codereview.webrtc.org/1909223004
Cr-Commit-Position: refs/heads/master@{#12465}
Instead of creating symlinks on Windows, the script is now:
* creating a junction for directories
* copying individual files.
This makes 'gclient sync' and 'gclient runhooks' no longer
require administrator's privileges.
If the script is run with administrator's privileges, a
warning will be printed, informing the user that it's not recommended.
Also clean up a few old documentation references to the
Chromium SVN->Git transition.
BUG=webrtc:4911
TESTED=Running the script with+without administrator's privileges.
I also tested the case of this change being rolled back, in which
case I verified that the copied files are still being deleted using
the same cleanup code path as the previous symlinks.
NOTRY=True
Review URL: https://codereview.webrtc.org/1845943004
Cr-Commit-Position: refs/heads/master@{#12233}
Reason for revert:
Actually, we're going to need this soon, so I'm going to add it back again. We'll use it as part of the future GN migration.
Original issue's description:
> Revert of Add tools/mb to setup_links.py (patchset #1 id:1 of https://codereview.webrtc.org/1692543002/ )
>
> Reason for revert:
> Doesn't solve the problem and MB is actually hardcoded to use gyp_chromium when running in GYP mode, so it's better to clean this up for now.
>
> Original issue's description:
> > Add tools/mb to setup_links.py
> >
> > I believe this is needed in order to setup the iOS simulator bots
> > using the ios recipe module. We'll also most likely use MB in the future
> > when moving over from GYP to GN (since that's the sole purpose of the tool:
> > to make such a migration easier).
> >
> > BUG=chromium:498746
> > NOTRY=True
> > TBR=phoglund@webrtc.org
> >
> > Committed: https://crrev.com/68da769ab9579cac98fe4da7fb5da6dbb3842216
> > Cr-Commit-Position: refs/heads/master@{#11575}
>
> TBR=phoglund@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:498746
>
> Committed: https://crrev.com/67ca0e16501d5c9179d3003a38a7cefc7cd3e259
> Cr-Commit-Position: refs/heads/master@{#11577}
TBR=phoglund@webrtc.org
NOTRY=True
Review URL: https://codereview.webrtc.org/1730113002
Cr-Commit-Position: refs/heads/master@{#11732}
Reason for revert:
Doesn't solve the problem and MB is actually hardcoded to use gyp_chromium when running in GYP mode, so it's better to clean this up for now.
Original issue's description:
> Add tools/mb to setup_links.py
>
> I believe this is needed in order to setup the iOS simulator bots
> using the ios recipe module. We'll also most likely use MB in the future
> when moving over from GYP to GN (since that's the sole purpose of the tool:
> to make such a migration easier).
>
> BUG=chromium:498746
> NOTRY=True
> TBR=phoglund@webrtc.org
>
> Committed: https://crrev.com/68da769ab9579cac98fe4da7fb5da6dbb3842216
> Cr-Commit-Position: refs/heads/master@{#11575}
TBR=phoglund@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:498746
Review URL: https://codereview.webrtc.org/1691723003
Cr-Commit-Position: refs/heads/master@{#11577}
I believe this is needed in order to setup the iOS simulator bots
using the ios recipe module. We'll also most likely use MB in the future
when moving over from GYP to GN (since that's the sole purpose of the tool:
to make such a migration easier).
BUG=chromium:498746
NOTRY=True
TBR=phoglund@webrtc.org
Review URL: https://codereview.webrtc.org/1692543002
Cr-Commit-Position: refs/heads/master@{#11575}
Change log: 6a04368..717238e
Full diff: 6a04368..717238e
Also add third_party/tcmalloc to the symlink list.
As per crrev.com/1611633003 host tools require tcmalloc.
No update to Clang.
BUG=chromium:580777
Review URL: https://codereview.webrtc.org/1629373002
Cr-Commit-Position: refs/heads/master@{#11369}
Fix creates a symlink tools/generate_stubs -> chromium/src/tools/generate_stubs which is used by ffmpeg on windows.
BUG=468365
NOTRY=True
Review URL: https://codereview.webrtc.org/1586083003
Cr-Commit-Position: refs/heads/master@{#11264}
Defining use_third_party_h264 directly, and indirectly defining use_openh264 (from third_party/openh264) and ffmpeg_branding (from third_party/ffmpeg).
These will be used in a follow-up CL that adds an encoder and decoder implementation.
The flags are added in this CL so that they can be used by trybots/waterfall bots in GN without "Build argument had no effect" errors. Equivalent GYP changes are also added.
BUG=468365
Review URL: https://codereview.webrtc.org/1575913003
Cr-Commit-Position: refs/heads/master@{#11204}
This is used on Mac to link against a precompiled libc++
library on Mac (see https://crbug.com/400091 for details)
TBR=tkchin@webrtc.org
TESTED=Verified the warnings like:
ld: warning: directory not found for option '-L../../third_party/libc++-static'
are no longer printed on Mac.
Review URL: https://codereview.webrtc.org/1475643010 .
Cr-Commit-Position: refs/heads/master@{#10797}
In https://codereview.webrtc.org/1430023005 all the code
references to ICU were removed. This actually removes the
library from being referenced.
TESTED=git cl try -c --bot=win_compile_rel --bot=linux_compile_rel --bot=android_compile_rel --bot=mac_compile_rel --bot=ios_rel -m tryserver.webrtc
R=phoglund@webrtc.org
Review URL: https://codereview.webrtc.org/1417563006 .
Cr-Commit-Position: refs/heads/master@{#10584}
Xvfb is needed for the screen capture tests in modules_unittests,
which also brings in xdisplaycheck used by testing/xvfb.py.
libjingle_media_unittest was missing a resource video in the .isolate
file.
BUG=chromium:497757
R=stip@chromium.org
Review URL: https://codereview.webrtc.org/1415603005 .
Cr-Commit-Position: refs/heads/master@{#10365}
Our perf test suite webrtc_perf_tests timed out, which caused most
of the delay landing this (https://crbug.comn/535973 and
https://codereview.chromium.org/1370133004).
Other problems with executing Android tests also needed to be
resolved in order to land this (http://crbug.com/534849).
Libvpx has moved from third_party/libvpx to third_party/libvpx_new
as of https://codereview.chromium.org/1323333002/
Android GN was blocking this roll due to a problem that ended up
being caused by a bug (http://crbug.com/534849).
Relevant changes:
* src/buildtools: f7310ee..8d89c1b
* src/third_party/boringssl/src: 1d128f3..4c60d35
* src/third_party/icu: 6b3ce81..423fc7e
* src/third_party/libjpeg_turbo: 631e2dd..e4e7503
* src/third_party/libvpx: ac1772e..70db223
* src/third_party/libyuv: fcacbfb..62c49dc
* src/tools/gyp: 5d01a8c..01528c7
* src/tools/swarming_client: 77f720b..6e5d2b2
Details: 310ea93..8cf53d6/DEPS
Clang version changed 245965:247874
Details: 310ea93..8cf53d6/tools/clang/scripts/update.sh
BUG=481034, 535973
TBR=marpan@webrtc.org
Review URL: https://codereview.webrtc.org/1355083002
Cr-Commit-Position: refs/heads/master@{#10101}
This updates the isolate.gypi copies we have to maintain in our
code repo to Chromium's revision 310ea93.
The changes about generating .isolated.gen.json files are needed
to support running with Swarming (https://www.chromium.org/developers/testing/isolated-testing)
Since isolated testing is now using a new launch script
in tools: isolate_driver.py, that's added to our links
script.
In order to use isolate_driver.py, the .isolate files must be in the
same directory as the test_name_run target is defined, which meant
I had to move around some of the isolate files and targets below
webrtc/modules.
BUG=497757
R=maruel@chromium.orgTBR=henrik.lundin@webrtc.org, mflodman@webrtc.org, niklas.enbom@webrtc.org
TESTED=Clobbered trybots:
git cl try -c --bot=linux_compile_rel --bot=mac_compile_rel --bot=win_compile_rel --bot=android_compile_rel --bot=ios_rel -m tryserver.webrtc
Review URL: https://codereview.webrtc.org/1373513002 .
Cr-Commit-Position: refs/heads/master@{#10081}
The WebKit dependency could be removed again after
https://codereview.chromium.org/1338193003/
Relevant changes:
* src/buildtools: 565d04e..f7310ee
* src/third_party/boringssl/src: ac8302a..1d128f3
* src/third_party/libvpx: 0304cef..ac1772e
* src/third_party/libyuv: 0bc626a..fcacbfb
* src/third_party/mockito/src: ed99a52..4d987dc
* src/tools/swarming_client: 2866a22..77f720b
Details: 5482f56..310ea93/DEPS
Clang version was not updated in this roll.
TBR=marpan@webrtc.org
Review URL: https://codereview.webrtc.org/1347153003 .
Cr-Commit-Position: refs/heads/master@{#9962}
Recent changes (https://codereview.chromium.org/1311013010) introduces a
dependency on WebKit (Blink) in Chromium, which forces us to start pulling
down that as well (+6GB). However Blink is about to be merged into the
Chromium repo soon anyway, so the size increase is inevitable.
Luckily, this can be removed in the next roll, if we roll past
http://crrev.com/348812
The ijar dependency was introduced in https://codereview.chromium.org/1323053003 (#347208)
Relevant changes:
* src/third_party/boringssl/src: 12fe1b2..ac8302a
* src/third_party/libvpx: a208eca..0304cef
* src/third_party/libyuv: 3c4f573..0bc626a
* src/tools/gyp: 6ee91ad..5d01a8c
Details: a28d8d5..5482f56/DEPS
Clang version was not updated in this roll.
R=torbjorng@webrtc.orgTBR=marpan@webrtc.org
BUG=webrtc:5005, chromium:530112
Review URL: https://codereview.webrtc.org/1305043008 .
Cr-Commit-Position: refs/heads/master@{#9956}
Add pylintrc file based on
https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/pylintrc
bit tightened up quite a bit (the one in depot_tools is far
more relaxed).
Remove a few excluded directories from pylint check and fixed/
suppressed all warnings generated.
Add GN format check + formatted all GN files using 'gn format'.
Cleanup redundant rules in tools/PRESUBMIT.py
TESTED=Ran 'git cl presubmit -vv', fixed the PyLint violations.
Ran it again with a modification in webrtc/build/webrtc.gni, formatted
all the GN files and ran it again.
R=henrika@webrtc.org, phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/50069004
Cr-Commit-Position: refs/heads/master@{#9274}
https://codereview.chromium.org/1051343002 adds a dependency
on Chromium's third_party/junit into base/ which affects our
Android tests that uses that code.
The precompiled JUnit 4.11 JAR file that is only by the
libjingle_peerconnection_java_unittest target on Linux has been
moved to third_party/junit-jar, since it collided with the expected
path for the JUnit dependency mentioned above.
It had to be kept since the Chromium JUnit is only possible to build
when OS==android.
This CL also brings in Mockito and Robolectric, which should be
useful for our Android tests.
Other relevant changes:
* src/buildtools: 3b302fe..15308f4
* src/third_party/libjpeg_turbo: 034e9a9..9e9058b
* src/third_party/libyuv: 32ad6e0..01db3d1
Details: a12e1e1..0cb2549/DEPS
Clang version was not updated in this roll.
BUG=4499
R=phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/48239004
Cr-Commit-Position: refs/heads/master@{#9113}
The trybots ended up in a state that could not be cleaned up
when other tryjobs were altering the checkout with different
variations of dependencies.
TBR=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/46139004
Cr-Commit-Position: refs/heads/master@{#9110}
We used to symlink the .gn file from Chromium but it's now
replaced by our own copy (needed for recent GN changes in
https://codereview.chromium.org/988563002).
Relevant changes:
* src/third_party/boringssl/src: e2e1326..40acdae
* src/third_party/icu: 46be516..10834e8
* src/third_party/nss: bb4e75a..d1edb68
* src/tools/gyp: d174d75..2889664
The entries for
* src/third_party/jsoncpp/source/include
* src/third_party/jsoncpp/source/src/lib_json
are removed and replaced by:
* src/third_party/jsoncpp/source @ab1e40f
(which doesn't matter for us since we symlink third_party/jsoncpp
Details: 5333e14..d8f8dc8/DEPS
Clang version was not updated in this roll.
R=henrika@webrtc.org, pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/48919004
Cr-Commit-Position: refs/heads/master@{#8959}
