47ed99872d
Use the clock to convert absolute capture timestamps to NTP times.
...
This allows callers to use timestamps generated from their own clocks
without worrying about converting to webrtc time.
No-Try because of lack of infra lack of capacity on macs.
No-Try: True
Bug: webrtc:11327
Change-Id: I7b1935654a2b23cf844c7b3622ed68763ced9da5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219785
Commit-Queue: Paul Hallak <phallak@google.com >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Minyue Li <minyue@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34076}
2021-05-21 12:41:50 +00:00
edc347c4e5
Introduce (Un)SubscribeDtlsTransportState methods.
...
WebRTC is going to remove cricket::DtlsTransportState and switch to
webrtc::DtlsTransportState. This CL introduces a set of new methods to
allow to subscribe to DTLS transport state updates while WebRTC
internally migrates away from cricket::DtlsTransportState.
No-Try: True
Bug: webrtc:12762
Change-Id: I79cf48e2f7122cc76fde6e4fd1541382fd096d53
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/218607
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34075}
2021-05-21 10:56:44 +00:00
95f1e5192c
Do not attempt setting the absolute capture time extension if we don't
...
get a timestamp.
Also, use -1 to signify an unset timestamp. This is what other callers
do: https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/modules/audio_coding/acm2/audio_coding_module.cc;l=306;drc=bbe4aed2302dc763935496b80a5cefb6a42d912d
No-Try because of lack of infra lack of capacity on macs.
No-Try: True
Bug: webrtc:11327
Change-Id: Ide0c0633579b6b2be3eea9912b13f858760de0ad
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219781
Commit-Queue: Paul Hallak <phallak@google.com >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34074}
2021-05-21 10:55:15 +00:00
2491dbdf0b
Make Clock::ConvertTimestampToNtpTime pure virtual
...
No-Try because of lack of infra lack of capacity on macs.
No-Try: True
Bug: webrtc:11327
Change-Id: I9296bb92fdd62800da3ddd80789164c80350577d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219782
Commit-Queue: Paul Hallak <phallak@google.com >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34073}
2021-05-21 09:55:14 +00:00
e93fe6c532
Enable Chromium to stop including api/proxy.h indirectly.
...
This change prepares for a later change in Chromium that makes it
stop depending on headers exposed by WebRTC that require inclusion of
api/proxy.h.
No-Try because of lack of infra lack of capacity on macs.
No-Try: True
Bug: webrtc:12787
Change-Id: I628424fe49e873027595b80336be2b821c22245e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219688
Commit-Queue: Markus Handell <handellm@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34072}
2021-05-21 09:35:35 +00:00
b59e9045bf
Add the ability to convert a timestamp to NTP time.
...
The timestamps returned by the clocks do not have an epoch. Each clock
should be able to convert a timestamp it returns to an NTP time.
The default implementation for querying for an NTP time is converting
the current timestamp.
This is favored over returning the offset between the relative and the
NTP time because there is a field trial that makes the real clock revert
to using system dependent methods for getting the NTP time.
Bug: webrtc:11327
Change-Id: Ia139b2744b407cae94420bf9112212ec577efb16
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219687
Reviewed-by: Minyue Li <minyue@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Paul Hallak <phallak@google.com >
Cr-Commit-Position: refs/heads/master@{#34071}
2021-05-21 04:34:11 +00:00
0cff39137b
Start with a BeginLog event in event log encoder unittest
...
Also rename encoding_ to encoding_type_
Bug: webrtc:11933
Change-Id: If4848199b96e9de612695dfe7ec52266ccd80bd3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219285
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Elad Alon <eladalon@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34070}
2021-05-20 17:44:30 +00:00
b8dc7fa5a6
Make AgcManagerDirect clipping parameters configurable
...
Bug: webrtc:12774
Change-Id: I99824b5aabe6f921a5db425dd1c1c1d4c606186c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219681
Commit-Queue: Hanna Silen <silen@webrtc.org >
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34069}
2021-05-20 16:53:59 +00:00
e2b9fc6909
Move FecOverheadRate, BitrateCallbacks to rtp_sender_egress_unittest.
...
Bug: webrtc:11340
Change-Id: I33dcaea0146429de94d7610b46592b41e0c5549a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219685
Commit-Queue: Erik Språng <sprang@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34068}
2021-05-20 14:38:12 +00:00
63b3095d2b
Make local to capturer clock offset a separate entry in PacketInfo.
...
This also changes the meaning of |estimated_capture_clock_offset| in
|absolute_capture_time_| to become a remote to capturer clock offset.
Bug: chromium:1056230, webrtc:10739
Change-Id: Id658590e027bbe77ae0834ea224e1dc977a305f2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219163
Commit-Queue: Minyue Li <minyue@webrtc.org >
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org >
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org >
Reviewed-by: Chen Xing <chxg@google.com >
Cr-Commit-Position: refs/heads/master@{#34067}
2021-05-20 13:42:57 +00:00
cbde0cf994
Roll chromium_revision 6291fe6f0e..e5dd2eb61e (884821:884954)
...
Change log: 6291fe6f0e..e5dd2eb61e
Full diff: 6291fe6f0e..e5dd2eb61e
Changed dependencies
* src/base: bf402f265f..d342f0198c
* src/build: d3e8244202..cdb2b715f2
* src/ios: f8290a0089..2d869c8a06
* src/testing: 6fdd56ebac..63cd964d09
* src/third_party: 2413ef8717..ad3aad297e
* src/third_party/depot_tools: dd0076703b..51e3708841
* src/third_party/freetype/src: 06e21ffedf..ebf9e5ac71
* src/tools: d7aa02d173..98b923e2d6
DEPS diff: 6291fe6f0e..e5dd2eb61e
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I9962f3a73387f19594fa726005d15cdad45157e1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219660
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34066}
2021-05-20 11:06:22 +00:00
0de1ed0244
Have only two pure virtual methods for webrtc::Clock,
...
`CurrentTime` and `CurrentNtpTime`. Make all other methods non-virtual.
Bug: webrtc:11327
Change-Id: I391d9eaec1ba27ec4f8e1901498c68c28a7ec4ff
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219466
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Paul Hallak <phallak@google.com >
Cr-Commit-Position: refs/heads/master@{#34065}
2021-05-20 10:44:11 +00:00
8ed1e9336e
Switch from check_targets to no_check_targets in .gn
...
Bug: webrtc:12785
Change-Id: I3d5252323393f6cfd536b48a867d55d07313d7c9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219341
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34064}
2021-05-20 10:42:21 +00:00
193f4bf6c1
Replace legacy getStats with standard getStats in the iOS example
...
Bug: webrtc:12688
Change-Id: I039cdae7647738d5f17b229c1137b72bf4aa7be0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219580
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34063}
2021-05-20 08:40:11 +00:00
bd346d7439
Update WebRTC code version (2021-05-20T04:01:58).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I51d91eef3ba1e709b9ae8d893151897e7924372f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219561
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34062}
2021-05-20 05:46:18 +00:00
069ed356be
Roll chromium_revision 0321a6153c..6291fe6f0e (884706:884821)
...
Change log: 0321a6153c..6291fe6f0e
Full diff: 0321a6153c..6291fe6f0e
Changed dependencies
* src/base: 62a9dbcb7f..bf402f265f
* src/build: e0e25a3b84..d3e8244202
* src/buildtools: 076a074891..b9af93e79f
* src/ios: 13d652bbe9..f8290a0089
* src/testing: ddea311afa..6fdd56ebac
* src/third_party: 81afca40f5..2413ef8717
* src/third_party/breakpad/breakpad: 3bea2815bf..c484031f1f
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/64fcc4794c..7da48e9f87
* src/third_party/depot_tools: 3ffca4bed7..dd0076703b
* src/tools: 9367b5119d..d7aa02d173
DEPS diff: 0321a6153c..6291fe6f0e
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I1972ece3a7adc412aba546081decd4dba98a49b8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219560
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34061}
2021-05-20 02:40:55 +00:00
4fb5684493
Roll chromium_revision b8d2317c2e..0321a6153c (884575:884706)
...
Change log: b8d2317c2e..0321a6153c
Full diff: b8d2317c2e..0321a6153c
Changed dependencies
* src/build: d0db4e6f41..e0e25a3b84
* src/buildtools: 20b1d0fc13..076a074891
* src/ios: f6d02ed75e..13d652bbe9
* src/testing: a6baa962fe..ddea311afa
* src/third_party: 290861ba4e..81afca40f5
* src/third_party/depot_tools: 6b0a611c2c..3ffca4bed7
* src/third_party/perfetto: 9a1689eeaa..565fc165d0
* src/tools: 93f86305be..9367b5119d
DEPS diff: b8d2317c2e..0321a6153c
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I00189108d3667a14f3f043f3c5ff2061ae256b87
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219503
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34060}
2021-05-19 23:26:50 +00:00
6c96611069
Roll chromium_revision 3bdbd47d23..b8d2317c2e (884422:884575)
...
Change log: 3bdbd47d23..b8d2317c2e
Full diff: 3bdbd47d23..b8d2317c2e
Changed dependencies
* src/base: e34cf0158f..62a9dbcb7f
* src/build: 4e5721997a..d0db4e6f41
* src/ios: e0e60851e1..f6d02ed75e
* src/testing: 1bebb81f26..a6baa962fe
* src/third_party: 721e99a5ba..290861ba4e
* src/third_party/freetype/src: 1bc801b0d6..06e21ffedf
* src/third_party/perfetto: dac610dd85..9a1689eeaa
* src/tools: 04d8fb2093..93f86305be
* src/tools/luci-go: git_revision:22d464e2f8f3bd2bd33f69fe819326d63f881008..git_revision:9cd9603def7a649cd3e29517180d6622be2fa898
* src/tools/luci-go: git_revision:22d464e2f8f3bd2bd33f69fe819326d63f881008..git_revision:9cd9603def7a649cd3e29517180d6622be2fa898
* src/tools/luci-go: git_revision:22d464e2f8f3bd2bd33f69fe819326d63f881008..git_revision:9cd9603def7a649cd3e29517180d6622be2fa898
DEPS diff: 3bdbd47d23..b8d2317c2e
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I31569661a7a962e619a1573e7a6189d7ac865c64
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219502
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34059}
2021-05-19 19:10:56 +00:00
86bd92fca9
Add test for many non-dropped packets in unreliable mode.
...
These tests document existing behavior; there are notes about where
this behavior is either surprising or wrong.
Bug: chromium:1148951
Change-Id: If9875fb744c44c129ff9949d1bab3d3d99f17b81
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/217520
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Victor Boivie <boivie@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34058}
2021-05-19 17:30:46 +00:00
e7481a4199
Add an UlpFec test to RtpRtcp unit tests.
...
Bug: webrtc:11340
Change-Id: I0ef9c07ff1c9a23af5cd1e6c226c1fb15e4758ca
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219469
Commit-Queue: Erik Språng <sprang@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34057}
2021-05-19 15:26:24 +00:00
398def6828
Improvements to AEC3 logging to simplify debugging
...
Adds log messages for
- AEC3 creation
- Transparent mode implementation selection
- Config parameter changes via RetrieveFieldTrialValue
Bug: webrtc:8671
Change-Id: Ibb1e76d66975a3a3c1227e31b9916a17b76e6c29
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219468
Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org >
Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34056}
2021-05-19 14:28:44 +00:00
aeb8ce882f
AEC3: Change adaptation speed of the matched filter after a delay is found
...
This change enables the use of two different adaptation speeds of the
matched filter of the delay estimator of AEC3.
One speed is used when no delay has been found, and one is used after a
reliable delay has been found. The purpose is to use a slower adaptation
speed to reduce the risk of divergence during double-talk without
slowing down the search for the initial delay.
The CL prepares for experimentation by adding field trials for
controlling the two adaptation speeds.
Bug: webrtc:12775
Change-Id: I817a1ab5ded0f78d20de45edcf04c708290173fc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219083
Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org >
Reviewed-by: Per Åhgren <peah@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34055}
2021-05-19 13:37:13 +00:00
402ceffff1
sctp: Reduce logging level for common calls
...
Reduced the level so that the library can be run with INFO level without
a lot of spam. VERBOSE is still reserved for frequent logs.
Also, using WARNING for logs that are not fatal and which can easily
be triggered by the user.
Bug: webrtc:12614
Change-Id: If09c302b2b5bfc002471f86a8aeb74ba1172c705
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219465
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34054}
2021-05-19 13:22:43 +00:00
3a45d32d4e
dcsctp: Report duplicate TSNs
...
Reporting the duplicate TSNs is a SHOULD in the RFC, and using the
duplicate TNSs is a MAY, and in reality I haven't seen an implementation
use it yet. However, it's good for debugging and for stats generation.
Bug: webrtc:12614
Change-Id: I1cc3f86961a8d289708cbf50d98dedfd25077955
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219462
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34053}
2021-05-19 12:57:03 +00:00
91fef0250b
Roll chromium_revision 108d11241e..3bdbd47d23 (884294:884422)
...
Change log: 108d11241e..3bdbd47d23
Full diff: 108d11241e..3bdbd47d23
Changed dependencies
* src/base: fb9171ae3b..e34cf0158f
* src/build: 4036cf1b17..4e5721997a
* src/ios: 254885a5e6..e0e60851e1
* src/testing: 7bf52eb391..1bebb81f26
* src/third_party: b29fa1975a..721e99a5ba
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c1e1d559b4..64fcc4794c
* src/third_party/perfetto: 7d6375fd3e..dac610dd85
* src/tools: 6124b15fd1..04d8fb2093
DEPS diff: 108d11241e..3bdbd47d23
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I634291ac4bb10ada2da89b21b6bba7a9b95a33ae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219441
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34052}
2021-05-19 12:33:53 +00:00
f6be1b22d6
Simplify RtpSenderTest.SendFlexfecPackets and move to RtpRtcp-level.
...
Bug: webrtc:11340
Change-Id: Ic83217994c447e490a6ac9cf04ceafa3dc009af7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219461
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34051}
2021-05-19 10:19:38 +00:00
3de4067092
Increase the bound for the value of the filter reset block interval
...
Bug: b/177359044
Change-Id: Id42022b42cad81a3eb2ac42b565d84f691448605
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/217890
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org >
Commit-Queue: Per Åhgren <peah@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34050}
2021-05-19 09:18:16 +00:00
12c881b21e
Make RtpHelper<>::sending_ atomic.
...
This is to address flakiness of "DoubleThread" tests for the media
channel class. More investigation is in order though, so I'm adding
a TODO. The bug appears to be in test code only though, so this is
just to deflake the bots.
Bug: webrtc:12783
Change-Id: Ib6cf78927f2a9be9d2c6aa7f6915b1131a206e7c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219460
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34049}
2021-05-19 08:56:46 +00:00
38f1d4bf8a
[LibvpxVp8Encoder] Don't DCHECK crash if I420 is not equal to I420A.
...
In CL https://webrtc-review.googlesource.com/c/src/+/216323 we fixed
the issue where I420 and I420A not being equal would result in dropping
frames in release builds.
But we forgot to update the corresponding DCHECK, meaning the I420 not
being the same as I420A issue still causes crashes on debug builds.
(I must have been running a release build not to catch this before?)
This CL replaces the DCHECK_EQ with an RTC_NOTREACHED inside the
IsCompatibleVideoFrameBufferType check.
Because this only affects debug builds, this CL does not need to be
backmerged anywhere.
Bug: chromium:1203206
Change-Id: I101823e8bca293e94d0f7ce507fe78cedff3ea1b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219281
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34048}
2021-05-19 08:48:46 +00:00
91a892f8ed
Add ability to dump the coarse filter in the echo subtractor
...
Bug: b/155316201
Change-Id: I008cdf1531af3c3c0fff4ce19ad5dd74f8e73f65
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/217891
Reviewed-by: Sam Zackrisson <saza@google.com >
Commit-Queue: Per Åhgren <peah@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34047}
2021-05-19 08:24:16 +00:00
cf0ec283d2
Delete RtcpStatistic struct as no longer used
...
Bug: webrtc:10678
Change-Id: Ic99910817f8b3044124a212627f0a754a54b69e7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219284
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34046}
2021-05-19 08:07:56 +00:00
5f4efd5cda
Update WebRTC code version (2021-05-19T04:03:01).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I338b90582344c00035eb450840f2d4200db4fc81
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219400
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34045}
2021-05-19 05:37:13 +00:00
723e92e93a
Roll chromium_revision 19bcae5aaa..108d11241e (884108:884294)
...
Change log: 19bcae5aaa..108d11241e
Full diff: 19bcae5aaa..108d11241e
Changed dependencies
* src/base: db30053b7a..fb9171ae3b
* src/build: 8ef5618407..4036cf1b17
* src/ios: 5b15656973..254885a5e6
* src/testing: d5026c75fa..7bf52eb391
* src/third_party: 575566d758..b29fa1975a
* src/third_party/depot_tools: 8c9a5b84cb..6b0a611c2c
* src/third_party/perfetto: f96c36dc3c..7d6375fd3e
* src/tools: 05f166d97e..6124b15fd1
* src/tools/luci-go: git_revision:5a038afb97f6b77e0fcefe1185317da216fced1f..git_revision:22d464e2f8f3bd2bd33f69fe819326d63f881008
* src/tools/luci-go: git_revision:5a038afb97f6b77e0fcefe1185317da216fced1f..git_revision:22d464e2f8f3bd2bd33f69fe819326d63f881008
* src/tools/luci-go: git_revision:5a038afb97f6b77e0fcefe1185317da216fced1f..git_revision:22d464e2f8f3bd2bd33f69fe819326d63f881008
DEPS diff: 19bcae5aaa..108d11241e
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I6f3d0ee62d98a15938ede74941fbe8c23109cd9e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219250
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34044}
2021-05-19 04:40:23 +00:00
fab9256fb6
Roll chromium_revision a0592593ad..19bcae5aaa (883988:884108)
...
Change log: a0592593ad..19bcae5aaa
Full diff: a0592593ad..19bcae5aaa
Changed dependencies
* src/base: 65528ba02a..db30053b7a
* src/build: d2ba2f2766..8ef5618407
* src/ios: c42253cc6c..5b15656973
* src/testing: fbeaf7e18b..d5026c75fa
* src/third_party: f977052770..575566d758
* src/third_party/depot_tools: fe7d709f05..8c9a5b84cb
* src/third_party/perfetto: 9109f50a74..f96c36dc3c
* src/tools: 018f0f1344..05f166d97e
DEPS diff: a0592593ad..19bcae5aaa
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ica23bc3172edfc3b3c4ca85f644f1bba7e8b14e3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219247
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34043}
2021-05-18 21:43:19 +00:00
ee483f701a
Roll chromium_revision ea49ecba06..a0592593ad (883877:883988)
...
Change log: ea49ecba06..a0592593ad
Full diff: ea49ecba06..a0592593ad
Changed dependencies
* src/base: 8cd88f78ba..65528ba02a
* src/build: d23e13a4cf..d2ba2f2766
* src/ios: c8fff43dd1..c42253cc6c
* src/testing: d7dc6149dd..fbeaf7e18b
* src/third_party: aa1f7453a2..f977052770
* src/third_party/perfetto: b91884a97a..9109f50a74
* src/tools: 540024077f..018f0f1344
* src/tools/luci-go: git_revision:bbac8f199026d706b08e53ca46d1a9560ae580d2..git_revision:5a038afb97f6b77e0fcefe1185317da216fced1f
* src/tools/luci-go: git_revision:bbac8f199026d706b08e53ca46d1a9560ae580d2..git_revision:5a038afb97f6b77e0fcefe1185317da216fced1f
* src/tools/luci-go: git_revision:bbac8f199026d706b08e53ca46d1a9560ae580d2..git_revision:5a038afb97f6b77e0fcefe1185317da216fced1f
DEPS diff: ea49ecba06..a0592593ad
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I947344772c6b24ef3c6a90665f94899d307727f5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219320
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34042}
2021-05-18 16:50:46 +00:00
db28555903
Improve test coverage for padding packet generation.
...
This is a follow-up to r34019. It adds checks for when padding can be
sent before media - and how timestamps are set on RTX padding.
Bug: webrtc:11340
Change-Id: I46fbd3c3eff9e308b5c65220718df749f2d9c46b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219162
Commit-Queue: Erik Språng <sprang@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34041}
2021-05-18 16:47:16 +00:00
567e847260
Move Send(Generic|Raw)Video from rtp sender unittest to RtpRtcp-level.
...
Bug: webrtc:11340
Change-Id: Id2204f136c06584f9284c1560832559bb8ac5011
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219283
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34040}
2021-05-18 14:33:44 +00:00
ea7474ee74
Remove redundant VideoSendStream::rtcp_stats field
...
its content is duplicated in the report_block_data member
Bug: webrtc:10678
Change-Id: I89421ae4ab5f727a233161924372105e222ed404
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219080
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34039}
2021-05-18 13:37:51 +00:00
a399c823bb
Field trial to disable the transient suppressor
...
This change adds the field trial "WebRTC-TransientSuppressorForcedOff"
that can be used to disable the transient suppressor (removal of
keyboard typing sounds). The field trial can be enabled by users via
command-line or via experimentation.
Bug: chromium:1186705
Change-Id: I7272df6a20fbbee24a7ba0904502c76bd775d275
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219282
Reviewed-by: Per Åhgren <peah@webrtc.org >
Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34038}
2021-05-18 12:34:37 +00:00
a77e16ca2c
Update BitBuffer methods to style guide
...
Specifically, use reference instead of pointer for out parameter
and place the out parameter last, for the following methods
ReadUInt8
ReadUInt16
ReadUInt32
ReadBits
PeekBits
ReadNonSymmetric
ReadSignedExponentialGolomb
ReadExponentialGolomb
Bug: webrtc:11933
Change-Id: I3f1efe3e29155985277b0cd18700ddea25fe7914
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/218504
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34037}
2021-05-18 11:10:27 +00:00
7c286c062c
Roll chromium_revision 1c010044c4..ea49ecba06 (883756:883877)
...
Change log: 1c010044c4..ea49ecba06
Full diff: 1c010044c4..ea49ecba06
Changed dependencies
* src/base: ec66cf6a5d..8cd88f78ba
* src/build: 30196c5652..d23e13a4cf
* src/ios: fb851c1163..c8fff43dd1
* src/testing: f2628833bb..d7dc6149dd
* src/third_party: 825768c708..aa1f7453a2
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/a68a0035fc..c1e1d559b4
* src/third_party/depot_tools: 1fc595b55c..fe7d709f05
* src/third_party/perfetto: 4690aa4a83..b91884a97a
* src/tools: 3d300ac023..540024077f
DEPS diff: 1c010044c4..ea49ecba06
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Iaaa75e90a3bc6d6092d80ca1ab6b2e7450338422
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219243
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34036}
2021-05-18 11:08:07 +00:00
fe6595f006
Include all RTP packet infos from the mix list when updating the audio frame for mixing.
...
Users of the mixer can use this information to determine which sources were included in the frame.
Bug: webrtc:12745
Change-Id: I11a8e3b1f4e8f95eb870336cad8dd082330bdf02
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/217768
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Minyue Li <minyue@webrtc.org >
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Reviewed-by: Chen Xing <chxg@google.com >
Commit-Queue: Doudou Kisabaka <doudouk@google.com >
Cr-Commit-Position: refs/heads/master@{#34035}
2021-05-18 11:05:37 +00:00
92bd9020af
dcsctp: Restrict fuzzing input length
...
Restricting the fizzing input length according to the instructions at
https://chromium.googlesource.com/chromium/src/testing/libfuzzer/+/HEAD/getting_started.md#common-tricks
Without this limit, it finds inputs that are unreasonably large (160kB+)
that just make the ASAN built fuzzer hit the default timeout of 60s.
Bug: webrtc:12614
Change-Id: I1417f22698fba8d9bd2c56f8c3d51850b8f00f54
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219161
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34034}
2021-05-18 09:22:37 +00:00
718acf6c1d
peerconnection: add test for createOffer({voiceActivityDetection: true})
...
and fix other tests to actually include CN in supported codecs.
BUG=webrtc:12365
Change-Id: I7154dd0046497604a6fc825ce81e85c1b9cadcef
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/218601
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Philipp Hancke <phancke@nvidia.com >
Cr-Commit-Position: refs/heads/master@{#34033}
2021-05-18 09:10:27 +00:00
4e9442dfe0
Update WebRTC code version (2021-05-18T04:02:06).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: Idfcffa14bf27c61eb2eab6e94e0e195c03740cf0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219241
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34032}
2021-05-18 05:35:55 +00:00
2e929eae1b
Roll chromium_revision 2620ef6e05..1c010044c4 (883646:883756)
...
Change log: 2620ef6e05..1c010044c4
Full diff: 2620ef6e05..1c010044c4
Changed dependencies
* src/base: 86fd9a0cc7..ec66cf6a5d
* src/build: c81ea93291..30196c5652
* src/testing: 152f86fc72..f2628833bb
* src/third_party: 6c8286300e..825768c708
* src/third_party/depot_tools: f059ec9368..1fc595b55c
* src/third_party/perfetto: 5e76bff1ab..4690aa4a83
* src/tools: 880bc078c4..3d300ac023
DEPS diff: 2620ef6e05..1c010044c4
/DEPS
Clang version changed llvmorg-13-init-9302-g897d7bce:llvmorg-13-init-10392-gd3676d4b
Details: 2620ef6e05..1c010044c4
/tools/clang/scripts/update.py
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I6f2fc23c5bef4e0b55273ae002c3de1ce8b949ec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219240
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34031}
2021-05-18 02:57:56 +00:00
8b9483228d
Roll chromium_revision fb62f861d3..2620ef6e05 (883525:883646)
...
Change log: fb62f861d3..2620ef6e05
Full diff: fb62f861d3..2620ef6e05
Changed dependencies
* src/base: 1afbc09004..86fd9a0cc7
* src/ios: dfe29bbab2..fb851c1163
* src/testing: 743d6d5078..152f86fc72
* src/third_party: c9b2cc4d2d..6c8286300e
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/a532699d20..a68a0035fc
* src/third_party/depot_tools: cd152033d0..f059ec9368
* src/tools: 9fd79ca06a..880bc078c4
DEPS diff: fb62f861d3..2620ef6e05
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Idac1c0256f515c87684f27b200d5c52a04bd1014
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219200
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34030}
2021-05-17 23:50:56 +00:00
c2310b2619
Set nativeObserver to 0 to avoid double release.
...
Bug: webrtc:12769
Change-Id: Ifcd3e8148e999740a697b27ddd12f6aca36c5440
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/218780
Commit-Queue: Tian Tan <tiantan@google.com >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34029}
2021-05-17 19:53:43 +00:00
bc42984226
Roll chromium_revision 5469e0bb11..fb62f861d3 (883387:883525)
...
Change log: 5469e0bb11..fb62f861d3
Full diff: 5469e0bb11..fb62f861d3
Changed dependencies
* src/base: 59242336d9..1afbc09004
* src/ios: c2badb41ee..dfe29bbab2
* src/testing: 31a90015dd..743d6d5078
* src/third_party: d822e7cb33..c9b2cc4d2d
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/9b2cdb769a..ddecaabdc8
* src/third_party/freetype/src: de15165774..1bc801b0d6
* src/third_party/usrsctp/usrsctplib: acfce46e42..22ba62ffe7
* src/tools: 2b137a091c..9fd79ca06a
DEPS diff: 5469e0bb11..fb62f861d3
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I8ee3cc2459430fd28a210f8eac05579aa75580a5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219180
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34028}
2021-05-17 18:37:43 +00:00
eadf4578e5
Remove check following SetChannel.
...
The number of invokes will vary based on number of receivers/senders,
so we can't have a fixed number there.
Bug: none
Change-Id: Iab3d529a5935c4b6cc95e9da6637acd880614972
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219101
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34027}
2021-05-17 17:49:01 +00:00