545727ecce
Move early-return in TimeToSendPadding.
...
Prevents taking send_critsect_ for checking sending status when not
actually intending to send padding.
BUG=
R=stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1218093002
Cr-Commit-Position: refs/heads/master@{#9526}
2015-07-01 13:31:14 +00:00
bd2522abf7
Fail RTP parsing on excessive padding length.
...
BUG=webrtc:4771
R=stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1220863002
Cr-Commit-Position: refs/heads/master@{#9525}
2015-07-01 12:35:56 +00:00
4daa90eed7
Prevent size_t underflow in H264 SPS parsing.
...
BUG=webrtc:4771
R=stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1219493004
Cr-Commit-Position: refs/heads/master@{#9523}
2015-07-01 10:00:20 +00:00
2f1509395b
Prevent OOB read on truncated H264 headers.
...
Prevents OOB reads on truncated FU-A NAL units, StapA headers and past
truncation just after StapA headers.
BUG=webrtc:4771
R=stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1218023003
Cr-Commit-Position: refs/heads/master@{#9522}
2015-06-30 15:23:42 +00:00
7ada923a94
Prevent OOB reads for zero-length H264 payloads.
...
Also fixes zero-length OOB reads for generic packetization.
BUG=webrtc:4771
R=stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1218013002
Cr-Commit-Position: refs/heads/master@{#9521}
2015-06-30 12:09:47 +00:00
48c3839e70
Prevent depacketizer OOB reads on zero-length VP8 payload.
...
BUG=webrtc:4771
R=stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1221643009
Cr-Commit-Position: refs/heads/master@{#9520}
2015-06-30 09:12:09 +00:00
6e355af348
Added fields for configuration information to the protobuf format
...
in the ACMDump. The ACMDump interface itself is not updated, so there
is no way (yet) to actually write the configuration fields.
BUG=
Review URL: https://codereview.webrtc.org/1202833003
Cr-Commit-Position: refs/heads/master@{#9519}
2015-06-30 08:51:19 +00:00
2e43b26c78
Prevent OOB reads in FEC packets without complete RED headers.
...
BUG=webrtc:4771
R=stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1220753003
Cr-Commit-Position: refs/heads/master@{#9518}
2015-06-30 08:32:47 +00:00
1adbacb19d
Adding method IsInBeam to beamformer class.
...
This was previously reviewed at:
https://webrtc-codereview.appspot.com/53729004/
Review URL: https://codereview.webrtc.org/1211613005
Cr-Commit-Position: refs/heads/master@{#9517}
2015-06-29 23:15:23 +00:00
3c60d61463
Remove a cast again, after it was shown to worsen Windows perf.
...
This will hurt Linux x64 perf, but we think that's a compiler bug and we're
willing to take the hit for the better clarity of the code sans cast as well as
the better Windows perf. Hopefully eventually the compiler will improve.
BUG=504813
TEST=none
TBR=andrew
Review URL: https://codereview.webrtc.org/1215053002
Cr-Commit-Position: refs/heads/master@{#9516}
2015-06-29 22:16:48 +00:00
71f6f4405c
iOS HW H264 support.
...
First step towards supporting H264 on iOS. More tuning/experimentation
required in future CLs. Tested using AppRTCDemo on iPhone6 + iPad Mini.
Future work to get it working on OS/X, simulator (renders black screen
currently) and with the Android AppRTCDemo. Currently protected with a
compile time guard.
BUG=4081
R=andrew@webrtc.org , haysc@webrtc.org , holmer@google.com , jiayl@webrtc.org , kjellander@webrtc.org , pbos@webrtc.org , phoglund@webrtc.org , stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1187573004 .
Cr-Commit-Position: refs/heads/master@{#9515}
2015-06-29 21:35:08 +00:00
70d5c475dd
Prevent out-of-bounds reads for short FEC packets.
...
BUG=webrtc:4771
R=stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1219703002
Cr-Commit-Position: refs/heads/master@{#9514}
2015-06-29 14:22:09 +00:00
1ca324f237
Adds UMA histogram for system delay jumps
...
Sudden platform system delay jumps can hurt AEC and we have no stats that monitor these jumps. How often do they occur, and when they are reported are they accurate?
This CL logs all jumps in both the reported and actual delay.
The histogram has been tested with a chromium build where a fake jump of 200 ms was applied after 5 seconds and it was registered correctly in chrome://histograms
BUG=488124
R=henrik.lundin@webrtc.org , peah@webrtc.org
Review URL: https://codereview.webrtc.org/1213733004 .
Cr-Commit-Position: refs/heads/master@{#9513}
2015-06-29 12:57:42 +00:00
c6891248b5
Simplify OWNERS structure in modules/audio_coding
...
All ownership is now handled by the top-level OWNERS file in
modules/audio_coding.
NOTRY=True
Review URL: https://codereview.webrtc.org/1212133005
Cr-Commit-Position: refs/heads/master@{#9512}
2015-06-29 11:54:50 +00:00
9b9f338f44
Adding Minyue to audio_coding/OWNERS
...
Review URL: https://codereview.webrtc.org/1205313002
Cr-Commit-Position: refs/heads/master@{#9511}
2015-06-29 09:29:24 +00:00
241338eeb7
Added support for keeping a buffer of the previous X seconds, to add to an AcmDump.
...
In addition, timestamps are now absolute instead of relative to LOG_START.
BUG=webrtc:4741
R=henrik.lundin@webrtc.org , kwiberg@webrtc.org , stefan@webrtc.org , terelius@webrtc.org
Review URL: https://codereview.webrtc.org/1209563002 .
Cr-Commit-Position: refs/heads/master@{#9509}
2015-06-26 08:19:33 +00:00
4b91bd0897
Move frame input (ViECapturer) to webrtc/video/.
...
Renames ViECapturer to VideoCaptureInput and initializes several
parameters on construction instead of setters.
Also removes an old deadlock suppression.
BUG=1695, 2999
R=asapersson@webrtc.org , mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/53559004 .
Cr-Commit-Position: refs/heads/master@{#9508}
2015-06-26 04:58:23 +00:00
ebe7422372
Created SphericalPoint in array_util.h
...
Review URL: https://codereview.webrtc.org/1211703002
Cr-Commit-Position: refs/heads/master@{#9507}
2015-06-25 21:24:11 +00:00
93fb53acf5
Adding a new ChangeLogger class to handle UMA logging of bitrates
...
This change introduces the sub-class ChangeLogger in AudioCodingModuleImpl. The class writes values to the named UMA histogram, but only if the value has changed since the last time (and always for the first call). This is to avoid the problem with audio codecs being registered but never used. Before this change, these codecs' bitrate was also logged, even though they were never used.
BUG=chromium:488124
R=kwiberg@webrtc.org
Review URL: https://codereview.webrtc.org/1203803004
Cr-Commit-Position: refs/heads/master@{#9506}
2015-06-25 20:03:12 +00:00
ecf6b81644
Pull the Voice Activity Detector out from the AGC
...
This change generates bit-exact values when running through audioproc_f than before.
This change was originally uploaded here:
* https://codereview.webrtc.org/1181933002/
* https://codereview.webrtc.org/1177043017/
And reverted because of an ASAN problem in Chrome here:
* https://codereview.webrtc.org/1192863006/
* https://codereview.webrtc.org/1194963003/
TBR=andrew@webrtc.org
Review URL: https://codereview.webrtc.org/1212543002
Cr-Commit-Position: refs/heads/master@{#9505}
2015-06-25 19:28:55 +00:00
0ea42d319e
Send Sdes using RtcpPacket
...
BUG=2450
R=asapersson@webrtc.org
Review URL: https://codereview.webrtc.org/1196863003 .
Cr-Commit-Position: refs/heads/master@{#9504}
2015-06-25 12:46:23 +00:00
51c7cbb86a
Revert "Pull the Voice Activity Detector out from the AGC"
...
This reverts commit 518c683f3e413523a458a94b533274bd7f29992d.
Breaks Linux-Asan bot
https://uberchromegw.corp.google.com/i/client.webrtc/builders/Linux%20Asan/builds/4348/steps/libjingle_peerconnection_unittest/logs/stdio
BUG=
TBR=aluebs@webrtc.org
Review URL: https://codereview.webrtc.org/1208793002 .
Cr-Commit-Position: refs/heads/master@{#9503}
2015-06-25 06:46:14 +00:00
518c683f3e
Pull the Voice Activity Detector out from the AGC
...
This change generates bit-exact values when running through audioproc_f than before.
This change was originally uploaded here:
* https://codereview.webrtc.org/1181933002/
* https://codereview.webrtc.org/1177043017/
And reverted because of an ASAN problem in Chrome here:
* https://codereview.webrtc.org/1192863006/
* https://codereview.webrtc.org/1194963003/
TBR=andrew@webrtc.org
Review URL: https://codereview.webrtc.org/1211563003
Cr-Commit-Position: refs/heads/master@{#9502}
2015-06-25 01:46:03 +00:00
ac4234ccfc
Add a [rtc_]build_with_neon variable to unify conditions.
...
Also consolidate ARM options for gn in an arm_neon_config.
R=jridges@masque.com , kjellander@webrtc.org , zhongwei.yao@chromium.org
Review URL: https://codereview.webrtc.org/1181373004 .
Cr-Commit-Position: refs/heads/master@{#9501}
2015-06-25 01:25:59 +00:00
1c7075f076
Ensure transient suppression is never enabled on mobile.
...
Review URL: https://codereview.webrtc.org/1209653002
Cr-Commit-Position: refs/heads/master@{#9500}
2015-06-25 01:14:17 +00:00
8d3e489d01
Update deeper codereview.settings files to match the root.
...
R=kjellander@webrtc.org
Review URL: https://codereview.webrtc.org/1190883002 .
Cr-Commit-Position: refs/heads/master@{#9498}
2015-06-24 19:40:39 +00:00
1b12cb0ef7
Enabling AudioDeviceTest.StartStopPlayout on Nexus 9
...
BUG=webrtc:4682
Review URL: https://codereview.webrtc.org/1206733003
Cr-Commit-Position: refs/heads/master@{#9497}
2015-06-24 11:27:35 +00:00
2c4c914819
In screenshare mode, suppress VP8 bitrate overshoot and increase quality
...
This change includes several improvements:
* VP8 configured with new rate control
* Detection of frame dropping, with qp bump for next frame
* Increased target and TL0 bitrates
* Reworked rate control (TL allocation) in screenshare_layers
A note on performance: PSNR and SSIM is expected to get slightly worse with this cl. Frame drops and delays should however improve.
BUG=4171
R=pbos@webrtc.org , stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1193513006 .
Cr-Commit-Position: refs/heads/master@{#9495}
2015-06-24 09:24:50 +00:00
084f3871b1
Reland mysterious cast that improves performance.
...
BUG=499241
TEST=none
TBR=andrew
Review URL: https://codereview.webrtc.org/1206683002
Cr-Commit-Position: refs/heads/master@{#9492}
2015-06-23 22:04:37 +00:00
6bfc82aaf1
Test whether removing a cast still hurts performance.
...
BUG=499241
TEST=none
TBR=andrew
Review URL: https://codereview.webrtc.org/1206653002
Cr-Commit-Position: refs/heads/master@{#9491}
2015-06-23 21:38:42 +00:00
747d5f6268
Reland "Added ACM_dump protobuf, class for reading/writing and...", commit e9bdfd859c309991b4ea759587f39eecdbd42bd4.
...
Changed the BUILD.gn file that was lacking some necessary items which caused Chromium to break.
Original review: https://webrtc-codereview.appspot.com/52059005/
The revert of the original CL was commit 7a75415419cbd52d798f9226010e9190e1cbad53.
BUG=webrtc:4741
R=henrik.lundin@webrtc.org
Review URL: https://codereview.webrtc.org/1200833002 .
Cr-Commit-Position: refs/heads/master@{#9489}
2015-06-23 08:08:17 +00:00
97c9f8d198
Remove iostream which causes a new static initializer
...
TBR=pthatcher@webrtc.org
BUG=webrtc:4576
Review URL: https://codereview.webrtc.org/1205553002 .
Cr-Commit-Position: refs/heads/master@{#9488}
2015-06-23 04:54:22 +00:00
72cfd6c468
Reland remaining bits of "Upconvert various types to int."
...
Most of commit cb180976dd0e9672cde4523d87b5f4857478b5e9 (which reverted
commit 83ad33a8aed1fb00e422b6abd33c3e8942821c24) was already re-landed. This relands the rest, including modifications by kwiberg to hopefully avoid regressing performance.
In a subsequent change I will see if removing the int16_t cast in this modified version still causes perf problems.
BUG=499241
TEST=none
TBR=andrew
Review URL: https://codereview.webrtc.org/1181693005
Cr-Commit-Position: refs/heads/master@{#9487}
2015-06-23 02:33:55 +00:00
db4fecfb01
Attempt to reland: Allow intelligibility to compile in apm ( https://codereview.webrtc.org/1182323005/ )
...
Revert of original: https://codereview.webrtc.org/1187033005/
Changes in original:
- Added files to gyp and BUILD
- Made minor fixes to get everything to compile
and intelligibility_proc to run
- Added comments
- Auto-reformatting
New Changes:
- Added <numeric> header to intelligibility_enhancer.cc to address buildbot errors
- Switched to use WAV for i/o in intelligibility_proc.cc to address windows errors
- clean up
Note: Patch 1 duplicates Patch 7 of https://codereview.webrtc.org/1182323005/
R=andrew@webrtc.org
Review URL: https://codereview.webrtc.org/1190733004 .
Cr-Commit-Position: refs/heads/master@{#9486}
2015-06-23 00:49:14 +00:00
6b4a564d21
Add UMA logging for target audio bitrate
...
This CL logs the target audio bitrate to a UMA histogram called
WebRTC.Audio.TargetBitrateInKbps. It logs the rate when a codec is
created, and when the target is explicitly updated. Note that since
each codec implementation is free to change or ignore the target
value, there is no guarantee that the logged value will actually be
used as the target.
BUG=chromium:488124
Review URL: https://codereview.webrtc.org/1178053002
Cr-Commit-Position: refs/heads/master@{#9484}
2015-06-22 13:35:22 +00:00
bdc0b0d869
Use RtcpPacket classes for SenderReport/ReceiveReport in RTCPSender
...
BUG=2450
R=asapersson@webrtc.org
Review URL: https://codereview.webrtc.org/1170723002 .
Cr-Commit-Position: refs/heads/master@{#9483}
2015-06-22 13:21:40 +00:00
9874ee0d7a
Add temporal-layers option to video_loopback.
...
BUG=
R=asapersson@webrtc.org , sprang@webrtc.org
Review URL: https://codereview.webrtc.org/1194533002
Cr-Commit-Position: refs/heads/master@{#9482}
2015-06-22 11:44:30 +00:00
ecb9a70c2d
Add AsyncInvoker files for chromium GN build
...
TBR=pthatcher@webrtc.org
BUG=4576
Review URL: https://codereview.webrtc.org/1196993003 .
Cr-Commit-Position: refs/heads/master@{#9481}
2015-06-22 06:37:09 +00:00
6a688f5265
Add default downscale threshold to QualityScaler.
...
Prevents downscaling below 160x90 or 90x160 to gain more quality.
BUG=4625
R=mflodman@webrtc.org
Review URL: https://codereview.webrtc.org/1160403004 .
Cr-Commit-Position: refs/heads/master@{#9480}
2015-06-22 06:03:07 +00:00
2ee2439a1f
Merge video_engine_core into webrtc target.
...
Merges the two video targets since video_engine is no longer usable
standalone.
BUG=webrtc:1695
R=mflodman@webrtc.org , stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1184763009 .
Cr-Commit-Position: refs/heads/master@{#9479}
2015-06-22 05:57:26 +00:00
e8d191f00f
Restore rows() and cols() in aligned_array.h
...
These getters were removed in https://codereview.webrtc.org/1172163004
but are used in external code, so it makes sense to keep
them around to make the class more useful.
R=henrikg@webrtc.org , pkasting@chromium.org
Review URL: https://codereview.webrtc.org/1178043005 .
Cr-Commit-Position: refs/heads/master@{#9478}
2015-06-20 18:11:02 +00:00
7a75415419
Revert "Added ACM_dump protobuf, class for reading/writing and unittest."
...
This reverts commit e9bdfd859c309991b4ea759587f39eecdbd42bd4.
This CL makes the GN chrome bot fail, not really sure why...
FAILED: /mnt/data/b/build/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/third_party/webrtc/modules/audio_coding/main/acm2/acm_dump.acm_dump.o.d
-DRTC_AUDIOCODING_DEBUG_DUMP -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2
-DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1
-DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1
-DENABLE_SPELLCHECK=1 -DDONT_EMBED_BUILD_METADATA -DUSE_UDEV
-DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_PANGO=1
-DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1
-DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DENABLE_WEBRTC=1
-DENABLE_EXTENSIONS=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_TASK_MANAGER=1
-DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1
-DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1
-DENABLE_SERVICE_DISCOVERY=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_REMOTING=1
-DENABLE_GOOGLE_NOW=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_HIDPI=1
-DV8_USE_EXTERNAL_STARTUP_DATA -DENABLE_BACKGROUND=1 -DENABLE_PRE_SYNC_BACKUP
-DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL
-DSAFE_BROWSING_SERVICE -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1
-DCR_CLANG_REVISION=239765-1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
-D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG
-DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGOOGLE_PROTOBUF_NO_RTTI
-DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -I../.. -Igen
-I../../third_party/protobuf/src -Igen/protoc_out
-I../../third_party/protobuf/src -I../../third_party/protobuf
-fno-strict-aliasing -fstack-protector --param=ssp-buffer-size=4 -m64
-march=x86-64 -funwind-tables -fPIC -pipe -pthread
-B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -Wall
-Wsign-compare -Wendif-labels -Werror -Wno-missing-field-initializers
-Wno-unused-parameter -Wno-c++11-narrowing -Wno-char-subscripts
-Wno-covered-switch-default -Wno-deprecated-register
-Wno-unneeded-internal-declaration -Wno-reserved-user-defined-literal
-Wno-inconsistent-missing-override -fvisibility=hidden -Xclang -load -Xclang
../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang
-plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -add-plugin
-Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -O2 -fno-ident
-fdata-sections -ffunction-sections -g1 -gsplit-dwarf -fno-threadsafe-statics
-fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -c
../../third_party/webrtc/modules/audio_coding/main/acm2/acm_dump.cc -o
obj/third_party/webrtc/modules/audio_coding/main/acm2/acm_dump.acm_dump.o
../../third_party/webrtc/modules/audio_coding/main/acm2/acm_dump.cc:11:10: fatal
error: 'webrtc/modules/audio_coding/main/acm2/acm_dump.h' file not found
#include "webrtc/modules/audio_coding/main/acm2/acm_dump.h"
^
1 error generated.
ninja: build stopped: subcommand failed.
TBR=ivoc@webrtc.org
BUG=
Review URL: https://codereview.webrtc.org/1195963002 .
Cr-Commit-Position: refs/heads/master@{#9474}
2015-06-19 21:30:27 +00:00
7f04b08d3b
Issue 4780: disabling multiple_routes breaks Turn/Tcp.
...
BUG=webrtc:4780
R=pthatcher@chromium.org
TBR=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1196453005 .
Cr-Commit-Position: refs/heads/master@{#9473}
2015-06-19 18:27:16 +00:00
f260fc2136
Revert "Pull the Voice Activity Detector out from the AGC"
...
This reverts commit 34be126c1b3ee60ecdb86b1de41a0648347450b2.
It breaks Chromium ASAN.
TBR=niklas.enbom@webrtc.org
Review URL: https://codereview.webrtc.org/1192863006 .
Cr-Commit-Position: refs/heads/master@{#9472}
2015-06-19 18:24:01 +00:00
f5f8f52a4b
Revert "Increase the kMaxNoiseProbability in voice_activity_detector_test"
...
This reverts commit c9b0f675687d318b9367b1d6764182b9411355de.
It breaks Chromium ASAN.
TBR=niklas.enbom@webrtc.org
BUG=
Review URL: https://codereview.webrtc.org/1194963003 .
Cr-Commit-Position: refs/heads/master@{#9471}
2015-06-19 18:18:02 +00:00
d4cec15c75
Resolved Rebase Conflicts
...
This is just https://webrtc-codereview.appspot.com/53629004/
Remove a constructor of VCMJitterBuffer.
Remove unnecessary factory use
Comment Fix
Move frame incoming simulation to the clock
DCHECK typo fix
Coding Style Fix
Rephrased some comments, and removed some virtual for override function.
Coding Style Fix
Coding Style Fix
Add a unittest for VCMReceiver::FrameForDecoding. Mainly test the time control algorithm.
BUG=
TBR=holmer@chromium.org
Review URL: https://codereview.webrtc.org/1173253008 .
Cr-Commit-Position: refs/heads/master@{#9470}
2015-06-19 16:17:10 +00:00
76eea37ed0
Workaround a (Windows) linker bug when doing a PGO build.
...
It looks like having a function that ends with "FATAL()" but doesn't also have a return value (even if it's useless).
This is causing a hang in link.exe when doing a PGO build (this has been blocking us from doing PGO builds for more than a month now). See https://connect.microsoft.com/VisualStudio/feedback/details/996802/link-exe-hang-during-the-pgo-optimization-step for more details.
BUG=chromium:491914
R=turaj@webrtc.org
Review URL: https://codereview.webrtc.org/1181033009 .
Cr-Commit-Position: refs/heads/master@{#9469}
2015-06-19 16:11:10 +00:00
c9b0f67568
Increase the kMaxNoiseProbability in voice_activity_detector_test
...
Because it breaks on Android.
TBR=ajm
Review URL: https://codereview.webrtc.org/1177043017 .
Cr-Commit-Position: refs/heads/master@{#9467}
2015-06-18 21:48:09 +00:00
dc13abc331
Initially when the design was to do this experiment in browser, which doesn't have webrtc code, it requires some glue code to bridge the difference between what's available in webrtc::base and browser process. Now since we're moving to renderer process, we could reuse a lot of existing interfaces instead of rolling our own.
...
BUG=webrtc:4576
R=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1173353002 .
Cr-Commit-Position: refs/heads/master@{#9466}
2015-06-18 21:44:46 +00:00
34be126c1b
Pull the Voice Activity Detector out from the AGC
...
This change generates bit-exact values when running through audioproc_f than before.
R=andrew@webrtc.org , bloch@google.com
Review URL: https://codereview.webrtc.org/1181933002 .
Cr-Commit-Position: refs/heads/master@{#9465}
2015-06-18 19:34:00 +00:00
