e62c2f2c77
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf
...
rename WebRtcKeyValueConfig to FieldTrialsView
Bug: webrtc:10335
Change-Id: If725bd498c4c3daf144bee638230fa089fdde833
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256965
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Jonas Oreland <jonaso@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36365}
2022-03-29 10:14:00 +00:00
b663cfaae4
Cleanup RtpPacketHistory from unused features
...
history no longer used for storing unsent packets and for legacy pacer.
Bug: None
Change-Id: I639c37de66857a64c620e80df6288fa6ce8326d4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253260
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36120}
2022-03-03 14:30:27 +00:00
9af4aa7cf4
Reland "Represent RtpPacketToSend::capture_time with Timestamp"
...
This reverts commit 56db8d09529d5ba92d24954a1d78a90c8ea2cd85.
Reason for revert: downstream problem addressed
Original change's description:
> Revert "Represent RtpPacketToSend::capture_time with Timestamp"
>
> This reverts commit 385eb9714daa80306d2f92d36678c42892dab555.
>
> Reason for revert: Causes problems downstream:
>
> #
> # Fatal error in: rtc_base/units/unit_base.h, line 122
> # last system error: 0
> # Check failed: value >= 0 (-234 vs. 0)
>
> Original change's description:
> > Represent RtpPacketToSend::capture_time with Timestamp
> >
> > Bug: webrtc:13757
> > Change-Id: I0ede22cd34e3a59afe1477d8edd495dce64e3242
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252586
> > Reviewed-by: Erik Språng <sprang@webrtc.org >
> > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
> > Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
> > Cr-Commit-Position: refs/heads/main@{#36083}
>
> Bug: webrtc:13757
> Change-Id: I8442abd438be8726cf671d0f372d50ecfac6847e
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252720
> Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org >
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
> Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#36087}
Bug: webrtc:13757
Change-Id: I1fa852757480116f35deb2b6c3c27800bdf5e197
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252781
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36093}
2022-02-28 10:04:37 +00:00
56db8d0952
Revert "Represent RtpPacketToSend::capture_time with Timestamp"
...
This reverts commit 385eb9714daa80306d2f92d36678c42892dab555.
Reason for revert: Causes problems downstream:
#
# Fatal error in: rtc_base/units/unit_base.h, line 122
# last system error: 0
# Check failed: value >= 0 (-234 vs. 0)
Original change's description:
> Represent RtpPacketToSend::capture_time with Timestamp
>
> Bug: webrtc:13757
> Change-Id: I0ede22cd34e3a59afe1477d8edd495dce64e3242
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252586
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#36083}
Bug: webrtc:13757
Change-Id: I8442abd438be8726cf671d0f372d50ecfac6847e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252720
Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org >
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36087}
2022-02-26 10:35:13 +00:00
385eb9714d
Represent RtpPacketToSend::capture_time with Timestamp
...
Bug: webrtc:13757
Change-Id: I0ede22cd34e3a59afe1477d8edd495dce64e3242
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252586
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36083}
2022-02-25 16:44:07 +00:00
d0321c5e5a
Deduplicate set of the rtp header extension uri constants
...
Bug: webrtc:7472
Change-Id: Ic0b4f2cc3374ba70a043310b5046d8bf91f0acbe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231949
Reviewed-by: Tommi <tommi@webrtc.org >
Commit-Queue: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#34990}
2021-09-14 13:38:44 +00:00
ac09f0dc92
Remove last traces of deferred sequencing.
...
Bug: webrtc:11340
Change-Id: I761be67d42959192355f9f6f54ed1f735da1fe96
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228646
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Per Åhgren <peah@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34770}
2021-08-16 12:44:37 +00:00
6a0a55907b
Reland "Correctly handle retransmissions/padding in early loss detection."
...
This is a reland of e9ae4729e03f60dbe3b1828dd9009b401097cd3f
TBR=philipel@webrtc.org ,terelius@webrtc.org
Original change's description:
> Correctly handle retransmissions/padding in early loss detection.
>
> This CL makes sure we don't cull packets from the history based on
> incorrect ack mapping, just like it's predecessor:
> https://webrtc-review.googlesource.com/c/src/+/218000
>
> It also changes the logic to make sure retransmits counts towards
> history pruning - and properly ignores padding/fec.
>
> Bug: webrtc:12713
> Change-Id: I7835d10e483687e960a9cce41d4e2f1a6c3189b4
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/221863
> Reviewed-by: Björn Terelius <terelius@webrtc.org >
> Reviewed-by: Philip Eliasson <philipel@webrtc.org >
> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
> Commit-Queue: Erik Språng <sprang@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#34293}
Bug: webrtc:12713
Change-Id: Iec123d71edafea98fe289acde007b57e212681f4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/222640
Commit-Queue: Erik Språng <sprang@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34297}
2021-06-16 08:14:27 +00:00
d6957c2eed
Revert "Correctly handle retransmissions/padding in early loss detection."
...
This reverts commit e9ae4729e03f60dbe3b1828dd9009b401097cd3f.
Reason for revert: Internal test failure
Original change's description:
> Correctly handle retransmissions/padding in early loss detection.
>
> This CL makes sure we don't cull packets from the history based on
> incorrect ack mapping, just like it's predecessor:
> https://webrtc-review.googlesource.com/c/src/+/218000
>
> It also changes the logic to make sure retransmits counts towards
> history pruning - and properly ignores padding/fec.
>
> Bug: webrtc:12713
> Change-Id: I7835d10e483687e960a9cce41d4e2f1a6c3189b4
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/221863
> Reviewed-by: Björn Terelius <terelius@webrtc.org >
> Reviewed-by: Philip Eliasson <philipel@webrtc.org >
> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
> Commit-Queue: Erik Språng <sprang@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#34293}
TBR=danilchap@webrtc.org ,terelius@webrtc.org ,sprang@webrtc.org ,philipel@webrtc.org ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
Change-Id: Iaca6dc7739d953e97add5f5d516139b4819e43ee
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:12713
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/222601
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34294}
2021-06-15 15:59:10 +00:00
e9ae4729e0
Correctly handle retransmissions/padding in early loss detection.
...
This CL makes sure we don't cull packets from the history based on
incorrect ack mapping, just like it's predecessor:
https://webrtc-review.googlesource.com/c/src/+/218000
It also changes the logic to make sure retransmits counts towards
history pruning - and properly ignores padding/fec.
Bug: webrtc:12713
Change-Id: I7835d10e483687e960a9cce41d4e2f1a6c3189b4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/221863
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34293}
2021-06-15 15:39:19 +00:00
943e2e6a57
Revert "Fix incorrect SSRC in RtpPacketSendInfo for RTX packets."
...
This reverts commit 82aa094a970a2c37634378910116bbe1d5abc633.
Reason for revert: Causes regression for an upstream project
Original change's description:
> Fix incorrect SSRC in RtpPacketSendInfo for RTX packets.
>
> Bug: webrtc:12713
> Change-Id: I1b5fb947ffe4ac80e23a6b891ea1a2c2156ba81f
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/218000
> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Commit-Queue: Erik Språng <sprang@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#34177}
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:12713
Change-Id: I20facf724bdb0136e7eb079c4834575184764174
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/221202
Reviewed-by: Andrey Logvin <landrey@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Andrey Logvin <landrey@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34218}
2021-06-03 11:59:39 +00:00
82aa094a97
Fix incorrect SSRC in RtpPacketSendInfo for RTX packets.
...
Bug: webrtc:12713
Change-Id: I1b5fb947ffe4ac80e23a6b891ea1a2c2156ba81f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/218000
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34177}
2021-05-31 20:51:07 +00:00
4fbc3fc59e
Move SendPacketUpdates* tests to rtp_sender_egress_unittest.
...
These should be the last of the testis from rtp_sender_unittest.cc that
should be moved and refactored to just test RtpSenderEgress.
Bug: webrtc:11340
Change-Id: Id09d7bbade608dd7194dcd8843d4f2887842a372
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/220140
Commit-Queue: Erik Språng <sprang@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34118}
2021-05-25 15:25:30 +00:00
552169c7db
Refactor RtpPacketCounter tests and move to rtp_sender_egress_unittest.
...
Bug: webrtc:11340
Change-Id: Ifdcb3d99113502fb5bebf1fc3ea5253a141d313b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219790
Commit-Queue: Erik Språng <sprang@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34115}
2021-05-25 12:55:45 +00:00
36005afeb4
Refactor and improve RtpSender packet history test.
...
This CL refactors RtpSenderTest.SendPacketHandlesRetransmissionHistory,
moves some testing to rtp_ender_egress_unittest and adds test coverage
for a few cases.
Bug: webrtc:11340
Change-Id: Ic225d2af43c3926f69fe3ea45f41b18c29b8b4fd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219796
Commit-Queue: Erik Språng <sprang@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34111}
2021-05-25 09:53:27 +00:00
e2b9fc6909
Move FecOverheadRate, BitrateCallbacks to rtp_sender_egress_unittest.
...
Bug: webrtc:11340
Change-Id: I33dcaea0146429de94d7610b46592b41e0c5549a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219685
Commit-Queue: Erik Språng <sprang@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34068}
2021-05-20 14:38:12 +00:00
4310375740
Move SendPacketObserver tests to rtp_sender_egress_unittest.
...
Bug: webrtc:11340
Change-Id: I865d52b3aa50e8500fc5ecb379538e53ca7ad250
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/218606
Commit-Queue: Erik Språng <sprang@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34020}
2021-05-17 13:23:04 +00:00
95aaf287bb
Refactors yet more rtp_sender_unitttests into rtp_sender_egress_unittest
...
Bug: webrtc:11340
Change-Id: I537c0efd5f0c4576fb43f193e4345618d59035ed
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/218604
Commit-Queue: Erik Språng <sprang@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34014}
2021-05-16 21:43:01 +00:00
bd09a46aa1
Move some tests out from rtp_sender_unittest.
...
Moves OnSendSideDelayUpdated and OnSendPacketUpdated out from
rtp_sender_unittest and into rtp_sender_egress_unittest and
rtp_rtcp_impl2_unittest. The former test now only tests the logic for
updating send-side-delay stats. The latter is now on a proper
RtpRtcp-level and also verifies that frame timestamps makes it to the
egress (as assumed by the first test).
Bug: webrtc:11340
Change-Id: I784042ad91eb66a4d1eebdbbc625f9522528bfb5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/218502
Commit-Queue: Erik Språng <sprang@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33996}
2021-05-12 14:01:29 +00:00
f2e581a740
Move PacketOptions-related tests to rtp_sender_egress_unittest.cc
...
Bug: webrtc:11340
Change-Id: I7fc405346e79c5308806d4c20fdb871a91dc59ff
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/217721
Commit-Queue: Erik Språng <sprang@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33948}
2021-05-07 12:56:22 +00:00
dec73a8164
Add pure RtpSenderEgress unit test fixture.
...
The extracts and refactors some test code from rtp_sender_unittest.cc
and puts it in a new target intended to only test RtpSenderEgress, and
do it as pure unit test, rather than the unholy
not-quite-unit-not-quite-integration-test thingy we have today.
Only a first test case is actually ported with this CL, but it's a
start...
Bug: webrtc:11340
Change-Id: Ie2cdde63a00a6ff6eba7b8d443eeb76ce2a527c9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/216180
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33841}
2021-04-27 10:11:40 +00:00
