036b3fdea2
Reland "stats: migrate to Timestamp"
...
This is a reland of commit 2235776597e2f47ec353ac911428eb9a54d64a10
Original change's description:
> stats: migrate to Timestamp
>
> BUG=webrtc:13756
>
> Change-Id: I04ba57f9c2ca5a974a406814023911b4eb2d6d38
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273942
> Commit-Queue: Philipp Hancke <phancke@microsoft.com >
> Reviewed-by: Henrik Boström <hbos@webrtc.org >
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#38365}
Bug: webrtc:13756
Change-Id: Ib8dc208197ae5e90f67114e7b043a73ee35421ea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/279080
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Philipp Hancke <phancke@microsoft.com >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38380}
2022-10-13 09:03:43 +00:00
c0794c23ff
Revert "stats: migrate to Timestamp"
...
This reverts commit 2235776597e2f47ec353ac911428eb9a54d64a10.
Reason for revert: Breaks compile.
RTCStatsReport::Create(timestamp) needs default value.
Original change's description:
> stats: migrate to Timestamp
>
> BUG=webrtc:13756
>
> Change-Id: I04ba57f9c2ca5a974a406814023911b4eb2d6d38
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273942
> Commit-Queue: Philipp Hancke <phancke@microsoft.com >
> Reviewed-by: Henrik Boström <hbos@webrtc.org >
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#38365}
Bug: webrtc:13756
Change-Id: I7eba2bb510af73be50397bd92f730bc6de1ce676
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/279044
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org >
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38369}
2022-10-12 14:23:40 +00:00
2235776597
stats: migrate to Timestamp
...
BUG=webrtc:13756
Change-Id: I04ba57f9c2ca5a974a406814023911b4eb2d6d38
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273942
Commit-Queue: Philipp Hancke <phancke@microsoft.com >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38365}
2022-10-12 11:43:39 +00:00
da6297dc53
[Stats] Avoid DCHECK crashing if SSRCs are not unique.
...
To properly handle SSRC collisions in non-BUNDLE we need to change how
RTP stats IDs are generated, but that is a riskier change to be dealt
with in a separate CL.
For now, we just make sure that crashing is not a possibility during
SSRC collisions as a mitigation for https://crbug.com/1361612 . This is
achieved by adding a TryAddStats() method to RTCStatsReport returning
whether successful.
Bug: chromium:1361612
Change-Id: I8577ae4c84a7c1eb3c7527e9efd8d1b0254269a3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/275766
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38197}
2022-09-26 10:28:01 +00:00
86ee89f73e
Simplify reference counting implementation of PendingTaskSafetyFlag.
...
On a 32bit system, this reduces the allocation size of the flag
down from 12 bytes to 8, and removes the need for a vtable (the extra
4 bytes are the vtable pointer).
The downside is that this change makes the binary layout of the
flag, less compatible with RefCountedObject<> based reference counting
objects and thus we don't immediately get the benefits of identical
COMDAT folding and subsequently there's a slight binary size increase.
With wider use, the binary size benefits will come.
Bug: none
Change-Id: I04129771790a3258d6accaf0ab1258b7a798a55e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215681
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33793}
2021-04-21 07:04:01 +00:00
cdebea0f48
stats: s/victim/other
...
BUG=webrtc:11680
Change-Id: I3bcfdd71647ccf923a19777059dc48ec93581143
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/187358
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com >
Cr-Commit-Position: refs/heads/master@{#32370}
2020-10-09 15:40:13 +00:00
6c70e16a4a
Fix RTCStatsReport::ConstIterator move constructor.
...
This problem has been originally discovered by clang-tidy while trying
to apply performance-move-const-arg [1] on [2].
[1] - https://clang.llvm.org/extra/clang-tidy/checks/performance-move-const-arg.html
[2] - https://webrtc-review.googlesource.com/c/src/+/120350
Bug: webrtc:10252
Change-Id: I2b0a116f78ca8096a6cf2bc23e2f4b8f372ca04f
Reviewed-on: https://webrtc-review.googlesource.com/c/120815
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26512}
2019-02-01 14:12:43 +00:00
10542f21c8
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries
...
Mechanically generated by running this command:
tools_webrtc/do-renames.sh update all-renames.txt && git cl format
Then manually updating:
tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc
Bug: webrtc:10159
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I54824cd91dada8fc3ee3d098f971bc319d477833
Reviewed-on: https://webrtc-review.googlesource.com/c/115653
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26226}
2019-01-11 17:11:39 +00:00
1c05765831
(3) Rename files to snake_case: move the files
...
Mechanically generated with this command:
tools_webrtc/do-rename.sh move all-renames.txt
Bug: webrtc:10159
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I8b05b6eab9b9d18b29c2199bbea239e9add1e690
Reviewed-on: https://webrtc-review.googlesource.com/c/115481
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26225}
2019-01-11 17:05:20 +00:00
