acd935b540
Reland of Delete all use of cricket::VideoFrame and cricket::WebRtcVideoFrame. (patchset #1 id:1 of https://codereview.webrtc.org/2471783002/ )
...
Reason for revert:
Relanding after known downstream breakages have been fixed.
Original issue's description:
> Revert of Delete all use of cricket::VideoFrame and cricket::WebRtcVideoFrame. (patchset #7 id:120001 of https://codereview.webrtc.org/2383093002/ )
>
> Reason for revert:
> Breaks chrome, see https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/19019/steps/compile/logs/stdio
>
> Analysis: Chrome uses cricket::VideoFrame, without explicitly including webrtc/media/base/videoframe.h, and breaks when that file is no longer included by any other webrtc headers. Will reland after updating Chrome.
>
> Original issue's description:
> > Delete all use of cricket::VideoFrame and cricket::WebRtcVideoFrame.
> >
> > Replaced with webrtc::VideoFrame.
> >
> > TBR=mflodman@webrtc.org
> > BUG=webrtc:5682
> >
> > Committed: https://crrev.com/45c8b8940042bd2574c39920804ade8343cefdba
> > Cr-Commit-Position: refs/heads/master@{#14885}
>
> TBR=perkj@webrtc.org ,pthatcher@webrtc.org ,tkchin@webrtc.org ,mflodman@webrtc.org ,stefan@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:5682
>
> Committed: https://crrev.com/7341ab8e2505c9763d208e069bda269018357e7d
> Cr-Commit-Position: refs/heads/master@{#14886}
TBR=perkj@webrtc.org ,pthatcher@webrtc.org ,tkchin@webrtc.org ,mflodman@webrtc.org ,stefan@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:5682
Review-Url: https://codereview.webrtc.org/2487633002
Cr-Commit-Position: refs/heads/master@{#15039}
2016-11-11 11:55:19 +00:00
7341ab8e25
Revert of Delete all use of cricket::VideoFrame and cricket::WebRtcVideoFrame. (patchset #7 id:120001 of https://codereview.webrtc.org/2383093002/ )
...
Reason for revert:
Breaks chrome, see https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/19019/steps/compile/logs/stdio
Analysis: Chrome uses cricket::VideoFrame, without explicitly including webrtc/media/base/videoframe.h, and breaks when that file is no longer included by any other webrtc headers. Will reland after updating Chrome.
Original issue's description:
> Delete all use of cricket::VideoFrame and cricket::WebRtcVideoFrame.
>
> Replaced with webrtc::VideoFrame.
>
> TBR=mflodman@webrtc.org
> BUG=webrtc:5682
>
> Committed: https://crrev.com/45c8b8940042bd2574c39920804ade8343cefdba
> Cr-Commit-Position: refs/heads/master@{#14885}
TBR=perkj@webrtc.org ,pthatcher@webrtc.org ,tkchin@webrtc.org ,mflodman@webrtc.org ,stefan@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5682
Review-Url: https://codereview.webrtc.org/2471783002
Cr-Commit-Position: refs/heads/master@{#14886}
2016-11-02 10:40:05 +00:00
45c8b89400
Delete all use of cricket::VideoFrame and cricket::WebRtcVideoFrame.
...
Replaced with webrtc::VideoFrame.
TBR=mflodman@webrtc.org
BUG=webrtc:5682
Review-Url: https://codereview.webrtc.org/2383093002
Cr-Commit-Position: refs/heads/master@{#14885}
2016-11-02 10:20:28 +00:00
859e86107d
Remove stop method from VideoTrackSourceInterface.
...
This method is no longer needed.
Follow-up on CL: https://codereview.webrtc.org/2306013002/
Review-Url: https://codereview.webrtc.org/2312603003
Cr-Commit-Position: refs/heads/master@{#14085}
2016-09-06 09:25:11 +00:00
a973f95386
Remove restart method from VideoTrackSourceInterface.
...
This method is no longer needed.
Review-Url: https://codereview.webrtc.org/2306013002
Cr-Commit-Position: refs/heads/master@{#14060}
2016-09-03 17:29:11 +00:00
72c8d2b708
Rename BEGIN_PROXY_MAP --> BEGIN_SIGNALLING_PROXY_MAP.
...
And BEGIN_WORKER_PROXY_MAP --> BEGIN_PROXY_MAP.
This rename was suggested by Tommi, with the idea that a proxy
invoking methods on the worker thread should be the common case.
It's a followup to https://codereview.webrtc.org/1861633002/
This cl also adds unittests for proxy calls to the
worker thread.
BUG=webrtc:5426
Review URL: https://codereview.webrtc.org/1871833002
Cr-Commit-Position: refs/heads/master@{#12374}
2016-04-15 10:49:13 +00:00
2ded9b19d1
Replace SetCapturer and SetCaptureDevice by SetSource.
...
Drop return value.
BUG=webrtc:5426
Review URL: https://codereview.webrtc.org/1766653002
Cr-Commit-Position: refs/heads/master@{#12291}
2016-04-08 09:24:01 +00:00
5b68ab50bb
Extended proxy abstraction, to call certain methods to the worker thread.
...
Extracted from cl https://codereview.webrtc.org/1766653002/ , where
AddOrUpdateSink results in a deadlock.
BUG=webrtc:5426
Review URL: https://codereview.webrtc.org/1861633002
Cr-Commit-Position: refs/heads/master@{#12281}
2016-04-07 14:46:00 +00:00
fcc640f8f6
Get VideoCapturer stats via VideoTrackSourceInterface in StatsCollector,
...
without involving the VideoMediaChannel.
BUG=webrtc:5426
Review URL: https://codereview.webrtc.org/1827023002
Cr-Commit-Position: refs/heads/master@{#12193}
2016-04-01 08:10:50 +00:00
c0d31e915c
Change VideoSourceInterface::needs_denoising() to return rtc::Optional<bool>
...
It turns out that it is used as if it has three states: on/off default.
This reverts back to the behaviour prior to https://codereview.webrtc.org/1773993002
BUG=chromium:594434
R=pbos@webrtc.org , pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1842073002 .
Cr-Commit-Position: refs/heads/master@{#12181}
2016-03-31 15:23:53 +00:00
9e083d2ac5
Reland of Delete empty API files and cleaned up includes. (patchset #1 id:1 of https://codereview.webrtc.org/1813083002/ )
...
Reason for revert:
New attempt. Cl for removing videosourceinterface.h dep in chrome is landed here: https://codereview.chromium.org/1810273003/
Original issue's description:
> Revert of Delete empty API files and cleaned up includes. (patchset #2 id:20001 of https://codereview.webrtc.org/1809053002/ )
>
> Reason for revert:
> Breaks Chromium build. Need to remove the references to the obsolete header files from Chromium and reland.
>
> Original issue's description:
> > Delete empty API files and cleaned up includes.
> >
> > TBR=glaznev@webrtc.org
> >
> > BUG=webrtc:5426
> >
> > Committed: https://crrev.com/c9022f508644dc33c01b05cb22ebfc2be145d6b2
> > Cr-Commit-Position: refs/heads/master@{#12039}
>
> TBR=nisse@webrtc.org ,glaznev@webrtc.org ,perkj@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:5426
>
> Committed: https://crrev.com/246b5273986d5a5b140b3d1a656baa8d40c36276
> Cr-Commit-Position: refs/heads/master@{#12042}
TBR=nisse@webrtc.org ,glaznev@webrtc.org ,deadbeef@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:5426
Review URL: https://codereview.webrtc.org/1819733002
Cr-Commit-Position: refs/heads/master@{#12065}
2016-03-20 16:38:44 +00:00
246b527398
Revert of Delete empty API files and cleaned up includes. (patchset #2 id:20001 of https://codereview.webrtc.org/1809053002/ )
...
Reason for revert:
Breaks Chromium build. Need to remove the references to the obsolete header files from Chromium and reland.
Original issue's description:
> Delete empty API files and cleaned up includes.
>
> TBR=glaznev@webrtc.org
>
> BUG=webrtc:5426
>
> Committed: https://crrev.com/c9022f508644dc33c01b05cb22ebfc2be145d6b2
> Cr-Commit-Position: refs/heads/master@{#12039}
TBR=nisse@webrtc.org ,glaznev@webrtc.org ,perkj@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5426
Review URL: https://codereview.webrtc.org/1813083002
Cr-Commit-Position: refs/heads/master@{#12042}
2016-03-17 22:03:46 +00:00
c9022f5086
Delete empty API files and cleaned up includes.
...
TBR=glaznev@webrtc.org
BUG=webrtc:5426
Review URL: https://codereview.webrtc.org/1809053002
Cr-Commit-Position: refs/heads/master@{#12039}
2016-03-17 16:57:30 +00:00
0d3eef2080
Add implementation of VideoTrackSource and make VideoCapturerTrackSource inherit from it.
...
BUG=webrtc:5426
R=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1773993002 .
Cr-Commit-Position: refs/heads/master@{#11923}
2016-03-09 01:39:33 +00:00
a3ede6c510
Renamed VideoSourceInterface to VideoTrackSourceInterface.
...
Moved VideoSourceInterface to MediaStreamInterface.h
Renamed VideoSourceTest to VideoCapturerTrackSourceTest
Renamed VideoSource to VideoCaptureTrackSource and cl lint and cl format.
BUG=webrtc:5426
TBR=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1770003002 .
Cr-Commit-Position: refs/heads/master@{#11893}
2016-03-08 00:28:03 +00:00
f2880a0e04
Change webrtc::VideoSourceInterface to inherit rtc::VideoSourceInterface.
...
Also introduce a typedef VideoTrackSourceInterface to be able to start changing clients such as Chrome to use the name VideoTrackSourceInterface.
Document: https://docs.google.com/a/google.com/document/d/1mEIw_0uDzyHjL3l8a82WKp6AvgR8Tlwn9JGvhbUjVpY/edit?usp=sharing
BUG=webrtc:5426
Review URL: https://codereview.webrtc.org/1758223002
Cr-Commit-Position: refs/heads/master@{#11854}
2016-03-03 09:51:56 +00:00
b24317bfda
Fix license headers in webrtc/api.
...
In addition to the code moved from talk/app/webrtc
there were some files in webrtc/api/objctests that still
had the libjingle license header.
BUG=webrtc:5418
TBR=tkchin@webrtc.org
NOTRY=True
Review URL: https://codereview.webrtc.org/1680293005
Cr-Commit-Position: refs/heads/master@{#11552}
2016-02-10 15:54:53 +00:00
15583c19d7
Move talk/app/webrtc to webrtc/api
...
The previously disabled warnings that were inherited from
talk/build/common.gypi are now replaced by target-specific disabling
of only the failing warnings. Additional disabling was needed since the stricter
compilation warnings that applies to code in webrtc/.
License headers will be updated in a follow-up CL.
Other modifications:
* Updated the header guards.
* Sorted the includes using chromium/src/tools/sort-headers.py
except for these files:
talk/app/webrtc/peerconnectionendtoend_unittest.cc
talk/app/webrtc/java/jni/androidmediadecoder_jni.cc
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc
webrtc/media/devices/win32devicemanager.cc
The HAVE_SCTP define was added for the peerconnection_unittests target
in api_tests.gyp.
I also checked that none of
SRTP_RELATIVE_PATH
HAVE_SRTP
HAVE_WEBRTC_VIDEO
HAVE_WEBRTC_VOICE
were used by the talk/app/webrtc code.
For Chromium, the following changes will need to be applied to the roll CL that updates the
DEPS for WebRTC and libjingle:
https://codereview.chromium.org/1615433002
BUG=webrtc:5418
NOPRESUBMIT=True
R=deadbeef@webrtc.org , pthatcher@webrtc.org , tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1610243002 .
Cr-Commit-Position: refs/heads/master@{#11545}
2016-02-10 09:53:26 +00:00