2bdcfadc8a
Revert of Removing webrtc::AudioFrame::energy_. (patchset #2 id:20001 of https://codereview.webrtc.org/1589953002/ )
...
Reason for revert:
The change breaks google3 tests for buzz/mediaengines/sae/audio_mixer.
Original issue's description:
> Remove webrtc::AudioFrame::energy_.
>
> BUG=webrtc:3315
>
> Committed: https://crrev.com/bacae81a1d91ae7b2a4bde37a66ab70513449989
> Cr-Commit-Position: refs/heads/master@{#11372}
TBR=kjellander@webrtc.org ,henrik.lundin@webrtc.org ,tommi@webrtc.org ,minyue@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:3315
Review URL: https://codereview.webrtc.org/1634143002
Cr-Commit-Position: refs/heads/master@{#11377}
2016-01-26 10:29:54 +00:00
bacae81a1d
Remove webrtc::AudioFrame::energy_.
...
BUG=webrtc:3315
Review URL: https://codereview.webrtc.org/1589953002
Cr-Commit-Position: refs/heads/master@{#11372}
2016-01-25 22:10:40 +00:00
6955870806
Convert channel counts to size_t.
...
IIRC, this was originally requested by ajm during review of the other size_t conversions I did over the past year, and I agreed it made sense, but wanted to do it separately since those changes were already gargantuan.
BUG=chromium:81439
TEST=none
R=henrik.lundin@webrtc.org , henrika@webrtc.org , kjellander@webrtc.org , minyue@webrtc.org , perkj@webrtc.org , solenberg@webrtc.org , stefan@webrtc.org , tina.legrand@webrtc.org
Review URL: https://codereview.webrtc.org/1316523002 .
Cr-Commit-Position: refs/heads/master@{#11229}
2016-01-13 00:26:55 +00:00
cfc319be1d
Reland of Work on flexible mode and screen sharing. (patchset #1 id:1 of https://codereview.webrtc.org/1438543002/ )
...
Reason for revert:
Failed test not related to this CL (test fails on
master at an earlier date), re-landing original CL..
(This time from my @webrtc account.)
Original issue's description:
> Revert of Work on flexible mode and screen sharing. (patchset #28 id:520001 of https://codereview.webrtc.org/1328113004/ )
>
> Reason for revert:
> Seems to break VideoSendStreamTest.ReconfigureBitratesSetsEncoderBitratesCorrectly on Linux Memcheck buildbot.
>
> Original issue's description:
> > Work on flexible mode and screen sharing.
> >
> > Implement VP8 style screensharing but with spatial layers.
> > Implement flexible mode.
> >
> > Files from other patches:
> > generic_encoder.cc
> > layer_filtering_transport.cc
> >
> > BUG=webrtc:4914
> >
> > Committed: https://crrev.com/77ccfb4d16c148e61a316746bb5d9705e8b39f4a
> > Cr-Commit-Position: refs/heads/master@{#10572}
>
> TBR=sprang@webrtc.org ,stefan@webrtc.org ,philipel@google.com ,asapersson@webrtc.org ,mflodman@webrtc.org ,philipel@webrtc.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:4914
>
> Committed: https://crrev.com/0be8f1d347bdb171462df89c2a4c69b3f3eb7519
> Cr-Commit-Position: refs/heads/master@{#10578}
TBR=sprang@webrtc.org ,stefan@webrtc.org ,philipel@google.com ,asapersson@webrtc.org ,mflodman@webrtc.org ,terelius@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4914
Review URL: https://codereview.webrtc.org/1431283002
Cr-Commit-Position: refs/heads/master@{#10581}
2015-11-10 15:17:26 +00:00
0be8f1d347
Revert of Work on flexible mode and screen sharing. (patchset #28 id:520001 of https://codereview.webrtc.org/1328113004/ )
...
Reason for revert:
Seems to break VideoSendStreamTest.ReconfigureBitratesSetsEncoderBitratesCorrectly on Linux Memcheck buildbot.
Original issue's description:
> Work on flexible mode and screen sharing.
>
> Implement VP8 style screensharing but with spatial layers.
> Implement flexible mode.
>
> Files from other patches:
> generic_encoder.cc
> layer_filtering_transport.cc
>
> BUG=webrtc:4914
>
> Committed: https://crrev.com/77ccfb4d16c148e61a316746bb5d9705e8b39f4a
> Cr-Commit-Position: refs/heads/master@{#10572}
TBR=sprang@webrtc.org ,stefan@webrtc.org ,philipel@google.com ,asapersson@webrtc.org ,mflodman@webrtc.org ,philipel@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4914
Review URL: https://codereview.webrtc.org/1438543002
Cr-Commit-Position: refs/heads/master@{#10578}
2015-11-10 13:31:22 +00:00
77ccfb4d16
Work on flexible mode and screen sharing.
...
Implement VP8 style screensharing but with spatial layers.
Implement flexible mode.
Files from other patches:
generic_encoder.cc
layer_filtering_transport.cc
BUG=webrtc:4914
Review URL: https://codereview.webrtc.org/1328113004
Cr-Commit-Position: refs/heads/master@{#10572}
2015-11-10 10:19:20 +00:00
c253a1c00e
Reland of "Change type of pid_diff (int16_t -> uint8_t) according to updates in RTP payload profile."
...
BUG=webrtc:5144
TBR=mflodman@webrtc.org
Review URL: https://codereview.webrtc.org/1409753007
Cr-Commit-Position: refs/heads/master@{#10533}
2015-11-06 08:12:09 +00:00
ff761fba82
modules: more interface -> include renames
...
This changes the following module directories:
* webrtc/modules/audio_conference_mixer/interface
* webrtc/modules/interface
* webrtc/modules/media_file/interface
* webrtc/modules/rtp_rtcp/interface
* webrtc/modules/utility/interface
To avoid breaking downstream, I followed this recipe:
1. Copy the interface dir to a new sibling directory: include
2. Update the header guards in the include directory to match the style guide.
3. Update the header guards in the interface directory to match the ones in include. This is required to avoid getting redefinitions in the not-yet-updated downstream code.
4. Add a pragma warning in the header files in the interface dir. Example:
#pragma message("WARNING: webrtc/modules/interface is DEPRECATED; "
"use webrtc/modules/include")
5. Search for all source references to webrtc/modules/interface and update them to webrtc/modules/include (*.c*,*.h,*.mm,*.S)
6. Update all GYP+GN files. This required manual inspection since many subdirectories of webrtc/modules referenced the interface dir using ../interface etc(*.gyp*,*.gn*)
BUG=5095
TESTED=Passing compile-trybots with --clobber flag:
git cl try --clobber --bot=win_compile_rel --bot=linux_compile_rel --bot=android_compile_rel --bot=mac_compile_rel --bot=ios_rel -m tryserver.webrtc
R=stefan@webrtc.org , tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1417683006 .
Cr-Commit-Position: refs/heads/master@{#10500}
2015-11-04 07:32:04 +00:00