166ef2788a
Format build_apprtc.py as requested by presubmit.
...
No-Try: True
Bug: None
Change-Id: I17e8abd3678dec4ffc33ce5932952046e06194e5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271500
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Evan Shrubsole <eshr@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Evan Shrubsole <eshr@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37761}
2022-08-12 09:13:52 +00:00
7d9f0dc40f
Downgrade go runtime to 1.16 for macOS AppRTC tests.
...
Starting from Go 1.17, modules are the default and cannot be disabled.
This requires a change in the GitHub repositury [1].
As a stopgap solution, this CL moves Go back to 1.16 and disables
modules [2].
[1] - https://github.com/webrtc/apprtc/tree/master/src/collider
[2] - https://go.dev/blog/go116-module-changes
No-Presubmit: True
Bug: webrtc:14342
Change-Id: Idd03639588bc03497a78f0cef350daebf3b2f1d9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271481
Reviewed-by: Evan Shrubsole <eshr@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37760}
2022-08-12 07:13:52 +00:00
c06c0cfa52
Update go runtime to 1.19 for macOS AppRTC tests.
...
Bug: webrtc:14342
Change-Id: I34ef63dba16582bcb613c4f25c3c61b460c03047
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271280
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37743}
2022-08-11 08:25:02 +00:00
8cc6695652
Reformat python files checked by pylint (part 1/2).
...
After recently changing .pylintrc (see [1]) we discovered that
the presubmit check always checks all the python files when just
one python file gets updated.
This CL moves all these files one step closer to what the linter
wants.
Autogenerated with:
# Added all the files under pylint control to ~/Desktop/to-reformat
cat ~/Desktop/to-reformat | xargs sed -i '1i\\'
git cl format --python --full
This is part 1 out of 2. The second part will fix function names and
will not be automated.
[1] - https://webrtc-review.googlesource.com/c/src/+/186664
No-Presubmit: True
Bug: webrtc:12114
Change-Id: Idfec4d759f209a2090440d0af2413a1ddc01b841
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/190980
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32530}
2020-10-30 10:13:11 +00:00
09dcafdd21
Revert "Always create output_dir in setup_apprtc.py."
...
This reverts commit 52a8da38f9ec6da7c487626c699d811e542e1cf5.
Reason for revert: It doesn't solve the problem.
Original change's description:
> Always create output_dir in setup_apprtc.py.
>
> This should probably fix [1]. It only happens on Windows bots and from
> the error it looks like if output_dir is missing, the unzipping just
> fails.
>
> [1] - https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Win%20Builder/4027
>
> Bug: None
> Change-Id: I2f0abe90898d6d15525b46fd74635e2a3150cb37
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151307
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#29064}
TBR=phoglund@webrtc.org ,mbonadei@webrtc.org
Change-Id: If8d93033dcb871476f23c1597f24efcd2e20cfb2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151420
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29067}
2019-09-04 18:19:12 +00:00
52a8da38f9
Always create output_dir in setup_apprtc.py.
...
This should probably fix [1]. It only happens on Windows bots and from
the error it looks like if output_dir is missing, the unzipping just
fails.
[1] - https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Win%20Builder/4027
Bug: None
Change-Id: I2f0abe90898d6d15525b46fd74635e2a3150cb37
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151307
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29064}
2019-09-04 13:50:00 +00:00
d7ab56d4c2
Finish migrating rtc_tools/testing to python3.
...
No-Try: True
Bug: None
Change-Id: Ie092d01f9f24b7a995c81ad02c0759445e5c60d6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146940
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28689}
2019-07-26 09:58:13 +00:00
67f88a0d30
Use print() instead of print in rtc_tools/ python scripts.
...
Bug: None
Change-Id: I065f8363583b0934b0b0e3d901b75d558514063c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146861
Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28688}
2019-07-26 06:46:41 +00:00
172a563442
Fix path to AppRTC/collider on Windows
...
Bug: webrtc:7602
No-Try: True
Change-Id: I4d8f254e1316481f35638a1a2882275dfec2b5c1
Reviewed-on: https://webrtc-review.googlesource.com/66860
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#22735}
2018-04-04 14:47:40 +00:00
8058fbbd6b
Bypass browser join confirmation in prebuilt AppRTC
...
This is still needed by Chromium tests.
Copied from https://webrtc.googlesource.com/webrtc.DEPS/+/76533443ed95184aa45dc3b4af383fc301a53f80/copy_apprtc.py
Bug: webrtc:7602
Change-Id: I17f0159fe43176df95ad2e27ff330650d6645d67
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/66680
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#22718}
2018-04-04 08:14:29 +00:00
8730135f26
Use sys.executable to launch another Python script
...
To make setup_apprtc.py work on Windows
Bug: webrtc:7602
Change-Id: I17c19c1cb8b2b71dafd90ae5f8be80e50c3397e9
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/66660
Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#22715}
2018-04-04 07:06:29 +00:00
12196b4e20
Update prebuilt AppRTC
...
Version cfb35d9212a06c1dfc31149c54f196708287a149
Google Cloud SDK 191.0.0
Node v8.9.4
Bug: None
No-Try: True
Change-Id: Ia488899e28bbee37db5cae0ada76729c349ba7dd
Reviewed-on: https://webrtc-review.googlesource.com/59324
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#22265}
2018-03-02 12:16:29 +00:00
51f8fa3664
Partial revert of "Update scripts to use DEPS-pinned depot_tools"
...
Revert the change to rtc_tools/testing/utils.py in
https://webrtc-review.googlesource.com/c/src/+/12540
because it breaks downstream build pipeline.
TBR=phoglund@webrtc.org
Bug: webrtc:8393,b/67931921
Change-Id: Iee77f6b9b15fe03894ee63b48c07eaf3dce40c99
No-try: True
Reviewed-on: https://webrtc-review.googlesource.com/13101
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20337}
2017-10-18 13:06:58 +00:00
ec57e05410
Update scripts to use DEPS-pinned depot_tools
...
Always use gn.py in depot_tools instead of just gn.
The https://cs.chromium.org/chromium/src/build/find_depot_tools.py
is looking up the DEPS-pinned copy in third_party/depot_tools
and adds it to the path when add_depot_tools_to_path() is called.
Similar use:
https: //cs.chromium.org/search/?q=%22find_depot_tools.add_depot_tools_to_path()%22&sq=package:chromium&type=cs
Bug: webrtc:8393
Change-Id: I3cfa3d96b4d0f60e8099e556876bc94340b1bbb5
Reviewed-on: https://webrtc-review.googlesource.com/12540
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Patrik Höglund <phoglund@google.com >
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20333}
2017-10-18 12:06:19 +00:00
92ea95e34a
Fixing WebRTC after moving from src/webrtc to src/
...
In https://webrtc-review.googlesource.com/c/src/+/1560 we moved WebRTC
from src/webrtc to src/ (in order to preserve an healthy git history).
This CL takes care of fixing header guards, #include paths, etc...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=tommi@webrtc.org
Bug: chromium:611808
Change-Id: Iea91618212bee0af16aa3f05071eab8f93706578
Reviewed-on: https://webrtc-review.googlesource.com/1561
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#19846}
2017-09-15 05:02:56 +00:00
bb547203bf
Moving src/webrtc into src/.
...
In order to eliminate the WebRTC Subtree mirror in Chromium,
WebRTC is moving the content of the src/webrtc directory up
to the src/ directory.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=tommi@webrtc.org
Bug: chromium:611808
Change-Id: Iac59c5b51b950f174119565bac87955a7994bc38
Reviewed-on: https://webrtc-review.googlesource.com/1560
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#19845}
2017-09-15 04:25:06 +00:00
