bd05f0ba52
Unconditionally build VP9 support.
...
Broken for PeerConnection either way (since VP9 support is announced)
and would fail on a CHECK apart from generating incorrect
offers/answers. This isn't a flag that we want to support, so it's
better to remove the foot-shooting gun.
BUG=
R=asapersson@webrtc.org , kjellander@webrtc.org , phoglund@webrtc.org , stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1451663002 .
Cr-Commit-Position: refs/heads/master@{#10676}
2015-11-17 14:27:41 +00:00
cfc319be1d
Reland of Work on flexible mode and screen sharing. (patchset #1 id:1 of https://codereview.webrtc.org/1438543002/ )
...
Reason for revert:
Failed test not related to this CL (test fails on
master at an earlier date), re-landing original CL..
(This time from my @webrtc account.)
Original issue's description:
> Revert of Work on flexible mode and screen sharing. (patchset #28 id:520001 of https://codereview.webrtc.org/1328113004/ )
>
> Reason for revert:
> Seems to break VideoSendStreamTest.ReconfigureBitratesSetsEncoderBitratesCorrectly on Linux Memcheck buildbot.
>
> Original issue's description:
> > Work on flexible mode and screen sharing.
> >
> > Implement VP8 style screensharing but with spatial layers.
> > Implement flexible mode.
> >
> > Files from other patches:
> > generic_encoder.cc
> > layer_filtering_transport.cc
> >
> > BUG=webrtc:4914
> >
> > Committed: https://crrev.com/77ccfb4d16c148e61a316746bb5d9705e8b39f4a
> > Cr-Commit-Position: refs/heads/master@{#10572}
>
> TBR=sprang@webrtc.org ,stefan@webrtc.org ,philipel@google.com ,asapersson@webrtc.org ,mflodman@webrtc.org ,philipel@webrtc.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:4914
>
> Committed: https://crrev.com/0be8f1d347bdb171462df89c2a4c69b3f3eb7519
> Cr-Commit-Position: refs/heads/master@{#10578}
TBR=sprang@webrtc.org ,stefan@webrtc.org ,philipel@google.com ,asapersson@webrtc.org ,mflodman@webrtc.org ,terelius@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4914
Review URL: https://codereview.webrtc.org/1431283002
Cr-Commit-Position: refs/heads/master@{#10581}
2015-11-10 15:17:26 +00:00
0be8f1d347
Revert of Work on flexible mode and screen sharing. (patchset #28 id:520001 of https://codereview.webrtc.org/1328113004/ )
...
Reason for revert:
Seems to break VideoSendStreamTest.ReconfigureBitratesSetsEncoderBitratesCorrectly on Linux Memcheck buildbot.
Original issue's description:
> Work on flexible mode and screen sharing.
>
> Implement VP8 style screensharing but with spatial layers.
> Implement flexible mode.
>
> Files from other patches:
> generic_encoder.cc
> layer_filtering_transport.cc
>
> BUG=webrtc:4914
>
> Committed: https://crrev.com/77ccfb4d16c148e61a316746bb5d9705e8b39f4a
> Cr-Commit-Position: refs/heads/master@{#10572}
TBR=sprang@webrtc.org ,stefan@webrtc.org ,philipel@google.com ,asapersson@webrtc.org ,mflodman@webrtc.org ,philipel@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4914
Review URL: https://codereview.webrtc.org/1438543002
Cr-Commit-Position: refs/heads/master@{#10578}
2015-11-10 13:31:22 +00:00
77ccfb4d16
Work on flexible mode and screen sharing.
...
Implement VP8 style screensharing but with spatial layers.
Implement flexible mode.
Files from other patches:
generic_encoder.cc
layer_filtering_transport.cc
BUG=webrtc:4914
Review URL: https://codereview.webrtc.org/1328113004
Cr-Commit-Position: refs/heads/master@{#10572}
2015-11-10 10:19:20 +00:00
a74c08dced
Move i420 files to the right location
...
There's also a presubmit check that disallows .. references
in GYP files, which this solves.
BUG=webrtc:5095
R=stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1418753002 .
Cr-Commit-Position: refs/heads/master@{#10371}
2015-10-22 10:23:21 +00:00
86b016027d
Add stats for average QP per frame for VP8 (for received video streams):
...
"WebRTC.Video.Decoded.VP8.Qp"
BUG=chromium:512752
Review URL: https://codereview.webrtc.org/1340623002
Cr-Commit-Position: refs/heads/master@{#10349}
2015-10-21 06:55:32 +00:00
71f6f4405c
iOS HW H264 support.
...
First step towards supporting H264 on iOS. More tuning/experimentation
required in future CLs. Tested using AppRTCDemo on iPhone6 + iPad Mini.
Future work to get it working on OS/X, simulator (renders black screen
currently) and with the Android AppRTCDemo. Currently protected with a
compile time guard.
BUG=4081
R=andrew@webrtc.org , haysc@webrtc.org , holmer@google.com , jiayl@webrtc.org , kjellander@webrtc.org , pbos@webrtc.org , phoglund@webrtc.org , stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1187573004 .
Cr-Commit-Position: refs/heads/master@{#9515}
2015-06-29 21:35:08 +00:00
57e5fd2e60
PRESUBMIT: Improve PyLint check and add GN format check.
...
Add pylintrc file based on
https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/pylintrc
bit tightened up quite a bit (the one in depot_tools is far
more relaxed).
Remove a few excluded directories from pylint check and fixed/
suppressed all warnings generated.
Add GN format check + formatted all GN files using 'gn format'.
Cleanup redundant rules in tools/PRESUBMIT.py
TESTED=Ran 'git cl presubmit -vv', fixed the PyLint violations.
Ran it again with a modification in webrtc/build/webrtc.gni, formatted
all the GN files and ran it again.
R=henrika@webrtc.org , phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/50069004
Cr-Commit-Position: refs/heads/master@{#9274}
2015-05-25 10:55:50 +00:00
98d8cf58ee
Hardware VP8 encoding: Use QP as metric for resize.
...
Add vp8 frame header parser to get QP from vp8 bitstream.
BUG= 4273
R=glaznev@webrtc.org , marpan@google.com , pbos@webrtc.org
TBR=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/49259004
Cr-Commit-Position: refs/heads/master@{#9256}
2015-05-21 18:11:53 +00:00
9695d8523b
Added VP9FrameBufferPool, a memory pool that is shared between libvpx and webrtc. Using the VP9 codec, the libvpx decoder will obtain its buffers from our memory pool. This lets us reuse the same buffers for our I420VideoFrames and not have to copy a frame for every decode (from libvpx buffers to webrtc/I420VideoFrame buffers).
...
(This is similar to chromium's MemoryPool in vpx_video_decoder.cc.)
BUG=1128
R=kjellander@webrtc.org , magjed@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/48149004
Cr-Commit-Position: refs/heads/master@{#9141}
2015-05-06 08:42:22 +00:00
61b4d518af
Dynamic resolution change for VP8 HW encode.
...
Off by default for now.
BUG=
R=glaznev@webrtc.org , stefan@webrtc.org
TBR=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/45849004
Cr-Commit-Position: refs/heads/master@{#9045}
2015-04-21 22:29:53 +00:00
968b0e20c3
Removed build dependency on er_tables_xor.h, since it has been deleted
...
As part of https://webrtc-codereview.appspot.com/45899004/ the file er_tables_xor.h was removed, but not its dependencies in .gn and .gypi.
BUG=N/A
TBR=pbos
Review URL: https://webrtc-codereview.appspot.com/48889004
Cr-Commit-Position: refs/heads/master@{#8944}
2015-04-07 19:04:44 +00:00
6b3ccfc6a6
GN: Cleanup no longer needed libvpx config.
...
The includes this config provided are now
present just by depending on libvpx.
R=tfarina@chromium.org
Review URL: https://webrtc-codereview.appspot.com/44949004
Cr-Commit-Position: refs/heads/master@{#8884}
2015-03-28 17:28:50 +00:00
ac2d27d9ae
Fix style violations in common_types.h and config.h
...
Mostly, it's about moving constructors and descructors to the .cc
files, so that they won't be inlined everywhere.
The reason this CL is so big is that a lot of code was using
common_types.h without declaring a dependency on webrtc_common, which
broke the build once common_types.h started to depend on
common_types.cc.
BUG=163
R=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/26089004
Cr-Commit-Position: refs/heads/master@{#8516}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8516 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-26 14:01:28 +00:00
ce22f13f0e
GN: Changes for vp9, opus and direct trace
...
Corresponding GN changes for
https://webrtc-codereview.appspot.com/34099004/
BUG=4185
R=brettw@chromium.org
Review URL: https://webrtc-codereview.appspot.com/40669004
Cr-Commit-Position: refs/heads/master@{#8377}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8377 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-16 12:47:45 +00:00
d7e34e1086
Make it easier to use external libyuv + cleanup GYP files.
...
It is now easier to use an external libyuv library.
Fix some GYP errors.
Remove the temporary webrtc_base target (depends on
https://codereview.chromium.org/865603002/ being landed
first).
BUG=4185
R=andresp@webrtc.org , andrew@webrtc.org , perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39579004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8154 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-26 19:17:26 +00:00
8649fed1b8
GN: Fix Windows build.
...
This required a tiny include fix in
src/third_party/winsdk_samples/src
which was committed in
https://code.google.com/p/webrtc/source/detail?r=7951
This incorporates contribution from vchigrin@yandex-team.ru
in https://webrtc-codereview.appspot.com/29299004/
BUG=261,1348,4105
R=pbos@webrtc.org
TBR=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/32889004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8027 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-08 21:22:01 +00:00
46d4d29a75
Add field trial for screenshare bitrates when using temporal layers.
...
BUG=
R=pbos@webrtc.org , pthatcher@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/31209004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7976 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-23 15:19:35 +00:00
9115cde6c9
Merge VP8 changes.
...
R=stefan@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/35389004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7841 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-09 10:36:40 +00:00
5b88317820
Add VP9 codec to VCM and vie_auto_test.
...
Include VP9 tests in videoprocessor_integrationtests.
Include end-to-end send/receiveVP9 test.
This is the same patch as https://code.google.com/p/webrtc/source/detail?r=7422 , which was reverted when rolled into chrome (due to bss size increase). Relanding this again as we now have the clear to get this in:
see https://code.google.com/p/webrtc/issues/detail?id=3932
R=kjellander@webrtc.org , mflodman@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/31829004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7588 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-01 06:10:48 +00:00
b1dac33cac
Revert cls (original cl + fixes) 7422-7424 "Add VP9 codec to VCM..."
...
BUG=3932
R=marpan@google.com
Review URL: https://webrtc-codereview.appspot.com/27779004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7470 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-17 18:54:46 +00:00
573c78e31c
Add VP9 codec to VCM and vie_auto_test.
...
Include VP9 tests in videoprocessor_integrationtests.
Include end-to-end send/receiveVP9 test.
Passes trybots.
R=kjellander@webrtc.org , mflodman@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/29449004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7422 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-10 16:44:47 +00:00
b8caf6a504
GN: Enable libvpx, add link target and convert some test targets
...
Libvpx now supports GN and this CL turns on compiling it.
I also introduced an executable target 'webrtc_tests'
that depends on all in WeBRTC + tests in order to get a full
linking step executed (since we've seen link problems for GN
when rolling WebRTC into Chromium).
I also converted a few test targets and made a GN file for
third_party/gflags.
BUG=3441
TESTED=Trybots + full Chromium build with a symlinked src/third_party/webrtc
dir to a workspace wit this CL applied.
R=brettw@chromium.org
TBR=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/25569004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7344 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-30 18:05:02 +00:00
f21ea918ad
GN: Add common configs to all targets.
...
This is needed to ensure we have the same build with GN
as with GYP, since GYP includes the common.gypi on a global level.
Several fixes has been needed in the past because some code have
been built without the right defines.
BUG=3441
R=brettw@chromium.org
Review URL: https://webrtc-codereview.appspot.com/28589004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7317 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-28 17:37:22 +00:00
6d08ca6379
GN: Prefix WebRTC specific variables with "rtc_"
...
BUG=3441
TESTED=Trybots + Running GN in a Chromium checkout with
src/third_party/webrtc symlinked to the WebRTC checkout
with this CL applied, both with the default GN settings
and using: --args="os=\"android\" cpu_arch=\"arm\""
R=brettw@chromium.org
Review URL: https://webrtc-codereview.appspot.com/27379004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7095 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-07 17:36:10 +00:00
42ee5b54b5
GN: Disable Chromium clang plugins for standalone build.
...
Now that WebRTC has rolled the chromium_revision past
http://crrev.com/284372 in r6784, clang has become the
default compiler. Since WebRTC standalone code doesn't
yet compile the Chromium Clang plugins enabled, this CL
disables them for the parts of the code that doesn't yet pass
compilation with them enabled.
The buildbots are using Goma which is not yet switched
over to Clang by default. That's why they're not red yet.
BUG=163
TEST=Passing compile locally on Linux using:
gn gen out/Debug --args="build_with_chromium=false is_debug=true" && ninja
-C out/Debug
gn gen out/Release --args="build_with_chromium=false is_debug=false" && ninja
-C out/Release
gn gen out/Default --args="build_with_chromium=false os=\"android\" cpu_arch=\"arm\" arm_version=7" && ninja -C out/Default
R=brettw@chromium.org
Review URL: https://webrtc-codereview.appspot.com/16279004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6966 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-25 14:15:35 +00:00
c56ae63ea6
r6709 lacks a change in BUILD.gn
...
BUG=
R=marpan@google.com , marpan@webrtc.org , pbos@webrtc.org , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/21919004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6710 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-16 22:18:49 +00:00
73823cafa4
Add initial gn build files for video_coding and video_processing.
...
BUG=
R=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19819004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6611 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-07 11:46:43 +00:00
1227ab89a7
GN: Add BUILD.gn files + kjellander to OWNERS
...
This should work as a foundation for all the work that is
left to do to make the parts of WebRTC that Chromium uses
to build with GN.
I implemented some the smaller modules myself in this CL.
The remaining work (TODO's in the .gn files) will be distributed
to various team members.
I'm adding myself to OWNERS files for BUILD.gn files in all the
directories where I'm adding a BUILD.gn file.
BUG=3441
TEST=
Successful compilation of WebRTC as standalone:
gn gen out/Default --args="build_with_chromium=false" && ninja -C out/Default
gn gen out/Default --args="build_with_chromium=false is_clang=true clang_use_chrome_plugins=false" && ninja -C out/Default
I built successfully from a Chromium checkout (with
https://codereview.chromium.org/321313006/ applied) using:
gn gen out/Default && ninja -C out/Default webrtc
R=brettw@chromium.org , niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/13749004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6523 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-23 19:21:07 +00:00
