6144b8422b
red: fix renegotiation
...
If RED is no longer used the send codec needs to be reconfigured.
To test on https://webrtc.github.io/samples/src/content/peerconnection/audio/
run:
await pc1.setLocalDescription();
await pc1.setRemoteDescription({type: 'answer', sdp:
pc1.remoteDescription.sdp.replace('red/48000', 'blue/48000')})
As a result, RED will be turned off and the bitrate will drop.
BUG=webrtc:11640
Change-Id: Icc7a83ae29e67d054399bf42010264e94c32127d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/221360
Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org >
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Reviewed-by: Per Åhgren <peah@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34719}
2021-08-11 12:00:13 +00:00
221fa4405c
Roll chromium_revision 304823aaf0..a48436a40a (910626:910736)
...
Change log: 304823aaf0..a48436a40a304823aaf0..a48436a40abbf7f0ed65..cb0fa26dea0787826362..3cc0083a1130fcc783eb..2425804d0d3cfa0080be..c46fd991e949a703f3d9..d76912e4d78c0c217b5a..c08f1b89036632a545dd..97138a27cc304823aaf0..a48436a40aTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I9a05ace1faa31c30dc319aab37a0a05a9298045b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228460
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34718}
2021-08-11 10:49:05 +00:00
10ed5f98b9
Increase sigslot internal pointer representation to 24 bytes.
...
Bug: webrtc:12836
Change-Id: Ic3bfa7fd637d27d580e6921afadb364bbba2fe03
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228425
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34717}
2021-08-11 09:32:32 +00:00
53d4be223b
Migrate software decoders to new VideoDecoder::Configure
...
Bug: webrtc:13045
Change-Id: I1fa28a7c2dd59f0889d98c8ec5f58161c0ec9f95
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228380
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34716}
2021-08-11 09:16:22 +00:00
bf75041b8d
Update stats_types.cc to use make_ref_counted.
...
Bug: webrtc:12701
Change-Id: I2db12680ae35359e02627edfea5f67910c39c431
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226740
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34715}
2021-08-11 09:02:59 +00:00
6c02c33df9
Add henrik.lundin as owner in audio/
...
Bug: none
No-Try: True
Change-Id: I9de4fab3b1db29c91396c371395d9d3399c80239
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228427
Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org >
Reviewed-by: Per Åhgren <peah@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34714}
2021-08-11 08:45:59 +00:00
e9655736e5
Reland "red: remove special-casing of no-redundancy"
...
This is a reland of 320c57b7c6bf68d8612a4f135f44b3d29e802113
Original change's description:
> red: remove special-casing of no-redundancy
>
> removes the special-casing of not sending a RED header when there is no redundant payload.
> This avoids switching back and forth between the primary and the red payload format (primarily at the start of the connection).
>
> BUG=webrtc:11640
>
> Change-Id: I8e0044bef1ed7c4168d9527645522392db2ed068
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/220932
> Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org >
> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
> Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#34703}
Bug: webrtc:11640
Change-Id: I5e5687be575183ee16d74df4a8170e4fedad739f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228422
Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org >
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34713}
2021-08-11 08:26:59 +00:00
d7b7ea6106
dcsctp: remove unused WritePacketHeader method
...
BUG=None
Change-Id: Ieeb19ef976fe88a66a4a7b985f0600bb01044753
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226945
Reviewed-by: Victor Boivie <boivie@webrtc.org >
Commit-Queue: Philipp Hancke <phancke@nvidia.com >
Cr-Commit-Position: refs/heads/master@{#34712}
2021-08-11 08:05:39 +00:00
8121003d15
Update WebRTC code version (2021-08-11T04:05:19).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: Idbd45784b1831cf2ef5cf170403f4b36ebce60ef
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228444
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34711}
2021-08-11 05:54:06 +00:00
81e19fea4f
Roll chromium_revision 383c5205be..304823aaf0 (910497:910626)
...
Change log: 383c5205be..304823aaf0383c5205be..304823aaf016479c6f13..8ada9074201d18359974..bbf7f0ed659bf0d7c3da..078782636273ebbcfad3..30fcc783eb37418be77b..3cfa0080behttps://chromium.googlesource.com/catapult.git/+log/b35ee4986e..abc7ba7d87
* src/third_party/depot_tools: 4f3583d6d5..49a703f3d97381b38f23..6632a545dd383c5205be..304823aaf0TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I9dfa265352eab96104d3ed42f09bee00ad0677a5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228442
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34710}
2021-08-11 03:24:22 +00:00
5c375fe5c8
Roll chromium_revision fc6bee4515..383c5205be (910288:910497)
...
Change log: fc6bee4515..383c5205befc6bee4515..383c5205beb12754566f..16479c6f13fec3cbb4cf..1d18359974b79b97c1f6..b825591df3155154d8a2..9bf0d7c3da3b5dec3ed1..73ebbcfad30e2e49c6bf..37418be77bb95c4868b1..bc7ddae23424dc2c7823..4f3583d6d5aefb45469e..47f819c3caad8b3b0f84..ff19e5b2e1bb09784511..3f8fabd85f7d1294d67c..7381b38f23fc6bee4515..383c5205beTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I384a4ab0377d479f42405f1a4d1ed93db819a9ce
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228440
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34709}
2021-08-10 22:42:30 +00:00
d4716eaf60
dcsctp: Add metrics support
...
To support implementing RTCSctpTransportStats, a few metrics are needed.
Some more were added that are useful for metric collection in SFUs.
Bug: webrtc:13052
Change-Id: Idafd49e1084922d01d3e6c5860715f63aea08b7d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228243
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34708}
2021-08-10 20:01:46 +00:00
1118ebac0a
Revert "red: remove special-casing of no-redundancy"
...
This reverts commit 320c57b7c6bf68d8612a4f135f44b3d29e802113.
Reason for revert:
Breaks CI tests: https://ci.chromium.org/ui/p/webrtc/builders/ci/Linux32%20Release/27236/overview
All CI tests: https://ci.chromium.org/p/webrtc/g/ci/console
Error is of the following type:
```
../../modules/audio_coding/codecs/red/audio_encoder_copy_red_unittest.cc:195: Failure
Expected equality of these values:
1u
Which is: 1
encoded_info_.encoded_bytes
Which is: 2
Stack trace:
0x56b298d9: webrtc::AudioEncoderCopyRedTest_CheckPayloadSizesSingle_Test::TestBody()
0x572fe317: testing::internal::HandleExceptionsInMethodIfSupported<>()
0x572fe1d4: testing::Test::Run()
0x572ff2ee: testing::TestInfo::Run()
```
Original change's description:
> red: remove special-casing of no-redundancy
>
> removes the special-casing of not sending a RED header when there is no redundant payload.
> This avoids switching back and forth between the primary and the red payload format (primarily at the start of the connection).
>
> BUG=webrtc:11640
>
> Change-Id: I8e0044bef1ed7c4168d9527645522392db2ed068
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/220932
> Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org >
> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
> Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#34703}
TBR=henrik.lundin@webrtc.org ,devicentepena@webrtc.org ,minyue@webrtc.org ,philipp.hancke@googlemail.com ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
Change-Id: Ide409232720df32b24022f99228f3b6ae81f06fe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:11640
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228421
Reviewed-by: Andrey Logvin <landrey@webrtc.org >
Commit-Queue: Andrey Logvin <landrey@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34707}
2021-08-10 18:09:16 +00:00
82ea522b27
dcsctp: Track the number of inflight DATA items
...
This corresponds to one part of sstat_unackdata in RFC6458. The
remaining part is the data in the send queue, which isn't packetized
yet, so it must be estimated. But the DATA items in the retransmission
queue is already determined, so it can be easily tracked and retrieved.
Bug: webrtc:13052
Change-Id: I16c3b5b61eb6b3022d7104e6457d943d5df3d6b9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228240
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34706}
2021-08-10 18:00:26 +00:00
2ddc39e2b9
Add max pre-decode queue size threshold for pacing
...
When pacing is enabled for the low latency rendering path,
frames are sent to the decoder in regular intervals. In case of a
jitter, these frames intervals could add up to create a large latency.
Hence, disable frame pacing if the pre-decode queue grows beyond the
threshold. The threshold for when to disable frame pacing is set
through a field trial. The default value is high enough so that
the behavior is not changed unless the field trial is specified.
Bug: chromium:1237402
Change-Id: I901fd579f68da286eca3d654118f60d3c55e21ce
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228241
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34705}
2021-08-10 17:01:53 +00:00
5653c95ca2
Relax video_codec parameter for RtpVideoStreamReceiver2::AddReceiveCodec
...
Instead of requiring huge VideoCodec struct, pass single member from it
Bug: webrtc:13045
Change-Id: I46a3c24cd2c9c3a450f897ed014cb95d7dfcc841
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228382
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34704}
2021-08-10 17:00:05 +00:00
320c57b7c6
red: remove special-casing of no-redundancy
...
removes the special-casing of not sending a RED header when there is no redundant payload.
This avoids switching back and forth between the primary and the red payload format (primarily at the start of the connection).
BUG=webrtc:11640
Change-Id: I8e0044bef1ed7c4168d9527645522392db2ed068
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/220932
Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org >
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34703}
2021-08-10 16:56:05 +00:00
43f25e36f7
red: fix redundancy shift and add tests
...
fixes an incorrect redundancy shift and add tests that would have caught this bug.
BUG=webrtc:11640
Change-Id: I6fe2fb21587fffc5fee4d403ac898e12d525a1cd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/224120
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34702}
2021-08-10 16:51:06 +00:00
0441bb625f
APM: add HW-only denormal disabler
...
Denormal numbers (see [1]) may origin in APM when the input is zeroed
after a non-zero signal. In extreme cases, instructions involving
denormal operands may run as much as 100 times slower, which seems to
be the case (to some extent) of crbug.com/1227566.
This CL adds a class that disables denormals only via hardware on x86
and on ARM. The class is used in APM and it is an adaption of [2].
Tested: appr.tc call on Chromium (Win, Mac)
[1] https://en.wikipedia.org/wiki/Denormal_number
[2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/audio/denormal_disabler.h
Fixed: chromium:1227566
Change-Id: I0ed2eab55dc597529f09f93c26c7a01de051fdbe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227768
Reviewed-by: Magnus Flodman <mflodman@webrtc.org >
Reviewed-by: Per Åhgren <peah@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34701}
2021-08-10 15:48:22 +00:00
db68979a20
Roll chromium_revision 6ce9efed52..fc6bee4515 (910174:910288)
...
Change log: 6ce9efed52..fc6bee45156ce9efed52..fc6bee45158f4dbc27d7..b12754566f8e6db3edf0..fec3cbb4cfb88f2d84ca..155154d8a2750eacd840..3b5dec3ed16a751ad8dd..0e2e49c6bf02c4020f87..bb097845111ade45cbad..978003f36a17ce438192..7d1294d67c6ce9efed52..fc6bee4515TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I6aee26cfcd7c133c9dbbd6422375b1055b0ba6d5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228401
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34700}
2021-08-10 15:24:16 +00:00
3abd10889f
Fix define if chain in audio decoder unittest
...
Follow up https://webrtc-review.googlesource.com/c/src/+/228247 . Turned out "#elif defined(WEBRTC_MAC) && defined(WEBRTC_ARCH_ARM64) // M1 Mac" branch was unreachable
Bug: webrtc:13053
Change-Id: Icf1aa5147347a1fad0dce8cca893bb3c598f658e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228381
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Commit-Queue: Andrey Logvin <landrey@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34699}
2021-08-10 13:00:33 +00:00
264cf54443
VideoSendStream: Don't disable the alive flag when updating layers.
...
When implicit start/stop happens via activation/deactivation of layers
occurs, don't change the state of the 'alive' flag since further
activations following full de-activation need to be allowed to happen
when Stop() has not been called.
Bug: chromium:1234779
Change-Id: Ic3cae387990122eaa2f48de096ff9dafa7c34414
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228242
Reviewed-by: Magnus Flodman <mflodman@webrtc.org >
Commit-Queue: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34698}
2021-08-10 12:45:33 +00:00
8c654aa059
Update bit exactness tests to match changes
...
Follow up for https://webrtc-review.googlesource.com/c/src/+/227773 , updating M1 checksums that were not updated in the previous CL.
Example M1 failed run: https://ci.chromium.org/ui/p/webrtc/builders/ci/MacARM64%20M1%20Release/401/overview
Bug: webrtc:13053
Change-Id: I111d1d3c4bf5828ee499f20799b527ca916d77e7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228247
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Commit-Queue: Andrey Logvin <landrey@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34697}
2021-08-10 12:19:13 +00:00
cfea2182f8
Use backticks not vertical bars to denote variables in comments
...
Bug: webrtc:12338
Change-Id: I89c8b3a328d04203177522cbdfd9e606fd4bce4c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228246
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34696}
2021-08-10 10:40:03 +00:00
603e6e3ffc
Update StreamStats.encode_frame_rate when GetStats is called.
...
Currently encode_frame_rate is updated (ComputeRate called) when a frame is encoded.
If a stream is stopped, encode_frame_rate will have an old value (the framerate at the time of the last encoded frame) instead of zero.
Bug: webrtc:13037
Change-Id: I1a2122df61e3e8187e57155dda71c0173cda4c5b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228220
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34695}
2021-08-10 09:37:33 +00:00
ecc46eff5b
Introduce new api to initialize VideoDecoder
...
Bug: webrtc:13045
Change-Id: If14fa3998176ee07b6f2835745568f70347ccac6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227766
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34694}
2021-08-10 08:42:43 +00:00
029d5d208c
Roll chromium_revision 5835c1f6b2..6ce9efed52 (910061:910174)
...
Change log: 5835c1f6b2..6ce9efed525835c1f6b2..6ce9efed5275b22feae2..8f4dbc27d75d63ac6037..8e6db3edf05fc2bf13fb..b88f2d84cabecd4a2bc5..750eacd840df181cbb46..6a751ad8ddhttps://chromium.googlesource.com/catapult.git/+log/7d8f51997c..b35ee4986e
* src/third_party/depot_tools: 7ecdc98e22..24dc2c7823fe727e39cb..17ce4381925835c1f6b2..6ce9efed52TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ic895473bbba9edfd949b6a27515398708e013fdc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228346
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34693}
2021-08-10 06:28:25 +00:00
64fd3af765
Update WebRTC code version (2021-08-10T04:05:55).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I3490c7e0ba258bf4bbe835d335e9d5fa3f027191
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228345
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34692}
2021-08-10 06:06:33 +00:00
6f1cc6cfcf
Roll chromium_revision bd48805637..5835c1f6b2 (909939:910061)
...
Change log: bd48805637..5835c1f6b2bd48805637..5835c1f6b2f4af438d45..5d63ac6037dd462fa3ba..5fc2bf13fba27f7aa276..becd4a2bc557a87f6423..df181cbb4632096a2dc8..b95c4868b1https://chromium.googlesource.com/catapult.git/+log/cf2488ab01..7d8f51997c
* src/third_party/depot_tools: e989bf92db..7ecdc98e2247cf8ebf4a..fed5521016938aae91f9..fe727e39cbbd48805637..5835c1f6b2TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I46a379ded21deae51c6b992085e50028df76a0c7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228342
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34691}
2021-08-10 01:05:42 +00:00
0b489303d2
Use backticks not vertical bars to denote variables in comments for /modules/audio_processing
...
Bug: webrtc:12338
Change-Id: I85bff694dd2ead83c939c4d1945eff82e1296001
No-Presubmit: True
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227161
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34690}
2021-08-09 21:49:02 +00:00
dc6801c618
Roll chromium_revision 539ec6ad64..bd48805637 (909776:909939)
...
Change log: 539ec6ad64..bd48805637539ec6ad64..bd48805637c2c7c369ae..75b22feae25a1c7d1535..f4af438d45998fe34bc2..dd462fa3babe0acd5e4e..a27f7aa276623e23e55c..57a87f6423https://chromium.googlesource.com/catapult.git/+log/c71b1c718d..cf2488ab01
* src/third_party/googletest/src: 2d924d7a97..aefb45469ecd62d9c037..938aae91f9539ec6ad64..bd48805637TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Id8f9073c60327872f6fd9e697c3a2a22dc063990
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228340
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34689}
2021-08-09 20:40:02 +00:00
37c155088e
Reland "Updated the default VP9 per-spatial-temporal layer settings."
...
This is a reland of 99fb5945b9c278cf33ef434ebacd5dfb9bde865d
Downstream project has been fixed.
Original change's description:
> Updated the default VP9 per-spatial-temporal layer settings.
>
> Bug: webrtc:11551
> Change-Id: If2029df444f576b41bfef302985d6e18d7cdc3b5
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227782
> Commit-Queue: Michael Horowitz <mhoro@google.com >
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#34668}
Bug: webrtc:11551
Change-Id: I23a87408f1a9df3a9ccb874698ff97f59cfbe791
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228280
Commit-Queue: Michael Horowitz <mhoro@google.com >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34688}
2021-08-09 17:42:35 +00:00
1fde34f703
Tweaks for LossBasedBweV2.
...
Caches the TCP fairness limit to avoid redundant calculation. Adds option to append the delay based estimate as a candidate. Makes the appending of acknowledged bitrate as a candidate optional. Adds a log-bandwidth bias term.
(submit on behalf of crodbro)
Bug: webrtc:12707
Change-Id: Ic4b0f58e6f0bc3b117fe78a2321a07db65afd9dd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228163
Commit-Queue: Ying Wang <yinwa@webrtc.org >
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34687}
2021-08-09 16:44:02 +00:00
913cfa76ec
Use backticks not vertical bars to denote variables in comments for /modules/rtp_rtcp
...
Bug: webrtc:12338
Change-Id: I52eb3b6675c4705e22f51b70799ed6139a3b46bc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227164
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34686}
2021-08-09 15:51:03 +00:00
7f9ab1aa1b
Use backticks not vertical bars to denote variables in comments for /modules/video_processing
...
Bug: webrtc:12338
Change-Id: I8933ab32cf9b215f0ac7f49ec4aa3d5b3dce6d2f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227160
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34685}
2021-08-09 15:36:42 +00:00
dcd7fc7ea8
Use backticks not vertical bars to denote variables in comments for /modules/video_coding
...
Bug: webrtc:12338
Change-Id: Ia8a9adea291d594e4f59a6a1203a7bfb0758adac
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227165
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34684}
2021-08-09 15:26:22 +00:00
7f854bce1f
Add supportsNativeHandle to the RTCVideoEncoder protocol.
...
The simulcast_encoder_adapter expects codecs that specify
supports_native_handle to perform resampling/scaling (through
GetEncoderInfo).
This change adds a method to the RTCVideoEncoder to let objc encoders
specify this rather than relying on the default.
Bug: webrtc:13044
Change-Id: I2efcbd42aa4f2048285f451c7b691fdeca111e62
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227641
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34683}
2021-08-09 15:21:52 +00:00
954c1d1a0c
Use backticks not vertical bars to denote variables in comments for /modules/video_capture
...
Bug: webrtc:12338
Change-Id: I262ead2039022d4a8135d506dc6c43857b9bfa04
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227099
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34682}
2021-08-09 15:20:43 +00:00
2373bb9799
Default-enable deferred sequence numbering for audio.
...
Bug: webrtc:11340
Change-Id: I5aa2a1e35b007c6d4c039f42f09c48fd7871f6ab
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227775
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Per Åhgren <peah@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34681}
2021-08-09 13:57:52 +00:00
55542302b3
remove GICE-specific stun error code
...
GICE was removed around M42
BUG=webrtc:4299
Change-Id: I4e83a888c3ecc1681799c07b47b75c9f31b40baa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227348
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34680}
2021-08-09 13:48:52 +00:00
ac762a45ce
Roll chromium_revision 0c4786e00c..539ec6ad64 (909432:909776)
...
Change log: 0c4786e00c..539ec6ad640c4786e00c..539ec6ad6470abf000d2..c2c7c369ae06f424e4a4..5a1c7d153599e2da7611..998fe34bc2cf5db89187..be0acd5e4e8f5788bc8d..623e23e55chttps://chromium.googlesource.com/catapult.git/+log/2e0d77d800..c71b1c718d
* src/third_party/depot_tools: 5339c686ff..e989bf92db6be8bfe499..47cf8ebf4acc9bb29491..8c0c217b5ahttps://aomedia.googlesource.com/aom.git/+log/d80b8cecab..da0b537ee1
* src/third_party/perfetto: b2d344e9c0..02c4020f87c3143befc1..cd62d9c0370c4786e00c..539ec6ad64TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Iae78712295e5fce25ea77e7eaca538b0815d3d18
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228201
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34679}
2021-08-09 13:43:42 +00:00
cec4343fb4
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture
...
Bug: webrtc:12338
Change-Id: I300ba78fc4423db7030e555d7e51d2cb2246e9a4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227162
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34678}
2021-08-09 13:12:52 +00:00
1fd7af5fb8
Use backticks not vertical bars to denote variables in comments for /modules/remote_bitrate_estimator
...
Bug: webrtc:12338
Change-Id: Ib8b70186223699360e2323411e0c0ba1673bcb7d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227097
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34677}
2021-08-09 12:27:52 +00:00
5ce7d14f81
Delete legacy rtp header parser as no longer used
...
Bug: None
Change-Id: I3c532eee7f2d9e5295874dd538730625c8d423ff
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227086
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Minyue Li <minyue@google.com >
Reviewed-by: Minyue Li <minyue@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34676}
2021-08-09 12:14:52 +00:00
bbdecaff89
Use backticks not vertical bars to denote variables in comments for /modules/utility
...
Bug: webrtc:12338
Change-Id: I8900efa25a5eebcf57ec894108e1212e1d5b8089
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227098
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34675}
2021-08-09 12:01:43 +00:00
ee3e3fdfb6
Use backticks not vertical bars to denote variables in comments for /modules/pacing
...
Bug: webrtc:12338
Change-Id: Id3b5081cf73be31829d75d7ef34942c2259053da
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227096
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34674}
2021-08-09 11:51:32 +00:00
3754e7c7ad
Revert "Updated the default VP9 per-spatial-temporal layer settings."
...
This reverts commit 99fb5945b9c278cf33ef434ebacd5dfb9bde865d.
Reason for revert: Speculative revert: breaks upstream project
Original change's description:
> Updated the default VP9 per-spatial-temporal layer settings.
>
> Bug: webrtc:11551
> Change-Id: If2029df444f576b41bfef302985d6e18d7cdc3b5
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227782
> Commit-Queue: Michael Horowitz <mhoro@google.com >
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#34668}
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:11551
Change-Id: Ief33f98d8a4e0ccf95d7004c2526c99829807d15
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228162
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Andrey Logvin <landrey@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34673}
2021-08-09 10:14:32 +00:00
63ac8790c6
[sigslot] - Remove SignalDestroyed from PortAllocatorSession.
...
Bug: webrtc:11943
Change-Id: I2d615dc08627789b759f5c41b564ead212cf672e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227966
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34672}
2021-08-09 09:26:12 +00:00
a53d83d813
buffered_frame_decryptor: dont assume GFD is present
...
BUG=webrtc:12995
Change-Id: I94aad0d419759d2ed04c5b1be55f0a0cea26b3f1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227220
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34671}
2021-08-09 09:06:02 +00:00
6dd6651852
Update WebRTC code version (2021-08-07T04:03:46).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I9f2d4c0b44db85a14dc427f21728dc4f7fc09ddc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227865
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34670}
2021-08-07 05:56:30 +00:00
