254ecffacf
Using absl::string_view to stringify an RTCErrorType.
...
Bug: webrtc:10198
Change-Id: Ie7fdba08df219a03ebe2ee5521c2840f28571bba
Reviewed-on: https://webrtc-review.googlesource.com/c/117162
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26277}
2019-01-16 11:49:00 +00:00
0acffb5b36
Expose jitterBufferEmittedCount in addition to the existing jitterBufferDelay for getStats().
...
NetEq currently only passes `jitterBufferDelay` to `getStats()`. We need its paired `jitterBufferEmittedCount` denominator stat for the calculations to be accurate.
Bug: webrtc:10192
Change-Id: I655aea629026ce9101409c2e0f18c2fa57a1c3ab
Reviewed-on: https://webrtc-review.googlesource.com/c/117320
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Commit-Queue: Chen Xing <chxg@google.com >
Cr-Commit-Position: refs/heads/master@{#26276}
2019-01-16 11:44:10 +00:00
77536a2b81
Rename EncodedImage::_length --> size_, and make private.
...
Use size() accessor function. Also replace most nearby uses of _buffer
with data().
Bug: webrtc:9378
Change-Id: I1ac3459612f7c6151bd057d05448da1c4e1c6e3d
Reviewed-on: https://webrtc-review.googlesource.com/c/116783
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26273}
2019-01-16 07:40:47 +00:00
ccc1b57e32
Poll is_hardware_accelerated from VideoEncoder instead of VideoEncoderFactory.
...
Currently, CPU overuse settings for HW encoders are sometimes being used
even though the actual encoder is a SW encoder, e.g. in case of SW fallback
when the encoder is initialized. Polling is_hardware_accelerated after the
encoder has been created and initialized will improve choosing the correct
CPU overuse settings.
Bug: webrtc:10065
Change-Id: Ic6bd67630a040b5a121c13fa63dd074006973929
Reviewed-on: https://webrtc-review.googlesource.com/c/116688
Commit-Queue: Mirta Dvornicic <mirtad@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26266}
2019-01-15 14:12:12 +00:00
4e5ffbe95d
Remove unneeded deps from api:call_api.
...
Bug: webrtc:10198
Change-Id: I0c86ea3afd68b959774e2f41b8ca7957b9b6c138
Reviewed-on: https://webrtc-review.googlesource.com/c/117160
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26249}
2019-01-14 16:20:09 +00:00
45340ca824
Remove legacy video codec factories.
...
Removes the deprecated video codec factories and the related flag and
helper classes.
Bug: webrtc:7925
Change-Id: I0a6d1666ece9ad074fefc79b626ba241765e1b98
Reviewed-on: https://webrtc-review.googlesource.com/c/113940
Commit-Queue: Anders Carlsson <andersc@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26245}
2019-01-14 14:56:40 +00:00
959e9b6b57
Publish rtc::QueuedTask in api as webrtc::QueuedTask
...
Bug: webrtc:10191
Change-Id: I7dcba28615c2f3e44442be410dedde15f5fb1deb
Reviewed-on: https://webrtc-review.googlesource.com/c/113502
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26244}
2019-01-14 14:48:12 +00:00
aec15aa810
(5) Rename files to snake_case: install forwarding headers
...
Mechanically generated with this command:
tools_webrtc/do-renames.sh install all-renames.txt && git cl format
Bug: webrtc:10159
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Ic8e99f71f2da62e5c99863c6d24a8cfe311466cd
Reviewed-on: https://webrtc-review.googlesource.com/c/115682
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26227}
2019-01-11 17:13:36 +00:00
10542f21c8
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries
...
Mechanically generated by running this command:
tools_webrtc/do-renames.sh update all-renames.txt && git cl format
Then manually updating:
tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc
Bug: webrtc:10159
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I54824cd91dada8fc3ee3d098f971bc319d477833
Reviewed-on: https://webrtc-review.googlesource.com/c/115653
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26226}
2019-01-11 17:11:39 +00:00
1c05765831
(3) Rename files to snake_case: move the files
...
Mechanically generated with this command:
tools_webrtc/do-rename.sh move all-renames.txt
Bug: webrtc:10159
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I8b05b6eab9b9d18b29c2199bbea239e9add1e690
Reviewed-on: https://webrtc-review.googlesource.com/c/115481
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26225}
2019-01-11 17:05:20 +00:00
4687915495
Enable use of MediaTransportInterface for video streams.
...
Bug: webrtc:9719
Change-Id: I8c6027b4b15ed641e42fd210b3ea87d121508a69
Reviewed-on: https://webrtc-review.googlesource.com/c/111751
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Reviewed-by: Peter Slatala <psla@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26219}
2019-01-11 14:06:15 +00:00
87da937789
Delete unused constant kVideoCodecI420
...
Followup to cl https://webrtc-review.googlesource.com/c/112596 .
Bug: webrtc:5791
Change-Id: Ie0375fa9e47dddd9e78d26fd63b8a349bacf5903
Reviewed-on: https://webrtc-review.googlesource.com/c/114983
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26211}
2019-01-11 09:04:56 +00:00
53eae87bf8
Add PeerConnection option to enable RTX handling in the audio jitter buffer.
...
Bug: webrtc:10178
Change-Id: I70abce0c7b74124d2b1978d9a5eb8216b6233d1a
Reviewed-on: https://webrtc-review.googlesource.com/c/116784
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org >
Reviewed-by: Minyue Li <minyue@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26203}
2019-01-10 16:28:43 +00:00
a8f58f001e
Add data() accessors to EncodedImage
...
Intend to make the |_buffer| member private, in a later cl.
Bug: webrtc:9378
Change-Id: I8398932a36d8d931a7e587edca7be3957bbafcfd
Reviewed-on: https://webrtc-review.googlesource.com/c/116782
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26201}
2019-01-10 15:30:55 +00:00
79a07cd9f6
Change type StreamsConfig::requests_alr_probing to abls::optional
...
That means it does not have to be set on every update of StreamsConfig.
BUG=webrtc:9586
Change-Id: I6a348160e209042857c4475323466e2aa92adef8
Reviewed-on: https://webrtc-review.googlesource.com/c/116690
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Per Kjellander <perkj@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26184}
2019-01-10 06:12:05 +00:00
c610e26be5
Include pacing buffer size in congestion window.
...
Bug: webrtc:10171
Change-Id: I9e21880a8b6f325415b62397081c301ee904f2ea
Reviewed-on: https://webrtc-review.googlesource.com/c/116068
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Christoffer Rodbro <crodbro@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26175}
2019-01-09 11:16:58 +00:00
40d55331d7
Include absl/memory/memory.h if absl::make_unique is used
...
Tbr: kwiberg@webrtc.org
Bug: None
Change-Id: Iaf4533d2ce0e80b351a8a664ef8cf7ba0e5ec583
Reviewed-on: https://webrtc-review.googlesource.com/c/115746
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Yves Gerey <yvesg@google.com >
Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26168}
2019-01-08 20:08:32 +00:00
455d27c49a
Adding audio network adaptor to video quality test.
...
Bug: b/122445011
Change-Id: I2f652f972e500fa700b65d89cb044f98bcfb1eed
Reviewed-on: https://webrtc-review.googlesource.com/c/116282
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Per Kjellander <perkj@webrtc.org >
Commit-Queue: Minyue Li <minyue@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26158}
2019-01-08 14:49:50 +00:00
d716fb9ecb
Reland "Refactor rate profile update."
...
This is a reland of b6cdfdc165d76d86a67d829e0ccec50c36106e73
Original change's description:
> Refactor rate profile update.
>
> RateProfile::frame_num specifies frame at which this rate profile
> should be applied.
>
> Bug: none
> Change-Id: I003ee43f44299a49d83f547558284817bfaeacc0
> Reviewed-on: https://webrtc-review.googlesource.com/c/115242
> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
> Reviewed-by: Seth Hampson <shampson@webrtc.org >
> Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#26080}
TBR=ilnik@webrtc.org ,shampson@webrtc.org
Bug: none
Change-Id: I6ccbb32efe3d52c97e73e248ce5f06d672c9fba5
Reviewed-on: https://webrtc-review.googlesource.com/c/116286
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org >
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26155}
2019-01-08 10:35:42 +00:00
08223c1576
Revert "Reland "Refactor rate profile update.""
...
This reverts commit 77aedaee6913e1eaa81fdb4aa0690a084cc15111.
Reason for revert: breaks VideoCodecTestVideoToolbox tests.
Original change's description:
> Reland "Refactor rate profile update."
>
> This is a reland of b6cdfdc165d76d86a67d829e0ccec50c36106e73
>
> Original change's description:
> > Refactor rate profile update.
> >
> > RateProfile::frame_num specifies frame at which this rate profile
> > should be applied.
> >
> > Bug: none
> > Change-Id: I003ee43f44299a49d83f547558284817bfaeacc0
> > Reviewed-on: https://webrtc-review.googlesource.com/c/115242
> > Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
> > Reviewed-by: Seth Hampson <shampson@webrtc.org >
> > Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#26080}
>
> Bug: none
> Change-Id: I2604878d0bbee0f2182ad74e3cc29546310b76f3
> Reviewed-on: https://webrtc-review.googlesource.com/c/115401
> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
> Reviewed-by: Seth Hampson <shampson@webrtc.org >
> Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#26145}
TBR=ilnik@webrtc.org ,shampson@webrtc.org ,ssilkin@webrtc.org
Change-Id: Ib53eae70c380eefa303ddb01441f23e32f06b3ad
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: none
Reviewed-on: https://webrtc-review.googlesource.com/c/116285
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org >
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26148}
2019-01-07 15:41:17 +00:00
77aedaee69
Reland "Refactor rate profile update."
...
This is a reland of b6cdfdc165d76d86a67d829e0ccec50c36106e73
Original change's description:
> Refactor rate profile update.
>
> RateProfile::frame_num specifies frame at which this rate profile
> should be applied.
>
> Bug: none
> Change-Id: I003ee43f44299a49d83f547558284817bfaeacc0
> Reviewed-on: https://webrtc-review.googlesource.com/c/115242
> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
> Reviewed-by: Seth Hampson <shampson@webrtc.org >
> Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#26080}
Bug: none
Change-Id: I2604878d0bbee0f2182ad74e3cc29546310b76f3
Reviewed-on: https://webrtc-review.googlesource.com/c/115401
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Seth Hampson <shampson@webrtc.org >
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26145}
2019-01-07 11:18:26 +00:00
1ebfb6aac7
Introduce VideoFrame::id to keep track of frames inside application.
...
Also switch webrtc code from deprecated constructors to the builder API.
Change-Id: Ie325bf1e9b4ff1e413fef3431ced8ed9ff725107
Bug: webrtc:10138
Reviewed-on: https://webrtc-review.googlesource.com/c/114422
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26132}
2019-01-04 08:59:26 +00:00
d02541e276
Add an observer API for DTLSTransport events.
...
This wires up the "state change" event and defines an observer
class that can be used by clients.
Bug: chromium:907849
Change-Id: I3cba2dc051a56280fb958f139f29cbb0022a39c6
Reviewed-on: https://webrtc-review.googlesource.com/c/114884
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26120}
2019-01-03 12:15:54 +00:00
bba675db3e
Clean up api/ DEPS
...
Add missing entries, move definitions to closer DEPS files.
Tbr: shampson@webrtc.org
Tbr: terelius@webrtc.org
Bug: None
Change-Id: I07574ad4d440eb729d21aba673981833261c1fcf
Reviewed-on: https://webrtc-review.googlesource.com/c/115742
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26114}
2019-01-02 18:41:43 +00:00
412d185b4a
Delete pre_encode_callback from VideoSendStream::Config
...
Bug: webrtc:9864
Change-Id: I7f0c897345c99765ea9de77bc70b43ba0e4af19b
Reviewed-on: https://webrtc-review.googlesource.com/c/115320
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26110}
2019-01-02 09:14:32 +00:00
0c02250969
Pass RtcEventLog to MediaTransportFactory.
...
Currently media transport can't log events to event log, but it should (things like bitrate estimates, goog cc logging, etc). This change make RtcEventLog available inside media transport.
Bug: webrtc:9719
Change-Id: I89a3b727049ccadc11c26c1d26ebaee3a1172556
Reviewed-on: https://webrtc-review.googlesource.com/c/115789
Commit-Queue: Peter Slatala <psla@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26106}
2018-12-28 19:40:28 +00:00
77938e6409
Simulcast work to enable RID mux.
...
Rids can now be sent using rtp_sender.
Hooking up the rid values in the voice and video engine is still WIP.
Bug: webrtc:10074
Change-Id: I245c7ecb23b67fc0ba65caaa5dbb4fcfd60c81bb
Reviewed-on: https://webrtc-review.googlesource.com/c/114505
Commit-Queue: Amit Hilbuch <amithi@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Seth Hampson <shampson@webrtc.org >
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org >
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26092}
2018-12-21 20:59:23 +00:00
a921660060
Add ability to paste VideoFrameBuffer into the middle of I010Buffer and I420Buffer
...
Bug: webrtc:10152
Change-Id: I721136a3ba3604f0c685ef28637fb84fcf94778e
Reviewed-on: https://webrtc-review.googlesource.com/c/115300
Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26089}
2018-12-21 14:24:48 +00:00
a1f78a4fa6
Revert "Refactor rate profile update."
...
This reverts commit b6cdfdc165d76d86a67d829e0ccec50c36106e73.
Reason for revert: breaks downstream projects
Original change's description:
> Refactor rate profile update.
>
> RateProfile::frame_num specifies frame at which this rate profile
> should be applied.
>
> Bug: none
> Change-Id: I003ee43f44299a49d83f547558284817bfaeacc0
> Reviewed-on: https://webrtc-review.googlesource.com/c/115242
> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
> Reviewed-by: Seth Hampson <shampson@webrtc.org >
> Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#26080}
TBR=ilnik@webrtc.org ,shampson@webrtc.org ,ssilkin@webrtc.org
Change-Id: I5957a0169841008436d1db70403d3694bf25d5cf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: none
Reviewed-on: https://webrtc-review.googlesource.com/c/115400
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org >
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26081}
2018-12-21 09:05:01 +00:00
b6cdfdc165
Refactor rate profile update.
...
RateProfile::frame_num specifies frame at which this rate profile
should be applied.
Bug: none
Change-Id: I003ee43f44299a49d83f547558284817bfaeacc0
Reviewed-on: https://webrtc-review.googlesource.com/c/115242
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Seth Hampson <shampson@webrtc.org >
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26080}
2018-12-21 08:32:35 +00:00
9405efaeff
Add element_type typedef to rtc::scoped_refptr
...
This allows rtc::scoped_refptr to be used with templates
that use element_type as the mechanism to interface with
smart pointers.
Bug: None
Change-Id: Ie742f416a78efce0b07cfa3009d939e51506ccf9
Reviewed-on: https://webrtc-review.googlesource.com/c/115100
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26078}
2018-12-20 19:11:22 +00:00
e920351798
Update PeerConnectionProxy to reflect new PeerConnectionInterface methods
...
Bug: webrtc:10133
Change-Id: I0fa62d7265b3a101e7c55695fca47b72d7fabf58
Reviewed-on: https://webrtc-review.googlesource.com/c/114913
Reviewed-by: Seth Hampson <shampson@webrtc.org >
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26060}
2018-12-19 18:41:26 +00:00
31d8b52075
Delete unneeded includes of rtc_base/stringutils.h.
...
Also delete corresponding dependencies on rtc_base:stringutils.
Bug: webrtc:6424
Change-Id: I2be5e021292eea2d788c76a63cc0e4f7cefd927d
Reviewed-on: https://webrtc-review.googlesource.com/c/114544
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26057}
2018-12-19 11:04:27 +00:00
503da94350
Adds first unacknowledged packet send time.
...
This will be used to calculate a lower bound for the round trip time in
a later CL.
Bug: webrtc:9718
Change-Id: I0a1d22045961fe6bd343d1d6ce9b36490b036bb1
Reviewed-on: https://webrtc-review.googlesource.com/c/114680
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26050}
2018-12-18 16:55:33 +00:00
358fba1f9d
Removes NetworkControllerTester
...
Replacing NetworkControllerTester usages with SimulatedTimeClient since
they have corresponding functionality.
Bug: webrtc:9510
Change-Id: I4a6a78142a9922e53b862eb8cb71ba9091236346
Reviewed-on: https://webrtc-review.googlesource.com/c/114660
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26048}
2018-12-18 16:11:22 +00:00
1c931c4f00
Use VideoSourceInterface for owning test video sources
...
CallTest, VideoQualityTest and VideoAnalyzer used test::TestVideoCapturer
as an interface for video sources. Change to use VideoSourceInterface instead,
since that's all they need.
This is a preparation for making test::VcmCapturer usable as a
VideoTrackSource, and replace use of cricket::VideoCapturer in example code.
Bug: webrtc:6353
Change-Id: I445f5f6f9b7342230b89f53a5722df9c9e92834f
Reviewed-on: https://webrtc-review.googlesource.com/c/114881
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26047}
2018-12-18 15:43:55 +00:00
73f2da9fa7
Remove VP8EncoderSimulcastProxy
...
The class has been renamed to EncoderSimulcastProxy.
Bug: webrtc:10069
Change-Id: Ief03cfb27145798ac46692d9e51371d2e119eeb0
Reviewed-on: https://webrtc-review.googlesource.com/c/114551
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26031}
2018-12-17 15:29:20 +00:00
833979f7b8
Adding metrics for hostname candidate use.
...
These metrics by themselves won't be as useful, unless they can be correlated to the use of the
feature 'WebRtcHideLocalIpsWithMdns'. This can be done by running a finch experiment where we turn
the feature on for a % of users, we can then compare these metrics for users with and without
the feature turned on.
A complementary change is required in Chrome:
tools/metrics/histograms/enums.xml
Bug: webrtc:9605 webrtc:10091 chromium:914452
Change-Id: Ibc6d16dec95a8e3943ce40063c02903769fe1cb4
Reviewed-on: https://webrtc-review.googlesource.com/c/113321
Commit-Queue: Jeroen de Borst <jeroendb@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Seth Hampson <shampson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26003}
2018-12-13 17:35:10 +00:00
fe79b34c11
Reorder methods and members of HdrMetadata
...
Bug: webrtc:8651
Change-Id: I67941a5918d5cd31a7b04b11aa20c500d49e9a62
Reviewed-on: https://webrtc-review.googlesource.com/c/114283
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26002}
2018-12-13 14:00:39 +00:00
e1301a8b3a
Revert "Implement read-only codecPayloadType in RtpParameters"
...
This reverts commit 806e06d1366b58878ced05cdd8d1d56394982fe6.
Reason for revert: Breaks WebRTC roll to Chromium. https://chromium-review.googlesource.com/c/chromium/src/+/1375538
02:52:35.346 7748 [6936:11248:1213/025234.206:ERROR:mediaengine.cc(80)] Attempted to set RtpParameters with modified codecPayloadType (INVALID_MODIFICATION)
Original change's description:
> Implement read-only codecPayloadType in RtpParameters
>
> Bug: webrtc:7580
> Change-Id: I6d901afa97262b6c6d9fe6c7366df465ec77bfb3
> Reviewed-on: https://webrtc-review.googlesource.com/c/113944
> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
> Reviewed-by: Seth Hampson <shampson@webrtc.org >
> Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Commit-Queue: Florent Castelli <orphis@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#25993}
TBR=steveanton@webrtc.org ,sakal@webrtc.org ,andersc@webrtc.org ,shampson@webrtc.org ,orphis@webrtc.org
Change-Id: I157f9a79ae7133395431891e15e2c053559d359b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:7580
Reviewed-on: https://webrtc-review.googlesource.com/c/114300
Reviewed-by: Henrik Grunell <henrikg@webrtc.org >
Commit-Queue: Henrik Grunell <henrikg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26000}
2018-12-13 12:13:30 +00:00
1dac6d8839
Sanitize candidates in ICE-level stats when necessary.
...
The address and the related address of local candidates are sanitized
accordingly when the mDNS concealment of local IPs is enabled. Also,
remote hostname candidates created from signaling are sanitized in stats
as well. A couple of unit tests are revised to reflect the desired
behavior of AsyncResolverInterface so that when a hostname candidate is
resolved, the hostname is kept in the candidate address.
Bug: webrtc:9605, chromium:914452
Change-Id: Iad9ad04ce4e50304e44cf04b15b97a7ae2dec960
Reviewed-on: https://webrtc-review.googlesource.com/c/113643
Reviewed-by: Qingsi Wang <qingsi@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Seth Hampson <shampson@webrtc.org >
Reviewed-by: Jeroen de Borst <jeroendb@webrtc.org >
Commit-Queue: Qingsi Wang <qingsi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25996}
2018-12-13 00:27:33 +00:00
806e06d136
Implement read-only codecPayloadType in RtpParameters
...
Bug: webrtc:7580
Change-Id: I6d901afa97262b6c6d9fe6c7366df465ec77bfb3
Reviewed-on: https://webrtc-review.googlesource.com/c/113944
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Seth Hampson <shampson@webrtc.org >
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25993}
2018-12-12 16:24:29 +00:00
f7f13e0742
Add end-to-end test for ColorSpace information
...
Bug: webrtc:8651
Change-Id: Ib7f6162c8dd41868b7d7acca8a6292b2d911c520
Reviewed-on: https://webrtc-review.googlesource.com/c/113941
Commit-Queue: Johannes Kron <kron@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25992}
2018-12-12 14:27:18 +00:00
c13f4be5f4
Add chroma siting to color space RTP extension
...
- Add chroma siting to color space RTP extension.
- Use 16 bits for max/min luminance.
- Change denominator of chromaticity and luminance.
- Add RTC_DCHECKs to protect against overflows.
Bug: webrtc:8651
Change-Id: If8b95bad6241381224eaba9c5bccce06a65a9195
Reviewed-on: https://webrtc-review.googlesource.com/c/113804
Commit-Queue: Johannes Kron <kron@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25990}
2018-12-12 13:13:15 +00:00
1d8307d706
Delete VideoCodec::targetBitrate
...
This member is unused by encoders.
Bug: None
Change-Id: I867013bfdb89f48782e84842de05bb57648e0b64
Reviewed-on: https://webrtc-review.googlesource.com/c/113882
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25988}
2018-12-12 12:48:15 +00:00
2701bc93df
Signals start rate when registering to TargetTransferRateObserver.
...
Bug: webrtc:10121
Change-Id: Ib608a98406d61225544d8b13bbcccb65c34e37f0
Reviewed-on: https://webrtc-review.googlesource.com/c/113814
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25983}
2018-12-12 09:22:32 +00:00
9d4fd55580
Make CONNECTION_WRITE_TIMEOUT configurable for ice connection
...
Bug: None
Change-Id: I0fd0616132705c6d15a77fc442be47080f1b81b1
Reviewed-on: https://webrtc-review.googlesource.com/c/112721
Reviewed-by: Qingsi Wang <qingsi@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25975}
2018-12-11 19:24:42 +00:00
6fe1fba7b1
Convert MediaSessionFactory to return unique_ptrs
...
Bug: None
Change-Id: Ia0dbe00fd063b083caad8598102236aa3bb3079d
Reviewed-on: https://webrtc-review.googlesource.com/c/113826
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Seth Hampson <shampson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25974}
2018-12-11 19:10:27 +00:00
01092957f5
Mark functions using old factory classes as deprecated.
...
The flag rtc_use_builtin_sw_codecs will be removed in a later CL and
this marks usage of the various entry points using the old video factory
API as deprecated.
Bug: webrtc:7925, webrtc:10044
Change-Id: I5c75516a41b0666e77539c028808cc2b173ed4bd
Reviewed-on: https://webrtc-review.googlesource.com/c/113061
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
Commit-Queue: Anders Carlsson <andersc@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25970}
2018-12-11 16:17:33 +00:00
ad858d1231
Improve the audio codec factory documentation.
...
Bug: none
Change-Id: Iefddb49d515bde0c8c5b7fb0d5c8dc79399b03a0
Reviewed-on: https://webrtc-review.googlesource.com/c/113802
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25969}
2018-12-11 15:50:29 +00:00
