612f858ba0
Adding test for SingleNalUnit mode
...
Test enables single-nalu mode, sets limit for nalu lenght and verifies
that encoder follows that limit.
I found that QP jumps significantly when the mode is enabled. In result
encoder might produce 4kbyte and 0.4kbyte frames back-to-back. But it
seems that happens only to couple of frames in the beginning. This
caused test to fail with default RC thresholds. To bypass this I
increased frame size mismatch threshold from 20 to 30%. This should be
Ok considering single-nalu mode is rare.
BUG=webrtc:8070
Review-Url: https://codereview.webrtc.org/3014623002
Cr-Commit-Position: refs/heads/master@{#20023}
2017-09-28 16:23:17 +00:00
a81403fd16
Calculate VP9 references to wrap at kPicIdLength instead of 16 bits.
...
Bug: webrtc:8293
Change-Id: Iedc09a10548c2112e99247a5845a02c1bd3e7b80
Reviewed-on: https://webrtc-review.googlesource.com/4200
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20017}
2017-09-28 13:53:38 +00:00
a82fcd0fc8
Remove unused mocks of process thread
...
Bug: None
Change-Id: Ib671c45ce46f45f2ce3ba59b6c041bf2466ca88a
Reviewed-on: https://webrtc-review.googlesource.com/4240
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20010}
2017-09-28 07:57:28 +00:00
638200e1eb
Add support for SW fallback decoder in VideoProcessor.
...
BUG=none
Change-Id: Ib144b377115a48d26ff053e3b4b43f5260aa9f84
Reviewed-on: https://webrtc-review.googlesource.com/3760
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#19999}
2017-09-27 12:51:26 +00:00
e19d8bfd5b
Modify some rate control and quality thresholds due to flakiness.
...
BUG=webrtc:8280
Review-Url: https://codereview.webrtc.org/3015683002
Cr-Commit-Position: refs/heads/master@{#19968}
2017-09-26 10:29:49 +00:00
dec82abab5
Disable flaky test VideoProcessorIntegrationTestMediaCodec.ForemanCif500kbpsVp8.
...
Test was Android-only, so it was disabled completely.
TBR=brandtr@webrtc.org
Bug: webrtc:8280
Change-Id: Id45eedac90fb892f5a380e5c2614037e01ee8c76
Reviewed-on: https://webrtc-review.googlesource.com/3460
Reviewed-by: Alex Loiko <aleloi@webrtc.org >
Commit-Queue: Alex Loiko <aleloi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#19954}
2017-09-25 16:25:03 +00:00
e21be1db4c
Reland of Fix the video buffer size should take rtt into consideration (patchset #2 id:160001 of https://codereview.chromium.org/3002033002/ )
...
Reason for revert:
Fixes has landed.
Original issue's description:
> Revert of Fix the video buffer size should take rtt into consideration (patchset #3 id:40001 of https://codereview.chromium.org/2980413002/ )
>
> Reason for revert:
> We are not certain this is the behavior we want.
>
> Original issue's description:
> > Fix the video buffer size should take rtt into consideration
> >
> > BUG=webrtc:8010
> >
> > Review-Url: https://codereview.webrtc.org/2980413002
> > Cr-Commit-Position: refs/heads/master@{#19285}
> > Committed: f1e08d0b58
>
> TBR=sprang@webrtc.org ,gustavogb@gmail.com
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=webrtc:8010
>
> Review-Url: https://codereview.webrtc.org/3002033002
> Cr-Commit-Position: refs/heads/master@{#19442}
> Committed: bdbc8895f3
TBR=sprang@webrtc.org ,gustavogb@gmail.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:8010
Review-Url: https://codereview.webrtc.org/3016633002
Cr-Commit-Position: refs/heads/master@{#19944}
2017-09-25 13:37:12 +00:00
2c30120fac
Revert of Add full stack tests for MediaCodec. (patchset #10 id:180001 of https://codereview.webrtc.org/3005253002/ )
...
Reason for revert:
Breaks KitKat/Lollipop perf bots.
Original issue's description:
> Add full stack tests for MediaCodec encoder.
>
> * Add audio_ prefix to CallTest::{en,de}coder_factory_.
> * Let VideoQualityTest only instantiate encoders using encoder factories.
> * Add HW encoder factories to VideoQualityTest.
> * Add full stack tests:
> - sqcif7 at 30 kbps: MediaCodec and libvpx.
> - 240p10 at 100 kbps: MediaCodec, libvpx, and MediaCodec+libvpx.
>
> BUG=webrtc:8219
>
> Review-Url: https://codereview.webrtc.org/3005253002
> Cr-Commit-Position: refs/heads/master@{#19923}
> Committed: https://webrtc.googlesource.com/src/+/2cefac6c1685abfcd7b90fdef8e926f1c2b79bfa
TBR=sprang@webrtc.org ,asapersson@webrtc.org ,kjellander@webrtc.org ,stefan@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:8219
Review-Url: https://codereview.webrtc.org/3016593002
Cr-Commit-Position: refs/heads/master@{#19926}
2017-09-22 11:30:08 +00:00
55c7eded94
VideoProcessorIntegrationTest: Group member variables into two structs containing target/actual rates.
...
- Group member variables into two structs: target rates/actual rates.
- Split verify and print of rate control metrics into separate functions.
- Rename member variables.
BUG=webrtc:6634
Review-Url: https://codereview.webrtc.org/3009423002
Cr-Commit-Position: refs/heads/master@{#19925}
2017-09-22 10:45:15 +00:00
2cefac6c16
Add full stack tests for MediaCodec encoder.
...
* Add audio_ prefix to CallTest::{en,de}coder_factory_.
* Let VideoQualityTest only instantiate encoders using encoder factories.
* Add HW encoder factories to VideoQualityTest.
* Add full stack tests:
- sqcif7 at 30 kbps: MediaCodec and libvpx.
- 240p10 at 100 kbps: MediaCodec, libvpx, and MediaCodec+libvpx.
BUG=webrtc:8219
Review-Url: https://codereview.webrtc.org/3005253002
Cr-Commit-Position: refs/heads/master@{#19923}
2017-09-22 07:46:25 +00:00
cb728ea83a
Fix Gn Untracked headers in webrtc/modules/video_coding.
...
Fixed following headers in this CL
===================================
src/webrtc/modules/video_coding/sequence_number_util.h
src/webrtc/modules/video_coding/codecs/interface/common_constants.h
src/webrtc/modules/video_coding/codecs/interface/mock/mock_video_codec_interface.h
src/webrtc/modules/video_coding/codecs/vp8/include/vp8_globals.h
src/webrtc/modules/video_coding/codecs/vp9/include/vp9_globals.h
src/webrtc/modules/video_coding/codecs/h264/include/h264_globals.h
src/webrtc/modules/video_coding/utility/mock/mock_frame_dropper.h
src/webrtc/modules/video_coding/test/test_util.h
src/webrtc/modules/video_coding/codecs/interface/video_error_codes.h
src/webrtc/modules/video_coding/codecs/interface/video_codec_interface.h
src/webrtc/modules/video_coding/include/mock/mock_video_codec_interface.h
Remaining:
===========
src/webrtc/modules/video_coding/include/video_codec_interface.h
src/webrtc/modules/video_coding/include/video_error_codes.h
BUG=webrtc:7620
Review-Url: https://codereview.webrtc.org/3012323002
Cr-Commit-Position: refs/heads/master@{#19886}
2017-09-18 10:08:08 +00:00
7120742701
Adding NOLINT for typedefs.h and common_types.h
...
Now that we have moved WebRTC from src/webrtc to src/, common_types.h
and typedefs.h are triggering a cpplint error.
The cpplint complaint is:
Include the directory when naming .h files [build/include] [4]
This CL disables the error but we have to remove these two headers
from the root directory.
NOPRESUBMIT=true
Bug: webrtc:5876
Change-Id: I08e1b69aadcc4b28ab83bf25e3819d135d41d333
Reviewed-on: https://webrtc-review.googlesource.com/1577
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Henrik Kjellander <kjellander@google.com >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#19859}
2017-09-15 13:03:51 +00:00
92ea95e34a
Fixing WebRTC after moving from src/webrtc to src/
...
In https://webrtc-review.googlesource.com/c/src/+/1560 we moved WebRTC
from src/webrtc to src/ (in order to preserve an healthy git history).
This CL takes care of fixing header guards, #include paths, etc...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=tommi@webrtc.org
Bug: chromium:611808
Change-Id: Iea91618212bee0af16aa3f05071eab8f93706578
Reviewed-on: https://webrtc-review.googlesource.com/1561
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#19846}
2017-09-15 05:02:56 +00:00
bb547203bf
Moving src/webrtc into src/.
...
In order to eliminate the WebRTC Subtree mirror in Chromium,
WebRTC is moving the content of the src/webrtc directory up
to the src/ directory.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=tommi@webrtc.org
Bug: chromium:611808
Change-Id: Iac59c5b51b950f174119565bac87955a7994bc38
Reviewed-on: https://webrtc-review.googlesource.com/1560
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#19845}
2017-09-15 04:25:06 +00:00
5adc73aad3
git-svn-id: http://webrtc.googlecode.com/svn/trunk@166 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-07 08:46:41 +00:00
f0a476bf76
Add PictureID and NonReference to codec information
...
The PictureID and NonReference information is now routed from the
encoder to the RTP packetizer through CodecSpecificInfo and
RTPVideoHeaderVP8.
Review URL: http://webrtc-codereview.appspot.com/51003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@155 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-07 08:04:23 +00:00
cdc943e2d5
VCM: 1. Updating handling of empty packets. 2. Updating JB test. 3. Removing un-used code.
...
Review URL: http://webrtc-codereview.appspot.com/59001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@142 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-01 18:15:11 +00:00
c13708271a
Update media_opt_util with frame size parameters.
...
Review URL: http://webrtc-codereview.appspot.com/51002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@141 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-01 17:18:53 +00:00
6b04739e04
Route CodecSpecificInfo from encoder to packetizer
...
Making a long chain of interface changes to route a CodecSpecificInfo
struct from the video encoder function to the RTPSenderVideo. This
will be used to convey information needed by the RTP packetizer when
building the RTP headers.
Review URL: http://webrtc-codereview.appspot.com/56001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@140 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-01 08:32:57 +00:00
b5427cbd35
Changing JPEG API to to accept rawImage and encodedImage; moved video_image.h from modules/video_coding/codecs to common_video/interface, and some general re-write to JPEG, especially with regard to memory handling. Required VCM/ViE changes are also included.
...
Review URL: http://webrtc-codereview.appspot.com/55002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@139 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-01 01:17:49 +00:00
e02b57e397
Updates to qm_select: Function to update content state, and function for FEC rate adjustment.
...
Added packetLoss parameter to qm_select, and some code clean-up.
Review URL: http://webrtc-codereview.appspot.com/44009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@128 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-28 00:02:51 +00:00
3ad9c18843
Update on content metrics:
...
Added metrics averaged over intervals of the loss/bandwidth reports, to be used for adjustment of robustness settings. Separated this set
from the (global) metrics used for resolution adaptation.
Some code cleanup in content_metrics.cc/.h.
Review URL: http://webrtc-codereview.appspot.com/52002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@125 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-24 18:08:33 +00:00
0d7e5bc712
Fix bug on key frame boost allocation, and some update/cleanup to same function.
...
Review URL: http://webrtc-codereview.appspot.com/50001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@123 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-23 16:36:33 +00:00
2b83acef3e
VCM/JB: Setting only non-empty frames for decoding (when not waiting for NACK).
...
Review URL: http://webrtc-codereview.appspot.com/49001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@117 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-22 17:25:06 +00:00
868b857395
Remove a test case that only causes problems due to badly
...
synchronized test. The test is as useful without this test case.
Review URL: http://webrtc-codereview.appspot.com/47003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@115 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-22 08:37:54 +00:00
2f887323a0
Bugfix in VP8 wrapper Decode method
...
Failed to preserve the size parameter in the keyframe storage.
Review URL: http://webrtc-codereview.appspot.com/48003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@113 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-21 14:33:28 +00:00
717c869579
Review URL: http://webrtc-codereview.appspot.com/48001
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@107 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-20 18:08:43 +00:00
b7a41937ba
Fixes missing initializations in video_coding.
...
Review URL: http://webrtc-codereview.appspot.com/43004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@104 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-20 14:43:51 +00:00
ab0cfe66a9
VP8 wrapper: Adding an IFDEF prior to new interface. This will allow the wrapper to build with the Bali release.
...
Review URL: http://webrtc-codereview.appspot.com/47001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@99 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-20 05:28:08 +00:00
3a321fca39
Updating VP8 wrapper with RC parameters
...
Review URL: http://webrtc-codereview.appspot.com/44001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@97 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-17 19:17:40 +00:00
e25b0148c9
Clean up of media_opt_util.cc
...
Review URL: http://webrtc-codereview.appspot.com/33007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@92 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-16 16:11:33 +00:00
7925dd575f
Added comments and an assert explaining that NACK hasn't been fully
...
implemented in the mt_rx_tx_test.
Review URL: http://webrtc-codereview.appspot.com/25018
git-svn-id: http://webrtc.googlecode.com/svn/trunk@79 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-15 07:37:23 +00:00
51f2453d98
Fixed a Flush/Start initialization bug in the jitter buffer. Also cleaned
...
up "Nack estimate".
Review URL: http://webrtc-codereview.appspot.com/32009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@78 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-15 07:37:08 +00:00
17705a9c5a
Review URL: http://webrtc-codereview.appspot.com/28004
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@74 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-14 17:54:20 +00:00
e01b865616
Implement Copy method for VP8 decoder
...
Use get/set reference frames to realize a decoder cloning. Must
also inject the latest keyframe. Note: this CL does not work with
the Bali release of libvpx. Must apply the bug fix in commit fbea3728.
Review URL: http://webrtc-codereview.appspot.com/32004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@67 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-13 07:02:25 +00:00
fea5f7e30e
Review URL: http://webrtc-codereview.appspot.com/34004
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@59 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-08 16:48:01 +00:00
9e7644c20c
Change implementation of Reset function in VP8 wrapper
...
The Reset function was modified so that the encoder is destroyed
and recreated on reset. Initialization of the encoder and setting
of the encoder speed is now done in a private method, to avoid
code duplication. (It is used both in InitEncode and in Reset.)
This change is needed to make the unit tests pass with newer
versions of libvpx.
Review URL: http://webrtc-codereview.appspot.com/33004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@56 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-08 07:02:33 +00:00
0b0c28c495
add android makefile, some modification in vpx makefile to build encoder from c source for now
...
Review URL: http://webrtc-codereview.appspot.com/29012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@50 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-07 17:24:39 +00:00
77ae29bc81
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-05-30 11:22:19 +00:00