286ee0123e
Revert "Add transaction id to CandidatePairEvents."
...
This reverts commit c308bdfa451ee2ceac7096b6777fcbf756f4091a.
Reason for revert: The msan bot has been consistently failing since this commit. See eg https://ci.chromium.org/p/webrtc/builders/luci.webrtc.ci/Linux%20MSan/16989
Original change's description:
> Add transaction id to CandidatePairEvents.
>
> The transaction id is a randomly generated number used to link stun
> requests and responses (https://tools.ietf.org/html/rfc5389#section-6 ).
> Logging this will help us debug ICE network issues.
>
> Bug: webrtc:9972
> Change-Id: I93167cb119aad99156e8727b6e4eeeff5198f924
> Reviewed-on: https://webrtc-review.googlesource.com/c/109720
> Commit-Queue: Zach Stein <zstein@webrtc.org >
> Reviewed-by: Qingsi Wang <qingsi@webrtc.org >
> Reviewed-by: Elad Alon <eladalon@webrtc.org >
> Reviewed-by: Björn Terelius <terelius@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#25848}
TBR=eladalon@webrtc.org ,terelius@webrtc.org ,zstein@webrtc.org ,qingsi@webrtc.org ,jeroendb@webrtc.org
Change-Id: Ib3b0a845f2300f4fcba2061650e17522735f08b3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9972
Reviewed-on: https://webrtc-review.googlesource.com/c/112581
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25852}
2018-11-30 09:28:25 +00:00
c308bdfa45
Add transaction id to CandidatePairEvents.
...
The transaction id is a randomly generated number used to link stun
requests and responses (https://tools.ietf.org/html/rfc5389#section-6 ).
Logging this will help us debug ICE network issues.
Bug: webrtc:9972
Change-Id: I93167cb119aad99156e8727b6e4eeeff5198f924
Reviewed-on: https://webrtc-review.googlesource.com/c/109720
Commit-Queue: Zach Stein <zstein@webrtc.org >
Reviewed-by: Qingsi Wang <qingsi@webrtc.org >
Reviewed-by: Elad Alon <eladalon@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25848}
2018-11-29 22:52:35 +00:00
918f50c5d1
Use absl::make_unique and absl::WrapUnique directly
...
Instead of going through our wrappers in ptr_util.h.
This CL was generated by the following script:
git grep -l ptr_util | xargs perl -pi -e 's,#include "rtc_base/ptr_util.h",#include "absl/memory/memory.h",'
git grep -l MakeUnique | xargs perl -pi -e 's,\b(rtc::)?MakeUnique\b,absl::make_unique,g'
git grep -l WrapUnique | xargs perl -pi -e 's,\b(rtc::)?WrapUnique\b,absl::WrapUnique,g'
git checkout -- rtc_base/ptr_util{.h,_unittest.cc}
git cl format
Followed by manually adding dependencies on
//third_party/abseil-cpp/absl/memory until `gn check` stopped
complaining.
Bug: webrtc:9473
Change-Id: I89ccd363f070479b8c431eb2c3d404a46eaacc1c
Reviewed-on: https://webrtc-review.googlesource.com/86600
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#23850}
2018-07-05 10:59:49 +00:00
59b4e3ea8c
Split IceCandidatePairEventType enum.
...
Disjoint subsets of the enum values are used for Ice candidate config
events and Ice candidate check events. This CL breaks out the config
part to a separate enum and by extension changes the icelogger interface
for config events.
Bug: webrtc:9336, webrtc:8111
Change-Id: I405b5c3981905c3c504b45afdddb3649469ed141
Reviewed-on: https://webrtc-review.googlesource.com/79943
Reviewed-by: Qingsi Wang <qingsi@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#23464}
2018-05-31 08:42:10 +00:00
8eca1ff510
Reland "Structured ICE logging via RtcEventLog."
...
This is a reland of eed5aa8904d09179971d3f4e7e10c109d7c62bfc
Original change's description:
> Structured ICE logging via RtcEventLog.
>
> This change list contains the structured logging module for ICE using
> the RtcEventLog infrastructure, and also extension to the log parser
> and analyzer.
>
> Bug: None
> Change-Id: I6539cf282155c2cde4d3161c53500c0746671a02
> Reviewed-on: https://webrtc-review.googlesource.com/34622
> Commit-Queue: Qingsi Wang <qingsi@google.com >
> Reviewed-by: Björn Terelius <terelius@webrtc.org >
> Reviewed-by: Peter Thatcher <pthatcher@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#21816}
TBR=pthatcher@webrtc.org ,terelius@webrtc.org ,deadbeef@webrtc.org
Bug: None
Change-Id: I3df585bf636315ceb0273967146111346a83be86
Reviewed-on: https://webrtc-review.googlesource.com/47545
Commit-Queue: Qingsi Wang <qingsi@google.com >
Reviewed-by: Qingsi Wang <qingsi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#21881}
2018-02-02 22:05:27 +00:00
78ac89b82f
Revert "Structured ICE logging via RtcEventLog."
...
This reverts commit eed5aa8904d09179971d3f4e7e10c109d7c62bfc.
Reason for revert: breaks downstream projects.
Original change's description:
> Structured ICE logging via RtcEventLog.
>
> This change list contains the structured logging module for ICE using
> the RtcEventLog infrastructure, and also extension to the log parser and
> analyzer.
>
> Bug: None
> Change-Id: I6539cf282155c2cde4d3161c53500c0746671a02
> Reviewed-on: https://webrtc-review.googlesource.com/34622
> Commit-Queue: Qingsi Wang <qingsi@google.com >
> Reviewed-by: Björn Terelius <terelius@webrtc.org >
> Reviewed-by: Peter Thatcher <pthatcher@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#21816}
TBR=phoglund@webrtc.org ,deadbeef@webrtc.org ,terelius@webrtc.org ,stefan@webrtc.org ,pthatcher@webrtc.org ,qingsi@google.com
Change-Id: I62d5807c636e442bec4ad1b1fdc4380102347be3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/46580
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#21822}
2018-01-31 09:38:41 +00:00
eed5aa8904
Structured ICE logging via RtcEventLog.
...
This change list contains the structured logging module for ICE using
the RtcEventLog infrastructure, and also extension to the log parser and
analyzer.
Bug: None
Change-Id: I6539cf282155c2cde4d3161c53500c0746671a02
Reviewed-on: https://webrtc-review.googlesource.com/34622
Commit-Queue: Qingsi Wang <qingsi@google.com >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Peter Thatcher <pthatcher@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#21816}
2018-01-31 02:18:39 +00:00
