Commit Graph

31445 Commits

Author SHA1 Message Date
007271fdd1 Delete obsolete TODO item
Tbr: mbonadei@webrtc.org
Bug: webrtc:10198, webrtc:9719
Change-Id: I2b4dba285ef191b0e97069e789d6c8f0524156eb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179481
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31741}
2020-07-16 10:27:30 +00:00
fca30875b6 Do not use internal source in video send stream tests.
Unless testing a behavior specific to video encoders with internal source.

Bug: None
Change-Id: Ia42177f2a0b7e658060208444870a7466c6779dd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179362
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Mirta Dvornicic <mirtad@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31740}
2020-07-16 09:42:47 +00:00
e51d6ac5d2 Fix override declarations and delete related TODOs
Bug: webrtc:10198, chromium:428099
Change-Id: Ic7b0dd3c58c3daa5ade4d2c503b77a51b29c716e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179380
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31739}
2020-07-16 07:42:02 +00:00
e43648a36e Add constrained high profile level for h264 codec to media_constants
Bug: None
Change-Id: I7b21d21744c9e12e38fde884b409a5c88d0802a4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179369
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Andrey Logvin <landrey@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31738}
2020-07-16 06:55:11 +00:00
c8c01f367b Roll chromium_revision 4b7890cdbe..f831fc29d7 (788759:788907)
Change log: 4b7890cdbe..f831fc29d7
Full diff: 4b7890cdbe..f831fc29d7

Changed dependencies
* src/base: ec68b2fa89..475d373720
* src/build: ad87d7f5d5..a96f2005a3
* src/ios: 2d7a9c2ef7..b50360f55b
* src/testing: 64f4ad1d7c..29ce189579
* src/third_party: 390aec887d..b36324caf7
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/f4db4dad69..0ea0cd5102
* src/third_party/depot_tools: 9d9199a509..5fcb48536c
* src/third_party/nasm: 4fa54ca5f7..19f3fad68d
* src/third_party/perfetto: 1a82e68482..c63cdce64c
* src/tools: f4f7f17aef..a28935f3fb
DEPS diff: 4b7890cdbe..f831fc29d7/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I5a147a483a6e21a8ce2630cbae80ae24e7515bed
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179442
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31737}
2020-07-16 04:46:01 +00:00
4c7bb27a10 Remove rtc::GlobalLock.
This change migrates a last stray consumer of GlobalLock
(SrtpSession) and removes all traces of GlobalLock/GlobalLockScope
from WebRTC.

Bug: webrtc:11567
Change-Id: I28059f2a10075815a4bdee8c357b9d3b6e50f18b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179361
Commit-Queue: Tommi <tommi@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31736}
2020-07-15 20:45:13 +00:00
e7e17d3e4c Roll chromium_revision bc87af3aed..4b7890cdbe (788656:788759)
Change log: bc87af3aed..4b7890cdbe
Full diff: bc87af3aed..4b7890cdbe

Changed dependencies
* src/base: e73e795a0a..ec68b2fa89
* src/build: 883c11fd88..ad87d7f5d5
* src/ios: 2081957477..2d7a9c2ef7
* src/testing: b18bbe77fd..64f4ad1d7c
* src/third_party: 520ed65d62..390aec887d
* src/third_party/perfetto: 73b607f9e3..1a82e68482
* src/tools: 39d9a5965a..f4f7f17aef
DEPS diff: bc87af3aed..4b7890cdbe/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I7fee3e3b1d8021b4b8fb14fb36150b234f85a824
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179345
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31735}
2020-07-15 20:43:08 +00:00
c2f113b3d7 Trigger CI bots.
Testing that iOS chromium.webrtc.fyi bots are fixed.

TBR=jleconte@webrtc.org

No-Try: True
Bug: None
Change-Id: Ia8b09301f6edcc9a7ff8cd131d1246f9e7f24965
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179381
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31734}
2020-07-15 17:50:55 +00:00
c179575648 Roll chromium_revision a29ceb7864..bc87af3aed (788510:788656)
Change log: a29ceb7864..bc87af3aed
Full diff: a29ceb7864..bc87af3aed

Changed dependencies
* src/base: 33ee6f93b1..e73e795a0a
* src/build: f7d7f7a066..883c11fd88
* src/ios: 5c133bfb8c..2081957477
* src/third_party: 38ab389587..520ed65d62
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/49d9f039e2..f4db4dad69
* src/third_party/freetype/src: 5fe7c044c2..b7c467b6ef
* src/third_party/perfetto: 55ef680dab..73b607f9e3
* src/tools: 6e92bc387b..39d9a5965a
DEPS diff: a29ceb7864..bc87af3aed/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I6203ac208ce1c77e41deeec3bd20d25a888bcb47
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179400
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31733}
2020-07-15 16:40:25 +00:00
0dd35d3732 Migrate to webrtc::GlobalMutex.
Bug: webrtc:11567
Change-Id: I853434745c427e54474739e9c573e0f6f4fcedef
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179283
Commit-Queue: Markus Handell <handellm@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31732}
2020-07-15 10:32:20 +00:00
a13e7a1d46 Add factory to create scalability structures by name
according to webrtc-svc spec draft

Bug: webrtc:11404
Change-Id: I318b8a1a5c5389f6e5d15c3dd7d93041459e37f9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178603
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31731}
2020-07-15 10:26:40 +00:00
97910da4e1 Do not use internal source in H.264 bitstream rewriting tests.
Bug: None
Change-Id: Ice1ffb4371ade57bd642f5fe86d6432f2c175d71
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179281
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Mirta Dvornicic <mirtad@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31730}
2020-07-15 09:27:03 +00:00
c6801d4522 sdp: parse and serialize b=TIAS
BUG=webrtc:5788

Change-Id: I063c756004e4c224fffa36d2800603c7b7e50dce
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179223
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Reviewed-by: Taylor <deadbeef@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31729}
2020-07-15 08:01:06 +00:00
9ad1f6feca Reland "Delete PeerConnectionInterface::BitrateParameters"
This is a reland of e2dfe74b0e29558ddea6473d0272bc38c838370c
Downstream breakage has been fixed.

Original change's description:
> Delete PeerConnectionInterface::BitrateParameters
>
> Replaced by the api struct BitrateSettings, added in
> https://webrtc-review.googlesource.com/74020
>
> Bug: None
> Change-Id: I8b50b32f5c7a8918fad675904d913a21fd905274
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/177665
> Commit-Queue: Niels Moller <nisse@webrtc.org>
> Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Reviewed-by: Taylor <deadbeef@webrtc.org>
> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31714}

Tbr: kwiberg@webrtc.org
Bug: None
Change-Id: Ic039e51f9f842329525887a28d1cb9819addc74b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179282
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31728}
2020-07-15 07:35:16 +00:00
c888ffa57f Delete CompositeDataChannelTransport
And delete the always null members data_channel_transport_ and
composite_data_channel_transport_ from the JsepTransport class.

Bug: webrtc:9719
Change-Id: Ibfd92b74708d63a75521f6f1d5fbc3830bd67e20
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179280
Reviewed-by: Taylor <deadbeef@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31727}
2020-07-15 06:54:06 +00:00
121f32c94a Roll chromium_revision 812a4946f7..a29ceb7864 (788405:788510)
Change log: 812a4946f7..a29ceb7864
Full diff: 812a4946f7..a29ceb7864

Changed dependencies
* src/base: 5f695d7378..33ee6f93b1
* src/build: 7a85719da2..f7d7f7a066
* src/ios: 068ad6af17..5c133bfb8c
* src/testing: 5990dd50d8..b18bbe77fd
* src/third_party: 198ff7b877..38ab389587
* src/third_party/depot_tools: fad2090a5e..9d9199a509
* src/tools: ec6df7875f..6e92bc387b
DEPS diff: 812a4946f7..a29ceb7864/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ibc650d4118561ef09a1416c5ae00806f9a356575
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179269
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31726}
2020-07-15 06:46:51 +00:00
77ca290aba Roll chromium_revision 20d0aa1d03..812a4946f7 (788294:788405)
Change log: 20d0aa1d03..812a4946f7
Full diff: 20d0aa1d03..812a4946f7

Changed dependencies
* src/base: 83eb350cd4..5f695d7378
* src/build: 7fadfd7ab3..7a85719da2
* src/ios: 0d895c45d7..068ad6af17
* src/testing: 23c858bc28..5990dd50d8
* src/third_party: 4fdb78f9b6..198ff7b877
* src/third_party/depot_tools: 68978076fd..fad2090a5e
* src/third_party/perfetto: c73e6969fb..55ef680dab
* src/tools: 9384b86ab7..ec6df7875f
DEPS diff: 20d0aa1d03..812a4946f7/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ied3f4b775ae57a9c17edef2ebd483932599f2558
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179300
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31725}
2020-07-15 01:28:39 +00:00
26d41f2fe6 Roll chromium_revision 3e578a0ddf..20d0aa1d03 (787863:788294)
Change log: 3e578a0ddf..20d0aa1d03
Full diff: 3e578a0ddf..20d0aa1d03

Changed dependencies
* src/base: 58be4be205..83eb350cd4
* src/build: 9e0406939e..7fadfd7ab3
* src/ios: 9ea7e555b7..0d895c45d7
* src/testing: 99f302a3dd..23c858bc28
* src/third_party: 75e5acda2a..4fdb78f9b6
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c4187c19b8..49d9f039e2
* src/third_party/depot_tools: 271a78ac35..68978076fd
* src/third_party/freetype/src: c922ffa5d2..5fe7c044c2
* src/third_party/perfetto: 85cf057d6c..c73e6969fb
* src/tools: 462ec10617..9384b86ab7
DEPS diff: 3e578a0ddf..20d0aa1d03/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I8e40f78adef56cb43644d78b30b64439cf479000
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179266
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31724}
2020-07-14 21:20:37 +00:00
80d2159ff4 Use Android Q API to test if MediaCodecInfo is HW Accelerated
Also, add the prefix of SW Codecs in Codec2.0.

Bug: None
Change-Id: Ifc7a079a68506975cd9e52ddaf6da69744ac0614
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/177800
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31723}
2020-07-14 08:57:52 +00:00
84bb634238 Delete legacy cricket::RtpHeaderExtension struct as unused
Bug: None
Change-Id: I8529475578a91173ca2e89e0bbbf186fc9d39472
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179222
Reviewed-by: Taylor <deadbeef@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31722}
2020-07-14 08:55:02 +00:00
47f87abccb Roll chromium_revision 432e660d6d..3e578a0ddf (787714:787863)
Change log: 432e660d6d..3e578a0ddf
Full diff: 432e660d6d..3e578a0ddf

Changed dependencies
* src/base: f0eb30876d..58be4be205
* src/build: 67bfb6e074..9e0406939e
* src/ios: 7b3dd6953a..9ea7e555b7
* src/third_party: 0cbb97ee80..75e5acda2a
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/570934c3da..c4187c19b8
* src/third_party/freetype/src: b1286b32a9..c922ffa5d2
* src/third_party/perfetto: 7d22cca0b4..85cf057d6c
* src/tools: d1d0f247b2..462ec10617
DEPS diff: 432e660d6d..3e578a0ddf/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I088e43163cee9069f39b3c5c4040c7839a613b74
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179242
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31721}
2020-07-14 07:55:27 +00:00
c7c412a36c Check for null before accessing SctpTransport map.
Bug: chromium:1104061
Change-Id: I52d44ff1603341777a873e747c625665bc11bfa5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179161
Commit-Queue: Taylor <deadbeef@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31720}
2020-07-13 19:46:30 +00:00
f60d4c2dfe Revert "Delete PeerConnectionInterface::BitrateParameters"
This reverts commit e2dfe74b0e29558ddea6473d0272bc38c838370c.

Reason for revert: Breaks downstream project

Original change's description:
> Delete PeerConnectionInterface::BitrateParameters
> 
> Replaced by the api struct BitrateSettings, added in
> https://webrtc-review.googlesource.com/74020
> 
> Bug: None
> Change-Id: I8b50b32f5c7a8918fad675904d913a21fd905274
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/177665
> Commit-Queue: Niels Moller <nisse@webrtc.org>
> Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Reviewed-by: Taylor <deadbeef@webrtc.org>
> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31714}

TBR=deadbeef@webrtc.org,ilnik@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org,kthelgason@webrtc.org

Change-Id: Ia62b3c43996e95668d7972882baf06a186a539d3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179221
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31719}
2020-07-13 15:41:39 +00:00
6e4416cd89 Roll chromium_revision f629a87d19..432e660d6d (787611:787714)
Change log: f629a87d19..432e660d6d
Full diff: f629a87d19..432e660d6d

Changed dependencies
* src/base: abd5405c28..f0eb30876d
* src/build: 9d828da174..67bfb6e074
* src/ios: 189676fa6d..7b3dd6953a
* src/third_party: 05a05f9845..0cbb97ee80
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/88e5b1f40c..570934c3da
* src/third_party/perfetto: 6ef441ecad..7d22cca0b4
* src/tools: 84642d7d96..d1d0f247b2
DEPS diff: f629a87d19..432e660d6d/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ifa6015f45820588096a09b7031b9a0109b978f3d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179200
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31718}
2020-07-13 14:36:26 +00:00
4ab7ddeb9f Migrate stray leftovers from rtc_base/ and test/ to webrtc::Mutex.
Migrates cases found from manual inspection of the code.

Bug: webrtc:11567
Change-Id: Ie8866435f3d3ca325e0811bf7cfb7e388ec987d4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179067
Reviewed-by: Tommi <tommi@webrtc.org>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31717}
2020-07-13 13:14:34 +00:00
4379a7db1f Reland "Migrate modules/desktop_capture and modules/video_capture to webrtc::Mutex."
This is a reland of 44dd3d743517fe85212ba4f68bda1e78c2e6d7ec

Original change's description:
> Migrate modules/desktop_capture and modules/video_capture to webrtc::Mutex.
> 
> Bug: webrtc:11567
> Change-Id: I7bfca17f91bf44151148f863480ce77804d53a04
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178805
> Commit-Queue: Markus Handell <handellm@webrtc.org>
> Reviewed-by: Tommi <tommi@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31681}

Bug: webrtc:11567
Change-Id: I03a32cb7194cffb9e678355c4af4d370b39384b3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179093
Reviewed-by: Tommi <tommi@webrtc.org>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31716}
2020-07-13 12:22:08 +00:00
30c8eaa1dc Add CPEPrefix.
This will enable automatic notifications of CVEs reported against
WebRTC such that we ensure we roll them into Chromium.

Bug: chromium:895969
Change-Id: Ib2f9e9a55b2fc2605dd8bbbc3774b91dee9a00b7
NoTry: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178404
Reviewed-by: Tommi <tommi@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31715}
2020-07-13 11:42:07 +00:00
e2dfe74b0e Delete PeerConnectionInterface::BitrateParameters
Replaced by the api struct BitrateSettings, added in
https://webrtc-review.googlesource.com/74020

Bug: None
Change-Id: I8b50b32f5c7a8918fad675904d913a21fd905274
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/177665
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Taylor <deadbeef@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31714}
2020-07-13 10:06:42 +00:00
48190984fb Auto roller: send trooper notifications only when Commit-Queue+2.
Change-Id: I54e430a1386bf49a155a9e3a2680509f403ac07b
Bug: webrtc:11781
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179092
Commit-Queue: Jeremy Leconte <jleconte@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31713}
2020-07-13 09:08:48 +00:00
21621e9d08 Delete obsolete method JsepTransport::NegotiateDatagramTransport
Left-over from https://webrtc-review.googlesource.com/c/src/+/176500.

Bug: webrtc:9719
Change-Id: I9e4c9e149756c0ff194a374c002e7d5ac022cfbd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178202
Reviewed-by: Taylor <deadbeef@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31712}
2020-07-13 08:52:58 +00:00
acc1123a80 Roll chromium_revision 598b095453..f629a87d19 (787511:787611)
Change log: 598b095453..f629a87d19
Full diff: 598b095453..f629a87d19

Changed dependencies
* src/base: fb172975a5..abd5405c28
* src/build: eca94691a0..9d828da174
* src/third_party: 0008680207..05a05f9845
* src/third_party/depot_tools: 0be4724e2f..271a78ac35
* src/tools: 2e25d4684d..84642d7d96
DEPS diff: 598b095453..f629a87d19/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I768f0891f781f758500d98ad91cb7d8c7c01875d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179189
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31711}
2020-07-13 02:52:43 +00:00
59f3c68a29 Inclusive language in DEPS.
TBR=tommi@webrtc.org

No-Try: True
Bug: webrtc:11680
Change-Id: I60c244b4597700722fddcf37b4f493f7dc300332
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179088
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31710}
2020-07-11 11:16:37 +00:00
35926d9c59 Revert "Test luci.notifier."
This reverts commit 8df59bc74ebb4d0b8e5d80a8b4f5c674db2a9c4d.

Reason for revert: Test completed.

Original change's description:
> Test luci.notifier.
> 
> This CL will be reverted as soon as we verify that the fix applied in
> https://webrtc-review.googlesource.com/c/src/+/179062 works.
> 
> Bug: None
> Change-Id: I1ef48f8e69d5592154b154de1700858aea4c32c4
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179063
> Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31703}

TBR=mbonadei@webrtc.org,jleconte@webrtc.org

Change-Id: If0d8b16ef92fd5b093ac3b8c22f04fb8e2822aa8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179087
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31709}
2020-07-11 10:05:11 +00:00
662918e3f0 Roll chromium_revision f0f2118569..598b095453 (787142:787511)
Change log: f0f2118569..598b095453
Full diff: f0f2118569..598b095453

Changed dependencies
* src/base: 16546fe468..fb172975a5
* src/build: 992194ef50..eca94691a0
* src/ios: 90035757d7..189676fa6d
* src/testing: 5c2a63f2d6..99f302a3dd
* src/third_party: 992830e84d..0008680207
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/e4221b4636..88e5b1f40c
* src/third_party/depot_tools: 9af33fa208..0be4724e2f
* src/third_party/ffmpeg: 15f6cfec63..d2dd36c035
* src/third_party/freetype/src: 96fb73efd5..b1286b32a9
* src/third_party/perfetto: af56531347..6ef441ecad
* src/tools: 5b541bb823..2e25d4684d
DEPS diff: f0f2118569..598b095453/DEPS

Clang version changed fb1aa286c1400ad7:04b9a46c842f793a2baedcad64de35fcbd3e93b7
Details: f0f2118569..598b095453/tools/clang/scripts/update.py

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I65178513449646a31b8a925f2080bcab37c1da21
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179149
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31708}
2020-07-11 09:09:47 +00:00
d3ec791f2d Reland "Test luci.notifier."
This is a reland of 8df59bc74ebb4d0b8e5d80a8b4f5c674db2a9c4d

Relanding as is for testing.

Original change's description:
> Test luci.notifier.
>
> This CL will be reverted as soon as we verify that the fix applied in
> https://webrtc-review.googlesource.com/c/src/+/179062 works.
>
> Bug: None
> Change-Id: I1ef48f8e69d5592154b154de1700858aea4c32c4
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179063
> Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31703}

TBR=jleconte@webrtc.org

No-Try: True
Bug: None
Change-Id: Ib83eeb57d41f20cdfd54271f59d22f932e3b96b3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179086
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31707}
2020-07-11 08:54:27 +00:00
2e978e3a8d Revert "Test luci.notifier."
This reverts commit 8df59bc74ebb4d0b8e5d80a8b4f5c674db2a9c4d.

Reason for revert: Let's turn the bot green and the try to turn it
read again since the notification comes only on status change.

Original change's description:
> Test luci.notifier.
> 
> This CL will be reverted as soon as we verify that the fix applied in
> https://webrtc-review.googlesource.com/c/src/+/179062 works.
> 
> Bug: None
> Change-Id: I1ef48f8e69d5592154b154de1700858aea4c32c4
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179063
> Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31703}

TBR=mbonadei@webrtc.org,jleconte@webrtc.org

Change-Id: I91e6debfbcb18bc840ca02a91ff736724ea9bbd1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179085
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31706}
2020-07-11 08:31:37 +00:00
bd393b29a5 Add target_sdk_version to rtc_test.
Starting fom crrev.com/c/2290319, the build system will start to
enforce the presence of target_sdk_version. This CL sets it to 23 to
keep the current behaviour.

TBR=titovartem@webrtc.org

Bug: None
Change-Id: If9b9d730c3899c4e6afbd6f08a56b5a73cf126a1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179084
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31705}
2020-07-11 08:25:04 +00:00
84a812e659 Check old_vector_size prior to copying in RTPFragmentationHeader::Resize
Bug: webrtc:11739
Change-Id: Ifafa0f8f00cc97e3a332b4f615fb828d89199d5b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178500
Commit-Queue: Tommi <tommi@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31704}
2020-07-10 17:35:53 +00:00
8df59bc74e Test luci.notifier.
This CL will be reverted as soon as we verify that the fix applied in
https://webrtc-review.googlesource.com/c/src/+/179062 works.

Bug: None
Change-Id: I1ef48f8e69d5592154b154de1700858aea4c32c4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179063
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31703}
2020-07-10 13:48:02 +00:00
1added5666 Revert "Migrate modules/desktop_capture and modules/video_capture to webrtc::Mutex."
This reverts commit 44dd3d743517fe85212ba4f68bda1e78c2e6d7ec.

Reason for revert: crbug.com/1104081

Original change's description:
> Migrate modules/desktop_capture and modules/video_capture to webrtc::Mutex.
> 
> Bug: webrtc:11567
> Change-Id: I7bfca17f91bf44151148f863480ce77804d53a04
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178805
> Commit-Queue: Markus Handell <handellm@webrtc.org>
> Reviewed-by: Tommi <tommi@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31681}

TBR=tommi@webrtc.org,handellm@webrtc.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: webrtc:11567
Change-Id: I4ee39947ba206522bce611341caef84ddb538068
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179080
Reviewed-by: Markus Handell <handellm@webrtc.org>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31702}
2020-07-10 13:43:22 +00:00
0800010dd6 peerconnection: remove old helper function
the TODO is obsolete, that code is only supported in plan-b mode and is a
one-liner.

BUG=webrtc:7600

Change-Id: I4e6c52c3a5b4cfff1b2d9185dedc786df9f474a4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179066
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/master@{#31701}
2020-07-10 12:35:59 +00:00
edacbd53de Reland "Implement packets_(sent | received) for RTCTransportStats"
This is a reland of fb6f975401972635a644c0db06c135b4c0aaef4a. Related
issue in chromium is fixed here:
https://chromium-review.googlesource.com/c/chromium/src/+/2287294

Original change's description:
> Implement packets_(sent | received) for RTCTransportStats
>
> Bug: webrtc:11756
> Change-Id: Ic0caad6d4675969ef3ae886f50326e4a2e1cbfe7
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178741
> Reviewed-by: Tommi <tommi@webrtc.org>
> Reviewed-by: Henrik Boström <hbos@webrtc.org>
> Commit-Queue: Artem Titov <titovartem@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31643}

Bug: webrtc:11756
Change-Id: I1e310e3d23248500eb7dabd23d0ce6c4ec4cb8c6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178871
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31700}
2020-07-10 11:50:59 +00:00
76ad2e0c05 Add jitter buffer delay metric to pc level tests
Bug: webrtc:11701
Change-Id: I45db3d179150dbad87e1b85a91d9d11feed1cb89
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179065
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Andrey Logvin <landrey@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31699}
2020-07-10 11:30:39 +00:00
265931ea3c Migrate VideoStreamDecoderImpl to webrtc::Mutex.
Bug: webrtc:11567
Change-Id: Ie5ae7aa630f1c702634cf6663853114b4e0f9d9b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179064
Reviewed-by: Magnus Flodman <mflodman@webrtc.org>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31698}
2020-07-10 11:02:28 +00:00
bc633d714d Roll chromium_revision a69b9c614c..f0f2118569 (786202:787142)
Change log: a69b9c614c..f0f2118569
Full diff: a69b9c614c..f0f2118569

Changed dependencies
* src/base: 9183ce544b..16546fe468
* src/build: 18e5f25087..992194ef50
* src/ios: 2ea69251b8..90035757d7
* src/testing: 778d425fe0..5c2a63f2d6
* src/third_party: 5d8b539958..992830e84d
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/430a742303..eda849d2e6
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/7cbda52a2d..e4221b4636
* src/third_party/depot_tools: e62496bafc..9af33fa208
* src/third_party/freetype/src: 0f35b042e0..96fb73efd5
* src/third_party/perfetto: faef2531ec..af56531347
* src/tools: af8d53c7e3..5b541bb823
DEPS diff: a69b9c614c..f0f2118569/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I075e13fb84c0c487f49f4cb8fdeb02579083f2ab
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179021
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31697}
2020-07-10 10:39:08 +00:00
4e5bc9f081 Reland "Complete migration from "track" to "inbound-rtp" stats"
This is a reland of 94fe0d3de5e8162d1a105fd1a3ec4bd2da97f43b with a fix.

Original change's description:
> Complete migration from "track" to "inbound-rtp" stats
>
> Bug: webrtc:11683
> Change-Id: I4c4a4fa0a7d6a20976922aca41d57540aa27fd1d
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178611
> Reviewed-by: Henrik Boström <hbos@webrtc.org>
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Commit-Queue: Eldar Rello <elrello@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#31683}

Bug: webrtc:11683
Change-Id: I173b91625174051c02ff34127aaf6c086d3c5c66
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179060
Commit-Queue: Eldar Rello <elrello@microsoft.com>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31696}
2020-07-10 10:17:50 +00:00
5e9874264c Add missing dependencies to java targets.
Starting from http://crrev.com/c/2289614, transitive dependencies are
not allowed anymore for java targts. This CL prepares WebRTC for the
next Chromium Roll.

Bug: None
Change-Id: I2aafa7be66c215b70d79e0f95272233fe7b37d3a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179061
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31695}
2020-07-10 09:17:00 +00:00
f7303e6486 Migrate leftovers in media/ and modules/ to webrtc::Mutex.
Bug: webrtc:11567
Change-Id: Id40a53fcec6cba1cd5af70422291ba46b0a6da8c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178905
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Magnus Flodman <mflodman@webrtc.org>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31694}
2020-07-10 08:27:45 +00:00
85585f4a52 Migrate rtc_tools/, sdk/, and system_wrappers/ to webrtc::Mutex.
Bug: webrtc:11567
Change-Id: Ia85cf457ac16ebec0a70d319506415e4dec46f30
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178903
Reviewed-by: Magnus Flodman <mflodman@webrtc.org>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31693}
2020-07-10 08:02:05 +00:00
e6f3897945 Revert "Complete migration from "track" to "inbound-rtp" stats"
This reverts commit 94fe0d3de5e8162d1a105fd1a3ec4bd2da97f43b.

Reason for revert:
Causes an assert in this line during a call:
https://source.chromium.org/chromium/chromium/src/+/master:third_party/webrtc/sdk/objc/api/peerconnection/RTCStatisticsReport.mm;drc=87a6e5ab4d8f0baf4e2a9b7752b43d825f9c0ce1;l=122?originalUrl=https:%2F%2Fcs.chromium.org%2F

where frameWidth appears more than once

Original change's description:
> Complete migration from "track" to "inbound-rtp" stats
> 
> Bug: webrtc:11683
> Change-Id: I4c4a4fa0a7d6a20976922aca41d57540aa27fd1d
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178611
> Reviewed-by: Henrik Boström <hbos@webrtc.org>
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Commit-Queue: Eldar Rello <elrello@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#31683}

TBR=hbos@webrtc.org,hta@webrtc.org,elrello@microsoft.com

Change-Id: I0ded36a40c8808dac5a777ed41815e52ab9a2573
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:11683
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179020
Reviewed-by: Zeke Chin <tkchin@webrtc.org>
Commit-Queue: Zeke Chin <tkchin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31692}
2020-07-10 00:06:53 +00:00