aaf9d051c7
Lower hd av1 quality threshold
...
Bug: None
Change-Id: I2b7bfbd8f5a2be13ede11df30272e5b001471453
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/255021
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36180}
2022-03-11 20:54:03 +00:00
fef0026f2f
Revert "Reland "remove NV12 to I420 conversion in webrtc AV1 Encoder.""
...
This reverts commit d7031692e3ba9eed78ead07f8bf34a847ca1fce6.
Reason for revert: Breaks downstream project
Original change's description:
> Reland "remove NV12 to I420 conversion in webrtc AV1 Encoder."
>
> This reverts commit 66557e1af3f95a70753e782224d13a6186ed0d2e.
>
> Reason for revert: Some downstream projects seem to have an old libaom version with no NV12 support yet. It will be updated soon.
>
> Original change's description:
> > Revert "remove NV12 to I420 conversion in webrtc AV1 Encoder."
> >
> > This reverts commit 9558ab41eb4de39c62cda2dd1e559f5814a3a0c7.
> >
> > Reason for revert: speculative revert: breaks downstream project
> >
> > Original change's description:
> > > remove NV12 to I420 conversion in webrtc AV1 Encoder.
> > >
> > > libaom supports for NV12 inputs for encoding av1 stream. It will reduce
> > > unnecessary conversion from NV12 to I420 format.
> > > (https://bugs.chromium.org/p/aomedia/issues/detail?id=3232&q=3232&can=2 )
> > >
> > > Bug: webrtc:13746
> > > Change-Id: I1407227d1690b3f63cb6581eef5d587e5f418892
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251920
> > > Reviewed-by: Erik Språng <sprang@webrtc.org >
> > > Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
> > > Commit-Queue: Shuhai Peng <shuhai.peng@intel.com >
> > > Cr-Commit-Position: refs/heads/main@{#36111}
> >
> > Bug: webrtc:13746
> > Change-Id: Ie928f7f5b5992337a9d186fa70b7fdec20a33f00
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253122
> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> > Commit-Queue: Artem Titov <titovartem@webrtc.org >
> > Owners-Override: Artem Titov <titovartem@webrtc.org >
> > Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
> > Cr-Commit-Position: refs/heads/main@{#36114}
>
> Bug: webrtc:13746
> Change-Id: Ib26ff6204abceb863b03d55e5953797c9ca27fc2
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253215
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
> Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#36156}
Bug: webrtc:13746
Change-Id: Ia9f8024bf70a82f8e26cd7a80d3020ed796c1b40
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/254262
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Reviewed-by: Andrey Logvin <landrey@webrtc.org >
Commit-Queue: Andrey Logvin <landrey@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36159}
2022-03-09 11:47:54 +00:00
d7031692e3
Reland "remove NV12 to I420 conversion in webrtc AV1 Encoder."
...
This reverts commit 66557e1af3f95a70753e782224d13a6186ed0d2e.
Reason for revert: Some downstream projects seem to have an old libaom version with no NV12 support yet. It will be updated soon.
Original change's description:
> Revert "remove NV12 to I420 conversion in webrtc AV1 Encoder."
>
> This reverts commit 9558ab41eb4de39c62cda2dd1e559f5814a3a0c7.
>
> Reason for revert: speculative revert: breaks downstream project
>
> Original change's description:
> > remove NV12 to I420 conversion in webrtc AV1 Encoder.
> >
> > libaom supports for NV12 inputs for encoding av1 stream. It will reduce
> > unnecessary conversion from NV12 to I420 format.
> > (https://bugs.chromium.org/p/aomedia/issues/detail?id=3232&q=3232&can=2 )
> >
> > Bug: webrtc:13746
> > Change-Id: I1407227d1690b3f63cb6581eef5d587e5f418892
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251920
> > Reviewed-by: Erik Språng <sprang@webrtc.org >
> > Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
> > Commit-Queue: Shuhai Peng <shuhai.peng@intel.com >
> > Cr-Commit-Position: refs/heads/main@{#36111}
>
> Bug: webrtc:13746
> Change-Id: Ie928f7f5b5992337a9d186fa70b7fdec20a33f00
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253122
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Commit-Queue: Artem Titov <titovartem@webrtc.org >
> Owners-Override: Artem Titov <titovartem@webrtc.org >
> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#36114}
Bug: webrtc:13746
Change-Id: Ib26ff6204abceb863b03d55e5953797c9ca27fc2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253215
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36156}
2022-03-09 11:15:13 +00:00
ddcfe405d3
Change PSNR threshold for av1 test
...
Bug: None
Change-Id: I47101a6625c2f1704599ea60ad3f2c05370da66e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/254101
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Jerome Jiang <jianj@google.com >
Cr-Commit-Position: refs/heads/main@{#36151}
2022-03-08 22:14:51 +00:00
15ee87fe0e
Use VideoCodec complexity to determine AV1 encoder cpu_speed.
...
Bug: webrtc:13744
Change-Id: Ib6d62dcdf7346d886c0aca09735c7d5c1f3e2455
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252340
Reviewed-by: Erik Språng <sprang@webrtc.org >
Auto-Submit: Michael Horowitz <mhoro@google.com >
Commit-Queue: Michael Horowitz <mhoro@google.com >
Cr-Commit-Position: refs/heads/main@{#36125}
2022-03-03 19:06:17 +00:00
66557e1af3
Revert "remove NV12 to I420 conversion in webrtc AV1 Encoder."
...
This reverts commit 9558ab41eb4de39c62cda2dd1e559f5814a3a0c7.
Reason for revert: speculative revert: breaks downstream project
Original change's description:
> remove NV12 to I420 conversion in webrtc AV1 Encoder.
>
> libaom supports for NV12 inputs for encoding av1 stream. It will reduce
> unnecessary conversion from NV12 to I420 format.
> (https://bugs.chromium.org/p/aomedia/issues/detail?id=3232&q=3232&can=2 )
>
> Bug: webrtc:13746
> Change-Id: I1407227d1690b3f63cb6581eef5d587e5f418892
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251920
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
> Commit-Queue: Shuhai Peng <shuhai.peng@intel.com >
> Cr-Commit-Position: refs/heads/main@{#36111}
Bug: webrtc:13746
Change-Id: Ie928f7f5b5992337a9d186fa70b7fdec20a33f00
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253122
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Owners-Override: Artem Titov <titovartem@webrtc.org >
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36114}
2022-03-02 16:01:28 +00:00
9558ab41eb
remove NV12 to I420 conversion in webrtc AV1 Encoder.
...
libaom supports for NV12 inputs for encoding av1 stream. It will reduce
unnecessary conversion from NV12 to I420 format.
(https://bugs.chromium.org/p/aomedia/issues/detail?id=3232&q=3232&can=2 )
Bug: webrtc:13746
Change-Id: I1407227d1690b3f63cb6581eef5d587e5f418892
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251920
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Shuhai Peng <shuhai.peng@intel.com >
Cr-Commit-Position: refs/heads/main@{#36111}
2022-03-02 14:18:36 +00:00
3147e29c4e
Refactor encoder-complexity param in VideoCodec w/backward compatibility
...
Move complexity parameter to the main VideoCodec class to enable
additional video codecs to use the parameter without creating a new
codec-specific structure.
Bug: webrtc:13694
Change-Id: Icb7cf640b178875d799f39ade8b5084e3222bb1c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251921
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Michael Horowitz <mhoro@google.com >
Cr-Commit-Position: refs/heads/main@{#36040}
2022-02-21 19:40:44 +00:00
454d2309de
Add bitrate adaptation tests
...
Bug: none
Change-Id: I3e2c503efc7a85a3daaa40cd8118c1b02d3b81cf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251680
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36013}
2022-02-16 10:25:13 +00:00
0b02d637c0
Calculate max/avg encode/decode latency in codec tests
...
Bug: none
Change-Id: Ie42461dd06b1764c99308393477921ea25319ab4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251687
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36007}
2022-02-15 18:14:41 +00:00
eb6c6fcf27
Fix delta frame delay calculation
...
The issue was introduced in https://webrtc-review.googlesource.com/c/src/+/132460 .
Bug: webrtc:10412
Change-Id: I92d1bd2be63ea34d150145cec63c282f7aa49ce8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251683
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35989}
2022-02-14 11:15:50 +00:00
ffdc6804bf
Reland: Added support for H264 YUV444 (I444) decoding.
...
PS#1 is a reland of "Added support for H264 YUV444 (I444) decoding." https://webrtc-review.googlesource.com/c/src/+/235340
Bug: chromium:1251096
Change-Id: Icd997c7f7732229954d5494343b4e7a70deb09d1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251303
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35964}
2022-02-09 11:57:55 +00:00
1f06508350
Update av1 video codec test threshold.
...
Bug: webrtc:13638
Change-Id: If17ae2519451953ac3e6054cb6cdc376594fe3d8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250040
Reviewed-by: Marco Paniconi <marpan@webrtc.org >
Reviewed-by: Fyodor Kyslov <kyslov@google.com >
Commit-Queue: Bohan Li <bohanli@google.com >
Cr-Commit-Position: refs/heads/main@{#35874}
2022-02-01 20:43:08 +00:00
1e157a9596
Remove more top-level const from parameters in function declarations
...
This CL removes even more top-level const from parameters in function
declarations. This change is safe because top-level const in function
declarations (not function definitions) are ignored by the compiler
and so change is just a no-op cleanup.
Bug: webrtc:13610
Change-Id: Icf6868c27b1fdb9d9915b3a7020eb34bdcf07a09
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249989
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Ali Tofigh <alito@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35866}
2022-02-01 09:15:50 +00:00
3f42fdf19f
Revert "Added support for H264 YUV444 (I444) decoding."
...
This reverts commit 3babb8af238a531cbff27951604b09bb78b762cd.
Reason for revert:
- Causes regressions to transceivers, see https://crbug.com/1291956 for more information, including tests to reproduce the issue.
This CL is not a pure revert. While it reverts everything else, it does
keep the new enum value (kProfilePredictiveHigh444). This is as to not
break Chromium which already depend on it. It is not listed in the
kProfilePatterns though so the enum value should never be applicable.
Original change's description:
> Added support for H264 YUV444 (I444) decoding.
>
> Added Nutanix Inc. to the AUTHORS file.
>
> PS#1 is a reland of "Added support for H264 YUV444 (I444) decoding." https://webrtc-review.googlesource.com/c/src/+/234540
>
> Bug: chromium:1251096
> Change-Id: I99a1b1e4d8b60192ff96f92334a430240875c66c
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/235340
> Reviewed-by: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Commit-Queue: Harald Alvestrand <hta@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#35684}
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:1251096, chromium:1291956
Change-Id: Ib4d8ea4898f9832914d88e7076e6b39da0c804ca
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249791
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Auto-Submit: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35835}
2022-01-29 10:45:39 +00:00
62238097c9
Remove top-level const from parameters in function declarations.
...
This is a safe cleanup change since top-level const applied to
parameters in function declarations (that are not also
definitions) are ignored by the compiler. Hence, such changes do
not change the type of the declared functions and are simply
no-ops.
Bug: webrtc:13610
Change-Id: Ibafb92c45119a6d8bdb6f9109aa8dad6385163a9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249086
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Ali Tofigh <alito@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35802}
2022-01-26 11:05:25 +00:00
604fd2f1ab
Remove RTC_DISALLOW_COPY_AND_ASSIGN from modules/
...
Bug: webrtc:13555, webrtc:13082
Change-Id: I2c2cbcbd918f0cfa970c1a964893220ba11d4b41
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247960
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: (Daniel.L) Byoungchan Lee <daniel.l@hpcnt.com >
Cr-Commit-Position: refs/heads/main@{#35771}
2022-01-24 11:50:20 +00:00
95701503f2
Make libaom_av1_encoder always build the libaom encoder.
...
Currently `CreateLibaomAv1Encoder` will either return an actual libaom AV1 encoder or a nullptr depening on whether the build flag `enable_libaom` was configured to true or not. This CL updates the `libaom_av1_encoder` build target to no longer depend on `enable_libaom` so that `CreateLibaomAv1Encoder` will always return an encoder instance.
Added `CreateLibaomAv1EncoderIfSupported` as a replacement to the old `CreateLibaomAv1Encoder`.
Bug: webrtc:13573
Change-Id: Ibdcd52c609acd79feefa2b86f19d1b4ca3e91d0a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/242360
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org >
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35763}
2022-01-21 13:45:47 +00:00
16cbed4782
Update how VP9 temporal up switch is populated
...
This CL updates both the static GOF pattern with the correct flags for
temporal_up_switch, as well the flexible mode logic to base the flag
on dependency descriptors instead use reference buffers.
Bug: webrtc:13576
Change-Id: I578f744bec51d1f3531da5f4a89d12f05a16a6c0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247187
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35741}
2022-01-19 15:42:21 +00:00
4b5caee6b1
VP9 encoder: mark only base spatial layer as keyframe
...
Bug: webrtc:13576
Change-Id: Ia4173d3aa2c8e546a818eccc5d6c09d1150dcaf4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247188
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35736}
2022-01-19 11:09:34 +00:00
ac0d18341d
Prepare for deleting implicit conversion from raw pointer to scoped_refptr.
...
Updates all webrtc code, to have a small followup cl to just add the
"explicit" keyword. Patchset #24 passed all webrtc tests, with explicit.
Bug: webrtc:13464
Change-Id: I39863d3752f73209b531120f66916dc9177bf63a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/242363
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35718}
2022-01-18 08:22:15 +00:00
3226e563d8
Reland "Disable frame dropping from codec settings."
...
This is a reland of 34aba3cefd9519a8da6700f725a9e2d99ee2ef61
Original change's description:
> Disable frame dropping from codec settings.
>
> This was broken in https://webrtc-review.googlesource.com/c/src/+/99062/
>
> Bug: webrtc:9734
> Change-Id: Ibce41a732cb2e943354c87fbb05be0dd218acf27
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/242366
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#35568}
Bug: webrtc:9734
Change-Id: I84efcab334b99aa08b07cc5e891681bfd5b2865f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247182
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35712}
2022-01-17 15:08:16 +00:00
3babb8af23
Added support for H264 YUV444 (I444) decoding.
...
Added Nutanix Inc. to the AUTHORS file.
PS#1 is a reland of "Added support for H264 YUV444 (I444) decoding." https://webrtc-review.googlesource.com/c/src/+/234540
Bug: chromium:1251096
Change-Id: I99a1b1e4d8b60192ff96f92334a430240875c66c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/235340
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35684}
2022-01-13 14:06:55 +00:00
31bd9fadb6
Disable Vp9ImplTest.DisableEnableBaseLayerWithSvcControllerTriggersKeyFrame
...
- Enable once a forward fix has landed in WebRTC
Bug: webrtc:13442
Change-Id: I0493fbbfbcf96e643d604406b350a3d315b24779
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245601
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Christoffer Jansson <jansson@google.com >
Cr-Commit-Position: refs/heads/main@{#35670}
2022-01-12 16:43:38 +00:00
b82193cec8
Disable DisableEnableBaseLayerTriggersKeyFrame
...
- Enable once a forward fix has landed in WebRTC.
Bug: webrtc:13442
Change-Id: I295383b84a753e8e1f65006cc6a3c00b78033aa4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245643
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Christoffer Jansson <jansson@google.com >
Cr-Commit-Position: refs/heads/main@{#35659}
2022-01-11 14:59:24 +00:00
5e180749a1
Revert "Disable frame dropping from codec settings."
...
This reverts commit 34aba3cefd9519a8da6700f725a9e2d99ee2ef61.
Reason for revert: Has unintended consequences for vp8 simulcast screenshare.
Original change's description:
> Disable frame dropping from codec settings.
>
> This was broken in https://webrtc-review.googlesource.com/c/src/+/99062/
>
> Bug: webrtc:9734
> Change-Id: Ibce41a732cb2e943354c87fbb05be0dd218acf27
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/242366
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#35568}
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:9734
Change-Id: I8a4758f6e915f40f89cc45f9530838b6cf6d1a49
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/242964
Reviewed-by: Erik Språng <sprang@webrtc.org >
Auto-Submit: Erik Språng <sprang@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35591}
2021-12-29 12:22:27 +00:00
34aba3cefd
Disable frame dropping from codec settings.
...
This was broken in https://webrtc-review.googlesource.com/c/src/+/99062/
Bug: webrtc:9734
Change-Id: Ibce41a732cb2e943354c87fbb05be0dd218acf27
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/242366
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35568}
2021-12-22 12:36:17 +00:00
8d87c463d9
ZeroHertzAdapterMode: slow down repeats on quality convergence.
...
The frame cadence adapter previously resulted in unconditional
frame repeating at max FPS. Change this to slow down to an idle
rate (1 Hz) when quality convergence in all configured spatial
layers has been achieved.
go/rtc-0hz-present
Bug: chromium:1255737
Change-Id: Ifa593dbf8a61aa29da20ac250da332734ae82791
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/241421
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Markus Handell <handellm@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35547}
2021-12-16 12:01:30 +00:00
d2cd8722cd
Consider frame orientation for number of spatial layers in VP9.
...
Addresses case where 540*960 would not get a 135*240 layer.
Bug: webrtc:13469
Change-Id: Icc291c65114fb400cc71659d76a786e359e5996c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239820
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Konrad Hofbauer <hofbauer@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35507}
2021-12-09 09:39:50 +00:00
0763ccc8e3
Don't configure SVC params without per layer bitrate configured.
...
Change-Id: Ieb200ce1a710078e380047ed8af73db0c5e0c751
Bug: none
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239442
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35457}
2021-12-02 09:52:32 +00:00
144e5bf87d
Use NONE if scalability mode is not specified
...
Bug: none
Change-Id: I8ffdb7fc41dec3c5b37483a6dcbb8fe7f03b59da
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/238984
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35418}
2021-11-25 13:50:14 +00:00
b09d87232b
Reland "Add dav1d decoder to WebRTC."
...
This reverts commit 8498b7e7f6b90fa036de2a6887d34256f0565b4f.
Reason for revert: Updating CL to include conditional build flag.
Original change's description:
> Revert "Add dav1d decoder to WebRTC."
>
> This reverts commit 147858577d4db6d257d3cc248fe571a1bbf887e3.
>
> Reason for revert: High binary size increase
>
> Original change's description:
> > Add dav1d decoder to WebRTC.
> >
> > Bug: none
> > Change-Id: I7642f42e592dcf510679f881f118bc4dab93b31c
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/237504
> > Commit-Queue: Philip Eliasson <philipel@webrtc.org >
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> > Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
> > Reviewed-by: Magnus Flodman <mflodman@webrtc.org >
> > Reviewed-by: Sergey Silkin <ssilkin@webrtc.org >
> > Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
> > Cr-Commit-Position: refs/heads/main@{#35394}
>
> TBR=danilchap@webrtc.org ,mbonadei@webrtc.org ,ilnik@webrtc.org ,philipel@webrtc.org ,mflodman@webrtc.org ,ssilkin@webrtc.org ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
>
> Change-Id: I00a8acd6ea94ce523c2d5ba705333c9174678180
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: none
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/238560
> Reviewed-by: Artem Titov <titovartem@webrtc.org >
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
> Owners-Override: Artem Titov <titovartem@webrtc.org >
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#35395}
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: none
Change-Id: Iff51848731646159e87e075c38af7cb6355f5b5b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/238661
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Magnus Flodman <mflodman@webrtc.org >
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org >
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35409}
2021-11-23 15:59:58 +00:00
984cf9b837
Explicitly set encoder and decoder format in codec tests.
...
This allows to differentiate and test codecs of the same type but
different implementations/settings.
Bug: none
Change-Id: I74f799b36411e63387513133ffc19a7f0c45d550
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/238165
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35396}
2021-11-22 08:18:25 +00:00
8498b7e7f6
Revert "Add dav1d decoder to WebRTC."
...
This reverts commit 147858577d4db6d257d3cc248fe571a1bbf887e3.
Reason for revert: High binary size increase
Original change's description:
> Add dav1d decoder to WebRTC.
>
> Bug: none
> Change-Id: I7642f42e592dcf510679f881f118bc4dab93b31c
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/237504
> Commit-Queue: Philip Eliasson <philipel@webrtc.org >
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
> Reviewed-by: Magnus Flodman <mflodman@webrtc.org >
> Reviewed-by: Sergey Silkin <ssilkin@webrtc.org >
> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#35394}
TBR=danilchap@webrtc.org ,mbonadei@webrtc.org ,ilnik@webrtc.org ,philipel@webrtc.org ,mflodman@webrtc.org ,ssilkin@webrtc.org ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
Change-Id: I00a8acd6ea94ce523c2d5ba705333c9174678180
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: none
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/238560
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
Owners-Override: Artem Titov <titovartem@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35395}
2021-11-19 18:47:42 +00:00
147858577d
Add dav1d decoder to WebRTC.
...
Bug: none
Change-Id: I7642f42e592dcf510679f881f118bc4dab93b31c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/237504
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Magnus Flodman <mflodman@webrtc.org >
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35394}
2021-11-19 15:03:12 +00:00
13d163654a
Delete support for has_internal_source
...
Bug: webrtc:12875
Change-Id: I9683e71e1fe5b24802033ffcb32a531ca685fc6f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179220
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Tommi <tommi@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35353}
2021-11-16 11:29:40 +00:00
d3251968d1
Prepare to rename RTC_NOTREACHED to RTC_DCHECK_NOTREACHED
...
Add implementation of RTC_DCHECK_NOTREACHED equal to the RTC_NOTREACHED.
The new macros will replace the old one when old one's usage will be
removed. The idea of the renaming to provide a clear signal that this
is debug build only macros and will be stripped in the production build.
Bug: webrtc:9065
Change-Id: I4c35d8b03e74a4b3fd1ae75dba2f9c05643101db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/237802
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35348}
2021-11-15 21:44:59 +00:00
528e4898e7
Set correct spatial layer number in FrameEncodeMetadataWriter
...
This CL set the spatial id in LibaomAv1Encoder and set correct number
of spatial layers for AV1 in FrameEncodeMetadataWriter.
Bug: None
Change-Id: I40092e45be88ec9ab75f228d9ca84c44e3cad326
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/237662
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Zhaoliang Ma <zhaoliang.ma@intel.com >
Cr-Commit-Position: refs/heads/main@{#35339}
2021-11-15 03:34:18 +00:00
dfec7a664b
Added main profile to supported H264 codecs
...
This adds the Main 3.1 profile to the list of supported H264 codecs. This unifies the output of WebRTC codecs among macOS/Windows (which both have Main 3.1 codecs) and headless Linux browsers.
Bug: None
Change-Id: Ife2fe8c1827be9368fabccc5f24ba316671b1b8b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/236600
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org >
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35328}
2021-11-10 10:56:13 +00:00
97597c0f51
Remove usage of INFO alias for LS_INFO in log messages
...
Bug: webrtc:13362
Change-Id: Ifda893861a036a85c045cd366f9eab33c62ebde0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/237221
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35310}
2021-11-04 13:46:17 +00:00
d3eb8f1152
libaom AV1 encoder wrapper cleanup.
...
Bug: none
Change-Id: Ia62ab4653a1c95e7a609d767d76f7e7c64c0e751
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/236843
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35292}
2021-11-01 13:58:32 +00:00
448231d654
Always call aom_codec_encode for every spatial layer in the libaom AV1 encoder wrapper.
...
Bug: none
Change-Id: I8556c4ba14393b958f4012fe9942af5523aae356
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/236341
Reviewed-by: Marco Paniconi <marpan@google.com >
Reviewed-by: Jerome Jiang <jianj@google.com >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35280}
2021-10-29 09:44:00 +00:00
d891c4940a
Configure generic temporal layer in VP8 screenshare
...
This ensures that the payload descriptor and potential generic
descriptors uses the same temporal layer.
Bug: b/200518293
Change-Id: I17e980b47fe6c814cb393fc459064576447aa27a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/236520
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Emil Lundmark <lndmrk@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35275}
2021-10-28 14:32:49 +00:00
f33fc35277
Set rates for av1 svc tests
...
Bug: webrtc:11404
Change-Id: I79c4cee99d1bee1cdd3a8e0f901fadc6178a07a6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/235602
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Jerome Jiang <jianj@google.com >
Cr-Commit-Position: refs/heads/main@{#35250}
2021-10-20 16:52:53 +00:00
823ba0b038
Cleanup WebRTC-Vp9DependencyDescriptor field trial
...
Bug: chromium:1178444
Change-Id: Ie2ec796e207fa427fdbe00c8ea41a6b4fefea155
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/235374
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Emil Lundmark <lndmrk@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35241}
2021-10-19 14:29:29 +00:00
d7dd0aa9ee
Move sendtask after decoded frame writer is initialized.
...
Bug: webrtc:13293
Change-Id: Ic71f92a5204715480e207f908f70ffff63e31279
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/235580
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Ying Wang <yinwa@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35235}
2021-10-19 11:32:33 +00:00
54f377308f
Revert "Added support for H264 YUV444 (I444) decoding."
...
This reverts commit 7d8ed3437295bcad945dab69f042cf52a05c0985.
Reason for revert: Breaks internal builds
Original change's description:
> Added support for H264 YUV444 (I444) decoding.
>
> Added Nutanix Inc. to the AUTHORS file.
>
> Bug: chromium:1251096
> Change-Id: Ib47c2b1f94797afb6c5090f3c46eae6f13110992
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234540
> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
> Reviewed-by: Stefan Holmer <stefan@webrtc.org >
> Reviewed-by: Niels Moller <nisse@webrtc.org >
> Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#35200}
TBR=ilnik@webrtc.org ,nisse@webrtc.org ,stefan@webrtc.org ,peterhanspers@webrtc.org ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com ,stefan.mitic@nutanix.com
Change-Id: I3048c353a2b6b4f3d4e5e53a88f48b456f1ce593
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1251096
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/235203
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35207}
2021-10-14 12:59:29 +00:00
7d8ed34372
Added support for H264 YUV444 (I444) decoding.
...
Added Nutanix Inc. to the AUTHORS file.
Bug: chromium:1251096
Change-Id: Ib47c2b1f94797afb6c5090f3c46eae6f13110992
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234540
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35200}
2021-10-14 11:06:55 +00:00
5a79d28eba
Require 16x16 alignment when using HardwareVideoEncoder for encoding.
...
It seems the Android CTS tests only verify that 16x16 aligned resolutions
are supported.
This change checks the validity of input frame's size when initialing
or encoding processes are about to start using H/W MediaCodec.
This change has additional APIs to retrieve
|requested_resolution_alignment| and |apply_alignment_to_all_simulcast_layers|
from JAVA VideoEncoder class and its inherited classes. HardwareVideoEncoder
using MediaCodec has values of 16 and true for above variables.
Bug: webrtc:13089
Change-Id: I0c4ebf94eb36da29c2e384a3edf85b82e779b7f9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/229460
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org >
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35169}
2021-10-08 13:15:12 +00:00
7b35b44b52
Zero initialize heap allocations in LibvpxVp9{Decoder,Encoder}
...
Bug: chromium:1251010
Change-Id: Iffefdc8bee3752f89b0201f56fd06a2253b53200
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232602
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Emil Lundmark <lndmrk@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35049}
2021-09-21 09:24:09 +00:00
