00d0a0a1a9
Copy video frames metadata between encoded and plain frames in one place
...
Currently some video frames metadata like rotation or ntp timestamps are
copied in every encoder and decoder separately. This CL makes copying to
happen at a single place for send or receive side. This will make it
easier to add new metadata in the future.
Also, added some missing tests.
Bug: webrtc:10460
Change-Id: Ia49072c3041e75433f125a61050d2982b2bec1da
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133346
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Johannes Kron <kron@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27719}
2019-04-23 14:31:03 +00:00
7aacdd9515
Reland "Delete CodecSpecificInfo argument from VideoDecoder::Decode"
...
This is a reland of 39d3a7de02d63894d12e7332322e1d80cd7c0d40
Original change's description:
> Delete CodecSpecificInfo argument from VideoDecoder::Decode
>
> Bug: webrtc:10379
> Change-Id: I079b419604bf4e9c1994fe203d7db131a0ccddb6
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/125920
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#27022}
Tbr: kwiberg@webrtc.org
Bug: webrtc:10379
Change-Id: I8197bebd2ae7dc460644a98795b8257b033c27c2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126480
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27565}
2019-04-11 13:03:52 +00:00
9d8eaac4ee
Delete unneeded direct includes of common_types.h
...
And delete corresponding dependencies on :webrtc_common. After this
change, common_types.h is included directly only from code in the
following directories:
api/
api/video/
api/video_codecs/
common_video/libyuv/include/
media/base/
modules/remote_bitrate_estimator/
modules/rtp_rtcp/source/
modules/video_coding/codecs/vp9/
There remains plenty of indirect dependencies on the types declared in
common_types.h, but the fewer direct dependencies should make it
easier to find the proper place for each type.
Bug: webrtc:5876
Change-Id: I93e8f214025ecb613c19fdec2015bd3f96c59aae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130501
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27376}
2019-04-01 07:18:13 +00:00
2c7b9825bc
Revert "Delete CodecSpecificInfo argument from VideoDecoder::Decode"
...
This reverts commit 39d3a7de02d63894d12e7332322e1d80cd7c0d40.
Reason for revert: This change broke an internal project
Original change's description:
> Delete CodecSpecificInfo argument from VideoDecoder::Decode
>
> Bug: webrtc:10379
> Change-Id: I079b419604bf4e9c1994fe203d7db131a0ccddb6
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/125920
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#27022}
TBR=brandtr@webrtc.org ,kwiberg@webrtc.org ,nisse@webrtc.org ,kthelgason@webrtc.org ,sprang@webrtc.org
Change-Id: I2c730cc1834a3b23203fae3d7881f0890802c37b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10379
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126320
Reviewed-by: Jeroen de Borst <jeroendb@webrtc.org >
Commit-Queue: Jeroen de Borst <jeroendb@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27026}
2019-03-07 19:40:17 +00:00
39d3a7de02
Delete CodecSpecificInfo argument from VideoDecoder::Decode
...
Bug: webrtc:10379
Change-Id: I079b419604bf4e9c1994fe203d7db131a0ccddb6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/125920
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27022}
2019-03-07 16:18:49 +00:00
b769894025
Remove rule that discourages passing optional by const reference
...
include example to demonstrate:
(subjectively) increased readability
(objectively) decreased binary size
Bug: None
Change-Id: I970e668af98d98725b2d527f44169a8b7c9d2338
Reviewed-on: https://webrtc-review.googlesource.com/c/121420
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26545}
2019-02-05 11:58:05 +00:00
a1bec23f6c
Pass on explicit color space for VP8 and H264
...
Bug: webtc:8651
Change-Id: I9d478e7123e915bff858d725d6008fcfeeb0779d
Reviewed-on: https://webrtc-review.googlesource.com/c/114424
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26044}
2018-12-18 12:32:03 +00:00
4dc66c53d0
Move EncodedImage class to api/video/
...
Bug: webrtc:9378
Change-Id: I8fb3b19cad0ad428abc6c8e6b507180d461882ba
Reviewed-on: https://webrtc-review.googlesource.com/c/104002
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Peter Slatala <psla@webrtc.org >
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25033}
2018-10-08 07:37:10 +00:00
5fbc0e0b33
Hide libvpx vp8 encoder behind an interface and add mock for testing.
...
Bug: webrtc:9809
Change-Id: I27baa0309511cbd849c09c5d063a64d1fb1fcebf
Reviewed-on: https://webrtc-review.googlesource.com/c/103442
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25005}
2018-10-05 08:51:52 +00:00
8df3a388a3
Deprecate RTPFragmentationHeader argument to VideoDecoder::Decode
...
Intend to delete in a later cl.
Bug: webrtc:6471
Change-Id: Icf0fcd40e0d3287dc59b684fae6552b40b47204a
Reviewed-on: https://webrtc-review.googlesource.com/39511
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#23162}
2018-05-08 08:09:35 +00:00
cc681ccf6b
Split vp8_impl into webm_vp8_encoder and webm_vp8_decoder
...
This work is in preparation for refactoring the TemporalLayers api.
Bug: webrtc:9012
Change-Id: I01908ee034fb79996e687ff72d10178acf102321
Reviewed-on: https://webrtc-review.googlesource.com/61781
Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#22445}
2018-03-15 11:57:07 +00:00