fbc347f2ef
Re-land r8342 "Switch to using AudioEncoderIsac instead of ACMISAC""
...
This reverts r8372, with a bug fix: allowing zero rate in
AudioEncoderIsac::Config. Without this fix, setting the rate to zero
triggered a CHECK. Existing callers assumed that zero was a valid
value. Setting the rate to zero will result in the default rate 32000
being set.
BUG=4228,chromium:458638
COAUTHOR=kwiberg@webrtc.org
R=tina.legrand@webrtc.org
TBR=tina.legrand@webrtc.org
CC=jmarusic@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39159004
Cr-Commit-Position: refs/heads/master@{#8378}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8378 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-16 14:28:45 +00:00
e35fa96cbe
Move isacfix.gypi and isac.gypi
...
Move webrtc/modules/audio_coding/codecs/isac/fix/source/isacfix.gypi
and webrtc/modules/audio_coding/codecs/isac/main/source/isac.gypi to
webrtc/modules/audio_coding/codecs/isac to pass recently
added _CheckNoSourcesAboveGyp presubmit rule.
BUG=4002
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37269004
Cr-Commit-Position: refs/heads/master@{#8376}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8376 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-16 12:47:22 +00:00
0f7f161ed6
Add audio_coding module OWNERS file.
...
It should simplify things to have an
OWNERS file at the top level of audio_coding, in addition
to the lower ones.
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39149004
Cr-Commit-Position: refs/heads/master@{#8373}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8373 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-16 09:53:47 +00:00
a8cc3440b1
Allowing RED decoding for Opus.
...
BUG=4247
TEST=reproduced and fixed the bug
R=henrik.lundin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/41809004
Cr-Commit-Position: refs/heads/master@{#8364}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8364 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-13 14:02:17 +00:00
ba97ea69f0
audio_coding/codec/ilbc: Removed usage of macro WEBRTC_SPL_MUL_16_16
...
The macro is in C defined as
#define WEBRTC_SPL_MUL_16_16(a, b) ((int32_t) (((int16_t)(a)) * ((int16_t)(b))))
(For definition on ARMv7 and MIPS, see common_audio/signal_processing/include/spl_inl_armv7.h and common_audio/signal_processing/include/spl_inl_mips.h)
The replacement consists of
- avoiding casts to int16_t if inputs already are int16_t
- adding explicit cast to <type> if result is assigned to <type> (other than int or int32_t)
Some other minor code cleanup also exists.
BUG=3348, 3353
TESTED=locally on Mac and trybots
R=henrik.lundin@webrtc.org , kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/34179004
Cr-Commit-Position: refs/heads/master@{#8358}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8358 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-13 09:52:42 +00:00
bb1219eca3
Add a unit test for callbacks with empty frames and fix bug in code
...
This change adds a couple of new tests that verify that callbacks
with frame type kFrameEmpty are sent in between comfort noise packets.
This used to be the case until r8268, and with the fix included in
this CL is once again so.
COAUTHOR=kwiberg@webrtc.org
R=minyue@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37229004
Cr-Commit-Position: refs/heads/master@{#8353}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8353 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-12 15:53:55 +00:00
6c68c85b46
Switch to using AudioEncoderOpus instead of ACMOpus
...
This change switches from the old codec wrapper ACMOpus to the new
AudioEncoderOpus wrapped in an ACMGenericCodecWrapper.
BUG=4228
TEST=Please, try the Opus codec extensively.
COAUTHOR=kwiberg@webrtc.org
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/33259004
Cr-Commit-Position: refs/heads/master@{#8341}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8341 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-11 21:34:06 +00:00
648f5d6dc7
pcm16b: Make input arrays const and use uint8_t[] for byte arrays
...
There were both uint8 and uint16 versions of the pcm16b encode and
decode functions; this patch removes the latter.
BUG=909
R=henrik.lundin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/34139004
Cr-Commit-Position: refs/heads/master@{#8309}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8309 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-10 09:19:09 +00:00
1c6239a3b6
G711: Make input arrays const and use uint8_t[] for byte arrays
...
BUG=909
R=henrik.lundin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39809004
Cr-Commit-Position: refs/heads/master@{#8294}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8294 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-09 12:56:16 +00:00
2b69eab077
Restructure GYP for vp9, opus and direct trace
...
This is needed to make the build more flexible for some use cases.
BUG=4185
R=andresp@webrtc.org , stefan@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/34099004
Cr-Commit-Position: refs/heads/master@{#8290}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8290 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-09 10:01:40 +00:00
f45c8ca88b
Reland r8248 "Introduce ACMGenericCodecWrapper"
...
This effectively reverts r8249.
This new class inherits from ACMGenericCodec. The purpose is to wrap
AudioEncoder objects into an ACMGenericCodec interface. This is a
temporary construction that will be used during the ACM redesign work.
BUG=4228
COAUTHOR=kwiberg@webrtc.org
TBR=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/38919004
Cr-Commit-Position: refs/heads/master@{#8255}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8255 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-05 18:30:16 +00:00
cf7efeba37
Add new AudioEncoderOpusTest
...
This test will replace AcmOpusTest when ACMOpus is removed. The old
AcmOpusTest also contains tests for setting and updating the
"application" setting in Opus. However, in the new AudioEncoderOpus
class, the application is trivially set in the Config struct at
construction, wherefore a test is no longer needed.
BUG=3926
R=minyue@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37929004
Cr-Commit-Position: refs/heads/master@{#8244}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8244 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-04 15:34:40 +00:00
c420a86f4c
Change name for local CriticalSectionScoped variable
...
Tools were complaining about (harmless) shadowing of variable names.
This is a follow-up to
https://webrtc-codereview.appspot.com/41659004/#msg8
BUG=3926
TBR=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37099004
Cr-Commit-Position: refs/heads/master@{#8225}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8225 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-02 10:36:39 +00:00
a1dfbf1e5c
WebRtcG722_Decode: Input array should be const uint8_t[]
...
BUG=909
R=henrik.lundin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/38799004
Cr-Commit-Position: refs/heads/master@{#8224}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8224 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-02 08:58:39 +00:00
4455f6243a
WebRtcIsacfix_Time2SpecNeon and _Spec2TimeNeon: Fix stack alignment
...
The ABI
(http://infocenter.arm.com/help/topic/com.arm.doc.ihi0042e/IHI0042E_aapcs.pdf )
says to 8-byte-align stack frames. That means we have to push an even
number of registers on function entry if we want to be able to make
subroutine calls without adjusting the stack first.
BUG=4177
R=bjornv@webrtc.org , henrik.lundin@webrtc.org , zhongwei.yao@arm.com
Review URL: https://webrtc-codereview.appspot.com/33149004
Cr-Commit-Position: refs/heads/master@{#8214}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8214 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-30 11:58:15 +00:00
13980253f0
Add new members to AudioEncoderOpus::Config
...
Adding fec_enabled and max_playback_rate_hz.
BUG=3926
COAUTHOR:kwiberg@webrtc.org
R=minyue@webrtc.org , tina.legrand@webrtc.org
TBR=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39659004
Cr-Commit-Position: refs/heads/master@{#8207}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8207 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-29 16:09:08 +00:00
a33f05e8d7
Re-land "Remove <(webrtc_root) from source file entries."
...
Changes differing from https://webrtc-codereview.appspot.com/37859004 :
* I put the include_tests==1 stuff of audio_coding.gypi in its
own audio_coding_tests.gypi file, including the Android and isolate
targets which were incorrectly located in the previous CL
* I moved the bwe utilities in remote_bitrate_estimator.gypi
into include_tests==1 since they depend on test.gyp after I
cleaned up the duplicated inclusion of rtp_file_reader.cc
R=stefan@webrtc.org
TBR=tina.legrand@webrtc.org
TESTED=Passing gyp and compile using:
webrtc/build/gyp_webrtc -Dinclude_tests=1
webrtc/build/gyp_webrtc -Dinclude_tests=0
I also setup a Chromium checkout with my checkout mounted in
third_party/webrtc and ran build/gyp_chromium successfully.
BUG=4185
Review URL: https://webrtc-codereview.appspot.com/33159004
Cr-Commit-Position: refs/heads/master@{#8205}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8205 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-29 14:30:41 +00:00
bdebccf384
Fix a number of things in AudioEncoderDecoderIsac*
...
- Add max_bit_rate and max_payload_size_bytes to config structs.
- Fix support for 48 kHz sample rate.
- Fix iSAC-RED.
- Add method UpdateDecoderSampleRate().
- Update locking structure with a separate lock for local member
variables used by the encoder methods.
BUG=3926
COAUTHOR:kwiberg@webrtc.org
R=minyue@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/41659004
Cr-Commit-Position: refs/heads/master@{#8204}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8204 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-29 14:11:09 +00:00
1ece0cbbec
Revert "Remove <(webrtc_root) from source file entries."
...
And the follow-up fix in r8198 that was not sufficient.
Reason: breaks Chromium bots runhooks (GYP).
I will have to try some more to make sure I don't
include test code, since include_tests==0 in Chromium.
TBR=andrew@webrtc.org , tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37039004
Cr-Commit-Position: refs/heads/master@{#8200}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8200 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-29 12:02:42 +00:00
2d2a1f9f05
Remove <(webrtc_root) from source file entries.
...
This required to move the AGC tools source files
into webrtc/tools and create a new agc_test_utils target.
Since audio_codec_speed_tests.gypi referenced sources above,
the best approach I could come up with was to add an audio_coding.gypi
file at a higher level and move the targets in there (+ the includes from
modules.gyp which is an improvement IMO).
I also added a PRESUBMIT.py check to prevent new source
entries being added with <(webrtc_root) in the path.
BUG=4185
R=andrew@webrtc.org , tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37859004
Cr-Commit-Position: refs/heads/master@{#8197}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8197 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-29 10:24:44 +00:00
4aecd008dd
Add support for 40 and 60 ms frames to AudioEncoderIlbc
...
BUG=3926
COAUTHOR:kwiberg@webrtc.org
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37789004
Cr-Commit-Position: refs/heads/master@{#8182}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8182 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-28 13:16:44 +00:00
8bb32d600b
Minor updates to AudioEncoderCng
...
Removing sample_rate_hz_ from AudioEncoderCng and from the config
struct. The sample rate will now be read from the underlying speech
codec.
BUG=3926
COAUTHOR:kwiberg@webrtc.org
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/40559004
Cr-Commit-Position: refs/heads/master@{#8173}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8173 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-27 20:54:22 +00:00
478cedc055
Add new methods to AudioEncoder interface
...
The following three methods are added:
rtp_timestamp_rate_hz()
SetTargetBitrate()
SetProjectedPacketLossRate()
Default implementations are provided, and a few overrides are
implemented. AudioEncoderCopyRed and AudioEncoderCng propagate the new
methods to the underlying speech codec.
BUG=3926
COAUTHOR:kwiberg@webrtc.org
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/34049004
Cr-Commit-Position: refs/heads/master@{#8171}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8171 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-27 18:25:40 +00:00
b6fab2b1cd
Introduce rtc::CheckedDivExact
...
Use the new method to replace local ones in AudioEncoder{Opus,Isac}.
COAUTHOR:kwiberg@webrtc.org
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/34779004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8148 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-26 11:08:53 +00:00
7dba7860c7
Setting Opus target application.
...
This CL is to allow to set Opus target application at the creation of an encoder.
According to Opus spec, there are three applications:
OPUS_APPLICATION_VOIP
OPUS_APPLICATION_AUDIO
OPUS_APPLICATION_RESTRICTED_LOWDELAY
BUG=
R=henrik.lundin@webrtc.org , tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37479004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8103 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-20 16:01:50 +00:00
6c3855258d
Add WebRtcIsacfix_AllpassFilter2FixDec16Neon()'s intrinsics version.
...
This intrinsics version gives bit-exact result as the current C
code. And the performance is 14% better than current assembly
neon version, 3.4 times faster than current C version. The test runs
under Cortex-a53 aarch32 mode, other cpu should give similar performance
result.
Change-Id: Icce5eaf2e17790ce44513d52b53b9f600cc16f96
BUG=4002
R=andrew@webrtc.org , jridges@masque.com
Review URL: https://webrtc-codereview.appspot.com/36689004
Patch from Zhongwei Yao <zhongwei.yao@arm.com >.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8070 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-15 02:56:06 +00:00
86e1e487e7
Move system_wrappers.gyp files to the proper directory.
...
Build targets should not refer to non-subpaths as was happening before when
source/system_wrappers.gyp refers to ../interface/ files.
R=kjellander@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37609004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8057 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-14 09:30:52 +00:00
2a26734f04
Partial revert of r7396
...
This change reverts a small part of what was done in r7396. It seems
like that change uncovered another issue with NEON.
BUG=4177,chrome-os-partner:31534
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/33849004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8043 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-12 20:52:21 +00:00
f3fd8e7cdf
Add NEON intrinsics version for transform_neon
...
WebRtcIsacfix_Time2SpecNeon and WebRtcIsacfix_Spec2TimeNeon are added.
TransformTest in modules_unittests is passed on ARM32/ARM64 platform.
Initially reviewed here:
https://webrtc-codereview.appspot.com/36449004/
BUG=4002
R=andrew@webrtc.org , jridges@masque.com
Change-Id: I0920ff66a0a0f529707fd7e6619f91e271a47019
Review URL: https://webrtc-codereview.appspot.com/31309004
Patch from Yang Zhang <yang.zhang@arm.com >.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8030 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-09 18:29:37 +00:00
84d84471f5
Minor fixes regarding accumulator usage on MIPS platforms.
...
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/33729004
Patch from Ljubomir Papuga <lpapuga@mips.com >.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7979 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-29 17:08:44 +00:00
1090a6eccf
Remove obsolete target_arch == armv7.
...
Also, use arm_version >= 7 so things will continue to work when building
for ARMv8 and higher targets.
BUG=3906
R=kjellander@webrtc.org , tkchin@webrtc.org , zhongwei.yao@arm.com
Review URL: https://webrtc-codereview.appspot.com/38379004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7957 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-18 21:36:18 +00:00
eed7a22bbf
Make an AudioEncoder subclass for iSAC redundant encoding
...
Adding unit test, too.
BUG=3926
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/36559005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7946 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-18 09:52:36 +00:00
cab1291745
Fixing the memory leak in AudioEncoderCopyRedDeathTest.NullSpeechEncoder
...
Re-enable the test and explicitly call delete on red, even though the
test should die in the AudioEncoderCopyRed cunstructor. Apparently,
things work a little differently under memcheck.
BUG=4108, 3926
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/38419004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7942 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-18 06:58:42 +00:00
eb544460e4
Rename _t struct types in audio_coding.
...
_t names are reserved in POSIX.
R=henrik.lundin@webrtc.org
BUG=162
Review URL: https://webrtc-codereview.appspot.com/34509004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7933 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-17 15:23:29 +00:00
e728ee03ba
Remove or rename typedefs with _t prefixes.
...
_t prefixes are reserved for additional typenames in POSIX.
R=henrik.lundin@webrtc.org , hta@webrtc.org , stefan@webrtc.org
BUG=162
Review URL: https://webrtc-codereview.appspot.com/36559004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7931 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-17 13:43:55 +00:00
a32487f97b
Disable AudioEncoderCopyRedDeathTest.NullSpeechEncoder
...
Fails linux memcheck.
BUG=4108
TBR=turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/29279004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7920 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-16 21:04:55 +00:00
c1c9291e9b
Make an AudioEncoder subclass for RED
...
This class only supports the simple case of payload duplication. That
is, one single encoder is used, and the redundant payload is a one-step
delayed payload.
BUG=3926
R=kjellander@webrtc.org , kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/31199004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7913 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-16 13:41:36 +00:00
88bdec8c3a
AudioEncoder subclass for iSACfix
...
This patch refactors AudioEncoderDecoderIsac so that it can share
almost all code with the very similar AudioEncoderDecoderIsacFix.
BUG=3926
R=henrik.lundin@webrtc.org , kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/29259004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7912 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-16 12:49:37 +00:00
b413a30097
Add WebRtcIsacfix_FilterMaLoopNeon's intrinsics version.
...
This intrinsics version gives bit-exact result as the current assembly
neon code. And the performance is 38% better than current assembly
neon version, 5.92 times faster than current C version. The test runs
under Cortex-a53 aarch32 mode, other cpu should give similar performance
result.
BUG=4002
R=andrew@webrtc.org , jridges@masque.com
Change-Id: I257e33ef6d634a519fd71adc4f52b06dd655bd9d
Review URL: https://webrtc-codereview.appspot.com/32749004
Patch from Zhongwei Yao <zhongwei.yao@arm.com >.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7891 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-15 07:23:49 +00:00
3b79daff14
Moving encoded_bytes into EncodedInfo
...
BUG=3926
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/35469004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7883 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-12 13:31:24 +00:00
0ca768b131
Adding DTX to WebRTC Opus wrapper (relanding).
...
This is relanding of r7846, which failed since the unit test depended on whether Opus is in fixed-point or float-point.
See the review of r7846 here:
https://webrtc-codereview.appspot.com/13219004/
Patch set 1 is the same as r7846. Further fixes are found in patch set 2 and later.
BUG=
R=henrik.lundin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/32299004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7878 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-11 16:09:35 +00:00
817e50dd7d
Make an AudioEncoder subclass for PCM16B
...
The implementation depends on AudioEncoderPcm to reduce code
duplication.
BUG=3926
R=kjellander@webrtc.org , kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/33589004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7872 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-11 10:47:19 +00:00
b3ad8cf6ca
Make an AudioEncoder subclass for iSAC
...
BUG=3926
Previously committed: https://code.google.com/p/webrtc/source/detail?r=7675
and reverted: https://code.google.com/p/webrtc/source/detail?r=7676
R=henrik.lundin@webrtc.org , kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/25359004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7871 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-11 10:08:19 +00:00
55d42c32a4
DCHECK: Reference condition parameter in release builds
...
So that caller's won't get warnings about unused variables for
variables that are only used in calls to DCHECK, such as
int x = ...
DCHECK_EQ(x, 17);
R=andrew@webrtc.org
Previously committed: https://code.google.com/p/webrtc/source/detail?r=7858
and reverted: https://code.google.com/p/webrtc/source/detail?r=7859
Review URL: https://webrtc-codereview.appspot.com/31169004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7869 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-11 08:32:30 +00:00
3cd26b677a
Revert r7858 ("DCHECK: Reference condition parameter in release builds")
...
Apparently Visual Studio is cleverer than I am at figuring out what
local variables are actually unused.
TBR=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/32739004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7859 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-10 08:57:14 +00:00
3148060e61
DCHECK: Reference condition parameter in release builds
...
So that caller's won't get warnings about unused variables for
variables that are only used in calls to DCHECK, such as
int x = ...
DCHECK_EQ(x, 17);
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/31169004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7858 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-10 08:45:47 +00:00
ff1a3e36bd
Make an AudioEncoder subclass for comfort noise
...
BUG=3926
R=bjornv@webrtc.org , kjellander@webrtc.org , kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/31129004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7857 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-10 07:29:08 +00:00
19dd129c69
Revert 7846 "Adding DTX to WebRTC Opus wrapper"
...
> Adding DTX to WebRTC Opus wrapper
>
> This is a step toward adding Opus DTX support in WebRTC.
>
> Note that opus_encode() returns 1 byte in case of DTX, then the packet does not need to be transmitted. See
>
> https://mf4.xiph.org/jenkins/view/opus/job/opus/ws/doc/html/group__opus__encoder.html
>
> We transmit the first 1-byte packet to let decoder be in-sync
>
> BUG=webrtc:1014
> R=henrik.lundin@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/13219004
TBR=minyue@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/34449004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7848 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-09 15:11:15 +00:00
4321f175f1
Adding DTX to WebRTC Opus wrapper
...
This is a step toward adding Opus DTX support in WebRTC.
Note that opus_encode() returns 1 byte in case of DTX, then the packet does not need to be transmitted. See
https://mf4.xiph.org/jenkins/view/opus/job/opus/ws/doc/html/group__opus__encoder.html
We transmit the first 1-byte packet to let decoder be in-sync
BUG=webrtc:1014
R=henrik.lundin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/13219004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7846 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-09 13:27:39 +00:00
e04a93bcf5
Move the AudioDecoder interface out of NetEq
...
It belongs with the codecs, next to the AudioEncoder interface.
R=andrew@webrtc.org , henrik.lundin@webrtc.org , kjellander@webrtc.org
Previously committed here: https://code.google.com/p/webrtc/source/detail?r=7798
and reverted here: https://code.google.com/p/webrtc/source/detail?r=7799
Review URL: https://webrtc-codereview.appspot.com/27309004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7839 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-09 10:12:53 +00:00
