665fb42d95
Fix gn check for Fuchsia builds.
...
Bug: None
Change-Id: I83b420b21b3acaedd86cdedb71febd1ce31ff7f0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264980
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Christoffer Jansson <jansson@webrtc.org >
Reviewed-by: Christoffer Jansson <jansson@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37106}
2022-06-03 08:14:03 +00:00
781c12e7fb
Reland "Refactor IceControllerEvent" 2/n
...
This is a partial reland of commit 794e68cf3dbc3b16ee8b12b5615d8a1622154dbd
which uses the new enum in P2PTransportChannel and BasicIceController.
Original change's description:
> Refactor IceControllerEvent
>
> This change is the first step in decoupling IceControllerEvent from
> the ICE switch reason. Further cleanup is earmarked, and will be
> landed after some internal cleanup.
>
> This change
> - adds a new enum - IceSwitchReason
> - adds a member for the new enum in IceControllerEvent
> - uses the new enum within P2PTransportChannel
> - adds methods to IceControllerInterface accepting the new enum
> - deprecates usages of the old enum in IceControllerInterface
> - adds conversion between the old and new enums for compatibility
>
> Bug: webrtc:14125, webrtc:14131
> Change-Id: I5b7201c3f631eb40db334dfeec842841a7e58174
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264140
> Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
> Commit-Queue: Sameer Vijaykar <samvi@google.com >
> Cr-Commit-Position: refs/heads/main@{#37051}
Bug: webrtc:14125, webrtc:14131
Change-Id: I81b0338ae2f0560cd3df7ad9bd9af37e7c3499df
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264554
Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
Commit-Queue: Sameer Vijaykar <samvi@google.com >
Cr-Commit-Position: refs/heads/main@{#37105}
2022-06-03 07:42:03 +00:00
35fc144e01
Rename 'iOS64 Sim Debug (iOS 14.0)' bot.
...
Change-Id: I83bb0dfd0edcc199c2e44d2627bb6945514a6c84
Bug: b/228171822
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264941
Commit-Queue: Jeremy Leconte <jleconte@google.com >
Reviewed-by: Christoffer Jansson <jansson@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37104}
2022-06-03 07:17:27 +00:00
33e5873712
Upgrade iOS bots to xcode 13.
...
Also update ios 14.0 simulators to 14.5 because tests were failing.
Change-Id: I36c946ff26899502ad611d3f473f3692374b08a4
Bug: b/228171822
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264830
Reviewed-by: Christoffer Jansson <jansson@webrtc.org >
Commit-Queue: Jeremy Leconte <jleconte@google.com >
Cr-Commit-Position: refs/heads/main@{#37103}
2022-06-03 07:06:37 +00:00
18b82e22ee
Update WebRTC code version (2022-06-03T04:04:21).
...
Bug: None
Change-Id: I533f3455ed016502ab1acdfa42c4988db2000ecc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264891
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37102}
2022-06-03 05:40:37 +00:00
cab538338c
Roll chromium_revision 4bf2035caa..7f7a2bf332 (1010241:1010362)
...
Change log: 4bf2035caa..7f7a2bf3324bf2035caa..7f7a2bf3327c5b5c49d4..d8263d5a2295eccc3411..b926bd174f9848e0f32d..a428411c9cef67f24fa2..7e2968b4fd3b22b4d888..2321cda59chttps://chromium.googlesource.com/catapult.git/+log/1cac3deac8..3a2e446a98
* src/third_party/depot_tools: 2a229719c2..14e6d235f23d0e79814e..1a11609b544bf2035caa..7f7a2bf332https://webrtc-review.googlesource.com/c/src/+/264888
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37101}
2022-06-03 00:40:06 +00:00
68e9eb770f
Roll chromium_revision 48fce5db5a..4bf2035caa (1010120:1010241)
...
Change log: 48fce5db5a..4bf2035caa48fce5db5a..4bf2035caa685d04c163..7c5b5c49d47b8bc6fed8..95eccc3411dc13b0ed71..9848e0f32d6728f53565..ef67f24fa228219c324d..3b22b4d8888f1fea025d..2a229719c2d685798123..c26872ed59fe9b816134..3d0e79814e48fce5db5a..4bf2035caahttps://webrtc-review.googlesource.com/c/src/+/264887
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37100}
2022-06-02 20:32:59 +00:00
3013d383c4
Roll chromium_revision 32b557421f..48fce5db5a (1010009:1010120)
...
Change log: 32b557421f..48fce5db5a32b557421f..48fce5db5af10a4cbe06..685d04c163d95e42df71..7b8bc6fed88b438f370d..dc13b0ed71122cd8d853..6728f5356599d293658d..28219c324d171a2ed360..fe9b81613432b557421f..48fce5db5ahttps://webrtc-review.googlesource.com/c/src/+/264881
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37099}
2022-06-02 17:09:56 +00:00
8d847f077c
Introduce PacerController::SendBurstInterval
...
Allows the PacerController to send packets in bursts. If there are enqued packets, or a packet is enqueued while the pacer have a small media debt, an enqued packet is allowed to be sent immediately as long as the debt is smaller than the set burst interval.
Bug: b/233850913
Change-Id: Ibb0fa63c97409ca23b9fa7148b5ff6ce8c4517e2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264462
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Commit-Queue: Per Kjellander <perkj@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37098}
2022-06-02 15:10:06 +00:00
5a3732cc8c
Disable tests depending on libyuv upscale filtering
...
Bug: NONE
Change-Id: I6e8147428b3dba3849a9835d2686083e8aec6d6b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264828
Commit-Queue: Magnus Jedvert <magjed@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37097}
2022-06-02 13:24:46 +00:00
4f7486ab3b
Destroy peerconnections in test when they refer to on-stack mocks
...
Adds a function to PeerConnectionIntegrationBaseTest to stop and destroy
the caller and callee objects. This should take care of dangling pointers.
Before this change, the affected test would crash randomly - typically
detected within a few minutes of a gtest-repeat=-1 run.
After this change, it has not crashed in 15 minutes of running.
Bug: webrtc:12592
Change-Id: I9980f8974015bf2b2104fcb83c2ca0d677d03c3e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264555
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37096}
2022-06-02 13:11:11 +00:00
028697365d
Reland "Add Fuchsia desktop capturer."
...
This is a reland of commit 39b6cb651ed158630cde4d11f5e981cad599f215
Original change's description:
> Add Fuchsia desktop capturer.
>
> This enables screen sharing on Fuchsia.
>
> Bug: chromium:1322341
> Change-Id: I2f52f6bfe7406b5fe36ae904a0cdf30e8168cac5
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262340
> Reviewed-by: Emircan Uysaler <emircan@google.com >
> Commit-Queue: Sarah Pham <smpham@google.com >
> Reviewed-by: Alexander Cooper <alcooper@chromium.org >
> Cr-Commit-Position: refs/heads/main@{#37029}
Bug: chromium:1322341
Change-Id: Iac7c764da03d91b3c79ac0bbd9eb4c717e8c11df
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264824
Reviewed-by: Christoffer Jansson <jansson@webrtc.org >
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37095}
2022-06-02 12:46:06 +00:00
3382c1c06e
Reland "Refactor IceControllerEvent" 1/n
...
This is a partial reland of commit 794e68cf3dbc3b16ee8b12b5615d8a1622154dbd
which
- adds a new enum - IceSwitchReason
- adds a member for the new enum in IceControllerEvent
- adds methods to IceControllerInterface accepting the new enum
- adds conversion between the old and new enums for compatibility
Original change's description:
> Refactor IceControllerEvent
>
> This change is the first step in decoupling IceControllerEvent from
> the ICE switch reason. Further cleanup is earmarked, and will be
> landed after some internal cleanup.
>
> This change
> - adds a new enum - IceSwitchReason
> - adds a member for the new enum in IceControllerEvent
> - uses the new enum within P2PTransportChannel
> - adds methods to IceControllerInterface accepting the new enum
> - deprecates usages of the old enum in IceControllerInterface
> - adds conversion between the old and new enums for compatibility
>
> Bug: webrtc:14125, webrtc:14131
> Change-Id: I5b7201c3f631eb40db334dfeec842841a7e58174
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264140
> Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
> Commit-Queue: Sameer Vijaykar <samvi@google.com >
> Cr-Commit-Position: refs/heads/main@{#37051}
Bug: webrtc:14125, webrtc:14131
Change-Id: I2ccdd53c80e38dc139669aa3f438864befed3dc0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264506
Commit-Queue: Sameer Vijaykar <samvi@google.com >
Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37094}
2022-06-02 12:24:36 +00:00
3eedc90052
Review RtcpTransciverConfig warnings
...
Move warning about missing receive_statistics to AddReceiver to avoid
producing it for rtp send only endpoints.
Remove warning about missing cname as unimportant.
Bug: webrtc:8239
Change-Id: I8a90aa4b378284b9c68f67678b2392b9461c95b4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264825
Reviewed-by: Emil Lundmark <lndmrk@webrtc.org >
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37093}
2022-06-02 11:53:36 +00:00
917ebd40c9
Roll chromium_revision 820d635a1c..32b557421f (1009897:1010009)
...
Change log: 820d635a1c..32b557421f820d635a1c..32b557421fdf6c053c6b..f10a4cbe06234a35b07f..d95e42df715e737be79c..86ab9dd743775d989568..8b438f370d07a9376d5f..122cd8d85361a2cc2edd..99d293658d5965d3e6fb..8f1fea025d42ce42ff35..e28fc0e83ffb1dcea2db..171a2ed360820d635a1c..32b557421fhttps://webrtc-review.googlesource.com/c/src/+/264840
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37092}
2022-06-02 10:48:56 +00:00
f73dc86cf5
Update gtest-parallel to the latest patch.
...
Patch includes:
* Consider tests that reach the timeout as failed.
e28fc0e83fhttps://webrtc-review.googlesource.com/c/src/+/264822
Commit-Queue: Jeremy Leconte <jleconte@google.com >
Reviewed-by: Christoffer Jansson <jansson@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37091}
2022-06-02 10:39:27 +00:00
b22cabcf76
Add AbslParse functions for TimeMode enum. (This allows creation of TimeMode ABSL_FLAGs.)
...
Bug: webrtc:14145
Change-Id: Id79c4411ba4443a3ee8a0da3990c36955cc9aa35
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264821
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Auto-Submit: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37090}
2022-06-02 10:07:16 +00:00
25361a89dd
Revert "Reland "Don't create PacketSocketFactory inside BasicPortAllocatorSession""
...
This reverts commit a8be79ce27f10a698bdb46e490c2bbcbb2300e52.
Reason for revert: Downstream projects were not fixed and I was to eager to reland this, sorry about this.
Original change's description:
> Reland "Don't create PacketSocketFactory inside BasicPortAllocatorSession"
>
> This is a reland of commit 7d4634cef76a1ac244d4b83faaf4c617bf236b71
>
> Original change's description:
> > Don't create PacketSocketFactory inside BasicPortAllocatorSession
> >
> > This extends AlwaysValidPointer to avoid creating a unique_ptr inside it.
> >
> > Bug: webrtc:13145
> > Change-Id: I73a4f18d0a7037b57f575b04b134e4f7eadceb79
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/263240
> > Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
> > Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com >
> > Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> > Cr-Commit-Position: refs/heads/main@{#37048}
>
> Bug: webrtc:13145
> Change-Id: I7d64c25b2942b392a1c35ff2fe1edc83d7b03746
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264503
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Reviewed-by: Christoffer Jansson <jansson@webrtc.org >
> Commit-Queue: Christoffer Jansson <jansson@webrtc.org >
> Reviewed-by: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com >
> Cr-Commit-Position: refs/heads/main@{#37088}
Bug: webrtc:13145
Change-Id: Ie7990bae9a7c864ffaa4eb5b637618caad509633
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264823
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Christoffer Jansson <jansson@webrtc.org >
Owners-Override: Christoffer Jansson <jansson@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37089}
2022-06-02 09:45:16 +00:00
a8be79ce27
Reland "Don't create PacketSocketFactory inside BasicPortAllocatorSession"
...
This is a reland of commit 7d4634cef76a1ac244d4b83faaf4c617bf236b71
Original change's description:
> Don't create PacketSocketFactory inside BasicPortAllocatorSession
>
> This extends AlwaysValidPointer to avoid creating a unique_ptr inside it.
>
> Bug: webrtc:13145
> Change-Id: I73a4f18d0a7037b57f575b04b134e4f7eadceb79
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/263240
> Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
> Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com >
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#37048}
Bug: webrtc:13145
Change-Id: I7d64c25b2942b392a1c35ff2fe1edc83d7b03746
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264503
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Christoffer Jansson <jansson@webrtc.org >
Commit-Queue: Christoffer Jansson <jansson@webrtc.org >
Reviewed-by: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com >
Cr-Commit-Position: refs/heads/main@{#37088}
2022-06-02 09:31:06 +00:00
7c3219265e
[PCLF] Add ToString function to VideoSubscription
...
Bug: b/231394729
Change-Id: I1bdebf5eb266d566452b98e2bf52f08b609c427d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264700
Auto-Submit: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37087}
2022-06-02 09:12:37 +00:00
d5ddad4cdb
Remove FrameBuffer2Proxy
...
FrameBuffer3Proxy and sync decoding has been shown to work. First step of cleaning up is to remove the FrameBuffer2Proxy.
Change-Id: Ic96303c2d4f9111cfeed9927e8826ea7ffe7ee17
Bug: webrtc:14003
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264126
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Evan Shrubsole <eshr@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37086}
2022-06-02 08:03:36 +00:00
709ab8b536
Update WebRTC code version (2022-06-02T04:05:29).
...
Bug: None
Change-Id: Ice47703cbbbaf183d406e84d09613c00e59a5786
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264761
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37085}
2022-06-02 05:34:46 +00:00
c4ca83c2bd
Send side bwe receives the delay based state even if the delay based bwe does not change its estimate.
...
Bug: webrtc:12707
Change-Id: If67dcc6d1cb70dc763ab65bdb8426de100bcc626
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261312
Reviewed-by: Per Kjellander <perkj@webrtc.org >
Commit-Queue: Per Kjellander <perkj@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37084}
2022-06-02 04:33:16 +00:00
f2c49491b3
Roll chromium_revision 6c9f8554db..820d635a1c (1009772:1009897)
...
Change log: 6c9f8554db..820d635a1c6c9f8554db..820d635a1c6f98109079..df6c053c6ba43fbff23f..234a35b07f7bb7790aae..775d9895683bf4fe4581..07a9376d5f897ed9f2d4..61a2cc2eddhttps://chromium.googlesource.com/catapult.git/+log/fba169d2a9..1cac3deac8
* src/third_party/depot_tools: e1197f06a8..5965d3e6fb6a3e0c3782..fb1dcea2db6c9f8554db..820d635a1chttps://webrtc-review.googlesource.com/c/src/+/264740
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37083}
2022-06-02 02:38:36 +00:00
7460d07c08
Merge "Update build flags for Cuttlefish support" am: c902b87e10 am: 0a73cff00c am: 8662063090 am: 25c955bfe5
...
Original change: https://android-review.googlesource.com/c/platform/external/webrtc/+/2111748
Change-Id: Ie1b309acc507674c4687d313be236693fb02040c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-06-02 01:26:54 +00:00
25c955bfe5
Merge "Update build flags for Cuttlefish support" am: c902b87e10 am: 0a73cff00c am: 8662063090
...
Original change: https://android-review.googlesource.com/c/platform/external/webrtc/+/2111748
Change-Id: Ia45c2715275c00d03f59962bcf96107f82fc46e9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-06-02 01:03:31 +00:00
8662063090
Merge "Update build flags for Cuttlefish support" am: c902b87e10 am: 0a73cff00c
...
Original change: https://android-review.googlesource.com/c/platform/external/webrtc/+/2111748
Change-Id: Iaf2e8e8d198bc5c8f28050dd00c8e0c3fee494dd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-06-02 00:47:01 +00:00
0a73cff00c
Merge "Update build flags for Cuttlefish support" am: c902b87e10
...
Original change: https://android-review.googlesource.com/c/platform/external/webrtc/+/2111748
Change-Id: I7265874d14c6f4f768ba4f742801dd88bb55bb0e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-06-02 00:29:59 +00:00
c902b87e10
Merge "Update build flags for Cuttlefish support"
2022-06-02 00:11:38 +00:00
bccb452eb6
[PCLF] Add ToString function for VideoResolution
...
Bug: b/231394729
Change-Id: Iac803440153d368f0c2ea143e64fe347323eeeef
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264556
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37082}
2022-06-01 21:40:56 +00:00
eb2d5ea25e
Update build flags for Cuttlefish support
...
Web camera crashes without change.
Change-Id: I8cfdc0f4f7d91e1040550ae5e6a84c03ae060311
Test: compiles, treehugger
Bug: 234571051
2022-06-01 21:08:26 +00:00
7e897aeb92
dcsctp: Add public API for setting priorities
...
This is a reland of commit 17a02a31d7d2897b75ad69fdac5d10e7475a5865.
This is the first part of supporting stream priorities, and adds the API
and very basic support for setting and retrieving the stream priority.
This commit doesn't in any way change the actual packet sending - the
specified priority values are stored, but not acted on.
This is all that is client visible, so clients can start using the API
as written, and they would never notice that things are missing.
Bug: webrtc:5696
Change-Id: I04d64a63cbaec67568496ad99667e14eba85f2e0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264424
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37081}
2022-06-01 20:46:25 +00:00
8c0f54b92c
Roll chromium_revision 464351309a..6c9f8554db (1009636:1009772)
...
Change log: 464351309a..6c9f8554db464351309a..6c9f8554db8feebe15cc..6f98109079dfd00fd062..a43fbff23fa0b530e9f8..7bb7790aae6c4c0c89bd..3bf4fe458152d60b14cb..897ed9f2d4d61b207491..c88a6a9ec3d55a1685ae..d836f02e9aab5c659fbd..6a3e0c3782464351309a..6c9f8554dbhttps://webrtc-review.googlesource.com/c/src/+/264607
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37080}
2022-06-01 20:32:25 +00:00
408143d5af
Refactor StunMessage a bit
...
* Add ctors for providing the type and transaction id at construction.
* Update tests to use them instead of SetType+SetTransactionID
* Make sure stun message enum types are based on uint16_t
* Mark SetTransactionID as deprecated.
* Mark SetStunMagicCookie as deprecated (unused in webrtc).
* Add SetTransactionIdForTest for the one test that uses it (might not
actually need it)
* Make StunRequest::Construct() protected.
* Add a TODO to follow up on this since construction of StunRequest
goes through an unnecessarily complex 3-step process involving
other classes and a virtual method.
Bug: none
Change-Id: Ib013e58f28e7b2b4fcb3b3e1034da31dfc93e9d3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264546
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37079}
2022-06-01 17:43:55 +00:00
80a860532e
Roll chromium_revision 14ba5b3811..464351309a (1009517:1009636)
...
Change log: 14ba5b3811..464351309a14ba5b3811..464351309ab14e9ee760..8feebe15ccfb6ee3587b..dfd00fd062893f06e590..a0b530e9f87ccc549b7c..6c4c0c89bd641074136b..52d60b14cb989b580fdb..d55a1685ae9d169e0c0e..ab5c659fbd14ba5b3811..464351309ahttps://webrtc-review.googlesource.com/c/src/+/264641
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37078}
2022-06-01 16:39:45 +00:00
cff66f537c
[DVQA] Add support for frames without frame id
...
Bug: b/234176678
Change-Id: Ibbd82e3341d7b4034173e6e5ada882e079449f8e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264552
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37077}
2022-06-01 13:31:46 +00:00
2a30693718
Add functions using Timestamp and TimeDelta for rtcp::TransportFeedback
...
BaseTime represents fixed point in time with unknown epoch and thus
make sense to convert to Timestamp type, however Timestamp should always
be positive. however legacy tests expect GetBaseTimeUs to return negative time sometimes.
Bug: webrtc:13757
Change-Id: I3f780a7775fdd1e271402c59384c1298db76f75a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264549
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Per Kjellander <perkj@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37076}
2022-06-01 13:05:55 +00:00
fd8ed05cee
[PCLF] Add equals method for VideoSubscription
...
Bug: b/231394729
Change-Id: I0957d96640e962d331f05c9541c36e8420e9f5aa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264557
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37075}
2022-06-01 12:36:45 +00:00
4eab9f47a5
Make the libaom AV1 encoder optional in RTCDefaultVideoEncoderFactory.
...
This is a partial revert of: https://webrtc-review.googlesource.com/c/src/+/262814
skip_shebang_check=True
bug: webrtc:13573
Change-Id: I08282df91446efa79ca86cc8dfe3b6daeb4eec9a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264543
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37074}
2022-06-01 10:54:55 +00:00
2f9d60b18d
Roll chromium_revision 326f66095b..14ba5b3811 (1009407:1009517)
...
Change log: 326f66095b..14ba5b3811326f66095b..14ba5b3811988a24a56a..fb6ee3587b0544ae3c9b..893f06e590021d1901d8..7ccc549b7c2436308cc9..641074136b739a76e05d..e1197f06a8b98dd169a1..d685798123531c4820f5..9d169e0c0e326f66095b..14ba5b3811https://webrtc-review.googlesource.com/c/src/+/264640
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37073}
2022-06-01 10:32:26 +00:00
9b9d533d48
Remove deprecated VideoReceiveStream alias
...
Bug: webrtc:7484
Change-Id: Id1b3c5e30259ffdad92a1a6ead94dd1acab63cff
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264563
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37072}
2022-06-01 10:17:55 +00:00
83e34eed87
Migrate some scripts to python3
...
python-modernize, format and some manual lint fixes
No-Try: True
Bug: None
Change-Id: I89d9f97f238be887962c67e18cc6480a8f6f3ac4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264551
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37071}
2022-06-01 10:09:36 +00:00
563dfd1948
Update WebRTC code version (2022-06-01T04:04:59).
...
Bug: None
Change-Id: Ie287ab84ab2760efca0546c637d7742b2c0d14fa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264601
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37070}
2022-06-01 06:44:17 +00:00
381d5e7ecd
Roll chromium_revision 9950f8039a..326f66095b (1009295:1009407)
...
Change log: 9950f8039a..326f66095b9950f8039a..326f66095ba9fbdf43af..b14e9ee760075ac49207..988a24a56a42eb62cc38..0544ae3c9b577819c114..021d1901d82f7fc69a1e..2436308cc9https://chromium.googlesource.com/catapult.git/+log/9717ac905b..fba169d2a9
* src/third_party/depot_tools: 41691abe86..739a76e05dddf7b7fb45..531c4820f59950f8039a..326f66095bhttps://webrtc-review.googlesource.com/c/src/+/264586
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37069}
2022-06-01 02:36:25 +00:00
185e9031f3
Roll chromium_revision e33e51ad95..9950f8039a (1009167:1009295)
...
Change log: e33e51ad95..9950f8039ae33e51ad95..9950f8039a82f8777552..a9fbdf43afab3703d871..075ac49207ed0a523ecc..42eb62cc38e664330104..577819c1142089f21ebb..2f7fc69a1e10a8286824..41691abe8640eee45831..989b580fdbe9d94093a7..ddf7b7fb45e33e51ad95..9950f8039ae33e51ad95..9950f8039ahttps://webrtc-review.googlesource.com/c/src/+/264584
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37068}
2022-05-31 23:02:55 +00:00
ee6ad1403a
Roll chromium_revision 1891773fa9..e33e51ad95 (1009039:1009167)
...
Change log: 1891773fa9..e33e51ad951891773fa9..e33e51ad95f902b7a9a2..82f87775528682a2dc85..ab3703d8711a14c57752..c30c515c84051b5c47a8..ed0a523ecc61885dc88b..e664330104c940de3868..2089f21ebbfeeb5c1043..40eee458313bb820e5ed..e9d94093a71891773fa9..e33e51ad95https://webrtc-review.googlesource.com/c/src/+/264582
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37067}
2022-05-31 18:36:15 +00:00
32c60b84c3
Reland "sdp: reject duplicate codecs with the same id but different name or clockrate"
...
This is a reland of commit ad6807805d12e48f11c3a68b4befaf8d7c23e8b5
Original change's description:
> sdp: reject duplicate codecs with the same id but different name or clockrate
>
> since something like
> rtpmap:96 VP8/90000
> rtpmap:96 VP9/90000
> or
> rtpmap:97 ISAC/32000
> rtpmap:97 ISAC/16000
> is wrong. Note that fmtp or rtcp-fb are not taken into account.
> Also note that sending invalid static payload types now throws an error.
>
> Drive-by: replace "RtpMap" with "Rtpmap" for consistency.
>
> BUG=None
>
> Change-Id: I2574b82a6f1a0afe3edc866e514a5dbca0798e8c
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/263641
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com >
> Cr-Commit-Position: refs/heads/main@{#37028}
Bug: webrtc:14140
Change-Id: I63a37aacea6b9e0a9d7570b8422849275eb69aae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264544
Reviewed-by: Christoffer Jansson <jansson@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com >
Cr-Commit-Position: refs/heads/main@{#37066}
2022-05-31 16:09:17 +00:00
6ef0a3816e
Delete old StringToProto signature
...
Bug: webrtc:13579
Change-Id: I9bc01ce6e41a906d962522d0b395702db7a578f7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/263583
Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37065}
2022-05-31 13:39:34 +00:00
874517b5f5
Revert "sdp: reject duplicate codecs with the same id but different name or clockrate"
...
This reverts commit ad6807805d12e48f11c3a68b4befaf8d7c23e8b5.
Reason for revert: Speculative revert due to consistent Mac browser
test failures preventing WebRTC from rolling int Chromium:
https://ci.chromium.org/ui/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Mac%20Tester/10410/overview
"Failed to parse SessionDescription. a=rtpmap:103 ISAC/16000 Duplicate payload type with conflicting codec name, clock rate or number of channels."
Original change's description:
> sdp: reject duplicate codecs with the same id but different name or clockrate
>
> since something like
> rtpmap:96 VP8/90000
> rtpmap:96 VP9/90000
> or
> rtpmap:97 ISAC/32000
> rtpmap:97 ISAC/16000
> is wrong. Note that fmtp or rtcp-fb are not taken into account.
> Also note that sending invalid static payload types now throws an error.
>
> Drive-by: replace "RtpMap" with "Rtpmap" for consistency.
>
> BUG=None
>
> Change-Id: I2574b82a6f1a0afe3edc866e514a5dbca0798e8c
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/263641
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com >
> Cr-Commit-Position: refs/heads/main@{#37028}
Bug: None
Change-Id: Ic9c06c9309bb68bd94bfdd2e30ffd6ff96f6812b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264540
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Christoffer Jansson <jansson@webrtc.org >
Reviewed-by: Philipp Hancke <philipp.hancke@googlemail.com >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37064}
2022-05-31 13:31:56 +00:00
1a5a81340d
Rename discarded_primary_packets to packets_discarded.
...
This it what it is called in the spec:
https://w3c.github.io/webrtc-stats/#dom-rtcreceivedrtpstreamstats-packetsdiscarded
Also log the metric in neteq_rtpplay.
Bug: webrtc:8199
Change-Id: Ie0262d17b913eb6949daa703844d90327eee0aa4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/263725
Reviewed-by: Minyue Li <minyue@webrtc.org >
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org >
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37063}
2022-05-31 13:24:24 +00:00
