3154a1cf9d
Reland r8210 "Add a new parameter to ACMGenericCodec constructor""
...
This effectively reverts r8211.
The problem with r8210 was that the change in constructor signature was not done for other codec selections that then default one. That is, some code that was hidden under #ifdef did not get updated. This is now fixed.
BUG=4228
COAUTHOR=kwiberg@webrtc.org
TBR=minyue@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37879004
Cr-Commit-Position: refs/heads/master@{#8215}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8215 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-30 12:30:22 +00:00
6752b85ff7
Revert r8210 "Add a new parameter to ACMGenericCodec constructor"
...
The change failed to compile on some bots.
TBR=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/34949004
Cr-Commit-Position: refs/heads/master@{#8211}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8211 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-30 06:36:41 +00:00
c3643f2fe3
Add a new parameter to ACMGenericCodec constructor
...
Adding the same parameter to the constructors in all subclasses.
This change is in preparation for changes to come where this will be
needed.
BUG=4228
COAUTHOR=kwiberg@webrtc.org
R=minyue@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/34849004
Cr-Commit-Position: refs/heads/master@{#8210}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8210 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-30 06:15:18 +00:00
7dba7860c7
Setting Opus target application.
...
This CL is to allow to set Opus target application at the creation of an encoder.
According to Opus spec, there are three applications:
OPUS_APPLICATION_VOIP
OPUS_APPLICATION_AUDIO
OPUS_APPLICATION_RESTRICTED_LOWDELAY
BUG=
R=henrik.lundin@webrtc.org , tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37479004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8103 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-20 16:01:50 +00:00
23a5e3c3b0
Remove DestructEncoderInst and its codec-specific implementations.
...
This method is seemingly never called.
BUG=none
TEST=none
R=henrik.lundin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/24539004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7131 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 08:52:26 +00:00
51bb33cc18
ACMOpus: Remove useless member variable fec_enabled_
...
R=henrik.lundin@webrtc.org , minyue@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/18319004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7057 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-04 08:42:44 +00:00
adee8f9242
Renaming SetOpusMaxBandwidth to SetOpusMaxPlaybackRate
...
This is to maintain the consistency with the Opus codec option "maxplaybackrate" defined in http://tools.ietf.org/html/draft-spittka-payload-rtp-opus-03
BUG=
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14279004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7038 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-03 12:28:06 +00:00
e9b493e763
Removing macro in acm_opus.cc
...
Remove it since macros are not recommended to use according to code style guide.
BUG=
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/21219004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6917 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-18 12:06:31 +00:00
e8018b0b24
Adding a 5% as packet loss level for Opus
...
This is a follow up of
https://webrtc-codereview.appspot.com/16979004/
The purpose of this CL is to add 5% as a level for optimizing the packet loss rate to report to Opus. Adding such a level makes the grid finer.
BUG=
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/13179004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6902 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-14 12:16:12 +00:00
6aac93bd9c
Adding SetOpusMaxBandwidth in VoE and ACM
...
This is a step to solve
https://code.google.com/p/webrtc/issues/detail?id=1906
In particular, we add an API in VoE and ACM to call Opus's API of setting maximum bandwidth.
TEST = added a test in voe_cmd_test and listened to the result
BUG=
R=henrika@google.com , henrika@webrtc.org , turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/21129004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6869 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-12 08:13:33 +00:00
1d956dd1a7
Since the packet loss rate cannot be estimated accurately, there is always a mismatch between the estimated packet loss rate and the true one. Such a mismatch will make Opus FEC suboptimal.
...
It is advisable to set the packet loss rate of FEC conservatively. Say, if the estimated loss rate is 5%, we can set it to 1%. The risk of degradation in quality is small and the overall performance is good.
BUG=
R=henrik.lundin@webrtc.org , turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/16979004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6844 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-07 12:31:36 +00:00
eec6ecdb1e
Landing pkasting's webrtc fixes for MSVC level 4 warnings in WebRTC.
...
---
Fixes for re-enabling more MSVC level 4 warnings: webrtc/ edition
This contains fixes for the following sorts of issues:
* Possibly-uninitialized local variable
* Signedness mismatch
* Assignment inside conditional
This also contains a small number of other cleanups to nearby code. In
particular several warning-disables for MSVC are removed because they don't seem
to be necessary (either that warning is not enabled or the code does not trigger
it).
BUG=crbug.com/81439
TEST=none
R=henrika@webrtc.org , pkasting@chromium.org
Review URL: https://webrtc-codereview.appspot.com/18769004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6667 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-11 19:09:59 +00:00
aa5ea1c0f9
1. Make a clear distinction between codec internal FEC and RED, confusing mentioning of FEC in the old codes is replaced by RED
...
2. Add two new APIs to configure codec internal FEC
3. Add a test and listened to results. This is based modifying EncodeDecodeTest and deriving a new class from it.
New ACM gives good result.
Old ACM does not use NetEq 4, so FEC won't be decoded.
BUG=
R=tina.legrand@webrtc.org , turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/11759004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6233 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-23 15:16:51 +00:00
92c0e29963
Run Opus with lower complexity setting on Android, iOS and/or ARM
...
This CL includes a call to Opus to set a lower complexity figure, if we are compiling for Android, iOS, or ARM (e.g. ChromeOS on ARM), where we know the devices are not powerful enough to run on higher complexity setting.
BUG=3093
R=minyue@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/10489004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5760 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-24 14:38:36 +00:00
6d5d248075
Wrap ACM2 code inside acm2 namespace. This gurantees that one ACM would not use components of others by accident.
...
BUG=
R=minyue@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2344004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4933 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-06 04:47:28 +00:00
48af652ea5
Prepare to compile ACM1 and ACM2.
...
ACM1 code is wrapped in namespace acm1. Inculde paths and define guards of ACM2 source codes are corrected. gypi file of ACM2 is changed so that ACM1 will later on depends on ACM2.
BUG=
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2206004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4743 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-13 23:06:59 +00:00
7959e16cc2
ACM2 integration with NetEq 4.
...
nack{.cc, .h, _unittest.cc} are basically copies from main/source/ folder, with cpplint warning cleaned up.
BUG=
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2190009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4736 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-12 18:30:26 +00:00
