6955870806
Convert channel counts to size_t.
...
IIRC, this was originally requested by ajm during review of the other size_t conversions I did over the past year, and I agreed it made sense, but wanted to do it separately since those changes were already gargantuan.
BUG=chromium:81439
TEST=none
R=henrik.lundin@webrtc.org , henrika@webrtc.org , kjellander@webrtc.org , minyue@webrtc.org , perkj@webrtc.org , solenberg@webrtc.org , stefan@webrtc.org , tina.legrand@webrtc.org
Review URL: https://codereview.webrtc.org/1316523002 .
Cr-Commit-Position: refs/heads/master@{#11229}
2016-01-13 00:26:55 +00:00
3f7219be70
Fixing issue where description contains empty ICE ufrag/pwd.
...
The issue occurred when deserializing and then serializing a rejected
content description, which doesn't have the ICE ufrag/pwd in the first
place.
BUG=webrtc:5105
Review URL: https://codereview.webrtc.org/1534363002
Cr-Commit-Position: refs/heads/master@{#11134}
2015-12-28 23:17:22 +00:00
a54a080112
Add ufrag to the ICE candidate signaling.
...
On the receiving side, if a candidate arrives with an old ufrag, it will be dropped. If it contains a new frag that has never seen before, it will hold the ufrag and create connections, although those connections are not pingable until the ICE credentials are received.
This could avoid a bunch of ICE generation issues.
BUG=webrtc:5138,webrt:5292
Review URL: https://codereview.webrtc.org/1498993002
Cr-Commit-Position: refs/heads/master@{#11060}
2015-12-17 02:37:27 +00:00
1387149ad1
Adding reduced size RTCP configuration down to the video stream level.
...
Still waiting to turn on negotiation (in mediasession.cc)
until we verify it's working as expected.
BUG=webrtc:4868
Review URL: https://codereview.webrtc.org/1418123003
Cr-Commit-Position: refs/heads/master@{#10958}
2015-12-09 20:37:59 +00:00
5237aaf243
Convert usage of ARRAY_SIZE to arraysize.
...
ARRAY_SIZE is the old version of arraysize and does not cover
all the cases in C++, arraysize is a copy of Chromium's
version and thus have wider coverage.
BUG=None
R=tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1405023016
Cr-Commit-Position: refs/heads/master@{#10594}
2015-11-11 07:44:39 +00:00
c80741f895
Fixing some issues with the direction attribute of m-lines in offers.
...
By default, we'll now offer to receive if already receiving
(meaning that the last remote description contained a track).
Also, m-lines that are neither receiving nor sending are now correctly
marked "inactive".
Also moved some logic relating to default tracks out of webrtcsdp.cc,
such that now the direction seen by upper layers will always be
consistent with the consumed/produced SDP.
BUG=528089
Review URL: https://codereview.webrtc.org/1406803004
Cr-Commit-Position: refs/heads/master@{#10376}
2015-10-22 20:14:51 +00:00
69f576010e
Added parsing of either space or colon for sctp-port.
...
BUG=https://code.google.com/p/webrtc/issues/detail?id=5039
Review URL: https://codereview.webrtc.org/1395523002
Cr-Commit-Position: refs/heads/master@{#10225}
2015-10-08 17:15:08 +00:00
0c4e06b4c6
Use suffixed {uint,int}{8,16,32,64}_t types.
...
Removes the use of uint8, etc. in favor of uint8_t.
BUG=webrtc:5024
R=henrik.lundin@webrtc.org , henrikg@webrtc.org , perkj@webrtc.org , solenberg@webrtc.org , stefan@webrtc.org , tina.legrand@webrtc.org
Review URL: https://codereview.webrtc.org/1362503003 .
Cr-Commit-Position: refs/heads/master@{#10196}
2015-10-07 10:23:32 +00:00
7cbd188c5e
Remove GICE (again).
...
R=guoweis@webrtc.org
Review URL: https://codereview.webrtc.org/1353713002 .
Cr-Commit-Position: refs/heads/master@{#9979}
2015-09-18 01:55:03 +00:00
d12140a68e
Revert change which removes GICE.
...
There are still dependencies on this functionality.
TBR=pthatcher@webrtc.org
BUG=526399
Review URL: https://codereview.webrtc.org/1336553003
Cr-Commit-Position: refs/heads/master@{#9920}
2015-09-10 20:32:21 +00:00
2159b89fa2
Reland "Remove GICE (gone forever!) and PORTALLOCATOR_ENABLE_SHARED_UFRAG (enabled forever)." becauese remoting code is using dead constants and breaks the FYI bots.
...
This reverts commit 5bdafd44c86ee46bd7e040f19828324583418b33.
Original CL: https://codereview.webrtc.org/1263663002/
R=guoweis@webrtc.org
Review URL: https://codereview.webrtc.org/1303393002 .
Cr-Commit-Position: refs/heads/master@{#9761}
2015-08-22 03:46:18 +00:00
5bdafd44c8
Revert "Reland "Remove GICE (gone forever!) and PORTALLOCATOR_ENABLE_SHARED_UFRAG (enabled forever)." becauese remoting code is using dead constants and breaks the FYI bots.""
...
This reverts commit 081f34b564e1a26ffbbe9515eba1fef7c736fdde.
Original code review see
https://codereview.webrtc.org/1291363005
The revert is due to a suspicion of "Reland "Remove GICE..." being the cause of failure on Linux memcheck, see
https://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/4137
TBR=pthatcher@webrtc.org ,
BUG=
Review URL: https://codereview.webrtc.org/1308753003 .
Cr-Commit-Position: refs/heads/master@{#9756}
2015-08-21 13:52:58 +00:00
081f34b564
Reland "Remove GICE (gone forever!) and PORTALLOCATOR_ENABLE_SHARED_UFRAG (enabled forever)." becauese remoting code is using dead constants and breaks the FYI bots."
...
This reverts commit 475243a134be003aab30bb17294ca6c664d0ef81.
R=guoweis@webrtc.org
Review URL: https://codereview.webrtc.org/1291363005 .
Cr-Commit-Position: refs/heads/master@{#9738}
2015-08-20 03:37:59 +00:00
fa301809b6
Revert "Remove GICE (gone forever!) and PORTALLOCATOR_ENABLE_SHARED_UFRAG (enabled forever)." becauese remoting code is using dead constants and breaks the FYI bots.
...
This reverts commit 3449faa553ec94c52ef2d0949867befb60992c88.
TBR=deadbeef@webrtc.org , juberti@webrtc.org
NOPRESUBMIT=true
Review URL: https://codereview.webrtc.org/1274273005
Cr-Commit-Position: refs/heads/master@{#9698}
2015-08-11 11:13:00 +00:00
3449faa553
Remove GICE (gone forever!) and PORTALLOCATOR_ENABLE_SHARED_UFRAG (enabled forever).
...
R=deadbeef@webrtc.org , juberti@webrtc.org
Review URL: https://codereview.webrtc.org/1263663002 .
Cr-Commit-Position: refs/heads/master@{#9692}
2015-08-10 19:22:59 +00:00
a9b4c32052
Nuke buffered latency mode. It's not actually working, and it's not used. It's just dead code complexity.
...
R=pbos@webrtc.org
Review URL: https://codereview.webrtc.org/1226093010 .
Cr-Commit-Position: refs/heads/master@{#9593}
2015-07-16 10:47:39 +00:00
083b73fb95
Use std::string references instead of copying contents.
...
This CL improves the memory footprint a bit by using string references
instead of creating a copy.
Review URL: https://codereview.webrtc.org/1241973002
Cr-Commit-Position: refs/heads/master@{#9592}
2015-07-16 09:46:43 +00:00
bb36fdf95f
Remove empty-string comparisons.
...
Use .empty() and !.empty() in favor of == "" or != "".
BUG=
R=tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1228913003
Cr-Commit-Position: refs/heads/master@{#9559}
2015-07-09 14:48:27 +00:00
c0c3a865f4
Prevent JS from bypassing RTP data channel bandwidth limitation.
...
Normally the RTP data channel is capped at 30kbps, but by mangling the
SDP string, one could get around this limitation. With this fix,
SdpDeserialize will return an error if it detects this condition.
BUG=280726
R=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1196403004 .
Cr-Commit-Position: refs/heads/master@{#9499}
2015-06-24 22:31:35 +00:00
144d01850b
fix indent on tokenize_first function signatures
...
R=juberti@google.com , pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/52499004
Cr-Commit-Position: refs/heads/master@{#9198}
2015-05-15 20:14:13 +00:00
0e07f92043
Split fmtp on semicolons not spaces as per RFC6871
...
BUG=4617
R=pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/47169004
Cr-Commit-Position: refs/heads/master@{#9193}
2015-05-15 16:21:16 +00:00
019087f5bb
Add safeguards against signalling peer-reflexive candidates.
...
BUG=4208
R=juberti@google.com
Review URL: https://webrtc-codereview.appspot.com/50799004
Cr-Commit-Position: refs/heads/master@{#9104}
2015-04-28 16:06:34 +00:00
7100dcd317
Adding "usedtx" as Opus codec parameter.
...
This is according to https://tools.ietf.org/html/draft-spittka-payload-rtp-opus-03
Specifically,
usedtx: specifies if the decoder prefers the use of DTX. values are 1 and 0. If no value is specified, usedtx is assumed to be 0.
BUG=1014
R=juberti@webrtc.org , tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/48499004
Cr-Commit-Position: refs/heads/master@{#8872}
2015-03-27 04:06:35 +00:00
2d25b44f47
Check associated payload type when negotiate RTX codecs.
...
At the moment, only payload name is checked when match two RTX codecs.
This will cause wrong behavior of codec negotiation if multiple RTX codecs
are added.
BUG=
R=pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/34189004
Cr-Commit-Position: refs/heads/master@{#8727}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8727 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-16 04:15:23 +00:00
a747093334
After another round of reviews.
...
Cr-Commit-Position: refs/heads/master@{#8483}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8483 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-24 20:20:19 +00:00
9616196c38
Merging definitions of IsSctp.
...
Cr-Commit-Position: refs/heads/master@{#8482}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8482 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-24 20:20:18 +00:00
12aa8a68f9
Post-rebase.
...
Cr-Commit-Position: refs/heads/master@{#8481}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8481 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-24 20:20:17 +00:00
1730869596
Added raw SCTP to IsSctp.
...
Cr-Commit-Position: refs/heads/master@{#8480}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8480 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-24 20:19:32 +00:00
871b1c373a
Review comments -- added IsSctp()
...
Cr-Commit-Position: refs/heads/master@{#8479}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8479 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-24 20:19:31 +00:00
d324546ced
Misc. cleanup split out of https://webrtc-codereview.appspot.com/37699004/ :
...
* Move constants into the files/functions that use them
* Declare variables in the narrowest scope possible
* Use correct (expected, actual) order for gtest macros
* Remove unused functions
* Untabify
* 80-column limit
* Avoid C-style casts
* Prefer true typed constants to "enum hack" constants
* Print size_t using the right format macro
* Shorten and simplify code
* Other random cleanup bits and style fixes
BUG=none
TEST=none
R=henrik.lundin@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/36179004
Cr-Commit-Position: refs/heads/master@{#8467}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8467 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-23 21:29:45 +00:00
a744a28b92
Templatize and clean up codec wildcards.
...
BUG=4123
R=pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39209004
Cr-Commit-Position: refs/heads/master@{#8422}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8422 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-18 21:38:20 +00:00
e9facf8bb3
Add range checks in a variety of places where the values will subsequently be
...
expected to be 0-127.
BUG=none
TEST=none
R=juberti@webrtc.org
TBR=henrika
Review URL: https://webrtc-codereview.appspot.com/37759004
Cr-Commit-Position: refs/heads/master@{#8399}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8399 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-17 20:37:35 +00:00
3341b401cc
Fix bug parsing media descriptions: the final field isn't a codec type for any of DTLS/SCTP, SCTP, or SCTP/DTLS.
...
BUG=none
TEST=none
R=juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/34029004
Cr-Commit-Position: refs/heads/master@{#8369}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8369 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-13 21:14:44 +00:00
57ac2c84dd
Default destination used by c line should be IPv4 only to avoid parsing error in legacy client.
...
Make sure the IP family overwrites the preference of candidates. Also,
make sure only UDP is used as default destination.
BUG=4269
R=juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/36009004
Cr-Commit-Position: refs/heads/master@{#8258}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8258 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-06 00:45:43 +00:00
5f93d0a140
Update libjingle license statements at top of talk files for consistency
...
BUG=2133
R=juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39559004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8105 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-20 21:36:13 +00:00
61c1247224
Fix a case where empty candidate id is used
...
BUG=4161
R=juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/35749004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8071 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-15 06:53:07 +00:00
8af11042cb
Avoid reading past end of string in GetLine.
...
BUG=3881
R=pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39369004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8017 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-07 19:15:51 +00:00
950c518251
Add adapter_type into Candidate object.
...
Expose adapter_type from Candidate such that we could add jmidata on top of this.
Created a new type of report just for Ice candidate. The candidate's id is used as part of report identifier. This code change only reports the best connection's local candidate's adapter type. There should be cleaning later to move other candidate's attributes to the new report.
This is migrated from issue 32599004
BUG=
R=juberti@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=7885
Committed: https://code.google.com/p/webrtc/source/detail?r=7906
Review URL: https://webrtc-codereview.appspot.com/36379004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7925 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-16 23:01:31 +00:00
e2b7585bc2
Move ViewRequest and MediaStreams to streamparams.h, and remove dependency on mediasessionclient.h and mediamessages.h. This is part of the effort to remove Jingle-specific code from WebRTC and into its own repository.
...
R=juberti@webrtc.org , pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/36519004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7921 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-16 21:09:08 +00:00
55360ae402
Revert "Add adapter_type into Candidate object."
...
This reverts commit aaf02cc2d4f696345ce0e6d5715f2cfa22aea689.
BUG=
TBR=juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/35539004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7908 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-16 05:28:10 +00:00
aaf02cc2d4
Add adapter_type into Candidate object.
...
Expose adapter_type from Candidate such that we could add jmidata on top of this.
Created a new type of report just for Ice candidate. The candidate's id is used as part of report identifier. This code change only reports the best connection's local candidate's adapter type. There should be cleaning later to move other candidate's attributes to the new report.
This is migrated from issue 32599004
BUG=
R=juberti@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=7885
Review URL: https://webrtc-codereview.appspot.com/36379004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7906 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-15 23:03:10 +00:00
fb108b5a28
Revert r7885.
...
Breaks compile step of other code where network name of
cricket::Candidate is used.
TBR=guoweis@webrtc.org ,juberti@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/31229004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7892 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-15 08:04:50 +00:00
18a3896bd2
Revert r7886:7887.
...
Broke build steps in other code that uses securetunnelsessionclient.cc
and others.
TBR=tommi@webrtc.org ,pthatcher@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/36439004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7890 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-15 07:03:04 +00:00
dee76f3b89
Move the obvious/easy Jingle-specific code into webrtc/libjingle.
...
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/32669004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7886 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-12 21:04:42 +00:00
8c9d79a29d
Add adapter_type into Candidate object.
...
Expose adapter_type from Candidate such that we could add jmidata on top of this.
Created a new type of report just for Ice candidate. The candidate's id is used as part of report identifier. This code change only reports the best connection's local candidate's adapter type. There should be cleaning later to move other candidate's attributes to the new report.
This is migrated from issue 32599004
BUG=
R=juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/36379004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7885 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-12 19:21:14 +00:00
d105cc81dc
Change dummy address to use 0.0.0.0 instead of ::
...
This is to not break compatiblity with FF.
https://code.google.com/p/chromium/issues/detail?id=430333
TBR=pthatcher@webrtc.org , juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/31979004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7661 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-07 11:22:06 +00:00
269fb4bc90
move xmpp and p2p to webrtc
...
Create a copy of talk/xmpp and talk/p2p under webrtc/libjingle/xmpp and
webrtc/p2p. Also makes libjingle use those version instead of the one in the talk folder.
BUG=3379
Review URL: https://webrtc-codereview.appspot.com/26999004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7549 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-28 22:20:11 +00:00
c9d6d14020
patch from issue 25469004
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7517 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-23 23:37:22 +00:00
28100cb388
Reverts r7459 "Create a copy of talk/xmpp and talk/p2p under webrtc/libjingle/xmpp and webrtc/p2p."
...
BUG=N/A
TBR=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/29829004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7472 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-17 22:03:39 +00:00
d1ba6d9cbf
Create a copy of talk/xmpp and talk/p2p under webrtc/libjingle/xmpp and webrtc/p2p.
...
BUG=3379
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/27709005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7459 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-15 17:30:28 +00:00
