8630cfe016
Guarding certain operations, e.g. bandwidth estimation, RTCP statistics update etc., not to be run on sync RTPS.
...
BUG=issue1770
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1485004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4052 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-16 23:54:54 +00:00
4ce838934c
Address sanitizer out of bounds read in iSAC
...
BUG=issue1770
TBR=tlegrand@google.com
Review URL: https://webrtc-codereview.appspot.com/1472006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4030 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-14 17:42:22 +00:00
185bae4b6f
Replace ExtraCodecOptions with new Config class that supports multiple settings at once.
...
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1452004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4017 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-14 08:02:25 +00:00
3004c79c6a
Fix clang errors in non-GYP_DEFINES=clang=1 build
...
BUG=1623
R=stefan@webrtc.org , tina.legrand@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1368004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3968 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-07 12:36:21 +00:00
bd4a2feddb
Fix off-by-one buffer overflow in WebRtcNetEQ_PacketBufferInsert().
...
BUG=1725
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1395004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3953 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-03 18:11:36 +00:00
d5726a1286
Formatting ACM tests
...
Pure formatting of all files located in /webrtc/modules/audio_coding/main/test/
Smaller manual modifications done after using Eclipse formatting tool, like wrapping long lines (mostly comments).
BUG=issue1024
Review URL: https://webrtc-codereview.appspot.com/1342004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3946 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-03 07:34:12 +00:00
03efc89151
Fix when SetMinimumPlayoutDelay is configured to 0
...
BUG=1720
R=turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1386005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3942 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-02 21:19:12 +00:00
342353780d
Consolidate common_audio into a single target.
...
In principle should reduce gyp processing time, but the difference was not measurable. In any case, it's a good simplification that aligns with having a single common_video target.
R=bjornv@webrtc.org , kma@webrtc.org , tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1375004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3928 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-30 23:43:26 +00:00
a942692725
Buf fix for r3883.
...
Review URL: https://webrtc-codereview.appspot.com/1319012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3889 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-23 16:08:29 +00:00
28d54ab18f
Improve AV-sync when initial delay is set and NetEq has long buffer.
...
Review URL: https://webrtc-codereview.appspot.com/1324006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3883 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-22 18:53:35 +00:00
db11fab49e
Adding Opus unit test
...
This CL adds a unit test for Opus, as well as new APIs for true stereo decoding (skipping master/slave approach).
BUG=
Review URL: https://webrtc-codereview.appspot.com/1222006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3860 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-17 10:39:41 +00:00
f1a3b4bc0c
Issue 1647. Avoid unsequenced modification.
...
issue=1647
test=trybots,manual
Review URL: https://webrtc-codereview.appspot.com/1327004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3858 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-16 17:01:35 +00:00
6e788df19e
Remove vim/emacs modelines from .gypi files
...
BUG=1655
Review URL: https://webrtc-codereview.appspot.com/1326005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3857 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-16 12:40:34 +00:00
92d1f07551
Elevate NetEq short-term activity statistics to ACM level for logging.
...
Review URL: https://webrtc-codereview.appspot.com/1313004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3850 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-15 16:52:04 +00:00
4b8de90dce
Disable -Wunsequenced warning in audio_coding_module
...
BUG=1647
TEST=Compile locally on Linux with clang enabled.
TBR=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1316005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3848 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-15 06:38:56 +00:00
e4b6064f8e
Replace legacy G_CONST with const.
...
BUG=1608
Review URL: https://webrtc-codereview.appspot.com/1310005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3814 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-10 18:06:57 +00:00
ab9202b673
Removing remaining WebRtc_Word32 not in typedefs.h
...
BUG=
Review URL: https://webrtc-codereview.appspot.com/1306006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3813 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-10 17:59:17 +00:00
806dc3b0e6
More trace events
...
The goal of this change is to unify tracing events styles
and add trace events for all RTP traffic.
BUG=1555
Review URL: https://webrtc-codereview.appspot.com/1290007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3806 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-09 19:54:10 +00:00
0946a56023
WebRtc_Word32 => int32_t etc. in audio_coding/
...
BUG=314
Review URL: https://webrtc-codereview.appspot.com/1271006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3789 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-09 00:28:06 +00:00
cf8e108158
Fixed a bug in isac-fix's entropy coding function: out of bounds acces to array.
...
BUG=227286
Review URL: https://webrtc-codereview.appspot.com/1293005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3781 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-08 16:37:53 +00:00
2e6b7e938f
In streaming mode it is preferable to fade to silence when sender stops sending, or long period of packet loss.
...
test=try bots.
Review URL: https://webrtc-codereview.appspot.com/1272004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3771 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-06 00:08:11 +00:00
79b0289bfc
Adds event traces and counters for WebRTC receive side.
...
Review URL: https://webrtc-codereview.appspot.com/1279005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3766 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-04 19:43:34 +00:00
bb8ada686e
TSan v2 reports data races in WebRTCAudioDeviceTest.FullDuplexAudioWithAGC
...
BUG=226044
TEST=content_unittests in Chrome with TSan v2 enabled
Review URL: https://webrtc-codereview.appspot.com/1201010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3760 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-04 08:39:09 +00:00
f81fad6267
Fix opus bitrate truncated to 16-bit int. This prevented setting bitrates higher
...
than 2^16kbps.
Review URL: https://webrtc-codereview.appspot.com/1275004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3748 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-01 22:25:11 +00:00
4b1cd5c5c0
G722-stereo has been missing when creating AudioDecoder.
...
Review URL: https://webrtc-codereview.appspot.com/1266004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3734 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-27 20:42:48 +00:00
4d06db557a
NetEq4 fails if the first packets inserted in are out-of-band DTMFs.
...
I had to take few steps to solve this issue. I have comments on places I made cahanges to clarify why I did the change.
Review URL: https://webrtc-codereview.appspot.com/1195004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3733 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-27 18:31:42 +00:00
ae4e2b352b
WebRtc_Word -> stdint in audio_coding/g711/
...
BUG=
Review URL: https://webrtc-codereview.appspot.com/1223004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3699 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-21 13:38:29 +00:00
01b507a406
WebRtc_Word -> stdint in audio_coding/cng/
...
BUG=
Review URL: https://webrtc-codereview.appspot.com/1222004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3697 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-21 11:28:42 +00:00
73222cff1a
Adding Opus frame length test
...
BUG=issue1015
Review URL: https://webrtc-codereview.appspot.com/1193005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3672 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-15 13:29:17 +00:00
d6cd64ac6a
Change intrinsic code in isac fix to let it pass chrome clang compiler.
...
Compiler complains about variables not initialized in instructions veor_s32() and vset_lane_s32().
Review URL: https://webrtc-codereview.appspot.com/1187006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3660 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-12 17:45:41 +00:00
e5a81ed793
Fixed issue 1497 in iSAC fixed point.
...
Bit exact.
Review URL: https://webrtc-codereview.appspot.com/1177005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3653 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-12 00:23:21 +00:00
23da8622c0
Optimized EstCodeLpcCoef() for iSAC with intrinsics in Android-Neon platform.
...
Cycles of the whole iSAC codec was reduced by 7.9%, measured by offline file test, with time() function.
Bit exact.
** Code style cleanup is not considered in this CL. **
Review URL: https://webrtc-codereview.appspot.com/1069004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3643 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-09 00:38:14 +00:00
7a7a008031
Changing non-const reference arguments to pointers, ACM
...
Part of refactoring of ACM, and recent lint-warnings.
This CL changes non-const references in the ACM API to pointers.
BUG=issue1372
Committed: https://code.google.com/p/webrtc/source/detail?r=3543
Review URL: https://webrtc-codereview.appspot.com/1103012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3555 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-21 10:27:48 +00:00
eb7ebf20ed
Revert 3543
...
> Changing non-const reference arguments to pointers, ACM
>
> Part of refactoring of ACM, and recent lint-warnings.
> This CL changes non-const references in the ACM API to pointers.
>
> BUG=issue1372
>
> Review URL: https://webrtc-codereview.appspot.com/1103012
TBR=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1116004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3544 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-20 15:57:31 +00:00
374aa49e1a
Changing non-const reference arguments to pointers, ACM
...
Part of refactoring of ACM, and recent lint-warnings.
This CL changes non-const references in the ACM API to pointers.
BUG=issue1372
Review URL: https://webrtc-codereview.appspot.com/1103012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3543 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-20 15:22:23 +00:00
a092cbf9b7
Fixing lint warnings from previous commit
...
In this CL I have removed (almost) all lint warnings I got for this commit:
https://code.google.com/p/webrtc/source/detail?r=3454 .
The only warning not fixed is a warning about usage of non-const reference. This will be fixed in a separate CL.
BUG=issue1372
Review URL: https://webrtc-codereview.appspot.com/1091006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3510 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-14 09:28:10 +00:00
6388c3e2fd
Implement initial delay. This CL allows clients of VoE to set an initial delay. Playout of audio is delayed and the extra playout delay is maintained during the call. While packets are buffered (in NetEq) to acheive the desired delay. ACM will playout silence (zeros). Initial delay has to be set before any packet is pushed into ACM.
...
TEST=ACM unit test is added, also a manual integration test is writen.
Review URL: https://webrtc-codereview.appspot.com/1097009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3506 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-12 21:42:18 +00:00
00ab7cf4fd
Fix perf output for audioproc and iSAC fixed-point tests
...
The measurement and trace entries had been mixed up in the calls to webrtc::test::PrintResult, resulting in the plotted graphs were named after the metric. The parameter names are quite confusing which probably led to this.
BUG=none
TEST=none
Review URL: https://webrtc-codereview.appspot.com/1093007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3496 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-11 12:33:03 +00:00
d83b9fdf45
Fixed a bug in iSAC transform functions on ARM-Neon platform. Performance unchanged.
...
Bugs=none
Test=trybots, and file bit-exact tests; passed.
Description of the bug: Neon registers q4-q7 not saved before calling the outside FFT routines in the assembly functions.
Review URL: https://webrtc-codereview.appspot.com/1097006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3480 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-06 23:53:13 +00:00
959da8d286
Added labels in transform_neon.S in iSAC-fix, so the tables be shared with other files in iOS build. Also, moved several code lines in the same file, in case register values cannot be preserved after a function call which could cause a crash in some platforms (e.g. iOS etc.).
...
Bugs: none
Review URL: https://webrtc-codereview.appspot.com/1072007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3473 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-05 20:46:55 +00:00
fa53d8717c
Fixing/disabling Windows x64 warnings
...
Disabled MSVC #4267 warnings in common.gypi to enable x64 builds
for Windows.
Fixed MSVC #4267 warnings in test/testsupport.
Added third_party/directxsdk to .gitignore.
With http://review.webrtc.org/1070008 landed, this should make it possible
to build for x64 on Windows.
BUG=1348
TEST=Compiling with http://review.webrtc.org/1070008 applied:
set GYP_DEFINES="target_arch=x64"
set GYP_GENERATORS=ninja
gclient sync
ninja -C out\Debug_x64
Review URL: https://webrtc-codereview.appspot.com/1060008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3464 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-04 10:07:17 +00:00
46d90dcd74
Adding three frame sizes to Opus
...
Adding support for 10, 40 and 60 ms packet sizes for Opus.
BUG=issue1015
Review URL: https://webrtc-codereview.appspot.com/1086004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3454 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-01 14:20:06 +00:00
aaad6134b9
Implementing stereo support for G.722
...
This CL implements stereo support for G.722 through a new class
AudioDecoderG722Stereo derived from AudioDecoderG722.
Also implementing tests for G.722 stereo.
Review URL: https://webrtc-codereview.appspot.com/1073006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3452 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-01 11:49:28 +00:00
763faeab4e
Removing a codec from NetEq database has a bug. |funcDurationEst| is not updated.
...
This is discovered during a test for controlling delay. It is not simple to reproduce it.
Bug=
test=manual test verified that |functionDurationEst| is correctly updated.
Review URL: https://webrtc-codereview.appspot.com/1074013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3448 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-31 18:21:58 +00:00
c0ada864b2
fix for issue 281.
...
A reverse copy is removed. The index to src buffer could be -1, this happens very often. The reverse copy is not needed as the content of the destination is overwritten further down in "WebRtcIlbcfix_CbConstruct()"
Bug=issue281
TEST=manual test over 1600 files TIMIT database, all outputs are bit-exact with the ones generated from head revision. Local run of asan does not generate any warning.
Review URL: https://webrtc-codereview.appspot.com/1063013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3447 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-31 18:21:06 +00:00
6e3968f62a
Fix NetEq4 unit tests for VS2012
...
This merges the changes from r3199.
Review URL: https://webrtc-codereview.appspot.com/1078010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3443 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-31 15:07:30 +00:00
73deaadd0e
Removing a hack for CNG
...
However, two other "hacks" had to be added to maintain bit-exactness
with legacy.
Note that this change requires a new version of the universal.rtp test
input, although the output reference stays the same.
Moving reference files, and using a new input vector for NetEq4.
The new input vector neteq_universal_new.rtp is identical to the old
neteq_universal.rtp, except that the payload type for CNG packets that
follows a wideband codec is changed to 98.
Update to resources revision 15 where the new reference files are.
Also changing a faulty log error.
Review URL: https://webrtc-codereview.appspot.com/1078009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3442 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-31 13:32:51 +00:00
ac59dba3f7
Adding iSAC-fb support
...
Adding tests, too.
Review URL: https://webrtc-codereview.appspot.com/1070011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3440 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-31 09:55:24 +00:00
51f11eb5ae
Fixing problems in audio_decoder_unittests
...
The tests did not work in Release mode because of the asserts.
Review URL: https://webrtc-codereview.appspot.com/1062010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3435 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-30 13:00:33 +00:00
ddf981c789
Disable iSAC fix test in audio_decoder_unittests
...
The test AudioDecoderIsacFixTest.EncodeDecode was disabled since it
triggers a valgrind warning. The issue is tracked in
https://code.google.com/p/webrtc/issues/detail?id=1353
BUG=1353
Review URL: https://webrtc-codereview.appspot.com/1084004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3434 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-30 12:29:48 +00:00
