b3e5acfb66
Cleanup traces in WebRTC
...
Remove some unused traces and add a trace counter for encoded video size.
R=holmer@google.com , mflodman@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1476004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4050 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-16 21:13:02 +00:00
b9bb3d1e7d
Avoid resetting encoder on identical settings.
...
BUG=1681
R=holmer@google.com , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1481005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4049 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-16 18:40:48 +00:00
890f6092e6
Bugfix: VCM would report wrong sentBitrate
...
issue: https://code.google.com/p/webrtc/issues/detail?id=1755
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1484004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4048 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-16 15:38:44 +00:00
9919ad5caf
Formatted FEC stuff.
...
Unfortunately I had to pull in quite a bit of stuff due to use of unencapsulated public member variables.
BUG=
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1401004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4047 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-16 15:06:28 +00:00
2038214c77
Log too long non-decodable duration events.
...
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1488004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4043 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-16 11:39:06 +00:00
7ebbea14a9
Add handling of the absolute send time header extension to the rtp_rtcp module.
...
BUG=
R=asapersson@webrtc.org , stefan@webrtc.org , tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1480004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4041 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-16 11:10:31 +00:00
6cfa3907c8
Updating NACK RTX test
...
BUG=1513
R=holmer@google.com , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1274006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4036 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-15 20:17:43 +00:00
cb20a5b2d7
VCM/JB: Bug fix in ExtractAndSetDecode
...
BUG=1771
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1466005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4035 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-15 17:10:44 +00:00
5add4ad09c
RemoteBitrateEstimatorTest::TestRateIncreaseReordering sent in arrival timestamps in non monotonically increasing order. Fixed.
...
BUG=
R=holmer@google.com , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1481004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4034 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-15 13:49:57 +00:00
c93b1d038d
CoreAudio Win: release resources safely under certain rare circumstance in GTalkplugin
...
BUG=
TEST=voe_auto_test
R=henrika@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1479004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4033 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-15 10:14:56 +00:00
e2a800644c
Linux support for typing detection
...
R=henrika@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1428006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4031 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-14 21:33:11 +00:00
4ce838934c
Address sanitizer out of bounds read in iSAC
...
BUG=issue1770
TBR=tlegrand@google.com
Review URL: https://webrtc-codereview.appspot.com/1472006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4030 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-14 17:42:22 +00:00
29b2219914
Adding a factory to remote bitrate estimator and allow it to be set via config.
...
Additionally:
- clean api to set remote bitrate estimator mode.
- clean api to set over use detector options.
R=mflodman@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1448006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4027 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-14 12:10:58 +00:00
1673481ed7
Fixes a bug where the render buffer size (and indirectly the non-continuous duration) was computed incorrectly.
...
BUG=1769
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1473004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4026 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-14 12:00:47 +00:00
bb984f516e
Removed Mac capture crash and memory leak.
...
BUG=1697,1761
R=xians@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1465005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4023 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-14 10:47:19 +00:00
527f6c62fc
Reformatted FEC tables.
...
BUG=
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1400004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4020 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-14 09:25:01 +00:00
185bae4b6f
Replace ExtraCodecOptions with new Config class that supports multiple settings at once.
...
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1452004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4017 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-14 08:02:25 +00:00
7bfb3a3227
Add more tracing for key frames.
...
R=mallinath@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1428004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4015 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-13 22:59:00 +00:00
43bf6ce322
Revert 4008 "Avoid resetting video encoder for similar configs."
...
> Avoid resetting video encoder for similar configs.
>
> BUG=1681
> R=holmer@google.com , mflodman@webrtc.org , stefan@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/1442006
TBR=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1431005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4010 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-13 15:39:26 +00:00
aa4efd1535
Avoid resetting video encoder for similar configs.
...
BUG=1681
R=holmer@google.com , mflodman@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1442006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4008 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-13 11:27:16 +00:00
1e3c794688
Use 2 threads for HD, or 1 for VGA or less.
...
BUG=1739
TEST=try bots
Review URL: https://webrtc-codereview.appspot.com/1438005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3996 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-09 18:43:38 +00:00
315d39866e
Formatted dtmf_queue.
...
BUG=
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1398004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3982 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-08 10:04:06 +00:00
d98e784f5f
Fix VCMProcessTimer::TimeUntilProcess() unsigned-integer underflow problem.
...
BUG=1665
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1341004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3979 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-08 06:38:53 +00:00
3be565b502
Refactoring for typing detection
...
R=henrika@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1370004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3976 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-07 21:04:24 +00:00
ef14488d03
Trigger a PLI if the duration of non-decodable frames exceeds a threshold.
...
BUG=1663
R=mikhal@webrtc.org , ronghuawu@chromium.org
Review URL: https://webrtc-codereview.appspot.com/1359004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3975 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-07 19:16:33 +00:00
8f86cc8712
VCM/Receiver: Return null when can't extract frame.
...
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1435004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3974 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-07 18:05:21 +00:00
474e915272
Relanding 3962: VCM/JB: Porting jitter_buffer_test to gtest
...
TBR=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1434004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3971 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-07 16:55:03 +00:00
759b041019
Relanding r3952: VCM: Updating receiver logic
...
BUG=r1734
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1433004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3970 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-07 16:36:00 +00:00
9c7685f9a6
VCM/JB: Break and skip to key if possible
...
BUG=1734
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1421004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3969 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-07 16:07:52 +00:00
3004c79c6a
Fix clang errors in non-GYP_DEFINES=clang=1 build
...
BUG=1623
R=stefan@webrtc.org , tina.legrand@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1368004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3968 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-07 12:36:21 +00:00
d3a1959678
Fix jitter buffer unittest.
...
TBR=mflodman@webrtc.org
BUG=1737
Review URL: https://webrtc-codereview.appspot.com/1430005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3967 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-07 12:35:58 +00:00
a5dee33639
Correctly add packets to nack list when sequence number wraps.
...
BUG=1737
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1427004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3966 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-07 11:11:17 +00:00
0f29810288
Fix crash in pacer.
...
BUG=1731
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1410006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3964 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-06 16:37:22 +00:00
4ce19b1664
Revert r3952 "VCM: Updating receiver logic"
...
TBR=phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1410005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3963 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-06 13:16:51 +00:00
273759048c
Revert r3956 "VCM/JB: Porting jitter_buffer_test to gtest."
...
TBR=phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1408005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3962 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-06 13:12:58 +00:00
233c58de47
Landing 1399004, Minor clean up on the un-used _measureDelay code
...
Those code is/will never used, removing it makes the code better.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3961 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-06 11:52:47 +00:00
45f2da0920
VCM/JB: Porting jitter_buffer_test to gtest.
...
Tests were not modified, but ported as is.
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1391004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3956 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-03 22:22:46 +00:00
a31c428307
Remove 44.1 kHz workaround from AudioDevice on PulseAudio.
...
We currently inform VoE that 44.1 kHz audio is 44 kHz. We now have arbitrary
resampling in VoE, allowing us to pass in the native 44.1 kHz.
Our ALSA interface always requires 48 kHz, allowing ALSA to handle resampling.
This also removes WEBRTC_PA_GTALK which was not defined anywhere.
BUG=webrtc:1395
TESTED=Using 44.1 for capture and render in loopback, ran through all codec channel/rate combinations. Quality is good. Testing AEC was difficult as I can't find a way to change the sample rate of an individual device in PulseAudio. Using a webcam at 32 kHz, other problems were the overriding contribution to quality degradation (delay issues, possible clock drift from the camera). At least I verified that the quality got no worse with this patch.
R=xians@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1384004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3955 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-03 19:01:46 +00:00
7cb766b016
Remove 44.1 kHz workaround from AudioDevice on WASAPI.
...
We currently inform VoE that 44.1 kHz audio is 44 kHz. We now have arbitrary
resampling in VoE, allowing us to pass in the native 44.1 kHz.
BUG=webrtc:1395
TESTED=Set capture device to 44.1 and render device to 48 and vice versa and observed good AEC. The quality is considerably worse before this change. Using 44.1 for capture and render in loopback, ran through all codec channel/rate combinations. Quality is good.
R=xians@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1383004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3954 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-03 18:56:38 +00:00
bd4a2feddb
Fix off-by-one buffer overflow in WebRtcNetEQ_PacketBufferInsert().
...
BUG=1725
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1395004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3953 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-03 18:11:36 +00:00
d3cd565ecf
VCM: Updating receiver logic
...
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1363005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3952 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-03 17:54:18 +00:00
77f6b2175e
Revert 3934 "Revert 3933 "Remove traces of deprecated WebRtc_Wor..."
...
> Revert 3933 "Remove traces of deprecated WebRtc_Word types."
>
> > Remove traces of deprecated WebRtc_Word types.
> >
> > BUG=314
> > R=tommi@webrtc.org
> >
> > Review URL: https://webrtc-codereview.appspot.com/1385004
>
> TBR=pbos@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/1386004
TBR=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1397004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3948 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-03 12:02:11 +00:00
d5726a1286
Formatting ACM tests
...
Pure formatting of all files located in /webrtc/modules/audio_coding/main/test/
Smaller manual modifications done after using Eclipse formatting tool, like wrapping long lines (mostly comments).
BUG=issue1024
Review URL: https://webrtc-codereview.appspot.com/1342004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3946 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-03 07:34:12 +00:00
03efc89151
Fix when SetMinimumPlayoutDelay is configured to 0
...
BUG=1720
R=turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1386005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3942 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-02 21:19:12 +00:00
52b4e8871a
Adding trace and changing pacing constants
...
BUG=1721,1722
R=mikhal@webrtc.org , niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1380005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3940 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-02 19:02:17 +00:00
68e5a68f07
Revert 3933 "Remove traces of deprecated WebRtc_Word types."
...
> Remove traces of deprecated WebRtc_Word types.
>
> BUG=314
> R=tommi@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/1385004
TBR=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1386004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3934 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-02 09:30:12 +00:00
265a5d298a
Remove traces of deprecated WebRtc_Word types.
...
BUG=314
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1385004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3933 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-02 09:11:20 +00:00
342353780d
Consolidate common_audio into a single target.
...
In principle should reduce gyp processing time, but the difference was not measurable. In any case, it's a good simplification that aligns with having a single common_video target.
R=bjornv@webrtc.org , kma@webrtc.org , tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1375004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3928 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-30 23:43:26 +00:00
dff69c56b0
Add AEC suppression level option to audioproc.
...
TBR=bjornv
Review URL: https://webrtc-codereview.appspot.com/1368007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3927 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-30 23:01:09 +00:00
4980679d35
Fixes two bugs in receive statistics.
...
- Reported bitrate wasn't reset correctly when no frames had been received.
- Internal framerate estimate wasn't reset when no frames had been received.
BUG=1713
Review URL: https://webrtc-codereview.appspot.com/1377004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3924 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-30 22:05:07 +00:00
