4331fcd517
Remove duplicate code in SocketDispatcher
...
This CL is a follow-up on https://codereview.webrtc.org/1452903006/ which
moved the definition of SocketDispatcher to physicalsocketserver.h.
Here the duplicate implementations are merged with only some #ifdef parts.
BUG=
Review URL: https://codereview.webrtc.org/1537273002
Cr-Commit-Position: refs/heads/master@{#11160}
2016-01-07 06:20:31 +00:00
44cc795016
Roll chromium_revision 4df108a..2a70cb1 (367307:367468)
...
Mac 32-bit support has been gone in Chromium for a long time, but was
removed in https://codereview.chromium.org/1557823002 . This called
for finally removing our Mac 32-bit builds, which was done in
http://crbug.com/574320 .
Change log: 4df108a..2a70cb1
Full diff: 4df108a..2a70cb1
Changed dependencies:
* src/third_party/libvpx_new/source/libvpx: ecb8dff..a9dd8a7
* src/third_party/nss: aee1b12..225bfc3
DEPS diff: 4df108a..2a70cb1
/DEPS
No update to Clang.
TBR=marpan@webrtc.org , stefan@webrtc.org ,
BUG=webrtc:5401, webrtc:5402
NOTRY=True
Review URL: https://codereview.webrtc.org/1556273002
Cr-Commit-Position: refs/heads/master@{#11159}
2016-01-07 06:12:36 +00:00
4f3c772015
Update default trybot names for changed Mac bots
...
Removing one more bot, which was missed in
https://codereview.webrtc.org/1563883002/
BUG=chromium:574320
TBR=phoglund@webrtc.org
NOTRY=True
Review URL: https://codereview.webrtc.org/1565893003
Cr-Commit-Position: refs/heads/master@{#11158}
2016-01-06 20:12:17 +00:00
67e83d6539
Update API for Objective-C RTCSessionDescription.
...
BUG=
R=tkchin@webrtc.org
Review URL: https://codereview.webrtc.org/1524303006 .
Patch from Jon Hjelle <hjon@andyet.net >.
Cr-Commit-Position: refs/heads/master@{#11157}
2016-01-06 20:05:32 +00:00
29d5e570b5
Update API for Objective-C RTCIceCandidate.
...
BUG=
R=tkchin@webrtc.org
Review URL: https://codereview.webrtc.org/1517253005 .
Patch from Jon Hjelle <hjon@andyet.net >.
Cr-Commit-Position: refs/heads/master@{#11156}
2016-01-06 19:49:18 +00:00
1aa6e4e095
Update default trybot names for changed Mac bots
...
BUG=chromium:574320
TBR=phoglund@webrtc.org
NOTRY=True
Review URL: https://codereview.webrtc.org/1563883002
Cr-Commit-Position: refs/heads/master@{#11155}
2016-01-06 17:14:46 +00:00
335ecf59d0
Disable VideoCaptureTest.Capabilities and CreateDelete fails on Mac
...
These tests started failing on the bots after switching the build
from 32 to 64-bit.
NOTRY=True
BUG=webrtc:5406
TBR=perkj@webrtc.org
Review URL: https://codereview.webrtc.org/1566683002
Cr-Commit-Position: refs/heads/master@{#11154}
2016-01-06 13:23:16 +00:00
b6802749f1
Fix a flaky turnport test failure
...
The connection was deleted asynchronously, so need to use EXPECT_TRUE_WAIT.
BUG=
TBR=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1567433002 .
Cr-Commit-Position: refs/heads/master@{#11153}
2016-01-05 21:51:07 +00:00
6b9ab9204b
Cease all future TURN requests when a TURN refresh request fails for a given TURN port.
...
This fixes an assert error in Turnport::OnSendStunPacket
BUG=webrtc:5388
Review URL: https://codereview.webrtc.org/1547373002
Cr-Commit-Position: refs/heads/master@{#11152}
2016-01-05 17:06:20 +00:00
37389b42b4
Don't delete an ICE connection until it has been pruned or timed out on writing in the case where it
...
hasn't received anything yet. Deleting an ICE connection before it is pruned or timed out
when it hasn't received anything yet leads to ICE connections being deleted
before they have a chance to send a ping and receive a response.
BUG=
Review URL: https://codereview.webrtc.org/1544003002
Cr-Commit-Position: refs/heads/master@{#11151}
2016-01-05 05:57:42 +00:00
e2976c87f7
Remove DISABLED_ON_ macros.
...
Macro incorrectly displays DISABLED_ON_ANDROID in test names for
parameterized tests under --gtest_list_tests, causing tests to be
disabled on all platforms since they contain the DISABLED_ prefix rather
than their expanded variants.
This expands the macro variants to inline if they're disabled or not,
and removes building some tests under configurations where they should
fail, instead of building them but disabling them by default.
The change also removes gtest_disable.h as an unused include from many
other files.
BUG=webrtc:5387, webrtc:5400
R=kjellander@webrtc.org , phoglund@webrtc.org
TBR=henrik.lundin@webrtc.org
Review URL: https://codereview.webrtc.org/1547343002 .
Cr-Commit-Position: refs/heads/master@{#11150}
2016-01-04 21:44:16 +00:00
13f61dfea5
Move fake-handle frame creation into test target.
...
Renames CreateFakeNativeHandleFrame to FakeNativeHandle::CreateFrame and
moves into test.gyp target 'fake_video_frames' which contains previous
frame_generator target.
Removes unused warnings from includers of
webrtc/test/fake_texture_frame.h which did not use the function above.
BUG=webrtc:5398
R=kjellander@webrtc.org
TBR=stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1554223002 .
Cr-Commit-Position: refs/heads/master@{#11149}
2016-01-04 21:36:49 +00:00
523702136f
Disabling CritSectTest on Windows DrMemory bot.
...
BUG=webrtc:5390
Review URL: https://codereview.webrtc.org/1554673002
Cr-Commit-Position: refs/heads/master@{#11148}
2016-01-04 19:50:50 +00:00
60ca31bf5d
Roll chromium_revision d66326c..4df108a (367167:367307)
...
The changes in d66326c..4df108a
/build/common.gypi
enables a lot more warnings, which have been disabled/fixed in this CL.
See tracking bugs for remaining work.
Change log: d66326c..4df108a
Full diff: d66326c..4df108a
Changed dependencies:
* src/buildtools: fee7f1e..6d0c448
* src/third_party/libsrtp: b8dd754..8a7662a
DEPS diff: d66326c..4df108a
/DEPS
No update to Clang.
BUG=webrtc:5397, webrtc:5398, webrtc:5399
TBR=hta@webrtc.org , perkj@webrtc.org
NOTRY=True
Review URL: https://codereview.webrtc.org/1553033002
Cr-Commit-Position: refs/heads/master@{#11147}
2016-01-04 18:16:01 +00:00
4138e08eb6
Convert DOS->Unix line endings for Dr memory exclude file.
...
NOTRY=True
NOPRESUBMIT=True
TBR=deadbeef@webrtc.org
Review URL: https://codereview.webrtc.org/1555043003 .
Cr-Commit-Position: refs/heads/master@{#11146}
2016-01-04 12:02:05 +00:00
06689a1d17
Fix a -Wunused-function warning in gn builds.
...
BUG=chromium:573250
Review URL: https://codereview.webrtc.org/1552863002
Cr-Commit-Position: refs/heads/master@{#11145}
2015-12-30 23:05:34 +00:00
112fe43b9f
Fill the remote pwd in the ice candidates when an ICE credential is received.
...
Also when a STUN ping arrives from an unknown address, try to find the pwd and generation from the remote ICE parameters.
BUG=
Review URL: https://codereview.webrtc.org/1549633004
Cr-Commit-Position: refs/heads/master@{#11144}
2015-12-30 21:32:51 +00:00
051b62014c
Roll chromium_revision 58e631b..d66326c (367148:367167)
...
Change log: 58e631b..d66326c
Full diff: 58e631b..d66326c
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1559533002
Cr-Commit-Position: refs/heads/master@{#11143}
2015-12-30 19:58:18 +00:00
41d1a62d43
Use getExternalStorageDirectory() for trace file.
...
Removes hard-coded /mnt/sdcard/ path.
BUG=
R=glaznev@webrtc.org
Review URL: https://codereview.webrtc.org/1548263003
Cr-Commit-Position: refs/heads/master@{#11142}
2015-12-30 17:23:35 +00:00
555ad274da
Roll chromium_revision c670faf..58e631b (367136:367148)
...
Change log: c670faf..58e631b
Full diff: c670faf..58e631b
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1559453002
Cr-Commit-Position: refs/heads/master@{#11141}
2015-12-30 12:06:01 +00:00
78ad5af9d4
Roll chromium_revision 55b9604..c670faf (367087:367136)
...
Change log: 55b9604..c670faf
Full diff: 55b9604..c670faf
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1550383003
Cr-Commit-Position: refs/heads/master@{#11140}
2015-12-30 03:59:10 +00:00
0c7e9f540b
Removing webrtc::PortAllocatorFactoryInterface.
...
ICE servers are now passed directly into PortAllocator,
making PortAllocatorFactoryInterface redundant. This CL also
moves SetNetworkIgnoreMask to PortAllocator.
R=phoglund@webrtc.org , pthatcher@webrtc.org , tkchin@webrtc.org
Review URL: https://codereview.webrtc.org/1520963002 .
Cr-Commit-Position: refs/heads/master@{#11139}
2015-12-29 22:15:02 +00:00
e86e15b2a2
Increasing timeout for TestResolverShutdown.
...
getaddrinfo() seems to take longer than a second occasionally.
BUG=webrtc:5191
R=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1536563005 .
Cr-Commit-Position: refs/heads/master@{#11138}
2015-12-29 20:51:21 +00:00
355113a702
Roll chromium_revision f84c240..55b9604 (367060:367087)
...
Change log: f84c240..55b9604
Full diff: f84c240..55b9604
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1558443002
Cr-Commit-Position: refs/heads/master@{#11137}
2015-12-29 20:19:03 +00:00
831afda3a7
Roll chromium_revision 75c7843..f84c240 (366966:367060)
...
Change log: 75c7843..f84c240
Full diff: 75c7843..f84c240
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1550273003
Cr-Commit-Position: refs/heads/master@{#11136}
2015-12-29 12:40:15 +00:00
2df2ba7ae1
[rtp_rtcp] Fix CL#1539423003
...
public function RtpHeaderParser::Parse with old signature restored as deprecated.
BUG=webrtc:5277
TBR=åsapersson
NOTRY=True
Review URL: https://codereview.webrtc.org/1550283002
Cr-Commit-Position: refs/heads/master@{#11135}
2015-12-29 09:12:15 +00:00
3f7219be70
Fixing issue where description contains empty ICE ufrag/pwd.
...
The issue occurred when deserializing and then serializing a rejected
content description, which doesn't have the ICE ufrag/pwd in the first
place.
BUG=webrtc:5105
Review URL: https://codereview.webrtc.org/1534363002
Cr-Commit-Position: refs/heads/master@{#11134}
2015-12-28 23:17:22 +00:00
9faf154960
Reland 1531763006
...
Enable IPv6 temporary address filtering on iOS.
We'll only use temporary address for IPv6. However, due to a bug in iOS sdk, the necessary headers are not included. This change copies the minimum necessary definitions such that we could retrieve the ip attributes.
BUG=webrtc:4343
Committed: https://crrev.com/29488c23644721c10a45eba74c67602b0262e582
Cr-Commit-Position: refs/heads/master@{#11114}
patch from issue 1531763006 at patchset 200001 (http://crrev.com/1531763006#ps200001 )
TBR=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1551703002 .
Cr-Commit-Position: refs/heads/master@{#11133}
2015-12-28 22:07:05 +00:00
6d3f11c366
Roll gtest-parallel.
...
Brings in fix that prevents disabled parameterized tests from running by
default.
BUG=webrtc:5280
TBR=kjellander@webrtc.org
Review URL: https://codereview.webrtc.org/1548373002
Cr-Commit-Position: refs/heads/master@{#11132}
2015-12-28 21:11:09 +00:00
f6975f4613
[rtp_rtcp] Lint errors cleaned from rtp_utility
...
R=åsapersson
BUG=webrtc:5277
Review URL: https://codereview.webrtc.org/1539423003
Cr-Commit-Position: refs/heads/master@{#11131}
2015-12-28 18:18:52 +00:00
e0d56a7225
Roll chromium_revision a97fe0c..75c7843 (366958:366966)
...
Change log: a97fe0c..75c7843
Full diff: a97fe0c..75c7843
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1544383002
Cr-Commit-Position: refs/heads/master@{#11130}
2015-12-28 11:57:59 +00:00
63193cefbf
Roll chromium_revision a54fe37..a97fe0c (366930:366958)
...
Change log: a54fe37..a97fe0c
Full diff: a54fe37..a97fe0c
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1550683004
Cr-Commit-Position: refs/heads/master@{#11129}
2015-12-28 04:00:10 +00:00
445e31521e
Roll chromium_revision 083ad1e..a54fe37 (366925:366930)
...
Change log: 083ad1e..a54fe37
Full diff: 083ad1e..a54fe37
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1547203002
Cr-Commit-Position: refs/heads/master@{#11128}
2015-12-27 20:00:04 +00:00
0e9f06f6d8
Roll chromium_revision e73d852..083ad1e (366918:366925)
...
Change log: e73d852..083ad1e
Full diff: e73d852..083ad1e
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1545303002
Cr-Commit-Position: refs/heads/master@{#11127}
2015-12-27 11:59:35 +00:00
74d8a11a6a
Roll chromium_revision e13537f..e73d852 (366904:366918)
...
Change log: e13537f..e73d852
Full diff: e13537f..e73d852
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1549243002
Cr-Commit-Position: refs/heads/master@{#11126}
2015-12-27 03:59:49 +00:00
bbff0d339a
Roll chromium_revision 0f24b97..e13537f (366898:366904)
...
Change log: 0f24b97..e13537f
Full diff: 0f24b97..e13537f
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1550633002
Cr-Commit-Position: refs/heads/master@{#11125}
2015-12-26 19:58:09 +00:00
40a2f03f8c
Roll chromium_revision c80b1b6..0f24b97 (366886:366898)
...
Change log: c80b1b6..0f24b97
Full diff: c80b1b6..0f24b97
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1549163003
Cr-Commit-Position: refs/heads/master@{#11124}
2015-12-26 11:57:47 +00:00
ef776dfcf9
Roll chromium_revision 353749a..c80b1b6 (366864:366886)
...
Change log: 353749a..c80b1b6
Full diff: 353749a..c80b1b6
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1550043002
Cr-Commit-Position: refs/heads/master@{#11123}
2015-12-26 04:04:34 +00:00
55e61593c4
Roll chromium_revision 244de00..353749a (366862:366864)
...
Change log: 244de00..353749a
Full diff: 244de00..353749a
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1544253002
Cr-Commit-Position: refs/heads/master@{#11122}
2015-12-25 20:02:26 +00:00
848e7a1871
Roll chromium_revision 7f27756..244de00 (366849:366862)
...
Change log: 7f27756..244de00
Full diff: 7f27756..244de00
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1549983002
Cr-Commit-Position: refs/heads/master@{#11121}
2015-12-25 11:59:24 +00:00
2c56d7fd7b
Roll chromium_revision 67b3d7f..7f27756 (366832:366849)
...
Change log: 67b3d7f..7f27756
Full diff: 67b3d7f..7f27756
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1549953002
Cr-Commit-Position: refs/heads/master@{#11120}
2015-12-25 03:59:44 +00:00
6f94a45d9f
Roll chromium_revision 9beac25..67b3d7f (366816:366832)
...
Change log: 9beac25..67b3d7f
Full diff: 9beac25..67b3d7f
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1547083002
Cr-Commit-Position: refs/heads/master@{#11119}
2015-12-24 20:04:31 +00:00
b26f18dd58
Roll chromium_revision 1417e01..9beac25 (366759:366816)
...
Change log: 1417e01..9beac25
Full diff: 1417e01..9beac25
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1543363002
Cr-Commit-Position: refs/heads/master@{#11118}
2015-12-24 12:03:27 +00:00
f01f8c9fb5
Roll chromium_revision 2b7b555..1417e01 (366738:366759)
...
Change log: 2b7b555..1417e01
Full diff: 2b7b555..1417e01
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1545003002
Cr-Commit-Position: refs/heads/master@{#11117}
2015-12-23 20:00:55 +00:00
c12f7f45b5
Roll chromium_revision 8a1fcdb..2b7b555 (366529:366738)
...
Change log: 8a1fcdb..2b7b555
Full diff: 8a1fcdb..2b7b555
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1543903003
Cr-Commit-Position: refs/heads/master@{#11116}
2015-12-23 12:01:03 +00:00
a6c86b23fe
Revert "Enable IPv6 temporary address filtering on iOS."
...
This reverts commit 29488c23644721c10a45eba74c67602b0262e582.
This broke chromium.fyi bot.
TBR=pthatcher@webrtc.org
BUG=
Review URL: https://codereview.webrtc.org/1547883002 .
Cr-Commit-Position: refs/heads/master@{#11115}
2015-12-23 04:17:37 +00:00
29488c2364
Enable IPv6 temporary address filtering on iOS.
...
We'll only use temporary address for IPv6. However, due to a bug in iOS sdk, the necessary headers are not included. This change copies the minimum necessary definitions such that we could retrieve the ip attributes.
BUG=webrtc:4343
Review URL: https://codereview.webrtc.org/1531763006
Cr-Commit-Position: refs/heads/master@{#11114}
2015-12-23 00:46:48 +00:00
93c08b7438
Adding bit exactness test for Opus decoding in NetEq.
...
Opus has become the mostly used codec in WebRTC. There, however, is no bit exactness test for Opus decoding in NetEq.
The new RTP file is generated by the following steps:
1. Encode a clean RTP file with Opus
RTPencode resources/audio_coding/speech_mono_32_48kHz.pcm neteq_opus_raw.rtp 960 opus 1
2. Adding jitter to the clean RTP file
RTPjitter neteq_opus_raw.rtp jitter.dat neteq_opus.rtp
(Note: jitter.dat does not exist in WebRTC resources folder. Check the source code for RTPjitter to know how to define such a file.)
BUG=webrtc:3987
TEST=observed Opus normal decoding and FEC decoding were used, listened to the reference output.
Review URL: https://codereview.webrtc.org/1515113002
Cr-Commit-Position: refs/heads/master@{#11113}
2015-12-22 17:57:47 +00:00
a72e7349d5
[rtp_rtcp] cleanup in RTCPSender class internals.
...
PrepareReportBlock and AddReportBlock private functions merged:
PrepareReportBlock moved report block from statistic to temporary structure
AddReportBlock copied that temporary structure into temporary map right after.
Thanks to rtcp packet classes that temporary structure is now unneccesary.
BUG=webrtc:5260
R=åsapersson
Review URL: https://codereview.webrtc.org/1538833002
Cr-Commit-Position: refs/heads/master@{#11112}
2015-12-22 16:07:48 +00:00
a8890a57a5
rtcp::Nack packet moved into own file and got Parse function
...
Review URL: https://codereview.webrtc.org/1461623003
Cr-Commit-Position: refs/heads/master@{#11111}
2015-12-22 11:43:10 +00:00