728a0ee459
Reland "Introduce ability to test echo in PC level test framework"
...
This is a reland of 77acb015b6ba886da3e7adb9c2106cf873fa8497
Original change's description:
> Introduce ability to test echo in PC level test framework
>
> Bug: webrtc:10138
> Change-Id: Ie638eaec5a46e37dc0eb52e9432fdebd0e4a1c4d
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147866
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Reviewed-by: Sam Zackrisson <saza@webrtc.org >
> Commit-Queue: Artem Titov <titovartem@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28892}
Bug: webrtc:10138
Change-Id: I0358239500ffadbdbae8090bf39535386fbfd40c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149805
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28917}
2019-08-20 12:18:28 +00:00
e21f3f574b
Revert "Delete mac_utils.h and mac_utils.cc"
...
This reverts commit ada8e17125d2124f5bcdc1558182ce95d6311d93.
Reason for revert: Breaks chromium, due to undeclared dependency on SystemConfiguration.framework
Original change's description:
> Delete mac_utils.h and mac_utils.cc
>
> They defined two functions: ToUtf16 and ToUtf8. The former was unused,
> and the latter is moved to
> modules/desktop_capture/mac/window_list_utils.cc, the only user.
>
> Tbr: sergeyu@chromium.org
> Bug: None
> Change-Id: Ib8a513da42e43ba8d41a2de4c1645b3f48448dc9
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148531
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
> Reviewed-by: Sergey Ulanov <sergeyu@google.com >
> Cr-Commit-Position: refs/heads/master@{#28913}
TBR=zijiehe@chromium.org ,nisse@webrtc.org ,kthelgason@webrtc.org ,sergeyu@google.com ,sergeyu@chromium.org
Change-Id: I9d6a2f63b3acde0eefab92d034529b800d6adcab
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149811
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28915}
2019-08-20 09:58:37 +00:00
ada8e17125
Delete mac_utils.h and mac_utils.cc
...
They defined two functions: ToUtf16 and ToUtf8. The former was unused,
and the latter is moved to
modules/desktop_capture/mac/window_list_utils.cc, the only user.
Tbr: sergeyu@chromium.org
Bug: None
Change-Id: Ib8a513da42e43ba8d41a2de4c1645b3f48448dc9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148531
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Sergey Ulanov <sergeyu@google.com >
Cr-Commit-Position: refs/heads/master@{#28913}
2019-08-20 08:52:28 +00:00
5870503d5e
Revert "Introduce ability to test echo in PC level test framework"
...
This reverts commit 77acb015b6ba886da3e7adb9c2106cf873fa8497.
Reason for revert: Downstream tests are failing.
Original change's description:
> Introduce ability to test echo in PC level test framework
>
> Bug: webrtc:10138
> Change-Id: Ie638eaec5a46e37dc0eb52e9432fdebd0e4a1c4d
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147866
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Reviewed-by: Sam Zackrisson <saza@webrtc.org >
> Commit-Queue: Artem Titov <titovartem@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28892}
TBR=mbonadei@webrtc.org ,saza@webrtc.org ,kwiberg@webrtc.org ,titovartem@webrtc.org
Change-Id: Idc87c1cb679712d701d30902bcae4e2c698cf1cd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10138
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149804
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28896}
2019-08-19 11:46:04 +00:00
77acb015b6
Introduce ability to test echo in PC level test framework
...
Bug: webrtc:10138
Change-Id: Ie638eaec5a46e37dc0eb52e9432fdebd0e4a1c4d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147866
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28892}
2019-08-19 10:19:41 +00:00
f5e5d250bc
BalancedDegradationSettings: add option to configure a min framerate diff.
...
If a framerate reduction (input fps - restricted fps) is less than the
configured diff, shorten interval to next qp check.
Bug: none
Change-Id: Ia0b9e0638e5ba75cdc20a1bb45bfcb7d858c5f89
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149040
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Reviewed-by: Magnus Flodman <mflodman@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28880}
2019-08-16 16:13:46 +00:00
1b247f1e6e
BalancedDegradationSettings: add option to configure min bitrate.
...
Add possibility to configure min bitrate based on resolution.
Only adapt up if bw estimate is above the min bitrate for next higher resolution.
Bug: none
Change-Id: Ie38faae07d23336675ec33697ace6f6fed322efa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148598
Reviewed-by: Magnus Flodman <mflodman@webrtc.org >
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28863}
2019-08-15 07:16:33 +00:00
0ee8008a0d
Use struct parser for rate control trial.
...
Bug: webrtc:9883
Change-Id: I9ec7988da2e4d88bedd9b71cae00452f531980d6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148581
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Jonas Olsson <jonasolsson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28856}
2019-08-14 11:47:12 +00:00
0c38a86533
BalancedDegradationSettings: add option to configure no fps limit.
...
If configuring max valid framerate (100), no framerate restriction is
used (std::numeric_limits<int>::max()).
E.g. pixels:1000|2000,fps:5|10 is same as pixels:1000|2000|3000,fps:5|10|100
Bug: none
Change-Id: Ie981841ee8e23cb73c0ef55738ca69055916d902
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148980
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Reviewed-by: Magnus Flodman <mflodman@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28854}
2019-08-14 08:56:38 +00:00
e4ba4ee837
Delete placeholder file rtc_base/function_view.h
...
Bug: None
Change-Id: If2d35a9745f1de6cc4d26814e8b7567a8466d831
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148527
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28820}
2019-08-09 09:39:32 +00:00
6685b328b9
Delete rtc_base/gunit_prod.h
...
Bug: None
Change-Id: I0d6e6536490758a102aec5362b89baf04353e570
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148524
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28818}
2019-08-09 08:44:30 +00:00
55251c3d49
Adds struct parameters parser/encoder.
...
This is similar to the field trial parser but it uses a normal struct
with normal fields as underlying storage. This makes it easier to
understand and use as only the encoding and parsing uses non-
standard constructs. Additionally, it makes it easier to use the
struct as a regular config struct when the values are not set
using field trials.
Bug: webrtc:9883
Change-Id: I5b16c2a71875b6f478383decff18fbaa62bc404a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145203
Reviewed-by: Jonas Olsson <jonasolsson@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28810}
2019-08-08 15:21:35 +00:00
383adc025a
Delete shim of PRId64 et al. on Windows
...
It should be present since MSVC 2013.
This is a port of 08e78a4733https://webrtc-review.googlesource.com/c/src/+/148443
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28805}
2019-08-08 08:29:18 +00:00
b1686786e8
Add RTC_ prefix to non-standard format specifier macro "PRIdNS"
...
Some of the macros in format_macros.h follow the C standard and try to fill holes in it (on Windows). But this one has no direct equivalent in the standard and is just mimicking the naming convention. That's not nice.
References:
https://devblogs.microsoft.com/cppblog/c99-library-support-in-visual-studio-2013/
https://stackoverflow.com/a/2524673
Change-Id: I53f3faca2976a5b5d4b04a67ffb56ae0f4e930b2
Bug: webrtc:10852
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147862
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28794}
2019-08-07 13:36:05 +00:00
b6685420c4
Delete unused format specifier macros for NSInteger and NSUInteger
...
Bug: webrtc:10852
Change-Id: I0f8ba32b3f22ebd1bb85602daeebd34fb3d8c544
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148441
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28792}
2019-08-07 12:25:16 +00:00
a22cab8a65
Calling DebugBreak() on Windows during fatal checks instead of relying on abort().
...
Bug: webrtc:10846
Change-Id: Ie701f47b9b7c9d88ea983540dce3f429903a18f7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147879
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28771}
2019-08-06 09:19:00 +00:00
7ba3b81ff5
Delete class PlatformFile.
...
Add seek methods to FileWrapper, and refactor WavReader to use that
class instead.
Bug: webrtc:6463
Change-Id: Ifbb1989a072da6280ea5fc04b4beff991614dd53
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147265
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28770}
2019-08-06 09:07:50 +00:00
d7ee76cadd
Wire up field trials for some experimental screenshare settings
...
Bug: b/132074409
Change-Id: I83d5334255bad4fcf585b9850506bbfe1914ba57
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147868
Commit-Queue: Erik Språng <sprang@webrtc.org >
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28758}
2019-08-05 13:47:01 +00:00
139f4dc7ac
QualityScaler: Add option to try fast adapt down at start up based on initial bw estimates.
...
optional<int> initial_bitrate_interval_ms: time interval since start of call
where fast adapt down is allowed.
optional<double> initial_bitrate_factor: try fast adapt down if bw estimate is
below initial bitrate * factor.
Bug: none
Change-Id: I63e1fdaac6556d8e9a961a42e11c925f9ecb9771
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147725
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org >
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28753}
2019-08-05 09:43:19 +00:00
b3f78deb78
Reland "Don't use all_dependent_configs for sdk frameworks"
...
This is a reland of 63741c7fa1aa55a38af11ac8cc04498722f9407d
It's possible to reland after the downstream fix in
https://chromium-review.googlesource.com/1730415
Original change's description:
> Don't use all_dependent_configs for sdk frameworks
>
> libs should be propagated to the final binary even without that:
> https://gn.googlesource.com/gn/+/master/docs/reference.md#var_libs
>
> But add some missing SDK framework dependencies:
>
> * RTCNativeI420Buffer.mm uses CGBitmapContextGetBytesPerRow.
> * socketrocket uses SecCertificateCopyData.
>
> Bug: None
> Change-Id: Iba38a5dfaf470a5a790d494cbec8ade44b1d16ba
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146082
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28605}
Bug: None
Change-Id: I6a1cd80c5177ef3a3b92ee55fc91e187b202d864
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147720
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28740}
2019-08-02 06:09:39 +00:00
4ed5b087f5
Skip empty strings in ToUtf(8|16).
...
We've observed a crash on Windows when the strings are empty, skipping the conversion seems reasonable in that case.
Bug: None
Change-Id: I3acf3060a88741fb750d7a0cc02e9422713c59cd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147380
Commit-Queue: Noah Richards <noahric@chromium.org >
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28709}
2019-07-30 19:35:37 +00:00
ec3580361e
Revert "Don't use all_dependent_configs for sdk frameworks"
...
This reverts commit 63741c7fa1aa55a38af11ac8cc04498722f9407d.
Reason for revert: It breaks a chromium.fyi bot (https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Mac%20Builder%20(dbg)/3974 )
Original change's description:
> Don't use all_dependent_configs for sdk frameworks
>
> libs should be propagated to the final binary even without that:
> https://gn.googlesource.com/gn/+/master/docs/reference.md#var_libs
>
> But add some missing SDK framework dependencies:
>
> * RTCNativeI420Buffer.mm uses CGBitmapContextGetBytesPerRow.
> * socketrocket uses SecCertificateCopyData.
>
> Bug: None
> Change-Id: Iba38a5dfaf470a5a790d494cbec8ade44b1d16ba
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146082
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28605}
TBR=mbonadei@webrtc.org ,oprypin@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: None
Change-Id: I9e2fdb5753905cb4bf04820a8077feba78f463e6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146542
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28628}
2019-07-22 08:46:36 +00:00
fefa77c426
Add pthread thread-local storage support for ScopedYieldPolicy
...
Emscripten does not support C++11 thread_local but does support
the pthread TLS API.
Bug: None
Change-Id: Ia21895148d1df7652579d086d9e1c0c53d7a85f4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145441
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28621}
2019-07-19 14:33:53 +00:00
836ab13f1c
Remove rtc::Flag.
...
WebRTC has been migrated to Abseil Flags.
Bug: webrtc:10616
Change-Id: Id4a363429ccd2dd55c0dff00c9490c15124fdccc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144631
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28620}
2019-07-19 14:05:01 +00:00
63741c7fa1
Don't use all_dependent_configs for sdk frameworks
...
libs should be propagated to the final binary even without that:
https://gn.googlesource.com/gn/+/master/docs/reference.md#var_libs
But add some missing SDK framework dependencies:
* RTCNativeI420Buffer.mm uses CGBitmapContextGetBytesPerRow.
* socketrocket uses SecCertificateCopyData.
Bug: None
Change-Id: Iba38a5dfaf470a5a790d494cbec8ade44b1d16ba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146082
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28605}
2019-07-19 06:30:54 +00:00
7f8dbe18ea
Add config to specify raw audio priority bitrate including overhead.
...
Bug: webrtc:10815
Change-Id: I6a498d6c6bcd4fe4ba6ccc4d6f407d686528d946
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145333
Commit-Queue: Christoffer Rodbro <crodbro@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28590}
2019-07-17 15:28:46 +00:00
0182a0300f
Reland "Remove the injectable bitrate allocation strategy API."
...
This is a reland of 80cb3f6db622442b6360e67851e8903aa0d06d03
Original change's description:
> Remove the injectable bitrate allocation strategy API.
>
> This removes PeerConnectionInterface::SetBitrateAllocationStrategy()
> plus a ton of now-dead code.
>
> Bug: webrtc:10556
> Change-Id: Icfae3bdd011588552934d9db4df16000847db7c3
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133169
> Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
> Reviewed-by: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Sebastian Jansson <srte@webrtc.org >
> Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28523}
TBR=kwiberg@webrtc.org
Bug: webrtc:10556
Change-Id: Ic17a7a7cc447292306876ee9582ad62fd2499765
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145900
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28585}
2019-07-17 10:20:45 +00:00
1cd6f3224a
Fix typo in comment.
...
TBR=artit@webrtc.org
No-Try: True
Bug: None
Change-Id: I96bdc4788b58f3e7f45da5e8ba383d991382079a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145404
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28566}
2019-07-12 19:51:23 +00:00
e95b57cdfc
Revert "Remove the injectable bitrate allocation strategy API."
...
This reverts commit 80cb3f6db622442b6360e67851e8903aa0d06d03.
Reason for revert: Performance regression on downstream project.
Original change's description:
> Remove the injectable bitrate allocation strategy API.
>
> This removes PeerConnectionInterface::SetBitrateAllocationStrategy()
> plus a ton of now-dead code.
>
> Bug: webrtc:10556
> Change-Id: Icfae3bdd011588552934d9db4df16000847db7c3
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133169
> Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
> Reviewed-by: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Sebastian Jansson <srte@webrtc.org >
> Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28523}
TBR=henrika@webrtc.org ,kwiberg@webrtc.org ,nisse@webrtc.org ,srte@webrtc.org ,alexnarest@webrtc.org ,jonasolsson@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:10556
Change-Id: Ife905d661e7b1a227662395c729a9336c62fd2d7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145338
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28560}
2019-07-12 15:27:19 +00:00
6564366f75
Use -Wno-undef to compile jsoncpp.
...
This should fix this error:
In file included from ../../api/audio/echo_canceller3_config_json.cc:19:
In file included from ../..\rtc_base/strings/json.h:18:
In file included from ../../third_party/jsoncpp/source/include\json/json.h:9:
In file included from ../../third_party/jsoncpp/source/include\json/autolink.h:9:
../../third_party/jsoncpp/source/include\json/config.h(126,5): error: '__GNUC__' is not defined, evaluates to 0 [-Werror,-Wundef]
Maybe we could also fix it upstream.
Bug: webrtc:10770
Change-Id: I68434c6957189f680625bd2f2b85422965a89785
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145322
Reviewed-by: Artem Titarenko <artit@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28558}
2019-07-12 13:13:46 +00:00
80cb3f6db6
Remove the injectable bitrate allocation strategy API.
...
This removes PeerConnectionInterface::SetBitrateAllocationStrategy()
plus a ton of now-dead code.
Bug: webrtc:10556
Change-Id: Icfae3bdd011588552934d9db4df16000847db7c3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133169
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28523}
2019-07-10 13:13:25 +00:00
a0eefc17f7
Rename USE_NATIVE_MUTEX_ON_MAC to RTC_USE_NATIVE_MUTEX_ON_MAC.
...
WebRTC internal macros should be prefixed by RTC_.
Bug: None
Change-Id: I1a0be41ca1ea35173edf34bc190fc425c5f2c67b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144782
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28509}
2019-07-08 16:54:29 +00:00
a4d873786f
Format almost everything.
...
This CL was generated by running
git ls-files | grep -P "(\.h|\.cc)$" | grep -v 'sdk/' | grep -v 'rtc_base/ssl_' | \
grep -v 'fake_rtc_certificate_generator.h' | grep -v 'modules/audio_device/win/' | \
grep -v 'system_wrappers/source/clock.cc' | grep -v 'rtc_base/trace_event.h' | \
grep -v 'modules/audio_coding/codecs/ilbc/' | grep -v 'screen_capturer_mac.h' | \
grep -v 'spl_inl_mips.h' | grep -v 'data_size_unittest.cc' | grep -v 'timestamp_unittest.cc' \
| xargs clang-format -i ; git cl format
Most of these changes are clang-format grouping and reordering includes
differently.
Bug: webrtc:9340
Change-Id: Ic83ddbc169bfacd21883e381b5181c3dd4fe8a63
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144051
Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28505}
2019-07-08 13:45:15 +00:00
48284b86d4
BalancedDegradationSettings: Add option to configure fps based on codec type.
...
Bug: none
Change-Id: I43b3d976b9400a0552fee80a6a65c215c71049ac
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144543
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org >
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28503}
2019-07-08 11:46:25 +00:00
51f599bdaa
Make rtc_base/base_java public.
...
Bug: webrtc:9048
Change-Id: I4ce8219fcc751ee89050a075df5ad44fc9e68237
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144524
Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28471}
2019-07-03 14:44:46 +00:00
84ce3c08a5
Macro rename s/CS_DEBUG_CHECKS/RTC_CS_DEBUG_CHECKS.
...
Bug: None
Change-Id: Ie55de3148cb450de8e37d53e810f2a2d590a1f6c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144049
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28466}
2019-07-03 13:49:52 +00:00
a2b30d8940
Add functions to read from/write to bitstream values with known max value
...
Bug: webrtc:10342
Change-Id: I701b09de574eb463daaf8d2c19008ac3452879eb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144033
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28465}
2019-07-03 13:30:01 +00:00
2c5af4f6dc
Add * and / operator into SamplesStatsCounter.
...
Add * and / operator into SamplesStatsCounter to simplify convertion
between samples units.
Bug: webrtc:10138
Change-Id: I985b60bc63c071ceaf0fddcdbcd3e6476353c0fe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/142171
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28456}
2019-07-03 09:19:36 +00:00
a09484940b
RateControlSettings: add option to set min pixels per frame for libvpx vp8.
...
Bug: none
Change-Id: I09aa1bcea2f4a9cd65ffeef1df1d9656e4604def
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144029
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28412}
2019-06-28 10:54:23 +00:00
9407776aa2
Temporarily suppress -Wdeprecated-declarations to update jsoncpp.
...
This is required to land [1] which introduces new APIs and deprecates
the old ones.
[1] - https://chromium-review.googlesource.com/c/chromium/src/+/1674449
Bug: webrtc:10770
Change-Id: Iceadf1fa1a3324db6c53f5c822c64ed6fc59fc76
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144021
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28407}
2019-06-27 20:00:26 +00:00
2644a703cc
Delete rtc::TryCritScope as unused
...
Bug: None
Change-Id: I9288f26d22835fc4e8ee7e5da5acfa4b4b527d8a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/143163
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28389}
2019-06-26 13:04:19 +00:00
1231419785
BalancedDegradationSettings: Add option to configure QP thresholds.
...
Add possibility to configure low/high QP thresholds based on resolution.
Bug: none
Change-Id: Iaa3168b77678bd74feb67295d7658c0140721231
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141867
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org >
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28348}
2019-06-24 09:32:51 +00:00
b028c6a8ff
Support __EMSCRIPTEN__ in rtc_base.
...
Bug: None
Change-Id: Ie0497e268b93ad15a164db85e8cefdb823d64a65
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140863
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28307}
2019-06-18 12:44:00 +00:00
5a8f860a01
Prepare for deletion of the NO_MAIN_THREAD_WRAPPING preprocessor define
...
This is a partial reland of
https://webrtc-review.googlesource.com/c/src/+/39680 ,
including only the (hopefully) non-problematic parts of it, but
postponing actual deletion of automatic thread wrapping.
Bug: webrtc:9714
Change-Id: I9b79dd073f0e945cbb62f3b54cff05eaaea9b06c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141664
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28265}
2019-06-13 13:51:17 +00:00
00e71ef49e
Fix TaskQueueLibevent::PostTask when used on the same TaskQueue
...
Stop using event_base_once because it doesn't guarantee to free QueuedTask when task not run and thus may break TaskQueue guarantee all posted tasks are eventually deleted
Bug: webrtc:10731, webrtc:10278
Change-Id: Id073a6092cf603cac5768da7a0770371053b20cc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141420
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28241}
2019-06-11 18:08:18 +00:00
171bd2644d
Delete unused MacOS code related to ERRCTX_OSSTATUS
...
Bug: webrtc:6424
Change-Id: I3f98d31677201fcc52e492a463945fb9f6f2e883
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/138831
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28231}
2019-06-11 13:11:56 +00:00
d2e5013858
Delete optional Runnable argument to rtc::Thread::Start
...
Intended to simplify later changes to thread shutdown logic.
Bug: webrtc:10648
Change-Id: I61ba240c0f4b73a0bc6af6a3471804ecb434c41f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137510
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28219}
2019-06-11 08:24:50 +00:00
240b893fd2
Reland "Link fewer X11-related libraries"
...
This is a reland of 829a5dce900b781376ea72ba5d869c5dbe58a82d
(unchanged)
Downstream is fixed in https://chromium-review.googlesource.com/1651786
Original change's description:
> Link fewer X11-related libraries
>
> Use an explicit list and don't add X11 dependency to rtc_base.
>
> Allow skipping code that depends on rarer extensions such as Xdamage, Xfixes.
>
> Bug: None
> Change-Id: Icb8d20a267358f5cd3f1ff2af31a669e0670d2f6
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140865
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Reviewed-by: Guido Urdaneta <guidou@webrtc.org >
> Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28204}
Bug: None
Change-Id: I51c60f7713eb49889cebbca2242f33b81b0aef39
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141301
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28218}
2019-06-11 07:34:49 +00:00
4606ded90c
Revert "Link fewer X11-related libraries"
...
This reverts commit 829a5dce900b781376ea72ba5d869c5dbe58a82d.
Reason for revert: Suspect of breaking autoroll to chromium: https://crrev.com/c/1651414 .
Original change's description:
> Link fewer X11-related libraries
>
> Use an explicit list and don't add X11 dependency to rtc_base.
>
> Allow skipping code that depends on rarer extensions such as Xdamage, Xfixes.
>
> Bug: None
> Change-Id: Icb8d20a267358f5cd3f1ff2af31a669e0670d2f6
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140865
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Reviewed-by: Guido Urdaneta <guidou@webrtc.org >
> Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28204}
TBR=zijiehe@chromium.org ,mbonadei@webrtc.org ,henrika@webrtc.org ,oprypin@webrtc.org ,guidou@webrtc.org
Change-Id: Ie106de700fc017dafa603d15eaec88c4790dacfb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141300
Reviewed-by: Marina Ciocea <marinaciocea@webrtc.org >
Commit-Queue: Marina Ciocea <marinaciocea@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28215}
2019-06-10 19:53:42 +00:00
646e096e03
Allow null FILE* to AecDumpFactory::Create
...
Also add Create method with a FileWrapper argument, extracted from cl
https://webrtc-review.googlesource.com/c/src/+/140283
Bug: webrtc:6463
Change-Id: If86f17d5fda964df0b5874bd5a15fcaed899dd4e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140946
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Alex Loiko <aleloi@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28211}
2019-06-10 14:09:19 +00:00
