335204c550
Revert of Provide RSA2048 as per RFC (patchset #9 id:200001 of https://codereview.webrtc.org/1329493005/ )
...
Reason for revert:
Breaks chrome.
Original issue's description:
> provide RSA2048 as per RFC
>
> BUG=webrtc:4972
>
> Committed: https://crrev.com/0df3eb03c9a6a8299d7e18c8c314ca58c2f0681e
> Cr-Commit-Position: refs/heads/master@{#10209}
TBR=hbos@webrtc.org ,juberti@google.com ,jbauch@webrtc.org ,henrikg@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4972
Review URL: https://codereview.webrtc.org/1397703002
Cr-Commit-Position: refs/heads/master@{#10210}
2015-10-08 09:30:21 +00:00
0df3eb03c9
provide RSA2048 as per RFC
...
BUG=webrtc:4972
Review URL: https://codereview.webrtc.org/1329493005
Cr-Commit-Position: refs/heads/master@{#10209}
2015-10-08 09:06:20 +00:00
f839dcc870
Add stats for rendered pixels (sqrt(w*h)) per second:
...
- "WebRTC.Video.RenderSqrtPixelsPerSecond"
BUG=chromium:512752
Review URL: https://codereview.webrtc.org/1366583002
Cr-Commit-Position: refs/heads/master@{#10208}
2015-10-08 07:42:07 +00:00
e0e88cf34b
Roll chromium_revision 22ce537..2a2c52e (352889:353013)
...
Change log: 22ce537..2a2c52e22ce537..2a2c52e7d28d12..ce3f4ad22ce537..2a2c52eTBR=marpan@webrtc.org , stefan@webrtc.org ,
CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal
Review URL: https://codereview.webrtc.org/1398663002
Cr-Commit-Position: refs/heads/master@{#10207}
2015-10-08 06:45:47 +00:00
e78e2c714b
Using different sequence numbers for different SSRCs
...
This seems to solve the unexpected behavior when selecting lower layers.
Also, this replaces https://codereview.webrtc.org/1327153002/
Review URL: https://codereview.webrtc.org/1350383004
Cr-Commit-Position: refs/heads/master@{#10206}
2015-10-08 06:44:35 +00:00
fddf6e526c
Use WebRTC logging in MediaCodec JNI code.
...
Also enable HW encoder scaling in AppRTCDemo.
R=wzh@webrtc.org
Review URL: https://codereview.webrtc.org/1396653002 .
Cr-Commit-Position: refs/heads/master@{#10205}
2015-10-07 23:51:20 +00:00
21622a1d19
Add option to print peer connection factory Java stack traces.
...
R=wzh@webrtc.org
Review URL: https://codereview.webrtc.org/1395693002 .
Cr-Commit-Position: refs/heads/master@{#10204}
2015-10-07 21:50:21 +00:00
91b348c702
Android MediaCodecVideoDecoder: Manage lifetime of texture frames
...
This CL should be the last one in a series to finally unblock camera texture capture.
The SurfaceTexture.updateTexImage() calls are moved from the video renderers into MediaCodecVideoDecoder, and the destructor of the texture frames will signal MediaCodecVideoDecoder that the frame has returned. This CL also removes the SurfaceTexture from the native handle and only exposes the texture matrix instead, because only the video source should access the SurfaceTexture.
BUG=webrtc:4993
R=glaznev@webrtc.org , perkj@webrtc.org
Review URL: https://codereview.webrtc.org/1378033003 .
Cr-Commit-Position: refs/heads/master@{#10203}
2015-10-07 20:57:17 +00:00
87962a9787
Roll chromium_revision df4218d..22ce537 (352811:352889)
...
Change log: df4218d..22ce537df4218d..22ce5379855a87..6f8a664df4218d..22ce537https://codereview.webrtc.org/1398463002
Cr-Commit-Position: refs/heads/master@{#10202}
2015-10-07 18:46:57 +00:00
c7199c2d0b
Read the number of TLs for VP9 too + cleanup
...
In video_sender.cc, properly read the number of temporal layers for VP9 too.
Also, some cleanup in video_loopback.cc and video_quality_test.h.
Review URL: https://codereview.webrtc.org/1351693005
Cr-Commit-Position: refs/heads/master@{#10201}
2015-10-07 13:43:43 +00:00
78543284d0
Fix minor GYP error in webrtc/tools/internal_tools.gyp
...
It seems 'deps' is similar to 'dependencies' for the ninja and make
generators in GYP, but some generators does not support it.
Better use the correct key.
This was introduced in https://codereview.webrtc.org/1387243002/
TBR=phoglund@webrtc.org
Review URL: https://codereview.webrtc.org/1386353003 .
Cr-Commit-Position: refs/heads/master@{#10200}
2015-10-07 12:51:40 +00:00
172f009be2
Get rid of SCHANNEL code.
...
BUG=webrtc:5045
Review URL: https://codereview.webrtc.org/1383253002
Cr-Commit-Position: refs/heads/master@{#10199}
2015-10-07 11:58:00 +00:00
0a6380f069
Roll chromium_revision d47c242..df4218d (352743:352811)
...
Change log: d47c242..df4218dd47c242..df4218dhttps://codereview.webrtc.org/1389293002
Cr-Commit-Position: refs/heads/master@{#10198}
2015-10-07 11:44:03 +00:00
70a5e0ead6
Remove (u)int typedefs from basictypes.h.
...
BUG=webrtc:5024
R=henrikg@webrtc.org
Review URL: https://codereview.webrtc.org/1387413002 .
Cr-Commit-Position: refs/heads/master@{#10197}
2015-10-07 11:19:47 +00:00
0c4e06b4c6
Use suffixed {uint,int}{8,16,32,64}_t types.
...
Removes the use of uint8, etc. in favor of uint8_t.
BUG=webrtc:5024
R=henrik.lundin@webrtc.org , henrikg@webrtc.org , perkj@webrtc.org , solenberg@webrtc.org , stefan@webrtc.org , tina.legrand@webrtc.org
Review URL: https://codereview.webrtc.org/1362503003 .
Cr-Commit-Position: refs/heads/master@{#10196}
2015-10-07 10:23:32 +00:00
8d15bd6dab
Reland of Collecting encode_time_ms for each frame (patchset #1 id:1 of https://codereview.webrtc.org/1383283005/ )
...
Reason for revert:
The reverted commit didn't affect the tests, but the one before: https://codereview.webrtc.org/1385563005/
I've run the test that was failing (EndToEndTest.AssignsTransportSequenceNumbers) locally multiple times, and it works fine (finishes successfully in 150-170ms).
Original issue's description:
> Revert of Collecting encode_time_ms for each frame (patchset #13 id:220001 of https://codereview.webrtc.org/1374233002/ )
>
> Reason for revert:
> Breaks EndToEndTest.AssignsTransportSequenceNumbers in video_engine_tests
> on several bots:
> http://build.chromium.org/p/client.webrtc/builders/Linux64%20Debug/builds/5507
> http://build.chromium.org/p/client.webrtc/builders/Mac64%20Debug/builds/4815
> http://build.chromium.org/p/client.webrtc/builders/Win%20SyzyASan/builds/3272
> http://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/4414
>
> It seems very unfortunate that it breaks on _exactly_ the bot configs that aren't covered by the CQ trybots.
>
> Original issue's description:
> > Collecting encode_time_ms for each frame.
> >
> > Also, in Sample struct, replacing double with the original type.
> > It makes more sense to save the original data as truthful as possible, and then
> > convert it to double later if necessary (in the plot script).
> >
> > Committed: https://crrev.com/092b13384e57b33e2003d9736dfa1f491e76f938
> > Cr-Commit-Position: refs/heads/master@{#10184}
>
> TBR=sprang@webrtc.org ,pbos@webrtc.org ,mflodman@webrtc.org ,asapersson@webrtc.org ,ivica@webrtc.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/810447972425e890bc7911af27f894b86e9b7e6f
> Cr-Commit-Position: refs/heads/master@{#10185}
TBR=sprang@webrtc.org ,pbos@webrtc.org ,mflodman@webrtc.org ,asapersson@webrtc.org ,kjellander@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.webrtc.org/1390163002
Cr-Commit-Position: refs/heads/master@{#10195}
2015-10-07 09:43:25 +00:00
d97ec30ce4
Remove default receive channel from WVoE; baby step 0.
...
Cleanup + add thread checker DCHECKs to various method in WebRtcVoiceEngine/MediaChannel.
BUG=webrtc:4690
Review URL: https://codereview.webrtc.org/1386653002
Cr-Commit-Position: refs/heads/master@{#10194}
2015-10-07 08:40:38 +00:00
67bcb609a3
GN: Port frame_analyzer and rgba_to_i420_converter targets
...
Original patch by tfarina@chromium.org at
https://webrtc-codereview.appspot.com/42999004/
BUG=chromium:461019, webrtc:4504
TESTED=Tested on Linux with the following command lines:
$ gn gen/out/Debug --args='is_debug=true build_with_chromium=false'
$ ninja -C out/Debug frame_analyzer rgba_to_i420_converter
Also successfully compiled from a Chromium checkout using the steps in webrtc:4504.
R=tfarina@chromium.org
Review URL: https://codereview.webrtc.org/1387243002 .
Cr-Commit-Position: refs/heads/master@{#10193}
2015-10-07 06:43:07 +00:00
7f315f58bc
Roll chromium_revision 6ebca7d..d47c242 (352640:352743)
...
Change log: 6ebca7d..d47c2426ebca7d..d47c242https://codereview.webrtc.org/1390983002
Cr-Commit-Position: refs/heads/master@{#10192}
2015-10-07 06:31:39 +00:00
a38e31a054
Update lower-level codereview.settings files.
...
Every now and then we get CLs to codereview.webrtc.org
that are created from a Chromium checkout by editing
the code in third_party/webrtc or third_party/libjingle.
By editing these lower-level codereview.settings files,
we instead cause a crash during 'git cl upload', but the
contents of the file will also be printed, which can work
as an error message. The alternative would be to entirely
remove the files.
BUG=
R=andrew@webrtc.org , tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1389963002 .
Cr-Commit-Position: refs/heads/master@{#10191}
2015-10-06 21:19:34 +00:00
a10492ff33
Fix VS 2015 warning by adding an additional cast
...
The OwningThread member of CRITICAL_SECTION is declared as having type
HANDLE but it is actually the thread's Thread ID which is a DWORD. When
doing 64-bit builds of Chromium with VS 2015 this triggers a warning
because of the suspicious conversion from 32-bit integer to 64-bit
pointer.
This change adds a cast (and some comments) to make the conversion
explicit and avoid the warning.
R=henrikg@webrtc.org
BUG=440500
Review URL: https://codereview.webrtc.org/1386183002
Cr-Commit-Position: refs/heads/master@{#10190}
2015-10-06 20:34:34 +00:00
4139c0f1c5
Java binding for RtpSender/RtpReceiver.
...
The Java PeerConnection maintains a cached list of Java RtpSenders
and RtpReceivers so that the same objects are returned every time
getSenders() or getReceivers() is called. They are disposed of when
PeerConnection.dispose() is called, which will also dispose their
referenced MediaStreamTracks.
Review URL: https://codereview.webrtc.org/1368143002
Cr-Commit-Position: refs/heads/master@{#10189}
2015-10-06 19:29:32 +00:00
10950692d6
Revert "Transport sequence number should be set also for retransmissions."
...
After this CL, video_engine_test started failing flakily in different bots for different CLs.
TBR=sprang@webrtc.org
Review URL: https://codereview.webrtc.org/1393553003 .
Cr-Commit-Position: refs/heads/master@{#10188}
2015-10-06 19:27:12 +00:00
a295320639
Roll chromium_revision 2a1b03e..6ebca7d (352576:352640)
...
Change log: 2a1b03e..6ebca7d2a1b03e..6ebca7dhttps://codereview.webrtc.org/1393453003
Cr-Commit-Position: refs/heads/master@{#10187}
2015-10-06 19:20:31 +00:00
0a6c4ca942
Catching more errors when parsing ICE server URLs.
...
Every malformed URL should now produce an error message in JS, rather than
silently failing and possibly printing a warning message to the console (and
possibly crashing).
Also added some unit tests, and made "ParseIceServers" public.
BUG=445002
Review URL: https://codereview.webrtc.org/1344143002
Cr-Commit-Position: refs/heads/master@{#10186}
2015-10-06 18:38:33 +00:00
8104479724
Revert of Collecting encode_time_ms for each frame (patchset #13 id:220001 of https://codereview.webrtc.org/1374233002/ )
...
Reason for revert:
Breaks EndToEndTest.AssignsTransportSequenceNumbers in video_engine_tests
on several bots:
http://build.chromium.org/p/client.webrtc/builders/Linux64%20Debug/builds/5507
http://build.chromium.org/p/client.webrtc/builders/Mac64%20Debug/builds/4815
http://build.chromium.org/p/client.webrtc/builders/Win%20SyzyASan/builds/3272
http://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/4414
It seems very unfortunate that it breaks on _exactly_ the bot configs that aren't covered by the CQ trybots.
Original issue's description:
> Collecting encode_time_ms for each frame.
>
> Also, in Sample struct, replacing double with the original type.
> It makes more sense to save the original data as truthful as possible, and then
> convert it to double later if necessary (in the plot script).
>
> Committed: https://crrev.com/092b13384e57b33e2003d9736dfa1f491e76f938
> Cr-Commit-Position: refs/heads/master@{#10184}
TBR=sprang@webrtc.org ,pbos@webrtc.org ,mflodman@webrtc.org ,asapersson@webrtc.org ,ivica@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.webrtc.org/1383283005
Cr-Commit-Position: refs/heads/master@{#10185}
2015-10-06 18:34:14 +00:00
092b13384e
Collecting encode_time_ms for each frame.
...
Also, in Sample struct, replacing double with the original type.
It makes more sense to save the original data as truthful as possible, and then
convert it to double later if necessary (in the plot script).
Review URL: https://codereview.webrtc.org/1374233002
Cr-Commit-Position: refs/heads/master@{#10184}
2015-10-06 14:13:50 +00:00
af4ced986b
Transport sequence number should be set also for retransmissions.
...
When fetching a packet from the rtp packet history, cuased by a
retransmission, the transport seq extension header is enabled but the
sequence number is set to 0. A new transport seq should be assigned in
this case.
BUG=
Review URL: https://codereview.webrtc.org/1385563005
Cr-Commit-Position: refs/heads/master@{#10183}
2015-10-06 13:02:57 +00:00
86fa298c3e
Roll chromium_revision 4bf3678..2a1b03e (352512:352576)
...
Change log: 4bf3678..2a1b03e4bf3678..2a1b03ehttps://codereview.webrtc.org/1383123004
Cr-Commit-Position: refs/heads/master@{#10182}
2015-10-06 12:28:22 +00:00
5d0379da2c
Remove kSkipFrame usage.
...
Since padding is no longer sent on Encoded() callbacks, dummy callbacks
aren't required to generate padding. This skip-frame behavior can then
be removed to get rid of dummy callbacks though nothing was encoded. As
frames don't have to be generated for frames that don't have to be sent
we skip encoding frames that aren't intended to be sent either, reducing
CPU load.
BUG=
R=mflodman@webrtc.org , stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1369923005 .
Cr-Commit-Position: refs/heads/master@{#10181}
2015-10-06 12:05:03 +00:00
13c433c299
Add delay metric (includes network delay (rtt/2) + jitter delay + decode time + render delay):
...
- "WebRTC.Video.OnewayDelayInMs"
BUG=chromium:512752
Review URL: https://codereview.webrtc.org/1351403008
Cr-Commit-Position: refs/heads/master@{#10180}
2015-10-06 11:08:22 +00:00
7bd242e53d
Enabling screensharing tests for Android
...
This CL runs the screensharing tests 5 times, and none of the Android trybots failed:
https://codereview.webrtc.org/1377663003/
Therefore, we can now probably enable the tests.
BUG=chromium:513170
Review URL: https://codereview.webrtc.org/1389573004
Cr-Commit-Position: refs/heads/master@{#10179}
2015-10-06 09:04:15 +00:00
9359b5b978
Disabling AudioDeviceTest.StartStopPlayout on Android.
...
BUG=5046
TBR=henrika@webrtc.org
Review URL: https://codereview.webrtc.org/1374963003 .
Cr-Commit-Position: refs/heads/master@{#10178}
2015-10-06 07:13:45 +00:00
d89f82ab65
Roll chromium_revision c511263..4bf3678 (352322:352512)
...
Change log: c511263..4bf3678c511263..4bf36780c88009..5fc8d39c511263..4bf3678https://codereview.webrtc.org/1384823003
Cr-Commit-Position: refs/heads/master@{#10177}
2015-10-06 02:47:40 +00:00
09f1350efa
Add option to reset Android video renderer first frame flag.
...
This allows to correctly report first frame event in applications which
use same remote video renderer for multiple calls.
R=wzh@webrtc.org
Review URL: https://codereview.webrtc.org/1384353002 .
Cr-Commit-Position: refs/heads/master@{#10176}
2015-10-05 20:01:41 +00:00
6caafbe5b6
Convert uint16_t to int for WebRTC cipher/crypto suite.
...
This is a follow up CL on https://codereview.webrtc.org/1337673002
BUG=
R=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1377733004 .
Cr-Commit-Position: refs/heads/master@{#10175}
2015-10-05 19:43:33 +00:00
1b33da1298
SurfaceTextureHelper fixes
...
Fixed a problem where eglBase.makecurrent() could be called after the context had been released if SurfaceTextureHelper was first created and immedately disconnected.
Add the possibility to inject a thread to use instead of creating a new.
BUG= webrtc:4993
R=magjed@webrtc.org
Review URL: https://codereview.webrtc.org/1384923002 .
Cr-Commit-Position: refs/heads/master@{#10174}
2015-10-05 19:06:48 +00:00
418503275c
Add ThreadChecker class to ThreadUtils
...
This class can be used for checking that method calls are made on the correct thread.
R=magjed@webrtc.org
Review URL: https://codereview.webrtc.org/1384303002 .
Cr-Commit-Position: refs/heads/master@{#10173}
2015-10-05 18:49:15 +00:00
d2838a74f1
Roll chromium_revision 07b4a8e..c511263 (352281:352322)
...
Change log: 07b4a8e..c51126307b4a8e..c511263https://codereview.webrtc.org/1384943002 .
Cr-Commit-Position: refs/heads/master@{#10172}
2015-10-05 16:12:25 +00:00
e0bce24065
VideoCapturerAndroid: Add custom nativeCreateVideoCapturer()
...
This CL shouldn't make any functional changes. It adds a new VideoCapturerAndroid.nativeCreateVideoCapturer() instead of always using VideoCapturer.nativeCreateVideoCapturer(). The purpose is to simplify androidvideocapturer_jni and VideoCapturerAndroid.create(). This way, it is possible to use the ctor instead of VideoCapturerAndroid.init() to initialize variables, and they can be made final etc.
R=perkj@webrtc.org
Review URL: https://codereview.webrtc.org/1360173002 .
Cr-Commit-Position: refs/heads/master@{#10171}
2015-10-05 14:22:06 +00:00
723dff1e6d
Poll stats more often to get more stable stats in ramp-up tests.
...
BUG=chromium:538649
R=pbos@webrtc.org
Review URL: https://codereview.webrtc.org/1384253004 .
Cr-Commit-Position: refs/heads/master@{#10170}
2015-10-05 12:59:50 +00:00
4cd053fe88
Only catch UnsatisfiedLinkError in Logging.java.
...
BUG=
Review URL: https://codereview.webrtc.org/1375913005
Cr-Commit-Position: refs/heads/master@{#10169}
2015-10-05 12:27:50 +00:00
f3a7c9d732
In rampup tests, set start time when starting poller thread.
...
This should avoid perf change caused by
https://codereview.webrtc.org/1378303004
BUG=539257
R=stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1383223002 .
Cr-Commit-Position: refs/heads/master@{#10168}
2015-10-05 12:03:29 +00:00
95cd8ea31a
Enable HW NS for N6 to fix HW AEC issue
...
TBR=magjed
BUG=b/24595150
Review URL: https://codereview.webrtc.org/1370413003 .
Cr-Commit-Position: refs/heads/master@{#10167}
2015-10-05 11:59:01 +00:00
dec5ebf106
Move sent key frame stats to send_statistics_proxy class.
...
BUG=
Review URL: https://codereview.webrtc.org/1374673003
Cr-Commit-Position: refs/heads/master@{#10166}
2015-10-05 09:36:20 +00:00
42b6c634f0
autoroller: Allow to specify Rietveld e-mail.
...
This is useful in order to specify which account to be used
for creating the Rietveld CL.
Always pass -f to force yes to any prompts during uplaod.
BUG=webrtc:4688
R=phoglund@webrtc.org
Review URL: https://codereview.webrtc.org/1383203002 .
Cr-Commit-Position: refs/heads/master@{#10165}
2015-10-05 08:44:34 +00:00
990d57dc65
Fix file order in base.gyp.
...
Review URL: https://codereview.webrtc.org/1386613003
Cr-Commit-Position: refs/heads/master@{#10164}
2015-10-05 08:22:32 +00:00
ba0f0a51d6
Disable flaky WebRtcVideoChannel2BaseTest.* on DrMemory/memcheck.
...
BUG=webrtc:4963
R=kjellander@webrtc.org
Review URL: https://codereview.webrtc.org/1388693002 .
Cr-Commit-Position: refs/heads/master@{#10163}
2015-10-05 08:11:07 +00:00
4bd8d092a2
Roll chromium_revision ca4c339..07b4a8e (352257:352281)
...
Change log: ca4c339..07b4a8eca4c339..07b4a8ehttps://codereview.webrtc.org/1387803002
Cr-Commit-Position: refs/heads/master@{#10162}
2015-10-05 04:20:31 +00:00
96a70f0183
Exclude WebRtcVideoChannel2BaseTest.AddRemoveCapturerMultipleSources on Dr Memory.
...
The test is flaky on Dr Memory (not at Linux memcheck as previously
committed in https://codereview.webrtc.org/1388663002 ).
BUG=5050
TBR=pbos@webrtc.org
Review URL: https://codereview.webrtc.org/1377183004 .
Cr-Commit-Position: refs/heads/master@{#10161}
2015-10-05 03:42:50 +00:00
