zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
26,625 Commits 1 Branch 0 Tags
4124dab7f3bbdd0529595c94b73247dbace51d84
Commit Graph

26625 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Sebastian Jansson
77efcd82db Reland "Replacing rtc::Thread with task queue for TestAudioDeviceModule." 
This is a reland of 1b871d07532c25d2f27e4db192cb9ce2229b1cee

Original change's description:
> Replacing rtc::Thread with task queue for TestAudioDeviceModule.
>
> This prepares for running it in simulated time.
>
> TBR=henrika@webrtc.org
>
> Bug: webrtc:10465
> Change-Id: I9b29b8af9aeba7f0c8209ca77294a63d8068ff1a
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126481
> Reviewed-by: Sebastian Jansson <srte@webrtc.org>
> Reviewed-by: Oskar Sundbom <ossu@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#27083}

TBR=henrika@webrtc.org

Bug: webrtc:10465
Change-Id: Icda8043fb5b1156129bc3b706bf8f190782b0921
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127520
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27093}
 2019-03-13 09:01:05 +00:00
Sebastian Jansson
793597b7c9 Removes TaskQueueBase::Current call in repeating task. 
Bug: webrtc:10365
Change-Id: Ie9fd1a28e96680b8b4b6ef8339c3eaba21ef9e18
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126781
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27092}
 2019-03-13 08:17:22 +00:00
Sebastian Jansson
cda86dd483 Removes usages of repeating task without task queue argument. 
This prepares from removing the overload in a followup CL.

Bug: webrtc:10365
Change-Id: I80db16e7d37944e3dc7d2799bbf45ef8f439a22c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126860
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27091}
 2019-03-13 08:07:56 +00:00
Amit Hilbuch
e7a5f7bfae Modifying MediaChannel to accept CopyOnWriteBuffer by value. 
MediaChannel accepted the RtpPacket buffers through non-const pointer.
This is both unclear and introduces questions regarding if the buffer is
actually copied or not.
This change modifies the method to accept by value to reduce ambiguity.
Usage of the non-const data() method which could potentially copy the
buffer contents is also reduced in favor of cdata() which never copies.

Bug: None
Change-Id: I3b2daef0d31cb6aacceb46c86da3a40ce836242b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127340
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Seth Hampson <shampson@webrtc.org>
Commit-Queue: Amit Hilbuch <amithi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27090}
 2019-03-12 23:49:57 +00:00
Benjamin Wright
dfaea9dd98 Fuzz rtc::StringToNumber. 
StringToNumber is directly used in parsing the SDP so it should be fuzzed.

Bug: webrtc:10395
Change-Id: I85b520fbefd34d3dba49950c5ff297b482c572b1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127123
Commit-Queue: Benjamin Wright <benwright@webrtc.org>
Reviewed-by: Qingsi Wang <qingsi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27089}
 2019-03-12 22:05:46 +00:00
Benjamin Wright
6a5e976fbe Add generic depacketizer fuzzer to WebRTC. 
The generic video depacketizer was missed in the initial fuzzing pass.

Bug: webrtc:10395
Change-Id: I166f27fc5897a2eafe38dad8e074834fefcc330e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127041
Reviewed-by: Qingsi Wang <qingsi@webrtc.org>
Commit-Queue: Benjamin Wright <benwright@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27088}
 2019-03-12 20:48:19 +00:00
Benjamin Wright
ade5cb8294 Field trial fuzzer. 
This simple fuzzer is intended to detect potential issues in the field trial
parsing code. Since these can be set by the browser it is better to have some
fuzzing coverage around this area.

Bug: webrtc:10395
Change-Id: I1b8b859d2107a0bc99cb7520cf0ef96f3d110547
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127121
Commit-Queue: Benjamin Wright <benwright@webrtc.org>
Reviewed-by: Qingsi Wang <qingsi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27087}
 2019-03-12 20:47:15 +00:00
Seth Hampson
fa852efb73 Revert "Replacing rtc::Thread with task queue for TestAudioDeviceModule." 
This reverts commit 1b871d07532c25d2f27e4db192cb9ce2229b1cee.

Reason for revert: Breaks webrtc downstream projects.

Original change's description:
> Replacing rtc::Thread with task queue for TestAudioDeviceModule.
> 
> This prepares for running it in simulated time.
> 
> TBR=henrika@webrtc.org
> 
> Bug: webrtc:10465
> Change-Id: I9b29b8af9aeba7f0c8209ca77294a63d8068ff1a
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126481
> Reviewed-by: Sebastian Jansson <srte@webrtc.org>
> Reviewed-by: Oskar Sundbom <ossu@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#27083}

TBR=henrika@webrtc.org,ossu@webrtc.org,srte@webrtc.org

Change-Id: I16d7c2a46d38c9aaf82cc3ab7bd7b9c5e10f5a5e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10465
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127341
Reviewed-by: Seth Hampson <shampson@webrtc.org>
Commit-Queue: Seth Hampson <shampson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27086}
 2019-03-12 20:05:53 +00:00
Seth Hampson
bd50a84336 Revert "Reland "DCHECK feedback_rtt is positive"" 
This reverts commit ab0d03dcaaa98677348d15352f7bc1e8e066180f.

Reason for revert: Broke webrtc importer.

Original change's description:
> Reland "DCHECK feedback_rtt is positive"
> 
> This is a reland of 37d4f91db3fd1d0e023a820d0cda86bb786a0f72
> Reason for reland: Got Aliby for Android FEC test flakes.
> 
> Original change's description:
> > DCHECK feedback_rtt is positive
> >
> > Bug: None
> > Change-Id: I6eb10d6a20a679fff08f604441f8e58dcd417608
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126464
> > Commit-Queue: Evan Shrubsole <eshr@google.com>
> > Reviewed-by: Sebastian Jansson <srte@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#27034}
> 
> Bug: None
> Change-Id: Iacacda9e3b141c69189f7931a1ec63d74b2dd845
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126920
> Commit-Queue: Sebastian Jansson <srte@webrtc.org>
> Reviewed-by: Ying Wang <yinwa@webrtc.org>
> Reviewed-by: Sebastian Jansson <srte@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#27082}

TBR=srte@webrtc.org,yinwa@webrtc.org,yvesg@webrtc.org,yvesg@google.com,eshr@google.com

Change-Id: Ia59f20019309c1e0b44029179d63558e92d39a85
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127324
Reviewed-by: Seth Hampson <shampson@webrtc.org>
Commit-Queue: Seth Hampson <shampson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27085}
 2019-03-12 19:40:25 +00:00
chromium-webrtc-autoroll
ea07650b0b Roll chromium_revision 8158f07c24..48038209dc (639862:640007) 
Change log: 8158f07c24..48038209dc
Full diff: 8158f07c24..48038209dc

Changed dependencies
* src/base: 1b069d3e88..351141a2c6
* src/build: ac2f1f6da8..477cc2028c
* src/ios: 2617208b4d..0a2c8ecd8b
* src/testing: d9c8fc7872..bdb01bb642
* src/third_party: bc7297d100..3a944a1807
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/eb73833a29..a7314e4d23
* src/tools: 848a110b95..1eb8f742ae
DEPS diff: 8158f07c24..48038209dc/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: If4b974f4b6cee911dc56adeac68cfd299d94bc28
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127323
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27084}
 2019-03-12 19:04:54 +00:00
Sebastian Jansson
1b871d0753 Replacing rtc::Thread with task queue for TestAudioDeviceModule. 
This prepares for running it in simulated time.

TBR=henrika@webrtc.org

Bug: webrtc:10465
Change-Id: I9b29b8af9aeba7f0c8209ca77294a63d8068ff1a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126481
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Oskar Sundbom <ossu@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27083}
 2019-03-12 18:25:31 +00:00
Evan Shrubsole
ab0d03dcaa Reland "DCHECK feedback_rtt is positive" 
This is a reland of 37d4f91db3fd1d0e023a820d0cda86bb786a0f72
Reason for reland: Got Aliby for Android FEC test flakes.

Original change's description:
> DCHECK feedback_rtt is positive
>
> Bug: None
> Change-Id: I6eb10d6a20a679fff08f604441f8e58dcd417608
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126464
> Commit-Queue: Evan Shrubsole <eshr@google.com>
> Reviewed-by: Sebastian Jansson <srte@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#27034}

Bug: None
Change-Id: Iacacda9e3b141c69189f7931a1ec63d74b2dd845
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126920
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Ying Wang <yinwa@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27082}
 2019-03-12 17:00:51 +00:00
Sebastian Jansson
ec65e1fee5 Allow construction of TaskQueueForTest with TaskQueueBase 
Using simulated time implementation of TaskQueue with TaskQueueForTest.

Bug: webrtc:10365
Change-Id: I9f853133aa9fcd5858a5e2e1e0f47ab1a6a5ca18
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127292
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27081}
 2019-03-12 16:31:39 +00:00
Jakob Ivarsson
1b4254ada5 Check current buffer time span instead of number of samples in postpone decoding after expand. 
Bug: webrtc:10392
Change-Id: I2ad4d8c7a3f87cab32e2ea097b2e05aa179e0bc0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126761
Reviewed-by: Minyue Li <minyue@webrtc.org>
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Commit-Queue: Jakob Ivarsson‎ <jakobi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27080}
 2019-03-12 16:25:24 +00:00
Niels Möller
075e7fdd00 Delete VCMPacket constructor with WebRtcRTPHeader 
Bug: webrtc:10397
Change-Id: I8f51616d6953af6b2d3bdfdf46b748b2a78702ea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127240
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27079}
 2019-03-12 15:18:41 +00:00
Ivo Creusen
c4b391a257 Revert "NetEQ RTP Play: Optionally write output audio file" 
This reverts commit 6330818ec8159ee476481ba4a89f884fb3653f3f.

Reason for revert: This breaks api/test/neteq_simulator_factory.cc, which unfortunately was not caught by our bots.

Original change's description:
> NetEQ RTP Play: Optionally write output audio file
> 
> This CL makes the output audio file optional to more
> quickly run neteq_rtpplay when no audio output is needed.
> The CL also includes necessary adaptations because of pre-existing
> dependencies (e.g., the output audio file name is used to create
> the plotting script file names).
> 
> The command line arguments are retro-compatible - i.e., same behavior
> when specifying the output audio file and the new flag
> --output_files_base_name is not used.
> 
> This CL also includes a test script with which the retro-compatibility
> has been verified.
> 
> Bug: webrtc:10337
> Change-Id: Ie3f301b3b2ed0682fb74426d9cf452396f2b112b
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126224
> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
> Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#27067}

TBR=henrik.lundin@webrtc.org,alessiob@webrtc.org,ivoc@webrtc.org

Change-Id: I0c63a8ba9566ef567ee398f571f2a511916fa742
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10337
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127293
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Commit-Queue: Ivo Creusen <ivoc@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27078}
 2019-03-12 14:28:23 +00:00
Jonas Olsson
e096004745 Enable configuring probes via field trial. 
This CL adds a field trial that lets us control the size of the initial probes, how we grow the following probes and how big and frequent our ALR probes are.

Bug: webrtc:10394
Change-Id: I6c7783dfada9aaf55cd836dd8991bb7b8ca4993b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126880
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27077}
 2019-03-12 14:27:18 +00:00
Jonas Olsson
cb96809e46 Make FieldTrialOptionals operator bool() explicit 
Implicit bool conversions behave wierdly in a bunch of cases, so let's make it explicit.

Bug: None
Change-Id: I15933e90d57c57218eed9608407aace5a640a6ea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127284
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27076}
 2019-03-12 14:24:48 +00:00
Niels Möller
bf40c380ae Pass flexfec_sender only to the protected media send stream. 
Fixes a regression from cl
https://webrtc-review.googlesource.com/c/src/+/123187.

Bug: webrtc:7135
Change-Id: Ifdbb3a3fd61610ac2b4d1f454aef71791f2a5b04
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127286
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27075}
 2019-03-12 14:18:08 +00:00
Artem Titov
fc6ab00a39 Introduce EmulatedRoute 
Introduce a handle for route created with network emulation layer,
that can be used to remove it in future properly.

Bug: webrtc:10138
Change-Id: I9fb847caeee24333bafb328727711af005b09224
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127283
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27074}
 2019-03-12 13:25:32 +00:00
Artem Titov
a268b69037 Rename EndpointConfig into EmulatedEndpointConfig 
Also fix minor issues in this class.

Bug: webrtc:10138
Change-Id: Icb3ec7f6296c34da260e701ec51d7b87ce62a4d7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127281
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27073}
 2019-03-12 13:24:29 +00:00
Tommi
30e60d6fd9 Remove dependency on DirectShow baseclasses (streams.h from the winsdk_samples directory). 
This required a fairly extensive overhaul:

* Removed locks from the implementation.
  The filter/pin architecture does use multiple threads,
  but the state is controlled on one and synchronization
  is done via flags that don't require locking.
  Note though that the baseclasses used a lot of locking, it's unclear why,
  but perhaps there are things I'm not aware of. The locking was not done
  consistently though, which doesn't seem to have been a problem.
* Change the code to not mix AddRef/Release and use of explicit 'delete'.
* Removed implementations of interfaces we don't need/use.
* Similarly some methods now return E_NOTIMPL.
* Added some utilities to make use of COM interfaces and concepts, easier.

BUG=webrtc:10374
TBR=mbonadei@webrtc.org

Change-Id: Iaedb1157d37ef5d5c75f727dba3d7de75ce22cd8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/125086
Commit-Queue: Tommi <tommi@webrtc.org>
Reviewed-by: Christian Fremerey <chfremer@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27072}
 2019-03-12 11:52:20 +00:00
Ruslan Burakov
2594f27bad Change some RTC_DCHECKs to RTC_DCHECK_EQ 
This makes the error messages more informative.

Bug: webrtc:10398
Change-Id: I161aa4bfa53f60d06500d42c883f18add4c58531
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127200
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Ruslan Burakov <kuddai@google.com>
Cr-Commit-Position: refs/heads/master@{#27071}
 2019-03-12 10:42:43 +00:00
Danil Chapovalov
4f779c6aec Remove legacy empty task_queue BUILD targets and build arg 
Now that they are unused

Bug: webrtc:10191
Change-Id: Id5f1b70ed8e084555ca809fef2a75359266f2ca1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126980
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27070}
 2019-03-12 10:06:04 +00:00
Niels Möller
70a83949b7 Delete use of WebRtcRTPHeader from FEC test code 
Tbr: srte@webrtc.org # comment change in modules/remote_bitrate_estimator/
Bug: webrtc:10397
Change-Id: Ic30e724c18c8812810ac7a608b7065d56a7676e8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126941
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27069}
 2019-03-12 09:40:02 +00:00
chromium-webrtc-autoroll
2eb54a4188 Roll chromium_revision ad6c7f0653..8158f07c24 (639761:639862) 
Change log: ad6c7f0653..8158f07c24
Full diff: ad6c7f0653..8158f07c24

Changed dependencies
* src/build: 611bb3306c..ac2f1f6da8
* src/testing: 6543ab367e..d9c8fc7872
* src/third_party: 42672dc020..bc7297d100
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4c54c5ccde..eb73833a29
* src/third_party/depot_tools: 8220b123a1..77e5d48a08
* src/tools: 73b61e26a1..848a110b95
DEPS diff: ad6c7f0653..8158f07c24/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Icad9e011834c125ceb9514216905e837f595dad7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127160
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27068}
 2019-03-12 09:20:18 +00:00
Alessio Bazzica
6330818ec8 NetEQ RTP Play: Optionally write output audio file 
This CL makes the output audio file optional to more
quickly run neteq_rtpplay when no audio output is needed.
The CL also includes necessary adaptations because of pre-existing
dependencies (e.g., the output audio file name is used to create
the plotting script file names).

The command line arguments are retro-compatible - i.e., same behavior
when specifying the output audio file and the new flag
--output_files_base_name is not used.

This CL also includes a test script with which the retro-compatibility
has been verified.

Bug: webrtc:10337
Change-Id: Ie3f301b3b2ed0682fb74426d9cf452396f2b112b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126224
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27067}
 2019-03-12 08:37:57 +00:00
chromium-webrtc-autoroll
dba16fd423 Roll chromium_revision 02df973441..ad6c7f0653 (639636:639761) 
Change log: 02df973441..ad6c7f0653
Full diff: 02df973441..ad6c7f0653

Changed dependencies
* src/base: f40dc27ccc..1b069d3e88
* src/build: 7bf9fe2a57..611bb3306c
* src/ios: f930d827ba..2617208b4d
* src/testing: 3b102bc158..6543ab367e
* src/third_party: 01fbcc9bfd..42672dc020
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/8a91b40f02..4c54c5ccde
* src/third_party/depot_tools: 53aa75c9ce..8220b123a1
* src/tools: 6fe34aa7aa..73b61e26a1
DEPS diff: 02df973441..ad6c7f0653/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Iaf4e33301accc3973826917c95eeb695f3e5718d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127021
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27066}
 2019-03-12 03:12:56 +00:00
chromium-webrtc-autoroll
b935d48991 Roll chromium_revision 20749e92ed..02df973441 (639533:639636) 
Change log: 20749e92ed..02df973441
Full diff: 20749e92ed..02df973441

Changed dependencies
* src/base: 74429604b8..f40dc27ccc
* src/build: 3dc511c004..7bf9fe2a57
* src/buildtools: a9db5def7f..794f2d1f1c
* src/buildtools/third_party/libc++/trunk: 9ae8fb4a3c..a50f503562
* src/ios: 411071a842..f930d827ba
* src/testing: b28dac3e12..3b102bc158
* src/third_party: e5afd5ac6f..01fbcc9bfd
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/a6124742d0..3390fd88d7
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c00fdb9d64..8a91b40f02
* src/third_party/depot_tools: 3485a263f4..53aa75c9ce
* src/tools: 7baff71ec3..6fe34aa7aa
DEPS diff: 20749e92ed..02df973441/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ic5192e919c94fa8459ca6489807faae0a4d4d811
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127001
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27065}
 2019-03-11 22:08:10 +00:00
chromium-webrtc-autoroll
7b0b9662f4 Roll chromium_revision f2f5c1896e..20749e92ed (639430:639533) 
Change log: f2f5c1896e..20749e92ed
Full diff: f2f5c1896e..20749e92ed

Changed dependencies
* src/base: 22e38d6529..74429604b8
* src/ios: eafe446412..411071a842
* src/third_party: 489f6328a5..e5afd5ac6f
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/b88eedc51a..c00fdb9d64
* src/tools: 75b8edbe4e..7baff71ec3
DEPS diff: f2f5c1896e..20749e92ed/DEPS

Clang version changed 354873:355581
Details: f2f5c1896e..20749e92ed/tools/clang/scripts/update.py

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I03592330c96712e3496713b20fe22a1d689b973e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126900
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27064}
 2019-03-11 18:31:07 +00:00
Danil Chapovalov
471783fc87 Remove rtc::QueuedTask alias, use webrtc::QueuedTask directly 
Use absl::WrapUnique/absl::make_unique to create the queued tasks.

Bug: webrtc:10191
Change-Id: I8f47a60cb326b0fc361c7f0e338b25373d39937c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126525
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27063}
 2019-03-11 16:49:21 +00:00
Niels Möller
125b5d6ffb Refactor RtpVideoStreamReceiver::OnReceivedPayloadData without WebRtcRTPHeader 
Bug: None
Change-Id: I7f96d9a7435a12a0390149e7854100f7fb7e7431
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126160
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27062}
 2019-03-11 16:36:10 +00:00
Sebastian Jansson
d155d686f8 Removes rtp level keep alive support. 
This is not used in practice as there's functionality on
other levels that serves the same purpose.

Bug: None
Change-Id: I0488dc42459b07607363eba0f2b06f4c50f7cda4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/125520
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27061}
 2019-03-11 14:47:15 +00:00
Sebastian Jansson
9ffb5df04e Removes unused mock_bitrate_controller. 
Bug: None
Change-Id: I53d29c0723e161810e8057d7b595102da6eeed31
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126760
Reviewed-by: Oskar Sundbom <ossu@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27060}
 2019-03-11 14:31:14 +00:00
Sam Zackrisson
d71edac904 Add an input size limit to APM fuzzer 
The fuzzer times out on too long inputs.
This CL limits tests to 400 000 bytes, ~ 12 seconds of 8 kHz float audio.

Bug: chromium:940209
Change-Id: I86b772f9d8989a8b129d933d25ece3631a6a365f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126780
Reviewed-by: Alex Loiko <aleloi@webrtc.org>
Commit-Queue: Sam Zackrisson <saza@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27059}
 2019-03-11 14:01:09 +00:00
Elad Alon
a5c0ba1861 Reland "Fix LibvpxVp8Encoder::FrameDropThreshold" 
This is a reland of 159e53a66eceb79003741ba0d990c502595c27bb
Reason for reland: Got Aliby for Android FEC test flakes.

Original change's description:
> Fix LibvpxVp8Encoder::FrameDropThreshold
>
> Bug: webrtc:10387
> Change-Id: I17b575546d6718f905429ac45705cb923ee52c10
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126232
> Commit-Queue: Elad Alon <eladalon@webrtc.org>
> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#27032}

Bug: webrtc:10387
Change-Id: Iaed760464d71ccfc6ad0e442b99f20c40c03e1e2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126762
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Yves Gerey <yvesg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27058}
 2019-03-11 13:37:38 +00:00
Marina Ciocea
e448a3fb54 Update DataChannel bufferedamount implementation. 
Call DataChannelObserver::OnBufferedAmountChange on each successful send.
Previously, the observer would get notified of buffered amount changes only when
queued send data is consumed. Data gets queued only if it cannot be sent right
away. According to the WebRTC standard[1], bufferedamount should be increased
before each sent and decreased after each successful sent. Update implementation
to be standard compliant.

Design doc: http://doc/1lorHBn-GMn5U0T0RQANxrsW0pXhw8XGZM-xZyVUOW90

[1] https://w3c.github.io/webrtc-pc/#dom-datachannel-bufferedamount

Bug: chromium:878682
Change-Id: Ife009d30c4a18dced9a54cf600a445bb1f02561d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/123237
Commit-Queue: Marina Ciocea <marinaciocea@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27057}
 2019-03-11 13:21:36 +00:00
Danil Chapovalov
ad89528051 Reland "Delete rtc::TaskQueue::Current in favor of webrtc::TaskQueueBase::Current" 
This reverts commit 42d8c93ec351b68554825b58a3dc6525a7dc84da.

Reason for revert: Got Aliby for FEC test flakes

Original change's description:
> Revert "Delete rtc::TaskQueue::Current in favor of webrtc::TaskQueueBase::Current"
> 
> This reverts commit 304e9d2df347630d71fd4423f5971f30dac73e41.
> 
> Reason for revert: Breaks downstream projects.
> Seems to make VideoSendStreamTest.SupportsFlexfecSimulcastVp8 flaky.
> 
> Original change's description:
> > Delete rtc::TaskQueue::Current in favor of webrtc::TaskQueueBase::Current
> > 
> > Bug: webrtc:10191
> > Change-Id: I506cc50a90c73a6a4f6a3de36de0999cca72f5ba
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126230
> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> > Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#27035}
> 
> TBR=danilchap@webrtc.org,kwiberg@webrtc.org
> 
> Change-Id: If98324f88e4b3d18bf2fe33597dfb9711867c243
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:10191
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126484
> Reviewed-by: Yves Gerey <yvesg@webrtc.org>
> Commit-Queue: Yves Gerey <yvesg@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#27041}

TBR=danilchap@webrtc.org,kwiberg@webrtc.org,yvesg@webrtc.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: webrtc:10191
Change-Id: Id87a17ae415142b8e0b11ba03ae7bad84a473fb0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126720
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Yves Gerey <yvesg@webrtc.org>
Commit-Queue: Yves Gerey <yvesg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27056}
 2019-03-11 12:32:49 +00:00
Yves Gerey
55500d26b7 Revert "Fix LibvpxVp8Encoder::FrameDropThreshold" 
This reverts commit 159e53a66eceb79003741ba0d990c502595c27bb.

Reason for revert: Might break downstream Android projects.

Original change's description:
> Fix LibvpxVp8Encoder::FrameDropThreshold
> 
> Bug: webrtc:10387
> Change-Id: I17b575546d6718f905429ac45705cb923ee52c10
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126232
> Commit-Queue: Elad Alon <eladalon@webrtc.org>
> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#27032}

TBR=ilnik@webrtc.org,eladalon@webrtc.org,sprang@webrtc.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: webrtc:10387
Change-Id: I08055d1b0234dccd4166a4eaf8eff56f909f99a8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126721
Reviewed-by: Yves Gerey <yvesg@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Yves Gerey <yvesg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27055}
 2019-03-11 12:16:09 +00:00
Sebastian Jansson
8a0c1f58cc Don't reset bitrate when allocatable minimum changes. 
This fixes an issue where the time between freezes dropped in
perf tests. This was triggered by resetting and updating the bitrates
immediately if the min allocatable bitrate changed, causing a drop in
target bitrate. With this CL, the change in min bitrate will not take
effect until we get more data.

Bug: chromium:940349
Change-Id: Ia680a5f1cfe71847ef90669987e7b89b240b9524
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126625
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27054}
 2019-03-11 11:46:38 +00:00
Danil Chapovalov
effdfe2014 Move dependency on chromium DefaultTaskQueueFactory 
That will avoid linkage error of targets that depend
on global_task_queue_factory without depending on rtc_task_queue

Bug: webrtc:10191
Change-Id: Ia67ea0a3abb715e28160e4e376133cc0309b14e2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126621
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27053}
 2019-03-11 11:28:28 +00:00
Mirko Bonadei
d4a37a6ee6 Support absl::string_view in RTC_CHECK. 
Bug: None
Change-Id: I8d4c296f1ac16a96adb88401f78ee9f65911bfc0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126482
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27052}
 2019-03-11 10:22:47 +00:00
Johannes Kron
8cc711a7e1 Update URI of TransportSequenceNumberV2 
The previous URI was a placeholder and is not valid. The URI
https://webrtc.org/experiments/rtp-hdrext/transport-wide-cc-02/
must be used instead.

Bug: webrtc:10264
Change-Id: Ibabde599b5bbd116c1c5e86ba0c9c64019bf7026
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126360
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Johannes Kron <kron@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27051}
 2019-03-11 10:15:52 +00:00
Artem Titov
aba8dc2a00 Rename EndpointNode into EmulatedEndpoint 
This CL is preparation for extraction of public API for network
emulation layer.

Bug: webrtc:10138
Change-Id: Id59204ea20a103dafce4122c59e51a354836c374
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126624
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27050}
 2019-03-11 09:47:47 +00:00
chromium-webrtc-autoroll
2057673c11 Roll chromium_revision 4029fd18b6..f2f5c1896e (639320:639430) 
Change log: 4029fd18b6..f2f5c1896e
Full diff: 4029fd18b6..f2f5c1896e

Changed dependencies
* src/build: 0ee4cbc26f..3dc511c004
* src/ios: 8a4c6be64e..eafe446412
* src/testing: 1ebfa8b2ad..b28dac3e12
* src/third_party: eef56ad4ca..489f6328a5
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/26a1944e90..b88eedc51a
* src/tools: 790bd0f47f..75b8edbe4e
DEPS diff: 4029fd18b6..f2f5c1896e/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I8df06c52ee67dac6d3345c63b8fa584fffc14028
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126689
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27049}
 2019-03-11 09:38:26 +00:00
Niels Möller
abea6e5114 Delete always-true member is_media_transport_factory_enabled_ 
Member was added to JsepTransportController in
https://webrtc-review.googlesource.com/c/119911, but only code path
setting it to false was deleted in
https://webrtc-review.googlesource.com/c/125040

Bug: webrtc:9719
Change-Id: I9d2c5f338dfc30a769ed54d64e7f5bf27c230e31
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126521
Reviewed-by: Peter Slatala <psla@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27048}
 2019-03-11 08:04:09 +00:00
Yves Gerey
c0c3e966d3 Revert "DCHECK feedback_rtt is positive" 
This reverts commit 37d4f91db3fd1d0e023a820d0cda86bb786a0f72.

Reason for revert: Breaks downstream Android projects.

Original change's description:
> DCHECK feedback_rtt is positive
> 
> Bug: None
> Change-Id: I6eb10d6a20a679fff08f604441f8e58dcd417608
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126464
> Commit-Queue: Evan Shrubsole <eshr@google.com>
> Reviewed-by: Sebastian Jansson <srte@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#27034}

TBR=srte@webrtc.org,yinwa@webrtc.org,eshr@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: None
Change-Id: I412cc3bf9fd6991d3afa68c0fd9289bfc84a98cd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126622
Reviewed-by: Yves Gerey <yvesg@google.com>
Commit-Queue: Yves Gerey <yvesg@google.com>
Cr-Commit-Position: refs/heads/master@{#27047}
 2019-03-10 11:00:37 +00:00
Yves Gerey
3368721537 Revert "Change clip_name -> clip_path in VideoQualityTestFixture::Params::Video." 
This reverts commit 184f6d5d75c198cb7b70b8f9b75e0b5096c6e577.

Reason for revert: Breaks downstream android projects.

Original change's description:
> Change clip_name -> clip_path in VideoQualityTestFixture::Params::Video.
> 
> This allows external users of this test fixture to specify a custom
> path, rather than just a custom file name.
> 
> Bug: webrtc:10349
> Change-Id: I84e886c8bc28583017ce9ed7b9e7ee6a8e95730f
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126227
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Reviewed-by: Åsa Persson <asapersson@webrtc.org>
> Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#27033}

TBR=brandtr@webrtc.org,kwiberg@webrtc.org,asapersson@webrtc.org

Change-Id: I56af4c74e0c38b5a14a6151b230ada4349e931da
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10349
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126620
Reviewed-by: Yves Gerey <yvesg@google.com>
Commit-Queue: Yves Gerey <yvesg@google.com>
Cr-Commit-Position: refs/heads/master@{#27046}
 2019-03-09 09:50:30 +00:00
chromium-webrtc-autoroll
32f887b119 Roll chromium_revision e4e8741478..4029fd18b6 (639216:639320) 
Change log: e4e8741478..4029fd18b6
Full diff: e4e8741478..4029fd18b6

Changed dependencies
* src/base: 8bdc3d35e1..22e38d6529
* src/build: 00fe925e26..0ee4cbc26f
* src/ios: 78ec766b49..8a4c6be64e
* src/testing: 78d234150a..1ebfa8b2ad
* src/third_party: 5d5ba518c7..eef56ad4ca
* src/tools: c954d6cb91..790bd0f47f
DEPS diff: e4e8741478..4029fd18b6/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I98b2e6d92b4954277266e21dbf643d0cbf32a5f8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126564
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27045}
 2019-03-09 05:49:09 +00:00
chromium-webrtc-autoroll
fe07c42538 Roll chromium_revision ecf963f5ce..e4e8741478 (639097:639216) 
Change log: ecf963f5ce..e4e8741478
Full diff: ecf963f5ce..e4e8741478

Changed dependencies
* src/base: 256b4bcfd9..8bdc3d35e1
* src/build: 9b449f0fab..00fe925e26
* src/ios: 6a86076c80..78ec766b49
* src/testing: c5f690fb1a..78d234150a
* src/third_party: 8606657597..5d5ba518c7
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/5869dbeaf2..26a1944e90
* src/third_party/depot_tools: cc43111eb2..3485a263f4
* src/tools: e0a3cda10d..c954d6cb91
DEPS diff: ecf963f5ce..e4e8741478/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I305e25458c7ea5098a9e740a919db4d52f2615f3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126580
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27044}
 2019-03-09 00:03:31 +00:00