zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
28,713 Commits 1 Branch 0 Tags
41478c7c1b2f9aeb5ba201d6d0c4bf91a2fdd4f2
Commit Graph

28713 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
chromium-webrtc-autoroll
0ee431178f Roll chromium_revision c7f850c75e..d5a13ccb8e (687596:687732) 
Change log: c7f850c75e..d5a13ccb8e
Full diff: c7f850c75e..d5a13ccb8e

Changed dependencies
* src/build: d501102a9b..36d9c4f858
* src/ios: 6707a43010..73642be5c4
* src/third_party: e5611f0d45..85c6d9ad77
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4eafd3bf8d..3a96577620
* src/tools: 26cd8f59c9..c549e0f77a
DEPS diff: c7f850c75e..d5a13ccb8e/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ibac2512cc3b88ef6a33cd30bea66f4c14f215ba4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149360
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28881}
 2019-08-16 18:31:38 +00:00
Åsa Persson
f5e5d250bc BalancedDegradationSettings: add option to configure a min framerate diff. 
If a framerate reduction (input fps - restricted fps) is less than the
configured diff, shorten interval to next qp check.

Bug: none
Change-Id: Ia0b9e0638e5ba75cdc20a1bb45bfcb7d858c5f89
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149040
Commit-Queue: Åsa Persson <asapersson@webrtc.org>
Reviewed-by: Magnus Flodman <mflodman@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28880}
 2019-08-16 16:13:46 +00:00
Henrik Andreassson
df625f46c0 Revert "[GetStats] Expose video codec implementation in standardized metrics." 
This reverts commit 2b9fa09fa3e3379fd8e76490c394f25670352ef2.

Reason for revert: speculative revert since it seems to break Chrome FYI bots. See https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Linux%20Tester/4206

Original change's description:
> [GetStats] Expose video codec implementation in standardized metrics.
> 
> Spec issue: https://github.com/w3c/webrtc-stats/issues/445
> Spec PR: https://github.com/w3c/webrtc-stats/pull/473
> 
> Now that the spec's RTCCodecStats.implementation has moved to
> RTCOutboundRtpStreamStats.encoderImplementation and
> RTCInboundRtpStreamStats.decoderImplementation, this CL implements them
> using the same string that the legacy getStats() API used.
> 
> Bug: webrtc:10890
> Change-Id: Ic43ce44735453626791959df3061ee253356015a
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149168
> Commit-Queue: Henrik Boström <hbos@webrtc.org>
> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#28877}

TBR=ilnik@webrtc.org,hbos@webrtc.org

Change-Id: Ia0b7f9806564cf28881c50d6371b8141a22e3431
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10890
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149175
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Commit-Queue: Henrik Andreassson <henrika@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28879}
 2019-08-16 15:29:28 +00:00
Chen Xing
6094953ed1 Add helper functions to convert between integer milliseconds and fixed-point seconds. 
This change adds the following helper functions to convert between "integer milliseconds"-style timestamps and durations, and "UQ32.32 and Q32.32"-style NTP timestamps and durations:
- Int64MsToQ32x32
- UInt64MsToUQ32x32
- Q32x32ToInt64Ms
- UQ32x32ToUInt64Ms

The Q-format NTP timestamps and durations are used by some RTP/RTCP packets.

Bug: webrtc:10739
Change-Id: I89123d2dba7370f26e239d722a4975bf5ac6e668
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148444
Commit-Queue: Chen Xing <chxg@google.com>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28878}
 2019-08-16 14:49:46 +00:00
Henrik Boström
2b9fa09fa3 [GetStats] Expose video codec implementation in standardized metrics. 
Spec issue: https://github.com/w3c/webrtc-stats/issues/445
Spec PR: https://github.com/w3c/webrtc-stats/pull/473

Now that the spec's RTCCodecStats.implementation has moved to
RTCOutboundRtpStreamStats.encoderImplementation and
RTCInboundRtpStreamStats.decoderImplementation, this CL implements them
using the same string that the legacy getStats() API used.

Bug: webrtc:10890
Change-Id: Ic43ce44735453626791959df3061ee253356015a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149168
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28877}
 2019-08-16 14:10:46 +00:00
Artem Titov
cc96db6de2 Simplify stats poller stop in PC level framework 
Bug: webrtc:10138
Change-Id: I9f6c2fd4109439df813b2bd0a47466eefb64defd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149065
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28876}
 2019-08-16 13:51:06 +00:00
Erik Språng
6950b3088c Fix thread naming in Call constructor 
This only fixes the name string you get when you query the threads, the
functionality is not changes.

Bug: None
Change-Id: I29408cf38e0e41faa127a70a010d37a980bb24ce
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149167
Reviewed-by: Tommi <tommi@webrtc.org>
Commit-Queue: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28875}
 2019-08-16 12:44:30 +00:00
Alex Narest
bbeb10925e Reporting audio device underrun counter 
Bug: webrtc:10884
Change-Id: I35636fcbc1e2a19a89242379cdff6ec5c12fd21a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149200
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Commit-Queue: Alex Narest <alexnarest@google.com>
Cr-Commit-Position: refs/heads/master@{#28874}
 2019-08-16 11:49:55 +00:00
Minyue Li
9b29d69650 Make ANA frame length controller more robust to encoder frame lengths. 
Bug: webrtc:10820
Change-Id: Ic3a30976d0181de9cdd35e44d4c5439cadad4812
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149163
Commit-Queue: Minyue Li <minyue@webrtc.org>
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28873}
 2019-08-16 10:55:39 +00:00
Henrik Andreassson
533c225c93 Revert "Correct conversion between float and fixed formats" 
This reverts commit 67e43c8b95057a889ba9946e47d50a265e1e9ac9.

Reason for revert: speculative revert since we see failing bots on Android after this change

https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Android%20Tests%20%28dbg%29%20%28K%20Nexus5%29/4124

Original change's description:
> Correct conversion between float and fixed formats
> 
> This CL changes the way that values are converted
> between fixed and floating point to
> -Avoid the former asymmetric conversion causing
> nonlinear distortions.
> -Reduce the complexity.
> 
> Bug: webrtc:6594
> Change-Id: I64d0cc31c5d16f397686a59a062cfbc4b336d94d
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132783
> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
> Commit-Queue: Per Åhgren <peah@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#28867}

TBR=henrik.lundin@webrtc.org,gustaf@webrtc.org,peah@webrtc.org

Change-Id: Id828a09de7075e48556fe2d0beba7a0c6ec227f6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:6594
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149165
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Commit-Queue: Henrik Andreassson <henrika@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28872}
 2019-08-16 10:40:11 +00:00
chromium-webrtc-autoroll
07a6652865 Roll chromium_revision f54998af9c..c7f850c75e (687496:687596) 
Change log: f54998af9c..c7f850c75e
Full diff: f54998af9c..c7f850c75e

Changed dependencies
* src/base: c245b4c2cf..e6ee54664a
* src/build: b9e0d9224b..d501102a9b
* src/ios: fa891cf749..6707a43010
* src/testing: e70d524717..be751f12d5
* src/third_party: 82f8cd10f8..e5611f0d45
* src/third_party/android_ndk: https://chromium.googlesource.com/android_ndk.git/+log/4e2cea441b..62582753e8
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2ae52adeee..4eafd3bf8d
* src/third_party/depot_tools: 26a8b9f356..9f4b37db0e
* src/tools: a44e1c7798..26cd8f59c9
DEPS diff: f54998af9c..c7f850c75e/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I07c1eccccca2624b9242f7efa72e3710d851c35a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149343
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28871}
 2019-08-16 08:31:10 +00:00
chromium-webrtc-autoroll
98bbd88883 Roll chromium_revision 7a2da7b921..f54998af9c (686822:687496) 
Change log: 7a2da7b921..f54998af9c
Full diff: 7a2da7b921..f54998af9c

Changed dependencies
* src/base: d22535e67d..c245b4c2cf
* src/build: 8ff415306c..b9e0d9224b
* src/ios: 84f749199b..fa891cf749
* src/testing: c3408396aa..e70d524717
* src/third_party: 6f8122c50d..82f8cd10f8
* src/third_party/android_deps/libs/com_android_support_animated_vector_drawable: version:27.0.0-cr0..version:28.0.0-cr0
* src/third_party/android_deps/libs/com_android_support_appcompat_v7: version:27.0.0-cr0..version:28.0.0-cr0
* src/third_party/android_deps/libs/com_android_support_cardview_v7: version:27.0.0-cr0..version:28.0.0-cr0
* src/third_party/android_deps/libs/com_android_support_design: version:27.0.0-cr0..version:28.0.0-cr0
* src/third_party/android_deps/libs/com_android_support_gridlayout_v7: version:27.0.0-cr0..version:28.0.0-cr0
* src/third_party/android_deps/libs/com_android_support_leanback_v17: version:27.0.0-cr0..version:28.0.0-cr0
* src/third_party/android_deps/libs/com_android_support_mediarouter_v7: version:27.0.0-cr0..version:28.0.0-cr0
* src/third_party/android_deps/libs/com_android_support_palette_v7: version:27.0.0-cr0..version:28.0.0-cr0
* src/third_party/android_deps/libs/com_android_support_preference_leanback_v17: version:27.0.0-cr0..version:28.0.0-cr0
* src/third_party/android_deps/libs/com_android_support_preference_v14: version:27.0.0-cr0..version:28.0.0-cr0
* src/third_party/android_deps/libs/com_android_support_preference_v7: version:27.0.0-cr0..version:28.0.0-cr0
* src/third_party/android_deps/libs/com_android_support_recyclerview_v7: version:27.0.0-cr0..version:28.0.0-cr0
* src/third_party/android_deps/libs/com_android_support_support_annotations: version:27.0.0-cr0..version:28.0.0-cr0
* src/third_party/android_deps/libs/com_android_support_support_compat: version:27.0.0-cr0..version:28.0.0-cr0
* src/third_party/android_deps/libs/com_android_support_support_core_ui: version:27.0.0-cr0..version:28.0.0-cr0
* src/third_party/android_deps/libs/com_android_support_support_core_utils: version:27.0.0-cr0..version:28.0.0-cr0
* src/third_party/android_deps/libs/com_android_support_support_fragment: version:27.0.0-cr0..version:28.0.0-cr0
* src/third_party/android_deps/libs/com_android_support_support_media_compat: version:27.0.0-cr0..version:28.0.0-cr0
* src/third_party/android_deps/libs/com_android_support_support_v13: version:27.0.0-cr0..version:28.0.0-cr0
* src/third_party/android_deps/libs/com_android_support_support_v4: version:27.0.0-cr0..version:28.0.0-cr0
* src/third_party/android_deps/libs/com_android_support_support_vector_drawable: version:27.0.0-cr0..version:28.0.0-cr0
* src/third_party/android_deps/libs/com_android_support_transition: version:27.0.0-cr0..version:28.0.0-cr0
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/73af388b69..2ae52adeee
* src/third_party/depot_tools: 9185e4495d..26a8b9f356
* src/third_party/googletest/src: 90a443f9c2..e9d5f427b5
* src/tools: 9c1b72ffba..a44e1c7798
Added dependencies
* src/third_party/android_deps/libs/com_android_support_cursoradapter
* src/third_party/android_deps/libs/com_android_support_localbroadcastmanager
* src/third_party/android_deps/libs/com_android_support_drawerlayout
* src/third_party/android_deps/libs/com_android_support_slidingpanelayout
* src/third_party/android_deps/libs/android_arch_lifecycle_livedata
* src/third_party/android_deps/libs/com_android_support_collections
* src/third_party/android_deps/libs/com_android_support_versionedparcelable
* src/third_party/android_deps/libs/com_android_support_customview
* src/third_party/android_deps/libs/com_android_support_viewpager
* src/third_party/android_deps/libs/com_android_support_asynclayoutinflater
* src/third_party/android_deps/libs/android_arch_lifecycle_livedata_core
* src/third_party/android_deps/libs/com_android_support_print
* src/third_party/android_deps/libs/com_android_support_loader
* src/third_party/android_deps/libs/com_android_support_swiperefreshlayout
* src/third_party/android_deps/libs/com_android_support_interpolator
* src/third_party/android_deps/libs/android_arch_lifecycle_viewmodel
* src/third_party/android_deps/libs/com_android_support_coordinatorlayout
* src/third_party/android_deps/libs/com_android_support_documentfile
* src/third_party/android_deps/libs/android_arch_core_runtime
DEPS diff: 7a2da7b921..f54998af9c/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Iceda756a8201f7a04d415922a5f73266bc7b8362
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149321
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28870}
 2019-08-16 00:35:23 +00:00
Qingsi Wang
e5defb167a Sanitize the selected candidate pair in the public API. 
The public API to obtain the selected candidate pair is changed to
GetSelectedCandidatePair in the ICE transport, and the returned pair
has address-sanitized candidates.

Bug: chromium:993878
Change-Id: I44f9d2385a84f9e22447108be2e57ef9e62671eb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149080
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Qingsi Wang <qingsi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28869}
 2019-08-15 18:36:35 +00:00
Jiawei Ou
ffc525bb96 Fix a bug/typo in WebRtcSpl_FilterAR which updates the wrong state vector 
Bug: webrtc:10877
Change-Id: I089ac68d71a31914ddb020cb78a44295230cb44b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149028
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28868}
 2019-08-15 16:46:22 +00:00
Per Åhgren
67e43c8b95 Correct conversion between float and fixed formats 
This CL changes the way that values are converted
between fixed and floating point to
-Avoid the former asymmetric conversion causing
nonlinear distortions.
-Reduce the complexity.

Bug: webrtc:6594
Change-Id: I64d0cc31c5d16f397686a59a062cfbc4b336d94d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132783
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28867}
 2019-08-15 13:51:39 +00:00
Per Åhgren
a1351271e6 Remove all AudioBuffer code that is not related to storing audio data 
This CL moves/removes all code from the AudioBuffer that:
-Is not directly handling audio data (e.g., keytaps, VAD descisions).
-Is caching aggregated versions of the rest of the audio data.
-Is not used (or only used in testing)

Bug: webrtc:10882
Change-Id: I737deb3f692748eff30f46ad806b2c6f6292802c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149072
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28866}
 2019-08-15 13:49:29 +00:00
Tommi
6e4791fe49 Add check for IsCurrent() for SendTask in SingleThreadedTaskQueueForTesting. 
The "IsCurrent" check seems to have been missing from the class, but may help with
tracking down issue 10880. I also replaced the 'infinite' wait in SendTask with a
couple of timeouts, arbitrarily chosen 30 seconds for 'abandon wait' and 10
seconds for 'warning' log.

Change-Id: Ia40a68658dd007c60771135718511f7e4110c0b0
Bug: webrtc:10880
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149068
Commit-Queue: Tommi <tommi@webrtc.org>
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28865}
 2019-08-15 08:57:23 +00:00
Danil Chapovalov
65feec5440 Reenable UlpfecWithNack integration tests 
To reduce flakiness, wait for ulpfec packet 30 seconds instead of 10 seconds.

Bug: webrtc:7285
Change-Id: I1ed77ed84a6cbab917fe0f7f69a26f904a2d6127
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149070
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28864}
 2019-08-15 07:53:53 +00:00
Åsa Persson
1b247f1e6e BalancedDegradationSettings: add option to configure min bitrate. 
Add possibility to configure min bitrate based on resolution.
Only adapt up if bw estimate is above the min bitrate for next higher resolution.

Bug: none
Change-Id: Ie38faae07d23336675ec33697ace6f6fed322efa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148598
Reviewed-by: Magnus Flodman <mflodman@webrtc.org>
Commit-Queue: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28863}
 2019-08-15 07:16:33 +00:00
Sebastian Jansson
3aa0d76cb0 Use struct parser for AlrDetector config. 
Bug: webrtc:9883
Change-Id: Ib58fa5ba87607a268f4960898625b1a5adcab69a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148596
Reviewed-by: Jonas Olsson <jonasolsson@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28862}
 2019-08-14 18:23:05 +00:00
Sebastian Jansson
71c6b565ac Allow sending abs-send-time for audio streams. 
Bug: webrtc:10742
Change-Id: I088c8221e04e84152cfce925051bf6bc23d5fe68
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149061
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28861}
 2019-08-14 17:46:56 +00:00
chromium-webrtc-autoroll
09ba21967c Roll chromium_revision fa752aeae4..7a2da7b921 (686692:686822) 
Change log: fa752aeae4..7a2da7b921
Full diff: fa752aeae4..7a2da7b921

Changed dependencies
* src/base: 5ceffc389a..d22535e67d
* src/build: 1bf9025a38..8ff415306c
* src/ios: 5a269bda85..84f749199b
* src/testing: 79c58842d5..c3408396aa
* src/third_party: 0a55df332f..6f8122c50d
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/942e493326..73af388b69
* src/tools: c638d5a32d..9c1b72ffba
DEPS diff: fa752aeae4..7a2da7b921/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I151cb9db641398eb3ae8f1ebdaa4ffaba8fe8cd9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149087
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28860}
 2019-08-14 16:31:36 +00:00
Minyue Li
c759f832e9 Avoid copying of vectors in RtpPacketInfos. 
Bug: chromium:982260
Change-Id: Ia4dab497b662e825f80c16530cdf615b62f0a5c9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148523
Commit-Queue: Minyue Li <minyue@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Chen Xing <chxg@google.com>
Cr-Commit-Position: refs/heads/master@{#28859}
 2019-08-14 15:46:02 +00:00
Sami Kalliomäki
c14b2335d9 Disable the most flaky tests on iOS. 
Disables:
 - RtpVideoSenderTest.DoesNotRetrasmitAckedPackets
 - VideoReceiveStreamTestWithFakeDecoder.RenderedFrameUpdatesGetSources

Bug: webrtc:10870, webrtc:10872, webrtc:10873
Change-Id: I410f781c30e45387c35055bf97424a68658174d3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148984
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org>
Reviewed-by: Magnus Flodman <mflodman@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28858}
 2019-08-14 15:42:11 +00:00
Erik Språng
7daf550776 Add new FrameRateEstimator utility class for more precis FPS estimation. 
This class looks first and foremost on frame intervals instead of
number of frames withing the averaging window. This leads to higher
prevision values than the bucketized methods of RateTracker and
RateStatistics.

It is also design to return floating point values, for cases where we
are running at low fps - such as a somewhat common 30/4 = 7.5fps.

Bug: webrtc:10481
Change-Id: I41c36caaf2b7b46edf7927c8dd08e6cde3380884
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148593
Reviewed-by: Magnus Flodman <mflodman@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28857}
 2019-08-14 12:15:06 +00:00
Sebastian Jansson
0ee8008a0d Use struct parser for rate control trial. 
Bug: webrtc:9883
Change-Id: I9ec7988da2e4d88bedd9b71cae00452f531980d6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148581
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Jonas Olsson <jonasolsson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28856}
 2019-08-14 11:47:12 +00:00
Sebastian Jansson
ad9113f191 Adds sequence numbers to feedback generator output. 
Bug: webrtc:10498
Change-Id: I2bbda067b9936636088e3fdd52f6979f51eb3c84
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149042
Reviewed-by: Jonas Olsson <jonasolsson@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28855}
 2019-08-14 10:26:18 +00:00
Åsa Persson
0c38a86533 BalancedDegradationSettings: add option to configure no fps limit. 
If configuring max valid framerate (100), no framerate restriction is
used (std::numeric_limits<int>::max()).

E.g. pixels:1000|2000,fps:5|10 is same as pixels:1000|2000|3000,fps:5|10|100

Bug: none
Change-Id: Ie981841ee8e23cb73c0ef55738ca69055916d902
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148980
Commit-Queue: Åsa Persson <asapersson@webrtc.org>
Reviewed-by: Magnus Flodman <mflodman@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28854}
 2019-08-14 08:56:38 +00:00
Yves Gerey
704c8c4446 Re-enable AudioDeviceTest in combination with sanitizers. 
Reactivate all tests which aren't flaky anymore.

Bug: webrtc:9751, webrtc:10867
Change-Id: I1d76e0f3e6cc82e78fc46214202f40a9666d41fd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149060
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Commit-Queue: Yves Gerey <yvesg@google.com>
Cr-Commit-Position: refs/heads/master@{#28853}
 2019-08-14 08:45:18 +00:00
Niels Möller
78c56cba00 Delete deprecated version of ReceiveStatistics::Create 
Bug: webrtc:10679
Change-Id: I885f38a80c0fe10f1596f33fa95e40a91b23001c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148445
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28852}
 2019-08-14 08:40:09 +00:00
chromium-webrtc-autoroll
1e04a9b33a Roll chromium_revision bcb9240637..fa752aeae4 (686583:686692) 
Change log: bcb9240637..fa752aeae4
Full diff: bcb9240637..fa752aeae4

Changed dependencies
* src/base: cef2da3ff4..5ceffc389a
* src/build: 1181c5da22..1bf9025a38
* src/ios: 87f1aea4ae..5a269bda85
* src/testing: ff17d80694..79c58842d5
* src/third_party: e6c01ab295..0a55df332f
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/772d5c6161..942e493326
* src/third_party/depot_tools: e765f65295..9185e4495d
* src/tools: 4250062d6d..c638d5a32d
DEPS diff: bcb9240637..fa752aeae4/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I8329c2d57354810d304989eccb6c8b8591238371
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149081
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28851}
 2019-08-14 05:16:20 +00:00
Alex Drake
fb6edd34db Handle case of empty connection in pair change event 
Bug: webrtc:10878
Change-Id: I49992bac3450e95b0f8aa388e21662f2d6f92a96
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149029
Reviewed-by: Qingsi Wang <qingsi@webrtc.org>
Commit-Queue: Alex Drake <alexdrake@google.com>
Cr-Commit-Position: refs/heads/master@{#28850}
 2019-08-14 01:08:49 +00:00
chromium-webrtc-autoroll
bb1994292b Roll chromium_revision 6652dd41e1..bcb9240637 (686436:686583) 
Change log: 6652dd41e1..bcb9240637
Full diff: 6652dd41e1..bcb9240637

Changed dependencies
* src/base: 3b6b0bfa74..cef2da3ff4
* src/build: b04a94993d..1181c5da22
* src/ios: 65891a8357..87f1aea4ae
* src/testing: 434276f11c..ff17d80694
* src/third_party: caf7bcdcac..e6c01ab295
* src/third_party/depot_tools: 9fc459b69c..e765f65295
* src/tools: 958ae62ebb..4250062d6d
DEPS diff: 6652dd41e1..bcb9240637/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I34a168d378b93205f9c02633e9cfe9d6b2e670df
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149027
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28849}
 2019-08-14 00:45:29 +00:00
Alex Drake
68c2a565ca Propagating Network Type in Candidate for JNI 
Bug: webrtc:10419
Change-Id: I32726c9a4095c998996acdbf00f72de18ed462c4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149025
Commit-Queue: Alex Drake <alexdrake@google.com>
Reviewed-by: Alex Glaznev <glaznev@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28848}
 2019-08-14 00:41:24 +00:00
Jiawei Ou
608e6ba394 Add AudioDecoderIsacT::Config to include sampling rate and BWInfo object 
This CL will make AudioDecoderIsacT symmetrical to AudioEncoderIsacT.

Bug: webrtc:10826
Change-Id: I78d1cf7bc2245bf4a282aabd81c8ece6ca23f285
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146683
Commit-Queue: Jiawei Ou <ouj@fb.com>
Reviewed-by: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28847}
 2019-08-14 00:40:19 +00:00
Bjorn A Mellem
05497f294a Pull a DataChannelTransportInterface out of MediaTransportInterface. 
DataChannelTransportInterface takes the OpenChannel, SendData,
CloseChannel, and SetDataSink methods.  MediaTransportInterface inherits
from DataChannelTransportInterface.

DatagramTransportInterface, the newer alternative to
MediaTransportInterface, also inherits from
DataChannelTransportInterface.

This will allow further refactors to enable the use of media-transport
style data channels alongside the datagram transport.

Bug: webrtc:9719
Change-Id: I2dd873785ea52d38055b62545c17e9e17c4e70c6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147840
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Bjorn Mellem <mellem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28846}
 2019-08-13 22:07:47 +00:00
Qingsi Wang
d419808e45 Revert "Set the usage pattern bits for adding remote ICE candidates from SDP." 
This reverts commit 7c6f74ab0344e9c6201de711d54026e9990b8e6c.

Reason for revert: Need to merge with stacked changes on bits in a single patch to avoid disruption.

Original change's description:
> Set the usage pattern bits for adding remote ICE candidates from SDP.
> 
> Currently these bits are only set when a remote ICE candidate is
> successfully added via addIceCandidate. For non-trickled sessions in
> which the remote candidates are added via the remote description, these
> bits are lost. This also happens for trickled sessions, though a rare
> case, when addIceCandidate does not succeed because the peer connection
> is not ready to add any remote candidate.
> 
> Bug: webrtc:10868
> Change-Id: Ib2f199f9ffc936060473934d25ba397ef31131a3
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148880
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Commit-Queue: Qingsi Wang <qingsi@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#28844}

TBR=hta@webrtc.org,qingsi@webrtc.org

Change-Id: Ia0d24b345f04e6c83199d7692bb55a440e6ff464
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10868
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149023
Reviewed-by: Qingsi Wang <qingsi@webrtc.org>
Commit-Queue: Qingsi Wang <qingsi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28845}
 2019-08-13 18:29:48 +00:00
Qingsi Wang
7c6f74ab03 Set the usage pattern bits for adding remote ICE candidates from SDP. 
Currently these bits are only set when a remote ICE candidate is
successfully added via addIceCandidate. For non-trickled sessions in
which the remote candidates are added via the remote description, these
bits are lost. This also happens for trickled sessions, though a rare
case, when addIceCandidate does not succeed because the peer connection
is not ready to add any remote candidate.

Bug: webrtc:10868
Change-Id: Ib2f199f9ffc936060473934d25ba397ef31131a3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148880
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Qingsi Wang <qingsi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28844}
 2019-08-13 17:23:35 +00:00
chromium-webrtc-autoroll
1a03784739 Roll chromium_revision 3ae2445b34..6652dd41e1 (686310:686436) 
Change log: 3ae2445b34..6652dd41e1
Full diff: 3ae2445b34..6652dd41e1

Changed dependencies
* src/base: 08d654afee..3b6b0bfa74
* src/build: b5e8d0f2d1..b04a94993d
* src/ios: 9b240182bf..65891a8357
* src/testing: b3a01bdf19..434276f11c
* src/third_party: 45dec31484..caf7bcdcac
* src/third_party/android_build_tools/aapt2: version:3.6.0-alpha03-5516695-cr0..by7YdhjwRQYtrv0Q_q_fPsqptrm5ib-SXmiNfgJYp50C
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/1c632e376b..772d5c6161
* src/third_party/depot_tools: 3c814957ee..9fc459b69c
* src/tools: bd69de11b0..958ae62ebb
DEPS diff: 3ae2445b34..6652dd41e1/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I7f934bc4c57f4ef2052ceeda06028bb994891f55
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149021
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28843}
 2019-08-13 16:32:45 +00:00
Elad Alon
9cfdb20b57 Control PeerConnectionFactory's default min/starting/max bitrates from experiment 
Bug: webrtc:10865
Change-Id: Ida88d34d9ee4f390af44d157eef55288fde3773e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148840
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28842}
 2019-08-13 15:07:00 +00:00
Niels Möller
d78196576d Delete StreamDataCountersCallback from ReceiveStatistics 
Bug: webrtc:10679
Change-Id: Ife6a4f598c5b70478244b15fc884f6a424d1505b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148521
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28841}
 2019-08-13 14:47:08 +00:00
Niels Möller
01525f9e03 Delete method StreamStatistician::GetDataCounters 
Usage replaced with GetReceiveStreamDataCounters.

Bug: None
Change-Id: Ic5f62ff8a8d33b9eec21657512ba6a0a44635e6d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148801
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28840}
 2019-08-13 13:46:45 +00:00
chromium-webrtc-autoroll
34aee67c11 Roll chromium_revision 514a543362..3ae2445b34 (686198:686310) 
Change log: 514a543362..3ae2445b34
Full diff: 514a543362..3ae2445b34

Changed dependencies
* src/base: 4def23584c..08d654afee
* src/build: a2984b015f..b5e8d0f2d1
* src/third_party: 1d6494df55..45dec31484
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/5d664a903a..1c632e376b
* src/third_party/depot_tools: d6186f9936..3c814957ee
* src/third_party/icu: 682a230923..9a5af81f58
* src/tools: 7bb19f3198..bd69de11b0
DEPS diff: 514a543362..3ae2445b34/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I86f196fac80dd35a5233f178ca506d3400ef29fb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148940
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28839}
 2019-08-13 04:36:37 +00:00
Alex Drake
43faee09e5 Implement JNI and objc implementation for Ice Candidate Pair Change event surfacing 
Bug: webrtc:10419
Change-Id: I18528bf2526e933568bf052de76a434f012161da
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148320
Commit-Queue: Alex Drake <alexdrake@google.com>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Anders Carlsson <andersc@webrtc.org>
Reviewed-by: Qingsi Wang <qingsi@webrtc.org>
Reviewed-by: Alex Glaznev <glaznev@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28838}
 2019-08-12 23:58:50 +00:00
chromium-webrtc-autoroll
519fc4454a Roll chromium_revision 01bf391305..514a543362 (686061:686198) 
Change log: 01bf391305..514a543362
Full diff: 01bf391305..514a543362

Changed dependencies
* src/build: 83361b5c77..a2984b015f
* src/ios: c80c920946..9b240182bf
* src/testing: 6c999f953c..b3a01bdf19
* src/third_party: 832776adac..1d6494df55
* src/third_party/depot_tools: 192e8a67cf..d6186f9936
* src/tools: 2aa4ce68d8..7bb19f3198
DEPS diff: 01bf391305..514a543362/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I3527d64e0f8506153a2482ffe5324574cfe1ebaf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148790
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28837}
 2019-08-12 22:34:57 +00:00
chromium-webrtc-autoroll
9809cadf9d Roll chromium_revision f0fd984a31..01bf391305 (685691:686061) 
Change log: f0fd984a31..01bf391305
Full diff: f0fd984a31..01bf391305

Changed dependencies
* src/base: f6cc884505..4def23584c
* src/build: 956965a6ea..83361b5c77
* src/ios: 6780db9c3e..c80c920946
* src/testing: 48823ed18a..6c999f953c
* src/third_party: 82063e79f0..832776adac
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/e00548aa79..5d664a903a
* src/third_party/depot_tools: 6d98232fde..192e8a67cf
* src/third_party/libjpeg_turbo: 81aef9014e..cd241207cb
* src/tools: 2aa12eadc5..2aa4ce68d8
DEPS diff: f0fd984a31..01bf391305/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Iab35f214cc9ca81a668b64138e088f95151fb78c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148789
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28836}
 2019-08-12 18:38:21 +00:00
Erik Språng
82d75a6214 Use unit types in RoundRobingPacketQueue and PacedSender 
This CL replaces various int types with DataRata, DataSize, Timestamp
and TimeDelta classes.

This is part of larger refactoring work where most of PacedSender will
be broken out into a class handling the logic and another responsible
for thread handling. Splitting that up for easier reviewing.

Bug: webrtc:10809
Change-Id: If57a238e5090c47bf3a99c2042783ae584b425f1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148591
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28835}
 2019-08-12 17:10:21 +00:00
Artem Titov
4d207a3460 Add frames_in_flight metric to catch not delivered frames 
Add frames_in_flight metric into PC framework to catch frames that were
captured but weren't delivered to the other side. Right now they won't
be reported as dropped, because it's unclear were they dropped or will
they be delivered. So the new metric is introduced. The lower value is
better for it.

Bug: webrtc:10138
Change-Id: Ide26b362a6b862bd961793cb53293becd92cfaa8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148599
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28834}
 2019-08-12 16:13:50 +00:00
Yves Gerey
110a4de4e2 Roll chromium_revision 8f0166a59b..f0fd984a31 (685582:685691) 
!! **Manual change** Less strict audio codec tests to accommodate opus fix [1].
!! This is meant to be a temporary mitigation.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/1746617

Change log: 8f0166a59b..f0fd984a31
Full diff: 8f0166a59b..f0fd984a31

Changed dependencies
* src/base: 17d8ac209c..f6cc884505
* src/build: d6837de8f1..956965a6ea
* src/ios: 76e0b0bc60..6780db9c3e
* src/testing: 5d328647a1..48823ed18a
* src/third_party: d70201c684..82063e79f0
* src/third_party/depot_tools: 1b4c7e9f38..6d98232fde
* src/tools: b8953a5bf5..2aa12eadc5
DEPS diff: 8f0166a59b..f0fd984a31/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I9869cc3f493bc82361e4f93ad846b32390edb340
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148700
Reviewed-by: Yves Gerey <yvesg@webrtc.org>
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Yves Gerey <yvesg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28833}
 2019-08-12 15:53:01 +00:00
Danil Chapovalov
40dc98a117 Print stack trace when a test crash 
That should simplify debugging failures caused by RTC_DCHECK/RTC_CHECK

TBR=kwiberg@webrtc.org [to pass DEPS change check]

Bug: None
Change-Id: Idb8be3b79309b4ad0baf5ae480356aa5c8cfe361
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148802
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28832}
 2019-08-12 15:36:20 +00:00