42a829e623
Delete implicit conversion from rtc::scoped_refptr<T> to T*
...
Bug: webrtc:13464
Change-Id: I24c742c11a4ea5c4e307e170ee4fbd4e81cf1814
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260325
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36808}
2022-05-09 09:06:44 +00:00
9432768024
Prepare for deletion of implicit conversion from rtc::scoped_refptr<T> to T*
...
Bug: webrtc:13464
Change-Id: I4c7095d3a1c7c1a9ab609f5f1595545f6cad18db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249087
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36693}
2022-04-28 12:58:56 +00:00
afb246b5a9
Update pc/ to not use implicit conversion from scoped_refptr<T> to T*.
...
Bug: webrtc:13464
Change-Id: I768646af8ded6338ef51486b8d69db1ad71e9a2c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259500
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36588}
2022-04-20 13:18:33 +00:00
1a58a3fe3f
Reland "Delete implicit conversion from raw pointer to scoped_ref_ptr"
...
This is a reland of 7b370b935ec0dac991da08f9da227df9ce245fd5
Original change's description:
> Delete implicit conversion from raw pointer to scoped_ref_ptr
>
> Followup to https://webrtc-review.googlesource.com/c/src/+/242363
>
> Bug: webrtc:13464
> Change-Id: I44358e8cfedeea92aac4ef47c540aff9a4865cdc
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247362
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#35897}
Bug: webrtc:13464
Change-Id: Ia0da558adb65852a900030ca7c2f2310a275188e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251140
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35943}
2022-02-08 08:40:44 +00:00
f2126a5184
Revert "Delete implicit conversion from raw pointer to scoped_ref_ptr"
...
This reverts commit 7b370b935ec0dac991da08f9da227df9ce245fd5.
Reason for revert: Breaking WebRTC in Chrome rolls. Roll can be found here https://chromium-review.googlesource.com/c/chromium/src/+/3436384/ . Example failed build https://ci.chromium.org/ui/p/chromium/builders/try/chromeos-amd64-generic-rel-compilator/65973/overview . Failures seem to be in ChromeOS with the nearby library:
error: no viable conversion from 'rtc::RefCountedObject<CreateSessionDescriptionObserverImpl> *' to 'rtc::scoped_refptr<CreateSessionDescriptionObserverImpl>'
Original change's description:
> Delete implicit conversion from raw pointer to scoped_ref_ptr
>
> Followup to https://webrtc-review.googlesource.com/c/src/+/242363
>
> Bug: webrtc:13464
> Change-Id: I44358e8cfedeea92aac4ef47c540aff9a4865cdc
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247362
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#35897}
TBR=mbonadei@webrtc.org ,nisse@webrtc.org ,tommi@webrtc.org ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
Change-Id: Ib0beb44421519c8393131c55564c62c9b4d91504
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:13464
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250621
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35905}
2022-02-04 08:21:01 +00:00
7b370b935e
Delete implicit conversion from raw pointer to scoped_ref_ptr
...
Followup to https://webrtc-review.googlesource.com/c/src/+/242363
Bug: webrtc:13464
Change-Id: I44358e8cfedeea92aac4ef47c540aff9a4865cdc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247362
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35897}
2022-02-03 10:20:23 +00:00
ac0d18341d
Prepare for deleting implicit conversion from raw pointer to scoped_refptr.
...
Updates all webrtc code, to have a small followup cl to just add the
"explicit" keyword. Patchset #24 passed all webrtc tests, with explicit.
Bug: webrtc:13464
Change-Id: I39863d3752f73209b531120f66916dc9177bf63a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/242363
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35718}
2022-01-18 08:22:15 +00:00
0e61fdd27c
Use backticks not vertical bars to denote variables in comments for /api
...
Bug: webrtc:12338
Change-Id: Ib97b2c3d64dbd895f261ffa76a2e885bd934a87f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226940
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34554}
2021-07-26 18:27:34 +00:00
662b306bae
Replace blocking invokes with PostTask in AndroidNetworkMonitor
...
Use PendingTaskSafetyFlag for safe Stop. Followup to
https://webrtc-review.googlesource.com/c/src/+/209181 .
Also fix rtc::scoped_refptr to work with RTC_PT_GUARDED_BY.
Bug: webrtc:12339
Change-Id: Ic0e3ecb17049f1a0e6af887ba5f97a5b48a32d98
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/211351
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Taylor <deadbeef@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33447}
2021-03-12 14:52:25 +00:00
ba916b7bd4
Mark scoped_refptr move and swap operations as noexcept
...
to align with chromium scoped_refptr implementation
and prefer move over copy in some cases.
Bug: webrtc:11078
Change-Id: I3178e74e611e4b23435668878e6bcc98bc2ce77d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159541
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29768}
2019-11-12 10:17:22 +00:00
9405efaeff
Add element_type typedef to rtc::scoped_refptr
...
This allows rtc::scoped_refptr to be used with templates
that use element_type as the mechanism to interface with
smart pointers.
Bug: None
Change-Id: Ie742f416a78efce0b07cfa3009d939e51506ccf9
Reviewed-on: https://webrtc-review.googlesource.com/c/115100
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26078}
2018-12-20 19:11:22 +00:00
85340ce516
Move rtc::scoped_refptr to api/.
...
rtc::scoped_refprt is used in WebRTC api/ code so it makes sense to
move it to api/ and remove exceptions from api/DEPS.
Bug: webrtc:9887
Change-Id: If58c387e5fdfacd8fc1830b4bd79fa1a73942cc9
Reviewed-on: https://webrtc-review.googlesource.com/c/111252
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25698}
2018-11-19 16:13:16 +00:00
