c4ec4a2e51
Add breaks in switch statement to fix AppRTCDemo crash
...
BUG=
Review URL: https://codereview.webrtc.org/1796953002
Cr-Commit-Position: refs/heads/master@{#11989}
2016-03-14 21:56:55 +00:00
a9635b83e0
Use the right mirroring state when switching cameras in AppRTCDemo.
...
BUG=
Review URL: https://codereview.webrtc.org/1799103002
Cr-Commit-Position: refs/heads/master@{#11988}
2016-03-14 20:43:41 +00:00
8bbbf2c3da
Rename RTCIceConnectionStateMax to RTCIceConnectionStateCount in Objective-C API.
...
BUG=
Review URL: https://codereview.webrtc.org/1799443006
Cr-Commit-Position: refs/heads/master@{#11987}
2016-03-14 20:15:52 +00:00
7fb69db670
Reland the CL to remove candidates when doing continual gathering
...
When doing candidate re-gathering in the same ICE generation, signal the remote side to remove its remote candidates.
Fixed the pure virtual method in jsep.h
BUG=
R=glaznev@webrtc.org , pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1788703003 .
Cr-Commit-Position: refs/heads/master@{#11985}
2016-03-14 18:59:34 +00:00
79858f8e9a
Update iOS AppRTCDemo to use the updated Objective-C API.
...
BUG=
Review URL: https://codereview.webrtc.org/1690313002
Cr-Commit-Position: refs/heads/master@{#11973}
2016-03-14 05:08:35 +00:00
0ce3bf9cc4
Fix lock behavior on RTCAudioSession.
...
In addition:
- Introduces RTCAudioSessionTest
- iOS/Mac gtests now have an autoreleasepool
- Moves ScopedAutoreleasePool to rtc_base_approved
- Introduces route change button in AppRTCDemo
BUG=webrtc:5649
Review URL: https://codereview.webrtc.org/1782363002
Cr-Commit-Position: refs/heads/master@{#11971}
2016-03-13 00:52:13 +00:00
2db1dbb2ca
Remove references to build_with_libjingle and libjingle_java GYP variables.
...
These were removed a while back in https://codereview.webrtc.org/1457053003
TBR=tkchin@webrtc.org
Review URL: https://codereview.webrtc.org/1790753004 .
Cr-Commit-Position: refs/heads/master@{#11967}
2016-03-12 05:34:35 +00:00
bad7b091af
Update examples GYP to avoid rtc_base_approved warning.
...
Updated peerconnection_server to not need stuff from rtc_base.
BUG=
Review URL: https://codereview.webrtc.org/1789463002
Cr-Commit-Position: refs/heads/master@{#11966}
2016-03-12 04:45:25 +00:00
6f59a4fc4f
Revert of Remove candidates when doing continual gathering (patchset #15 id:560001 of https://codereview.webrtc.org/1648813004/ )
...
Reason for revert:
Breaks the build. Suggest we reland with a default implementation of the new method, update Chrome, land a change that changes |{}| -> |= 0;|
Here's the error:
FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/content/renderer/media/webrtc/test_support_content.mock_peer_connection_dependency_factory.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD -DCR_CLANG_REVISION=262839-1 -DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_TOPCHROME_MD=1 -DDCHECK_ALWAYS_ON=1 -DFIELDTRIAL_TESTING_ENABLED -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PDF=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DMOJO_USE_SYSTEM_IMPL -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=0 -DSK_SUPPORT_GPU=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DUNIT_TEST -DGTEST_HAS_RTTI=0 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DCHROME_PNG_WRITE_SUPPORT -DPNG_USER_CONFIG -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DOSX -DWEBRTC_MAC -DWEBRTC_POSIX -DXML_STATIC -DWEBRTC_CHROMIUM_BUILD -DUSE_LIBPCI=1 -DUSE_OPENSSL=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen -I../.. -I../../third_party/khronos -I../../gpu -I../../skia/config -Igen/angle -I../../third_party/WebKit/Source -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/utils/mac -I../../skia/ext -I../../testing/gmock/include -I../../testing/gtest/include -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -Igen/ui/resources -Igen/protoc_out -I../../third_party/protobuf -I../../third_party/protobuf/src -I../../third_party/WebKit -I../../ipc -I../../third_party/opus/src/include -I../../third_party/WebKit -I../../third_party/npapi -I../../third_party/npapi/bindings -I../../third_party/libpng -I../../third_party/zlib -I../../third_party/libwebp -I../../third_party/ots/include -I../../third_party/qcms/src -I../../third_party/iccjpeg -I../../third_party/libjpeg_turbo -I../../v8/include -I../../third_party/webrtc_overrides -I../../third_party/libjingle/overrides -I../../third_party/libjingle/source -I../../third_party -I../../third_party/expat/files/lib -I../../third_party/libvpx/source/libvpx -isysroot /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -O2 -gdwarf-2 -fvisibility=hidden -Werror -mmacosx-version-min=10.6 -arch x86_64 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wno-selector-type-mismatch -Wpartial-availability -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -Wno-shift-negative-value -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang /b/build/slave/Mac_Builder/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -fcolor-diagnostics -fno-strict-aliasing -c ../../content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc -o obj/content/renderer/media/webrtc/test_support_content.mock_peer_connection_dependency_factory.o
../../content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc:404:14: error: allocating an object of abstract class type 'content::MockSessionDescription'
return new MockSessionDescription(type, sdp);
^
../../third_party/webrtc/api/jsep.h💯 18: note: unimplemented pure virtual method 'RemoveCandidates' in 'MockSessionDescription'
virtual size_t RemoveCandidates(
^
1 error generated.
ninja: build stopped: subcommand failed.
Original issue's description:
> When doing candidate re-gathering in the same generation, Remove the existing local candidate on the same network
> and signaling the remote side to remove its remote candidate by setting the candidate priority to 0.
>
> BUG=
>
> Committed: https://crrev.com/84430da6817ce69c53bfad088be5c9df8b420f01
> Cr-Commit-Position: refs/heads/master@{#11958}
TBR=pthatcher@webrtc.org ,deadbeef@webrtc.org ,glaznev@webrtc.org ,honghaiz@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.webrtc.org/1785613011
Cr-Commit-Position: refs/heads/master@{#11960}
2016-03-11 22:05:15 +00:00
84430da681
When doing candidate re-gathering in the same generation, Remove the existing local candidate on the same network
...
and signaling the remote side to remove its remote candidate by setting the candidate priority to 0.
BUG=
Review URL: https://codereview.webrtc.org/1648813004
Cr-Commit-Position: refs/heads/master@{#11958}
2016-03-11 21:28:12 +00:00
6a4a03c59c
Add an option to soft reset HW decoder.
...
Soft reset can be used when input frame resolution changes
to avoid re creating MediaCodec instance.
Instead MediaCodec is flushed and some variables are reset.
R=pbos@webrtc.org , perkj@webrtc.org
Review URL: https://codereview.webrtc.org/1732533002 .
Cr-Commit-Position: refs/heads/master@{#11878}
2016-03-04 22:11:02 +00:00
4f735d16ad
Enable iOS AppRTCDemo send side BWE.
...
BUG=
Review URL: https://codereview.webrtc.org/1757173002
Cr-Commit-Position: refs/heads/master@{#11865}
2016-03-04 01:54:37 +00:00
db25d2e8c5
Make VideoTrack and VideoTrackRenderers implement rtc::VideoSourceInterface.
...
This patch tries to only change the interface to VideoTrack, with
minimal changes to the implementation. Some points worth noting:
VideoTrackRenderers should ultimately be deleted, but it is kept for
now since we need an object implementing webrtc::VideoRenderer, and
that shouldn't be VideoTrack.
BUG=webrtc:5426
TBR=glaznev@webrtc.org // please look at examples
Review URL: https://codereview.webrtc.org/1684423002
Cr-Commit-Position: refs/heads/master@{#11775}
2016-02-26 09:25:02 +00:00
615fabb661
Add looping sound button to AppRTCDemo
...
This exposes the issue where AVAudioPlayer will stop playing when the
VoiceProcessing I/O audio unit is initialized.
BUG=
R=haysc@webrtc.org , henrika@webrtc.org
Review URL: https://codereview.webrtc.org/1710053004 .
Cr-Commit-Position: refs/heads/master@{#11750}
2016-02-24 18:58:58 +00:00
dc0e381eb5
Add more camera resolutions to camera scaling slider.
...
Plus allow to use loopback adapter in loopback call.
BUG=b/26287075
R=wzh@webrtc.org
Review URL: https://codereview.webrtc.org/1720283002 .
Cr-Commit-Position: refs/heads/master@{#11714}
2016-02-23 00:48:36 +00:00
461121c67b
Replaced eglbase_jni with with holding a EglBase in PeerConnectionFactory.
...
Review URL: https://codereview.webrtc.org/1695763002
Cr-Commit-Position: refs/heads/master@{#11627}
2016-02-15 14:28:40 +00:00
15583c19d7
Move talk/app/webrtc to webrtc/api
...
The previously disabled warnings that were inherited from
talk/build/common.gypi are now replaced by target-specific disabling
of only the failing warnings. Additional disabling was needed since the stricter
compilation warnings that applies to code in webrtc/.
License headers will be updated in a follow-up CL.
Other modifications:
* Updated the header guards.
* Sorted the includes using chromium/src/tools/sort-headers.py
except for these files:
talk/app/webrtc/peerconnectionendtoend_unittest.cc
talk/app/webrtc/java/jni/androidmediadecoder_jni.cc
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc
webrtc/media/devices/win32devicemanager.cc
The HAVE_SCTP define was added for the peerconnection_unittests target
in api_tests.gyp.
I also checked that none of
SRTP_RELATIVE_PATH
HAVE_SRTP
HAVE_WEBRTC_VIDEO
HAVE_WEBRTC_VOICE
were used by the talk/app/webrtc code.
For Chromium, the following changes will need to be applied to the roll CL that updates the
DEPS for WebRTC and libjingle:
https://codereview.chromium.org/1615433002
BUG=webrtc:5418
NOPRESUBMIT=True
R=deadbeef@webrtc.org , pthatcher@webrtc.org , tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1610243002 .
Cr-Commit-Position: refs/heads/master@{#11545}
2016-02-10 09:53:26 +00:00
dfb769d848
Remove deprecated PeerConnectionObserver::OnStateChange and OnIceComplete
...
These methods are no longer used.
OnStateChange needs to be removed from Chrome before this cl lands. https://codereview.chromium.org/1668413003/
TBR=glaznev@webrtc.org for webrtc/examples
Review URL: https://codereview.webrtc.org/1669993003
Cr-Commit-Position: refs/heads/master@{#11537}
2016-02-09 11:09:50 +00:00
a96e2d77cb
Move talk/media to webrtc/media
...
I removed the 'libjingle' target in talk/libjingle.gyp and replaced
all users of it with base/base.gyp:rtc_base. It seems the jsoncpp
and expat dependencies were not used by it's previous references.
The files in talk/media/testdata were uploaded to Google Storage and
added .sha1 files in resources/media instead of simply moving them.
The previously disabled warnings that were inherited from
talk/build/common.gypi are now replaced by target-specific disabling
of only the failing warnings. Additional disabling was needed since the stricter
compilation warnings that applies to code in webrtc/.
License headers will be updated in a follow-up CL in order to not
break Git history.
Other modifications:
* Updated the header guards.
* Sorted the includes using chromium/src/tools/sort-headers.py
except for these files:
talk/app/webrtc/peerconnectionendtoend_unittest.cc
talk/app/webrtc/java/jni/androidmediadecoder_jni.cc
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc
webrtc/media/devices/win32devicemanager.cc.
* Unused GYP reference to libjingle_tests_additional_deps was removed.
* Removed duplicated GYP entries of
webrtc/base/testutils.cc
webrtc/base/testutils.h
The HAVE_WEBRTC_VIDEO and HAVE_WEBRTC_VOICE defines were used by only talk/media,
so they were moved to the media.gyp.
I also checked that none of
EXPAT_RELATIVE_PATH,
FEATURE_ENABLE_VOICEMAIL,
GTEST_RELATIVE_PATH,
JSONCPP_RELATIVE_PATH,
LOGGING=1,
SRTP_RELATIVE_PATH,
FEATURE_ENABLE_SSL,
FEATURE_ENABLE_VOICEMAIL,
FEATURE_ENABLE_PSTN,
HAVE_SCTP,
HAVE_SRTP,
are used by the talk/media code.
For Chromium, the following changes will need to be applied to the roll CL that updates the
DEPS for WebRTC and libjingle: https://codereview.chromium.org/1604303002/
BUG=webrtc:5420
NOPRESUBMIT=True
TBR=tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1587193006
Cr-Commit-Position: refs/heads/master@{#11495}
2016-02-05 07:52:35 +00:00
d1fb26d457
Add iOS tracing.
...
BUG=
Review URL: https://codereview.webrtc.org/1650993004
Cr-Commit-Position: refs/heads/master@{#11469}
2016-02-03 09:51:22 +00:00
6043f2e5d6
Revert of Adding "first packet received" notification to PeerConnectionObserver. (patchset #5 id:80001 of https://codereview.webrtc.org/1581693006/ )
...
Reason for revert:
onFirstMediaPacketReceived() breaks bot.
Original issue's description:
> Adding "first packet received" notification to PeerConnectionObserver.
>
> R=glaznev@webrtc.org , pthatcher@webrtc.org , tkchin@webrtc.org
>
> Committed: https://crrev.com/42265a8cc3b3f3db4aa2c29005aed2fb4393adef
> Cr-Commit-Position: refs/heads/master@{#11401}
>
> Committed: https://crrev.com/08a6eab75e13613183509d91d3892c1db57f6fc5
> Cr-Commit-Position: refs/heads/master@{#11404}
TBR=pthatcher@webrtc.org ,tkchin@webrtc.org ,glaznev@webrtc.org ,deadbeef@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.webrtc.org/1647483004
Cr-Commit-Position: refs/heads/master@{#11415}
2016-01-28 13:06:16 +00:00
08a6eab75e
Adding "first packet received" notification to PeerConnectionObserver.
...
R=glaznev@webrtc.org , pthatcher@webrtc.org , tkchin@webrtc.org
Committed: https://crrev.com/42265a8cc3b3f3db4aa2c29005aed2fb4393adef
Cr-Commit-Position: refs/heads/master@{#11401}
Review URL: https://codereview.webrtc.org/1581693006 .
Cr-Commit-Position: refs/heads/master@{#11404}
2016-01-27 21:38:57 +00:00
7b3c72ffa9
Revert of Adding "first packet received" notification to PeerConnectionObserver. (patchset #4 id:60001 of https://codereview.webrtc.org/1581693006/ )
...
Reason for revert:
Seems that the end-to-end unit tests are now flaky: https://build.chromium.org/p/client.webrtc/builders/Win64%20Debug/builds/6283
Will reland after fixing the test flakiness.
Original issue's description:
> Adding "first packet received" notification to PeerConnectionObserver.
>
> R=glaznev@webrtc.org , pthatcher@webrtc.org , tkchin@webrtc.org
>
> Committed: https://crrev.com/42265a8cc3b3f3db4aa2c29005aed2fb4393adef
> Cr-Commit-Position: refs/heads/master@{#11401}
TBR=pthatcher@webrtc.org ,tkchin@webrtc.org ,glaznev@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.webrtc.org/1640173004
Cr-Commit-Position: refs/heads/master@{#11402}
2016-01-27 21:03:47 +00:00
42265a8cc3
Adding "first packet received" notification to PeerConnectionObserver.
...
R=glaznev@webrtc.org , pthatcher@webrtc.org , tkchin@webrtc.org
Review URL: https://codereview.webrtc.org/1581693006 .
Cr-Commit-Position: refs/heads/master@{#11401}
2016-01-27 20:10:44 +00:00
ec2922f864
Change PeerConnectionFactory.setVideoHwAccelerationOptions to create shared Egl context for harware encoders and decoders.
...
Before this fix, it was required that the EGL context used as an argument was kept open until all PeerConnections using the context had been closed. With this fix, that is no longer required.
Also, if a released EGLContext (EGL_NO_CONTEXT) is used, harware codecs will fallback to use byte buffers for encoding and decoding.
BUG=b/26583522
R=glaznev@webrtc.org
Review URL: https://codereview.webrtc.org/1615153002 .
Cr-Commit-Position: refs/heads/master@{#11398}
2016-01-27 14:25:56 +00:00
cec0a08275
Add a new interface for creating a udp socket in which it binds the socket to a network if the network handle is set.
...
Plus, in stunport, turnport and allocation sequence, create a socket using the new interface.
BUG=
Review URL: https://codereview.webrtc.org/1556743002
Cr-Commit-Position: refs/heads/master@{#11279}
2016-01-15 22:49:15 +00:00
d66b44d565
Reland "Added option to specify a maximum file size when recording an AEC dump.", commit ae2c5ad12afc8cc29fe9c59dea432b697b871a87.
...
The revert of the original CL was commit 36d4c545007129446e551c45c17b25377dce89a4.
Original review: https://codereview.webrtc.org/1413483003/
The original CL changes a function on audio_processing.h that is used by Chrome, this CL adds back the old function.
TBR=glaznev@webrtc.org , henrik.lundin@webrtc.org , solenberg@google.com , henrikg@webrtc.org , perkj@webrtc.org
BUG=webrtc:4741
Committed: https://crrev.com/f4f5cb09277d5ef6aeac8341e5f54a055867803a
Cr-Commit-Position: refs/heads/master@{#11093}
Review URL: https://codereview.webrtc.org/1540103002
Cr-Commit-Position: refs/heads/master@{#11267}
2016-01-15 11:06:41 +00:00
67b1e1ab0b
Put options as the argument of the java PeerConnectionFactory constructor.
...
BUG=
Review URL: https://codereview.webrtc.org/1581903002
Cr-Commit-Position: refs/heads/master@{#11257}
2016-01-14 22:45:44 +00:00
41d1a62d43
Use getExternalStorageDirectory() for trace file.
...
Removes hard-coded /mnt/sdcard/ path.
BUG=
R=glaznev@webrtc.org
Review URL: https://codereview.webrtc.org/1548263003
Cr-Commit-Position: refs/heads/master@{#11142}
2015-12-30 17:23:35 +00:00
0c7e9f540b
Removing webrtc::PortAllocatorFactoryInterface.
...
ICE servers are now passed directly into PortAllocator,
making PortAllocatorFactoryInterface redundant. This CL also
moves SetNetworkIgnoreMask to PortAllocator.
R=phoglund@webrtc.org , pthatcher@webrtc.org , tkchin@webrtc.org
Review URL: https://codereview.webrtc.org/1520963002 .
Cr-Commit-Position: refs/heads/master@{#11139}
2015-12-29 22:15:02 +00:00
a4df27b671
Revert of Reland "Added option to specify a maximum file size when recording an AEC dump." (patchset #2 id:20001 of https://codereview.webrtc.org/1541633002/ )
...
Reason for revert:
Compile error on Android needs to be fixed before relanding.
Original issue's description:
> Reland "Added option to specify a maximum file size when recording an AEC dump.", commit ae2c5ad12afc8cc29fe9c59dea432b697b871a87.
>
> The revert of the original CL was commit 36d4c545007129446e551c45c17b25377dce89a4.
> Original review: https://codereview.webrtc.org/1413483003/
>
> The original CL changes a function on audio_processing.h that is used by Chrome, this CL adds back the old function.
>
> NOTRY=true
> TBR=glaznev@webrtc.org , henrik.lundin@webrtc.org , solenberg@google.com , henrikg@webrtc.org , perkj@webrtc.org
> BUG=webrtc:4741
>
> Committed: https://crrev.com/f4f5cb09277d5ef6aeac8341e5f54a055867803a
> Cr-Commit-Position: refs/heads/master@{#11093}
TBR=glaznev@webrtc.org ,henrik.lundin@webrtc.org ,solenberg@google.com ,henrikg@webrtc.org ,perkj@webrtc.org ,kwiberg@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4741
Review URL: https://codereview.webrtc.org/1537213002
Cr-Commit-Position: refs/heads/master@{#11094}
2015-12-19 18:14:18 +00:00
f4f5cb0927
Reland "Added option to specify a maximum file size when recording an AEC dump.", commit ae2c5ad12afc8cc29fe9c59dea432b697b871a87.
...
The revert of the original CL was commit 36d4c545007129446e551c45c17b25377dce89a4.
Original review: https://codereview.webrtc.org/1413483003/
The original CL changes a function on audio_processing.h that is used by Chrome, this CL adds back the old function.
NOTRY=true
TBR=glaznev@webrtc.org , henrik.lundin@webrtc.org , solenberg@google.com , henrikg@webrtc.org , perkj@webrtc.org
BUG=webrtc:4741
Review URL: https://codereview.webrtc.org/1541633002
Cr-Commit-Position: refs/heads/master@{#11093}
2015-12-19 18:02:39 +00:00
36d4c54500
Revert of Added option to specify a maximum file size when recording an AEC dump. (patchset #5 id:120001 of https://codereview.webrtc.org/1413483003/ )
...
Reason for revert:
Breaks Chrome-FYI bots because of a change in the StartDebugRecording function in audio_processing.h, that is called from Chrome.
Original issue's description:
> Added option to specify a maximum file size when recording an AEC dump.
>
> For applications with a strict filesize limit for debug files,
> I added an option to specify a maximum filesize for AEC dumps. An
> existing unit test is extended to check that the feature works as
> advertised.
>
> BUG=webrtc:4741
> TBR=glaznev@webrtc.org
>
> Committed: https://crrev.com/ae2c5ad12afc8cc29fe9c59dea432b697b871a87
> Cr-Commit-Position: refs/heads/master@{#11081}
TBR=pthatcher@webrtc.org ,henrik.lundin@webrtc.org ,henrikg@webrtc.org ,solenberg@webrtc.org ,andrew@webrtc.org ,kwiberg@webrtc.org ,perkj@webrtc.org ,glaznev@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4741
Review URL: https://codereview.webrtc.org/1533913004
Cr-Commit-Position: refs/heads/master@{#11087}
2015-12-18 16:05:21 +00:00
ae2c5ad12a
Added option to specify a maximum file size when recording an AEC dump.
...
For applications with a strict filesize limit for debug files,
I added an option to specify a maximum filesize for AEC dumps. An
existing unit test is extended to check that the feature works as
advertised.
BUG=webrtc:4741
TBR=glaznev@webrtc.org
Review URL: https://codereview.webrtc.org/1413483003
Cr-Commit-Position: refs/heads/master@{#11081}
2015-12-18 11:53:42 +00:00
9638143033
Reland of Made EglBase an abstract class and cleaned up. (patchset #1 id:1 of https://codereview.webrtc.org/1522073002/ )
...
Reason for revert:
Clients have been updated.
Original issue's description:
> Revert of Made EglBase an abstract class and cleaned up. (patchset #4 id:60001 of https://codereview.webrtc.org/1526463002/ )
>
> Reason for revert:
> Revert due breaking other clients.
>
> Original issue's description:
> > Made EglBase an abstract class and cleaned up.
> > Adds EglBase10 that implemenents EglBase for EGL 1.0
> >
> > BUG=webrtc:4993
> > TBR=glaznew@webrtc.org
> >
> > Committed: https://crrev.com/3207916f35ded33f586774e2c98d4d0089fe3c6e
> > Cr-Commit-Position: refs/heads/master@{#11011}
>
> TBR=magjed@webrtc.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:4993
>
> Committed: https://crrev.com/e22e1cb399748112f308b488e7535754ef6b807d
> Cr-Commit-Position: refs/heads/master@{#11013}
TBR=magjed@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4993
Review URL: https://codereview.webrtc.org/1522303004
Cr-Commit-Position: refs/heads/master@{#11024}
2015-12-15 10:48:13 +00:00
e22e1cb399
Revert of Made EglBase an abstract class and cleaned up. (patchset #4 id:60001 of https://codereview.webrtc.org/1526463002/ )
...
Reason for revert:
Revert due breaking other clients.
Original issue's description:
> Made EglBase an abstract class and cleaned up.
> Adds EglBase10 that implemenents EglBase for EGL 1.0
>
> BUG=webrtc:4993
> TBR=glaznew@webrtc.org
>
> Committed: https://crrev.com/3207916f35ded33f586774e2c98d4d0089fe3c6e
> Cr-Commit-Position: refs/heads/master@{#11011}
TBR=magjed@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4993
Review URL: https://codereview.webrtc.org/1522073002
Cr-Commit-Position: refs/heads/master@{#11013}
2015-12-14 14:43:39 +00:00
3207916f35
Made EglBase an abstract class and cleaned up.
...
Adds EglBase10 that implemenents EglBase for EGL 1.0
BUG=webrtc:4993
TBR=glaznew@webrtc.org
Review URL: https://codereview.webrtc.org/1526463002
Cr-Commit-Position: refs/heads/master@{#11011}
2015-12-14 14:21:19 +00:00
0b0a88b918
Add aecdump support to AppRTCDemo
...
Review URL: https://codereview.webrtc.org/1514473008
Cr-Commit-Position: refs/heads/master@{#10985}
2015-12-11 07:28:50 +00:00
70625e5bf3
Enable cpplint for webrtc/examples and fix all uncovered cpplint errors.
...
BUG=webrtc:5273
TESTED=Fixed issues reported by:
find webrtc/examples/ -type f -name *.cc -o -name *.h | grep -v objc | xargs cpplint.py
followed by 'git cl presubmit'.
NOTRY=True
Review URL: https://codereview.webrtc.org/1504283004
Cr-Commit-Position: refs/heads/master@{#10960}
2015-12-09 22:18:20 +00:00
edd8fefa9b
Add new view that renders local video using AVCaptureLayerPreview.
...
BUG=
Review URL: https://codereview.webrtc.org/1497393002
Cr-Commit-Position: refs/heads/master@{#10940}
2015-12-08 19:08:44 +00:00
6f28cf0b95
Implement standalone event tracing in AppRTCDemo.
...
Logs tracing events (TRACE_EVENT0 and friends) to storage in a format
compatible with chrome://tracing which can be used for performance
evaluation, finding lock contention and other sweet things). Tracing is
still basic and doesn't contain thread metadata or logging of tracing
arguments.
BUG=webrtc:5158
R=tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1457383002 .
Cr-Commit-Position: refs/heads/master@{#10921}
2015-12-07 22:17:26 +00:00
40455d6f37
This cl change so that we use EGL14 where it is supported and EGL10 otherwise. The idea is to make this agnostic to an application and for WebRTC except in EGLBase.
...
The reason we want to use EGL14 is to be able to use EGLExt.eglPresentationTimeANDROID when writing textures to MediaEncoder.
BUG=webrtc:4993
TBR=glaznew@webrtc.org
Review URL: https://codereview.webrtc.org/1461083002
Cr-Commit-Position: refs/heads/master@{#10864}
2015-12-02 09:07:22 +00:00
9f8d39d1b6
Add simple end to end test for video capture and encode using textures.
...
BUG=webrtc:4993
Review URL: https://codereview.webrtc.org/1482333002
Cr-Commit-Position: refs/heads/master@{#10849}
2015-12-01 06:59:42 +00:00
d48015364d
Add option to capture to texture in AppRTCDemo for Android.
...
The purpose is to be able to easier test and find differences between the path when capturing to textures or byte buffers.
This require https://codereview.webrtc.org/1403713002/ to work.
BUG=webrtc:4993
R=magjed@webrtc.org
TBR=glaznew@webrtc.org
Review URL: https://codereview.webrtc.org/1452423003 .
Cr-Commit-Position: refs/heads/master@{#10766}
2015-11-24 10:13:34 +00:00
5c489c9d3e
Add OpenSL ES enable setting to AppRTCDemo (part 2).
...
It is now possible to enable OpenSL ES on devices that supports it.
Fix for https://codereview.webrtc.org/1449083002/
Review URL: https://codereview.webrtc.org/1455563002
Cr-Commit-Position: refs/heads/master@{#10678}
2015-11-17 18:12:46 +00:00
e66339296b
Add OpenSL ES enable setting to AppRTCDemo.
...
Disable OpenSL ES by default.
Plus remove no longer used CPU overuse detection option.
Review URL: https://codereview.webrtc.org/1449083002
Cr-Commit-Position: refs/heads/master@{#10670}
2015-11-17 12:05:35 +00:00
eb8b388273
Fix VP9 support in AppRTCDemo.
...
Default VP9 selection is no longer triggered by field trial string
after https://codereview.webrtc.org/1432673002 , so VP9 need to
be selected now through SDP mangling.
R=wzh@webrtc.org
Review URL: https://codereview.webrtc.org/1452783002 .
Cr-Commit-Position: refs/heads/master@{#10660}
2015-11-16 22:12:01 +00:00
68876f990e
Introduces Android API level linting, fixes all current API lint errors.
...
This CL attempts to annotate accesses on >16 API levels using as
small scopes as possible. The TargetApi notations mean "yes, I know
I'm accessing a higher API and I take responsibility for gating the
call on Android API level". The Encoder/Decoder classes are annotated
on the whole class, but they're only accessed through JNI; we should
annotate on method level otherwise and preferably on private methods.
This patch also fixes some compiler-level deprecation warnings (i.e.
-Xlint:deprecation), but probably not all of them.
BUG=webrtc:5063
R=henrika@webrtc.org , kjellander@webrtc.org , magjed@webrtc.org
Review URL: https://codereview.webrtc.org/1412673008 .
Cr-Commit-Position: refs/heads/master@{#10624}
2015-11-12 16:37:01 +00:00
fa566d610f
Remove webrtc/examples/android/media_demo.
...
The JNI code for VoiceEngine is not maintained and VoiceEngine is being
refactored. This is not a supported Java interface, use AppRTCDemo as a
starting point instead.
Also renames webrtc/libjingle_examples.gyp webrtc/webrtc_examples.gyp to
replace the previous file (that only contained media_demo).
BUG=
R=henrika@webrtc.org , kjellander@webrtc.org
Review URL: https://codereview.webrtc.org/1439593002 .
Cr-Commit-Position: refs/heads/master@{#10599}
2015-11-11 12:11:21 +00:00
1323fc39ba
Remove webrtc/test/channel_transport/include
...
Move the header file into webrtc/test/channel_transport instead.
BUG=webrtc:5095
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel --bot=win_compile_rel --bot=mac_compile_rel -m tryserver.webrtc --bot=ios_rel
R=henrika@webrtc.org , henrikg@webrtc.org
Review URL: https://codereview.webrtc.org/1431983006 .
Cr-Commit-Position: refs/heads/master@{#10595}
2015-11-11 09:34:35 +00:00
