acd935b540
Reland of Delete all use of cricket::VideoFrame and cricket::WebRtcVideoFrame. (patchset #1 id:1 of https://codereview.webrtc.org/2471783002/ )
...
Reason for revert:
Relanding after known downstream breakages have been fixed.
Original issue's description:
> Revert of Delete all use of cricket::VideoFrame and cricket::WebRtcVideoFrame. (patchset #7 id:120001 of https://codereview.webrtc.org/2383093002/ )
>
> Reason for revert:
> Breaks chrome, see https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/19019/steps/compile/logs/stdio
>
> Analysis: Chrome uses cricket::VideoFrame, without explicitly including webrtc/media/base/videoframe.h, and breaks when that file is no longer included by any other webrtc headers. Will reland after updating Chrome.
>
> Original issue's description:
> > Delete all use of cricket::VideoFrame and cricket::WebRtcVideoFrame.
> >
> > Replaced with webrtc::VideoFrame.
> >
> > TBR=mflodman@webrtc.org
> > BUG=webrtc:5682
> >
> > Committed: https://crrev.com/45c8b8940042bd2574c39920804ade8343cefdba
> > Cr-Commit-Position: refs/heads/master@{#14885}
>
> TBR=perkj@webrtc.org ,pthatcher@webrtc.org ,tkchin@webrtc.org ,mflodman@webrtc.org ,stefan@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:5682
>
> Committed: https://crrev.com/7341ab8e2505c9763d208e069bda269018357e7d
> Cr-Commit-Position: refs/heads/master@{#14886}
TBR=perkj@webrtc.org ,pthatcher@webrtc.org ,tkchin@webrtc.org ,mflodman@webrtc.org ,stefan@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:5682
Review-Url: https://codereview.webrtc.org/2487633002
Cr-Commit-Position: refs/heads/master@{#15039}
2016-11-11 11:55:19 +00:00
7341ab8e25
Revert of Delete all use of cricket::VideoFrame and cricket::WebRtcVideoFrame. (patchset #7 id:120001 of https://codereview.webrtc.org/2383093002/ )
...
Reason for revert:
Breaks chrome, see https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/19019/steps/compile/logs/stdio
Analysis: Chrome uses cricket::VideoFrame, without explicitly including webrtc/media/base/videoframe.h, and breaks when that file is no longer included by any other webrtc headers. Will reland after updating Chrome.
Original issue's description:
> Delete all use of cricket::VideoFrame and cricket::WebRtcVideoFrame.
>
> Replaced with webrtc::VideoFrame.
>
> TBR=mflodman@webrtc.org
> BUG=webrtc:5682
>
> Committed: https://crrev.com/45c8b8940042bd2574c39920804ade8343cefdba
> Cr-Commit-Position: refs/heads/master@{#14885}
TBR=perkj@webrtc.org ,pthatcher@webrtc.org ,tkchin@webrtc.org ,mflodman@webrtc.org ,stefan@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5682
Review-Url: https://codereview.webrtc.org/2471783002
Cr-Commit-Position: refs/heads/master@{#14886}
2016-11-02 10:40:05 +00:00
45c8b89400
Delete all use of cricket::VideoFrame and cricket::WebRtcVideoFrame.
...
Replaced with webrtc::VideoFrame.
TBR=mflodman@webrtc.org
BUG=webrtc:5682
Review-Url: https://codereview.webrtc.org/2383093002
Cr-Commit-Position: refs/heads/master@{#14885}
2016-11-02 10:20:28 +00:00
792469709d
Refactor WebRtcVideoCapturer.
...
Pass incoming frames directly to VideoCapturer::OnFrame (after
conversion to cricket::VideoFrame), without using SignalFrameCaptured
or WebRtcCapturedFrame.
BUG=webrtc:5682
Review-Url: https://codereview.webrtc.org/2258933003
Cr-Commit-Position: refs/heads/master@{#13861}
2016-08-23 12:50:20 +00:00
ef8b61e110
Enable -Winconsistent-missing-override flag.
...
The problem with gmock is worked around by commenting out any other override declarations in classes using gmock.
NOPRESUBMIT=True
BUG=webrtc:3970
Review-Url: https://codereview.webrtc.org/1921653002
Cr-Commit-Position: refs/heads/master@{#12563}
2016-04-29 13:09:23 +00:00
09c3a1e291
Use rtc::scoped_refptr for WebRtcVideoCapturer.
...
Un-breaks peerconnection_client which would instantly use-after-free on
an allocated VCM because it wasn't building a scoped_refptr so all
references to the VCM were dropped.
BUG=webrtc:5229
TBR=tommi@webrtc.org
TEST=Run peerconnection_client locally, verify that there's no crash.
Review URL: https://codereview.webrtc.org/1817953005 .
Cr-Commit-Position: refs/heads/master@{#12088}
2016-03-22 16:17:47 +00:00
8ad582d83f
Remove DeviceManager and DeviceInfo.
...
BUG=webrtc:5615, webrtc:5620
Review URL: https://codereview.webrtc.org/1715883002
Cr-Commit-Position: refs/heads/master@{#12020}
2016-03-16 16:35:04 +00:00
686a8efad9
Replace scoped_ptr with unique_ptr in webrtc/media/
...
BUG=webrtc:5520
Review URL: https://codereview.webrtc.org/1728503002
Cr-Commit-Position: refs/heads/master@{#11779}
2016-02-26 11:00:39 +00:00
a50924115e
This reland https://codereview.webrtc.org/1655793003/ with the change that cricket::VideoCapturer::SignalVideoFrame is added back and used for frame forwarding. It is used in Chrome remoting.
...
BUG=webrtc:5426
R=pthatcher@webrtc.org
TBR=pthatcher@webrtc.org for moved channelmanager....
Review URL: https://codereview.webrtc.org/1689923002 .
Cr-Commit-Position: refs/heads/master@{#11597}
2016-02-12 12:31:08 +00:00
5ad129741c
Rename webrtc/media/webrtc -> webrtc/media/engine
...
BUG=webrtc:5420
NOTRY=True
R=pthatcher@google.com , pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1684163002 .
Cr-Commit-Position: refs/heads/master@{#11591}
2016-02-12 05:39:50 +00:00
