4fb3d2bcca
Add defaulted move constructors for some types that just got copy constructors
...
They can all benefit from moving, since they contain std::string and
std::vector. We intended to add these in
https://codereview.webrtc.org/1896953004/ , but got compiler errors we
couldn't make sense of, so we skipped them. It turns out that what the
compiler was complaining about was that when we said we'd have a
user-defined move constructor, it stopped generating a copy assignment
operator for us. This CL solves the problem by outfitting the types
with defaulted copy and move assignment operators too.
Review URL: https://codereview.webrtc.org/1899173002
Cr-Commit-Position: refs/heads/master@{#12469}
2016-04-22 11:59:34 +00:00
470dd37b41
Roll chromium_revision 212f976fef..61ed337cfe (387882:388120)
...
https://codereview.chromium.org/1826693002 enables some
more Clang warnings which were fixed.
Change log: 212f976fef..61ed337cfe
Full diff: 212f976fef..61ed337cfe
No dependencies changed.
No update to Clang.
TBR=
NOTRY=True
Review URL: https://codereview.webrtc.org/1896953004
Cr-Commit-Position: refs/heads/master@{#12422}
2016-04-19 10:03:31 +00:00
098c1de578
Fixes for PNaCl build of remoting client plugin with GN.
...
1. Added support for PNaCl in base.
2. Separated parts of desktop_capture module that need to be
compiled for PNaCl.
BUG=512899
R=jiayl@chromium.org , jiayl@webrtc.org
Review URL: https://codereview.webrtc.org/1323453003 .
Cr-Commit-Position: refs/heads/master@{#9836}
2015-09-01 18:36:50 +00:00
88fbb2d86b
Switch to using base/constructormagic.h and remove system_wrappers/interface/constructor_magic.h.
...
Same as https://webrtc-codereview.appspot.com/19519004 . The issue in
http://chromegw.corp.google.com/i/internal.chromium.webrtc.fyi/builders/Linux ...
is solved by this change
http://src.chromium.org/viewvc/chrome/trunk/src/third_party/libjingle/libjing ...
(tested locally).
BUG=3380
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/17619005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6218 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-21 21:18:46 +00:00
2fa7f79094
Revert 6202 "Switch to using base/constructormagic.h and remove ..."
...
> Switch to using base/constructormagic.h and remove system_wrappers/interface/constructor_magic.h.
>
> BUG=N/A
> R=andrew@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/19519004
TBR=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14579007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6210 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-21 11:07:29 +00:00
125ffd709d
Switch to using base/constructormagic.h and remove system_wrappers/interface/constructor_magic.h.
...
BUG=N/A
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19519004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6202 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-20 15:20:44 +00:00
6ab45b9dab
Implement DesktopRegion subtraction.
...
Region subtraction is used in chromoting client, so it's needed to
replace SkRegion.
R=wez@chromium.org
Review URL: https://webrtc-codereview.appspot.com/2205004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4741 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-13 19:53:16 +00:00
e72428442d
Fix some chromium-style warnings in webrtc/modules/desktop_capture/
...
BUG=163
R=sergeyu@chromium.org
Review URL: https://webrtc-codereview.appspot.com/1904004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4446 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-31 15:32:43 +00:00
3ee13e4ac2
Optimized DesktopRegion implementation.
...
Now DestktopRegion can merge overlapping rectangles.
R=wez@chromium.org
Review URL: https://webrtc-codereview.appspot.com/1526004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4161 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-06-04 00:38:39 +00:00
15e32ccd30
Add DesktopCapturer interface for desktop capturers.
...
The new DesktopCapturer interface will be used for screen and window
captures. Beside DesktopCapturer itself also added classes/interfaces
that it depends on.
R=alexeypa@chromium.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1322007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3917 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-29 20:10:57 +00:00