fdd2340311
Revert "Detect leaks of TextureBufferImpl objects."
...
This reverts commit 44bd29a3b068363e013cd425c68fd00dba21d633.
Reason for revert:
Going for an alternative implementation that makes this unnecessary
https://webrtc-review.googlesource.com/c/src/+/150649
Original change's description:
> Detect leaks of TextureBufferImpl objects.
>
> The performance cost is not trivial but according to my profiling,
> it is acceptable.
>
> Bug: b/139745386
> Change-Id: I0e63221ccf22e9f6fb32c630ff63a279e765994a
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150539
> Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
> Commit-Queue: Sami Kalliomäki <sakal@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28973}
TBR=sakal@webrtc.org ,kthelgason@webrtc.org
Change-Id: Ic6266e5fd24389d41a6d5dbfe51de6505b861b12
Bug: b/139745386
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150650
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28983}
2019-08-28 12:35:04 +00:00
44bd29a3b0
Detect leaks of TextureBufferImpl objects.
...
The performance cost is not trivial but according to my profiling,
it is acceptable.
Bug: b/139745386
Change-Id: I0e63221ccf22e9f6fb32c630ff63a279e765994a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150539
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28973}
2019-08-27 13:53:48 +00:00
f03b365875
Reland "Raise IllegalStateException for calls to retain() or release() on zero ref count"
...
This is a reland of 8a959bfa88b08e215baf3b38e914c41e483c9ece
Original change's description:
> Raise IllegalStateException for calls to retain() or release() on zero ref count
>
> Bug: None
> Change-Id: I3205e77b5adfdc4f5dbd7509d1ca0e8b08af62f2
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/142175
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28319}
Bug: None
Change-Id: If8fb02ca149257dd29b0c3352347369168a5cef3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/142807
Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28372}
2019-06-25 14:42:55 +00:00
18f1f0c1f5
Revert "Raise IllegalStateException for calls to retain() or release() on zero ref count"
...
This reverts commit 8a959bfa88b08e215baf3b38e914c41e483c9ece.
Reason for revert: Breaks a downstream test.
Original change's description:
> Raise IllegalStateException for calls to retain() or release() on zero ref count
>
> Bug: None
> Change-Id: I3205e77b5adfdc4f5dbd7509d1ca0e8b08af62f2
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/142175
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28319}
TBR=sakal@webrtc.org ,nisse@webrtc.org
Change-Id: I522cc5264789d8c7088de6df6e47584622265a94
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/142806
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28320}
2019-06-19 08:50:53 +00:00
8a959bfa88
Raise IllegalStateException for calls to retain() or release() on zero ref count
...
Bug: None
Change-Id: I3205e77b5adfdc4f5dbd7509d1ca0e8b08af62f2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/142175
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28319}
2019-06-19 08:00:57 +00:00
69540f4419
Use android Nullable instead of javax Nullable
...
This is a propagation of upstream chromium change needed to
resume DEPS autorolls into WebRTC.
Original comment from upstream change:
> This change is made in preparation for an ErrorProne
> check to catch this at compile time. See bug for details.
Bug: chromium:771683
Change-Id: I56aed15f73a633dcadae7ece6c645cd3596f9257
Reviewed-on: https://webrtc-review.googlesource.com/c/113505
Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Artem Titarenko <artit@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25951}
2018-12-10 15:03:58 +00:00
61db3fd77f
Make VideoFrame.Buffer implementations lock-free.
...
Replaces lock-based implementation with AtomicInteger.
Bug: webrtc:7749
Change-Id: I226093b0af2090c080dfd4f87ed8f33a3f9efbd8
Reviewed-on: https://webrtc-review.googlesource.com/64162
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#22798}
2018-04-09 16:29:59 +00:00
