be50ab645a
Including algorithm header to avoid VS2013 breakage
...
The header file <algorithm> must be included when std::min and std::max
are used.
R=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/9309004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5638 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-04 15:10:03 +00:00
04a691adac
Removing a variable that was never read
...
In NetEq4, the local variable discard_count in
PacketBuffer::DiscardOldPackets() was incremented but never read.
Removing it.
TBR=turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8909004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5584 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-20 15:27:00 +00:00
78f0db4710
Fix the break caused by r5579.
...
TBR=tlegrand@google.com
BUG=
Review URL: https://webrtc-codereview.appspot.com/8939004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5581 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-19 23:07:31 +00:00
c2d69d3229
Resolves memcheck issue in AudioCodingModuleTest. The issue is coditional jumnp based on uninitialized variable.
...
BUG=2944
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8919004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5579 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-19 20:31:17 +00:00
056287eee0
This CL separate all ACM tests with new and old implementation of ACM and NetEq. The reason is to debug an issue with failure on Android try bots. We need to see if the error only occurs with the new ACM/NetEq, or if it is a flakiness that affects both.
...
BUG=issue2874
R=minyue@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8829004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5576 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-19 13:45:54 +00:00
2086e0fbf3
Remove unnecessary warnings.
...
BUG=
TEST=try job
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8719005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5565 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-18 14:22:20 +00:00
340746aa13
Misc small nits in NetEq
...
Fixing a few small things found recently. This is mostly cosmetics.
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8749005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5558 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-17 11:37:16 +00:00
e2fc13e42f
Refactoring common_audio/signal_processing: Removed two macros used by isac only.
...
Removed a macro for malloc() and one for free(). They are only used by the audio codec isac, where I replaced the macro with its implementation.
Further, the includes were updated with full paths and put in alphabetical order.
BUG=N/A
TESTED=trybots,module_tests,module_unittests
R=turaj@webrtc.org , turajs@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8449004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5554 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-14 23:12:34 +00:00
fcfc6a990e
Small refactoring of NetEq unittest for CNG with clock drift
...
Converting the test to a method within the test fixture, and setting
up two tests that call this method. One for positive and one for
negative clock drift. The one with positive clock drift is disabled
for now since it does not pass, but will be re-enabled shortly.
This change is only made for NetEq4.
R=tlegrand@google.com
Review URL: https://webrtc-codereview.appspot.com/8599004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5541 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-13 11:42:28 +00:00
a80be4b23c
Add boundary checking to supress gcc 4.8.3 warning.
...
BUG=2888
Test=try, voe_cmd_test
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8389004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5526 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-11 16:38:45 +00:00
75642fcd9a
Implementing replacement audio support in neteq_rtpplay
...
This CL makes it possible to replace the payload in an RTP stream
with audio from another (PCM) file. The new payload will be encoded as
PCM16b. The RTP headers will be updated to reflect this change of
payload type.
BUG=2834
R=turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7659004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5490 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-05 08:49:13 +00:00
e6ab21b9ca
Fixing a bug in DummyRTPpacket
...
This bug caused writing outside allocated memory when RTP header
extensions were used.
BUG=2834
TBR=turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8009005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5489 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-05 08:46:46 +00:00
f6a638e001
Trivial rename of non-compile time consts.
...
R=henrik.lundin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7669006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5482 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-04 01:31:28 +00:00
83aee8f450
Fixing test name for NetEqPerformanceTest
...
The naming did not follow conventions.
BUG=2859
TBR=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7829004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5469 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-31 11:46:34 +00:00
84eb0e952e
Add clean test to NetEq perf test
...
Add another test to NetEqPerformanceTest with no packet losses or
clock drift. The purpose of this test would be to focus on the
"clean" code path, i.e., the path taken when there are no network
problems. The reason is that this code path is presumably much
lighter in complexity, and regressions could easily drown in the
heavier code involved when combating losses and drift.
BUG=2859
R=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7689005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5452 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-28 21:50:35 +00:00
4ffd9c7423
Add full path to headers
...
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7199004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5395 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-16 09:01:39 +00:00
d9faa46d57
Changing to using factory methods for some classes in NetEq
...
In this CL, the Expand, Accelerate and PreemptiveExpand objects are
created using factory methods. The factory methods are injected into
NetEqImpl on creation. This is a step towards implementing a no-decode
operation.
BUG=2776
R=turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6999005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5382 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-14 10:18:45 +00:00
d0b436a935
Revert "Activate ACM test for Android in modules_tests." (rev5364).
...
TBR=turaj@webrtc.org ,tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6999006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5372 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-13 13:15:59 +00:00
2c03bf1641
Increasing simulation time for NetEqPerformanceTest
...
This is to get better "signal-to-noise ratio" in the performance bots.
The neteq4-runtime metric is expected to increase by a factor of 10.
BUG=2397
TBR=minyue@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6989005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5369 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-13 09:04:23 +00:00
7cc64b3747
Activate ACM test for Android in modules_tests.
...
TEST=local on Nexus 7.
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6589004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5364 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-10 22:35:09 +00:00
a366e810a9
Adding NetEq performance test to webrtc_perf_tests
...
The performance test is based on the neteq4_speed_test application. The
bulk of the test code is extracted into a test class, and included into
the neteq_unittest_tools target. The actual gtest that runs the
performance test is implemented in neteq_performance_unittest.cc, and
built as a part of webrtc_perf_tests.
The old stand-alone test application is now made dependent on the new
test class, to avoid code duplication.
BUG=2397
R=andrew@webrtc.org , kjellander@webrtc.org , turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6749004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5362 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-10 08:24:04 +00:00
e7ce437333
Fixing lint errors in NetEq4
...
Just taking care of a few old lint errors.
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6799004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5359 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-09 14:01:55 +00:00
60730cfe3c
Remove the requirement to call set_sample_rate_hz and friends.
...
Instead have ProcessStream transparently handle changes to the stream
audio parameters (sample rate and channels). This removes two locks
per 10 ms ProcessStream call taken by VoiceEngine (four total with the
audio level indicator.)
Also, prepare future improvements by having the splitting filter take
a length parameter. This will allow it to work at different sample
rates. Remove the useless splitting_filter wrapper.
TESTED=voe_cmd_test with audio processing enabled and switching between
codecs; unit tests.
R=aluebs@webrtc.org , bjornv@webrtc.org , turaj@webrtc.org , xians@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3949004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5346 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-07 17:45:09 +00:00
24301a67c6
Update talk to 58174641 together with http://review.webrtc.org/4319005/ .
...
R=turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5809004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5287 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-13 19:17:43 +00:00
a92baead39
ACM 2 compatibility with ACM 1.
...
Removing an unregisterd codec from ACM 1 does not result in an error, so should be for ACM 2. Also ACM 1 has post-decode VAD on and AMC 2 needs to have it on by default.
BUG=
Test=trybits
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5549005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5276 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-13 00:10:44 +00:00
f9bdbe3619
Roll chromium_revision 232627:238260
...
This brings us the updated swarming_client
that has moved out from Chromium into a standalone
project.
Because of this, all .isolate files needed to be
updated as well, similar to the changes in
https://codereview.chromium.org/29993003
TEST=trybots passing
BUG=none
R=andrew@webrtc.org , perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4859004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5260 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-11 13:37:12 +00:00
917306d3fd
Change uses of the obsolete armv7 setting to arm_version==7.
...
BUG=http://crbug.com/234135
R=andrew@webrtc.org , fischman@webrtc.org , kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5369004
Patch from Mostyn Bramley-Moore <mostynb@opera.com >.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5250 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-10 09:26:07 +00:00
eb7def234e
Fix compilation errors on Fedora 20.
...
peerconnection_jni.cc: syscall() comes from <unistd.h>
RTPtimeshift.cc: char* being compared to 0 instead of the atoi() of it
rtp_payload_registry_unittest.cc: avoid narrowing int to uint32.
BUG=2700
R=andrew@webrtc.org , fischman@webrtc.org , henrik.lundin@webrtc.org , henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5019004
Patch from Victor Costan <costan@gmail.com >.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5248 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-09 21:34:30 +00:00
b477fa6d21
Small fixes to plot_neteq_delay.m
...
Fixing problems with wrap-arounds and other small things. Adding an
extra output value.
Review URL: https://webrtc-codereview.appspot.com/4929004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5210 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-04 12:28:47 +00:00
9523b55826
Fix a typo in neteq.gypi
...
This CL is for NetEq3. The #define for iSAC-fb was wrong on one
line. It did not affect the defualt use case, but resulted in
errors if 48 kHz mode was enabled.
TBR=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4909004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5208 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-04 08:24:49 +00:00
5ecdef11cc
Do not use recursive calling in NetEq test tools
...
This CL removes recursive calling in:
- NETEQTEST_DummyRTPpacket::readFromFile,
- NETEQTEST_RTPpacket::readFromFile.
The files currently exist for both NetEq3 and NetEq4, and all are
changed with this CL.
R=turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4699004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5200 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-03 08:26:49 +00:00
8418e9696b
Fixing NetEq tests for new Opus version
...
The new version of Opus doesn't generate the same number of bytes encoding the test vectors in audio_decoder_unittest. Therefore the test was updated not to check the length of the encoded packet, to prepare for the coming roll of Opus. Same change was applied to iSAC, which can also generate different number of bytes on different platforms.
BUG=1459
R=henrik.lundin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4609004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5195 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-29 09:30:43 +00:00
5272eb8d83
Don't register iSAC-swb and iSAC-fb in NetEqDecodingTest.
...
Android bots break due to r5164. This CL patches that issue.
BUG=
TEST=modules_unittests on local device.
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4309004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5166 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-23 00:11:32 +00:00
78b41a09bd
Fix issues with sequence number wrap-around in jitter statistics.
...
Related CL for NetEq 3 is https://code.google.com/p/webrtc/source/detail?r=5150
Jitter statistics was not very sensitive to timestamp warp-around, and NetEqDecodingTest.TimestampWrap *DID NOT* fail before fixes applied. However, we still keep the test.
The criteria for the tests are not satisfied for first few packets, before any wrap-around happens. We could either relax the bound or ignore the first few packets. We chose the latter.
BUG=2662
TEST=modules_unittests,trybots
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4219004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5164 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-22 20:27:07 +00:00
1e8c93c953
Distinguish instances of ACM1 from ACM2 by a version string. This is fpr testing purposes and will be removed when the experiment is done and ACM1 is fade out.
...
BUG=
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4069006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5161 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-22 17:04:49 +00:00
6f6ba6edee
Fix issues with sequence number wrap-around in jitter statistics
...
Wrap-arounds in sequence numbers (and in timestamps) were not always
treated correctly. This is fixed by introducing two helper functions
for correct comparisons, and by casting to the right word size.
Also added a new member variable to AutomodeInst_t. The new member keeps
track of when the first packet has been registered in the automode code.
This was previously done implicitly (and not very good) using the fact
that the lastSeqNo and lastTimestamp members were initialized to zero.
Two new unit tests were added as part of this CL.
NetEqDecodingTest.SequenceNumberWrap was failing before the fixes were
made; now it is ok.
BUG=2654
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4139004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5150 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-21 13:17:29 +00:00
7a05ae5c69
Adding back main() to the test. Now it is possible to choose between ACM1 and ACM2, furthermore, the test can simulate a channel with packet loss and FEC can be activated. Packet loss pattern is based on channel implementation in Channel{.cc,.h}, which currently is a determenistic pattern with 1 every 3rd packet is discarded.
...
The main() was deleted in r4731.
BUG=
R=andrew@webrtc.org , minyue@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2370004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5132 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-18 18:16:53 +00:00
e8433eb115
Reimplementing NetEq4's AudioVector
...
The current implementation using std::vector is too slow.
This CL introduces a new implementation, using a regular
array as data container.
In AudioMultiVector::ReadInterleavedFromIndex, a special case for
1 channel was implemented, to further reduce runtime. Finally,
AudioMultiVector::Channels was reimplemented.
The changes in this CL reduces the runtime of neteq4_speed_test
by 33%.
BUG=1363
R=turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3509004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5115 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-12 13:15:02 +00:00
3e427263ee
Reducing opus_test runtime to pass Android test
...
BUG=2609
R=solenberg@webrtc.org , tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3639004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5111 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-11 22:03:52 +00:00
57eb858698
Remove ".." from include_dirs in build/common.
...
BUG=1662
TEST=compile on trybots
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2332004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5107 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-11 10:20:27 +00:00
58cd31665c
Address Clag Analyzer issues.
...
Following are the issues related to NetEq 4, discovered by Clang Analyzer.
https://x20web.corp.google.com/~pbos/scan-build-2013-10-10-1/report-b44b95.html#EndPath
Valid; perhaps unlikely, addressed.
https://x20web.corp.google.com/~pbos/scan-build-2013-10-10-1/report-6beef6.html#EndPath
Valid, addressed.
https://x20web.corp.google.com/~pbos/scan-build-2013-10-10-1/report-2e3883.html#EndPath
Valid; Addressed
https://x20web.corp.google.com/~pbos/scan-build-2013-10-10-1/report-293659.html#EndPath
Valid; Addressed.
https://x20web.corp.google.com/~pbos/scan-build-2013-10-10-1/report-b875cd.html#EndPath
Valid; Addressed.
https://x20web.corp.google.com/~pbos/scan-build-2013-10-10-1/index.html
Not valid;
https://x20web.corp.google.com/~pbos/scan-build-2013-10-10-1/report-86f2ed.html#EndPath
Not Valid; the assert statement will be short-circuited, however I also added a check of nullity of |packet|.
https://x20web.corp.google.com/~pbos/scan-build-2013-10-10-1/report-3a5669.html#EndPath
Not Valid: |energy_input| and |energy_expand| are both non-negative, therefore if-statement condition on line 226 is not satisfied unless |energy_input| >= 1. Therefore |energy_input| cannot be zero after normalization to 14-bits, i.e. operations on lines 228 & 229.
https://x20web.corp.google.com/~pbos/scan-build-2013-10-10-1/report-2f914f.html#EndPath
Valid; addressed.
https://x20web.corp.google.com/~pbos/scan-build-2013-10-10-1/report-2332b1.html#EndPath
Valid; addressed.
https://x20web.corp.google.com/~pbos/scan-build-2013-10-10-1/report-de8dea.html#EndPath
Not valid; |out_len| is set when Process() is called, however, it makes sense to initialize to zero when declaring |out_len|.
https://x20web.corp.google.com/~pbos/scan-build-2013-10-10-1/report-b671a3.html#EndPath
Valid; addressed.
BUG=
R=henrik.lundin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2729005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5064 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-31 15:15:55 +00:00
55e1723713
Avoid a leak in AudioCodingModuleTest.TestIsac. The leak was caught by LSAN.
...
BUG=2515
TEST=reproduced locally on linux and verified the fix resolves the issue.
R=henrik.lundin@webrtc.org , kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2499004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5048 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-29 04:40:09 +00:00
fe5d36b6fe
Move RtcpStatistics to webrtc/common_types.h, to be used by vie as well.
...
We will do some refactoring of video engine and would like to use the
same rtcp stats struct there. Both video and audio seem to use 8bit
fraction lost, so that is changed in the struct as well.
BUG=
R=henrik.lundin@webrtc.org , kjellander@webrtc.org , mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2959004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5039 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-28 09:21:07 +00:00
31628aae7e
Upgrade scoped_ptr to Chromium's latest version.
...
Analogous to the recent libjingle change: http://cl/54929753-p10 .
This supports scoped_ptr<T[]> and scoped_ptr<C, FreeDeleter> rather
than scoped_array and scoped_ptr_malloc respectively.
- Add Chromium's template-based COMPILE_ASSERT. We didn't have this
previously in order to support the macro in C. Instead, move the
existing macro to compile_assert_c.h.
- Additionally copy the move.h and template_util.h depedencies and add
the WARN_UNUSED_RESULT macro.
- Leave scoped_array and scoped_ptr_malloc for now, but mark as
deprecated.
- Remove scoped_ptr foo(NULL) use. The default constructor handles it.
- Remove the now redundant COMPILE_ASSERT from peerconnection_jni.cc.
- Add a CHECK_ARRAY_SIZE macro to rtp_format_vp8_unittest.cc to remove
some repeated code.
TESTED=trybots
R=pbos@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2449005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5015 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-22 12:50:00 +00:00
621df678c8
WEBRTC_{BIG, LITTLE}_ENDIAN -> WEBRTC_ARCH_{BIG, LITTLE}_ENDIAN.
...
Mostly to remove a long-standing TODO...
TESTED=trybots
R=turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2369005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5013 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-22 10:27:23 +00:00
1871dd2fb7
NetEq4: Removing templatization for AudioVector
...
This is the last CL for removing templates in Audio(Multi)Vector.
BUG=1363
R=turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2341004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4960 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-14 20:33:25 +00:00
6d5d248075
Wrap ACM2 code inside acm2 namespace. This gurantees that one ACM would not use components of others by accident.
...
BUG=
R=minyue@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2344004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4933 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-06 04:47:28 +00:00
f31639612d
Accounting for wrap-around of timestamps.
...
BUG=
R=henrik.lundin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2340006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4932 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-06 02:21:24 +00:00
3f9288f987
Add APK and isolate target for video_engine_tests
...
Add .isolate file and _run target for video_engine_tests.
Move tools/swarm_client to be untracked in all .isolate file,
so refactorings in swarm_client doesn't require us updating
all our .isolate files (similar to the changes for the
Chromium tests done in:
https://src.chromium.org/viewvc/chrome?view=rev&revision=218844 )
Update modules_unittests.isolate with new NetEq4 reference files
needed.
TEST=trybots passing
I also setup a Chromium workspace where I patched third_party/webrtc
with the changes in this CL, followed by compiling with the settings
described in
https://code.google.com/p/webrtc/issues/detail?id=1882#c11
I then verified that the video_engine_tests_apk dir was created
in the output folder.
BUG=1916,2462
R=andrew@webrtc.org , henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2344007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4925 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-04 18:20:38 +00:00
7ee3efb0d8
Disable Receiver unittests on Android.
...
BUG=
TBR=minyue@google.com
Review URL: https://webrtc-codereview.appspot.com/2344005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4909 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-03 00:05:15 +00:00
