a1a93fba36
Roll chromium_revision 1645d3d94d..cd3b1fea2d (651391:651505)
...
Change log: 1645d3d94d..cd3b1fea2d
Full diff: 1645d3d94d..cd3b1fea2d
Changed dependencies
* src/base: fc5b2dc0e5..8b6a1456f6
* src/build: 1daeec1375..57582c144e
* src/ios: 29d29b7f20..d7fe686bf5
* src/third_party: 6006d39fc9..2dd0dc0f3a
* src/third_party/depot_tools: 4b79c3870c..7e7523be4e
* src/tools: fc26e4ab83..0e2ddb5b1a
DEPS diff: 1645d3d94d..cd3b1fea2d
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: If457a98d7e246e66989d2c6ebda7a89dff8c3835
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133400
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#27653}
2019-04-16 23:34:50 +00:00
1859dc04fd
Revert "Refactoring DataContentDescription class"
...
This reverts commit 8a9193c217d818fea77b9540bd4ca7ebad53db76.
Reason for revert: Breaks downstreams
Original change's description:
> Refactoring DataContentDescription class
>
> This CL splits the cricket::DataContentDescription class into
> two classes: cricket::DataContentDescription (used for RTP data) and
> cricket::SctpDataContentDescription (used for SCTP only).
>
> SctpDataContentDescription no longer inherits from
> MediaContentDescriptionImpl, and no longer contains "codecs".
>
> Design document:
> https://docs.google.com/document/d/1H5LfQxJA2ikMWTQ8FZ3_GAmaXM7knfVQWiSz6ph8VQ0/edit#
>
> Bug: webrtc:10358
> Change-Id: Ie7160610506aeef56d1f821b5fdb5d9492201f43
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132700
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Commit-Queue: Harald Alvestrand <hta@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#27651}
TBR=steveanton@webrtc.org ,kwiberg@webrtc.org ,hbos@webrtc.org ,hta@webrtc.org
Change-Id: I3b8a68cd481c41ce30eeb5ffbc5da735a9659019
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10358
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133360
Reviewed-by: Seth Hampson <shampson@webrtc.org >
Commit-Queue: Seth Hampson <shampson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27652}
2019-04-16 20:56:06 +00:00
8a9193c217
Refactoring DataContentDescription class
...
This CL splits the cricket::DataContentDescription class into
two classes: cricket::DataContentDescription (used for RTP data) and
cricket::SctpDataContentDescription (used for SCTP only).
SctpDataContentDescription no longer inherits from
MediaContentDescriptionImpl, and no longer contains "codecs".
Design document:
https://docs.google.com/document/d/1H5LfQxJA2ikMWTQ8FZ3_GAmaXM7knfVQWiSz6ph8VQ0/edit#
Bug: webrtc:10358
Change-Id: Ie7160610506aeef56d1f821b5fdb5d9492201f43
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132700
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27651}
2019-04-16 20:34:34 +00:00
5111c338ca
Roll chromium_revision 2e4f1b8087..1645d3d94d (650971:651391)
...
Change log: 2e4f1b8087..1645d3d94d
Full diff: 2e4f1b8087..1645d3d94d
Changed dependencies
* src/base: e92dbd2eed..fc5b2dc0e5
* src/build: 45887bbd00..1daeec1375
* src/ios: e9e306553a..29d29b7f20
* src/testing: c044935b34..8a394c7d20
* src/third_party: 082b5dec62..6006d39fc9
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/9de7d78395..73185de866
* src/third_party/depot_tools: db58954c8c..4b79c3870c
* src/third_party/libvpx/source/libvpx: c46694c1d9..da5be113f3
* src/tools: 97410bd377..fc26e4ab83
DEPS diff: 2e4f1b8087..1645d3d94d
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,marpan@webrtc.org , jianj@chromium.org ,
BUG=None
Change-Id: Ibc5bb17e0663ea54c33630086d4ea8b1624ae296
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133321
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#27650}
2019-04-16 19:39:44 +00:00
153056b059
Add ability to play audio in circle for TestAudioDevice wav file capturer
...
Also use this ability in PC smoke test.
Bug: webrtc:10138
Change-Id: I83d526344f203082a19377d9642c9e453454f7ad
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133163
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27649}
2019-04-16 15:33:03 +00:00
50150a18f4
Delete VCMJitterBuffer::UpdateRtt and related unused code
...
Bug: webrtc:7408
Change-Id: Ic4bd745ed36dd7f7d5eec6531e05204035a545fd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133188
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27648}
2019-04-16 15:13:13 +00:00
034f1916b5
Revert "Add more adaptation text logs for VideoSendStream."
...
This reverts commit d0298f4b161fe2afd4c6b334da31218c115a7eeb.
Reason for revert: This change makes the text output for three simulcast layers dangerously close to 1024 characters. Will reland with a larger value.
Original change's description:
> Add more adaptation text logs for VideoSendStream.
>
> Tested: Manual tests in app.
> Bug: None
> Change-Id: I2739a23d37c05cbe1ba9be5c788d1c647265a895
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133186
> Reviewed-by: Niels Moller <nisse@webrtc.org >
> Commit-Queue: Rasmus Brandt <brandtr@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#27644}
TBR=brandtr@webrtc.org ,nisse@webrtc.org
Change-Id: Ic6c0c863f6e4aba12feb6c6938db2930396c32f4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133204
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27647}
2019-04-16 14:46:57 +00:00
dd1c16f00c
Use absl::make_unique in TestAudioDeviceModule factory methods
...
Bug: webrtc:10138
Change-Id: Ibe9f4b4343b8e5c9a5e1a6d41bd06b24d69db878
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133166
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27646}
2019-04-16 14:43:55 +00:00
7eb4248b02
Delete unused class Vp9SsMap
...
Appears unused since https://codereview.webrtc.org/1426813002
Bug: webrtc:7408
Change-Id: I13b8c35548314705eaf31ff2366636f358fef718
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133203
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27645}
2019-04-16 14:36:55 +00:00
d0298f4b16
Add more adaptation text logs for VideoSendStream.
...
Tested: Manual tests in app.
Bug: None
Change-Id: I2739a23d37c05cbe1ba9be5c788d1c647265a895
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133186
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27644}
2019-04-16 13:52:53 +00:00
7d204d5ce9
Disallow buffer level filtering for DTX packets.
...
We knew that we should not update buffer level during DTX period. We already fulfill this upon no packet receipt. But we missed doing it for DTX-signaling packets. This CL is to fix that.
Bug: b/129521878
Change-Id: I72ca18e3b21e956123fe6e3119ef0d7c981c9eec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133183
Commit-Queue: Minyue Li <minyue@webrtc.org >
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org >
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27643}
2019-04-16 13:31:32 +00:00
494947bbcf
Remove direct use of FieldTrials from modules/remote_bitrate_estimator
...
Instead use WebRtcKeyValueConfig and FieldTrialBasedConfig
BUG=webrtc:10335
Change-Id: Ie148cb466f86d8fa1ded5c7f125fbcccf6e7dbe3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132714
Commit-Queue: Per Kjellander <perkj@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27642}
2019-04-16 13:23:12 +00:00
bfb735b5a1
Exclude RTX from pacer delay plots
...
This is because padding (sent as RTX) makes the plot unreadable.
TBR=terelius@webrtc.org
Bug: None
Change-Id: Iddf681eab6ec826c6f3c620aac65e2bd6f31b895
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133182
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27641}
2019-04-16 13:05:52 +00:00
70c2db1aa0
Reland "Make negotiationneeded processing in PeerConnection spec compliant."
...
The new processing applies only in Unified Plan mode.
Plan B retains the old-style processing.
This is a reland of 1fa06041bcd8a0119e557d16e7b54a9110c5ad03
Original change's description:
> Make negotiationneeded processing in PeerConnection spec compliant.
>
> This CL fixes the problem of misfired negotiationneeded notifications due
> to the lack of a NegotiationNeeded slot and the proper procedure to
> update it.
>
>
> Change-Id: Ie273c691f11316c9846606446f6cf838226b5d5c
> Bug: chromium:740501
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/131283
> Commit-Queue: Guido Urdaneta <guidou@webrtc.org >
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Reviewed-by: Henrik Boström <hbos@webrtc.org >
> Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#27594}
Bug: chromium:740501
Change-Id: I048ae81b2b00086f6d669e94eecf426f0db0ec08
TBR: steveanton@webrtc.org
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133162
Commit-Queue: Guido Urdaneta <guidou@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27640}
2019-04-16 12:04:33 +00:00
c3f31dc395
Avoid copying of InlinedVector by DefaultTemporalLayers ctor
...
Bug: None
Change-Id: I31767a97ad5438001b6fc348157ef25a97ed6168
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133180
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Elad Alon <eladalon@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27639}
2019-04-16 10:50:41 +00:00
a7e78f24dd
Default enabling decoding on task queue.
...
Bug: webrtc:10365
Change-Id: I3e367129317e7a7f7f1e1531d7013e07ca5101bb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133160
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27638}
2019-04-16 09:53:34 +00:00
eb02a76b36
Allow negative delta in EventRateCounter.
...
Bug: webrtc:10365
Change-Id: I13192d1e179ef5637210cfea3e67010d00117957
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133025
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27637}
2019-04-16 09:32:42 +00:00
6cf61f53ad
Delete unneeded includes of async_invoker.h
...
Bug: None
Change-Id: I3753592f8eb53eb2b31cf645b80c446bd2251404
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133027
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27636}
2019-04-16 07:28:06 +00:00
a4c22b9662
Using NetworkEmulationManager in Scenario tests.
...
Bug: webrtc:9510
Change-Id: Ib619526269c58f0c46c0c1f01ba6c0efa5f79ba5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132781
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27635}
2019-04-16 06:24:26 +00:00
884adca3a0
Log details when RtpDemuxer fails to deliver a packet
...
Bug: None
Change-Id: Ie9dc5c3c545073d2e43b464d2585cb945eb346fb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/131360
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Amit Hilbuch <amithi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27634}
2019-04-16 00:47:53 +00:00
6df49d8983
Fixing issue with creating StreamParams when track id is not signaled.
...
Current logic requires a stream id and track ids when creating a stream
that does not have SSRCs signaled.
This change removes the requirement for stream ids. The requirement for
track id is softer, as one should be generated when it is not present.
Bug: webrtc:10551
Change-Id: Ibc0cc181c6b18efa8394b6c0e4820e3a13da70c4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133080
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Amit Hilbuch <amithi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27633}
2019-04-16 00:34:04 +00:00
53625ca8ab
Roll chromium_revision a35784fb06..2e4f1b8087 (650856:650971)
...
Change log: a35784fb06..2e4f1b8087
Full diff: a35784fb06..2e4f1b8087
Changed dependencies
* src/base: 8beae815b0..e92dbd2eed
* src/build: 7c4aed4851..45887bbd00
* src/buildtools: 218cb3d12e..d5c58b84d5
* src/buildtools/third_party/libc++/trunk: fbddc46986..9b96c3dbd4
* src/ios: 468d16d887..e9e306553a
* src/third_party: 1b3f717046..082b5dec62
* src/third_party/r8: SlcbUnEufAQ-iuOwGOl8yYQuctmpf7bMqh59kBfpil0C..BReCwfbVwCNM2Ry4QpnrwlE3Y5gPJ2rRoyMbxFS0-4UC
* src/tools: ff070cdf4a..97410bd377
DEPS diff: a35784fb06..2e4f1b8087
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ie44fc059c61e2dbb26be7508ab9de53c940e25f8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133017
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#27632}
2019-04-15 21:50:51 +00:00
5d97f552ba
Allow injection of time controller to NetworkEmulationManagerImpl.
...
Bug: webrtc:10365
Change-Id: I6a0e04459f75e8134787e605057dcb03cae55cd8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132780
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27631}
2019-04-15 18:53:24 +00:00
2f92b414ae
Roll chromium_revision 8d55ca9363..a35784fb06 (650742:650856)
...
Change log: 8d55ca9363..a35784fb06
Full diff: 8d55ca9363..a35784fb06
Changed dependencies
* src/base: 39249a7fe2..8beae815b0
* src/build: 3b075157b4..7c4aed4851
* src/ios: 1fa5b61040..468d16d887
* src/third_party: dd3857ca4d..1b3f717046
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/b614c567e8..9de7d78395
* src/tools: dc8f3b2879..ff070cdf4a
DEPS diff: 8d55ca9363..a35784fb06
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Icfcd4f6a1b83e903d0907294c1f282d6a80b17fa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133061
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#27630}
2019-04-15 18:31:24 +00:00
2bab5ad3b1
AEC3: Avoid using filter output in suppression gain computation in non-linear mode
...
As non-linear mode uses a suppressed version of y (not e) as output, this change
uses Y2, rather than E2, as nearend spectrum when computing the suppression gains.
E2 is still used in linear mode.
This change also affects how the minimum suppression gains are calculated. The
minimum gain is now min_echo_power / weighted_residual_echo.
Bug: webrtc:10550
Change-Id: I2904c5a09dd64b06bf25eb5a37c18dab50297794
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133023
Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org >
Reviewed-by: Per Åhgren <peah@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27629}
2019-04-15 16:08:41 +00:00
01738c63aa
Wire up RTCInboundRtpStreamStats.lastPacketReceivedTimestamp.
...
This collects this metric for both audio and video streams.
https://w3c.github.io/webrtc-stats/#dom-rtcinboundrtpstreamstats-lastpacketreceivedtimestamp
This is a follow-up to https://webrtc-review.googlesource.com/c/src/+/130479
which calculated this metric. This CL is purely plumbing from
"StreamDataCounters::last_packet_received_timestamp_ms" to
RTCInboundRtpStreamStats.
Bug: webrtc:10449
Change-Id: I757ad19b5b8e84553da5edd4a75efa3e1fe30b56
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/131397
Commit-Queue: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27628}
2019-04-15 16:06:01 +00:00
3d11e2f81c
Allow encoder target bitrate to reach media rate if there is headroom.
...
This CL adds a field trial that enables the EncoderBitrateAdjuster to
allow higher target bitrate if we are not network constrained. We still
don't allow the bitrate to go higher than the average target media rate
though.
Bug: webrtc:10155
Change-Id: Id5995070aa0cbe84b9305a422279141b38664bb1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132717
Commit-Queue: Erik Språng <sprang@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27627}
2019-04-15 15:11:39 +00:00
f9846bc172
Adding DTX logic to FakeDecodeFromFile (used be NetEqTest).
...
Bug: b/129521878
Change-Id: Ifcf868048a39ef1d2cc736988479f921e668167b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132799
Commit-Queue: Minyue Li <minyue@webrtc.org >
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org >
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27626}
2019-04-15 15:03:39 +00:00
72b7524d87
Adds more stats to CallStatsCollector.
...
Also adding checks to avoid adding empty stats.
Bug: webrtc:10365
Change-Id: I37ab32a3d4271fcad419f17841a8d2e524d73245
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133020
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27625}
2019-04-15 14:47:56 +00:00
df88cc014a
Allow injection of network estimator into GoogCC.
...
Bug: webrtc:10498
Change-Id: Ie9225411db201dfcfa0a37a3c40992acbdc215bb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132402
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org >
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27624}
2019-04-15 14:12:08 +00:00
ef86d1413e
Refactor of SimulationNode.
...
This prepares for using network emulation manager in Scenario tests.
Bug: webrtc:9510
Change-Id: I6ae1b21790d0bcd2b01a3b293231d0859afc1ac8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132719
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27623}
2019-04-15 14:11:00 +00:00
54c6640efb
Disallow time stretching during DTX.
...
Bug: b/129521878
Change-Id: I32f60c661c6cae001840c9fe83fc848fe23acabc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132789
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org >
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Commit-Queue: Minyue Li <minyue@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27622}
2019-04-15 14:05:11 +00:00
ff7730d2ba
Reland "Fix threading model of video quality test with audio enabled"
...
This is a reland of f537da6c194d2c021709a255563c27b261e92488
Original change's description:
> Fix threading model of video quality test with audio enabled
>
> Bug: None
> Change-Id: Ifb7fc57df54ec4d0a6f8c7f0504f3c06de6ac756
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130514
> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
> Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org >
> Commit-Queue: Artem Titov <titovartem@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#27413}
Bug: None
Change-Id: I4fb793a5a5f636103159ed537847d6f2deb60108
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132797
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27621}
2019-04-15 14:04:09 +00:00
6796ec2289
Add OnFrameDropped() to Vp8FrameBufferController
...
Prior to this CL, this was indicated by passing |size_bytes| = 0
to the method.
Bug: webrtc:10501
Change-Id: Icff3bb83344834dc62d62bde5ec5d05096a08e11
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132712
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Commit-Queue: Elad Alon <eladalon@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27620}
2019-04-15 12:35:45 +00:00
7e53be0555
NetEQ: GenerateBackgroundNoise moved to BackgrounNoise
...
Bug: webrtc:10548
Change-Id: Ie9da0755793078b81c60c3751abcbff13da40ede
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132788
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27619}
2019-04-15 12:23:15 +00:00
9a2ca0a9d8
Reland "Adds more performance stats collection to scenario tests."
...
This is a reland of 63b0b2cf307b47bae3c10b295ece9a5f6d9bd7a4
Original change's description:
> Adds more performance stats collection to scenario tests.
>
> Bug: webrtc:10365
> Change-Id: I66dce6ff21242c30af674f89fc9fd19172d4a3af
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/131948
> Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#27585}
Bug: webrtc:10365
Change-Id: Id7ddb64ac17ecbb4de223dec497bc562040ba7c4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132711
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27618}
2019-04-15 12:13:45 +00:00
5b69873cb5
Remove direct use of FieldTrials from AlrDetector
...
Instead use WebRtcKeyValueConfig and FieldTrialBasedConfig.
The purpose is to allow a user of GoogCC to use different settings on different instances.
BUG=webrtc:10335
Change-Id: I2f837688c9fdd341eecb44484cc784b1c80da1a9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132791
Commit-Queue: Per Kjellander <perkj@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27617}
2019-04-15 12:11:36 +00:00
315de596b0
Switch to RTC_LOG(LS_INFO) for non-perf VideoCodecTest text output.
...
This allows picking up the output in Android tests, where stdout/stderr
is lost but RTC_LOGs are picked up by the org.webrtc.Logging utility.
Tested: Downstream Android tests.
Bug: webrtc:10349
Change-Id: I1379f4303640dbc9621c64d9c88cf61bc8447ab6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132704
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org >
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27616}
2019-04-15 12:08:15 +00:00
7a3fe89138
Tweak libvpx vp8/vp9 encoder rc settings based on network headroom.
...
This CL adds an experiment where aggressiveness of the rate controller
is tuned based on if the application is network constrained or not.
Bug: webrtc:10155
Change-Id: I6c8cd116f57321c5b36cf5a69840913936091aaa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132786
Commit-Queue: Erik Språng <sprang@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27615}
2019-04-15 11:59:15 +00:00
2bc59b694d
Roll chromium_revision 1a9381db11..8d55ca9363 (650638:650742)
...
Change log: 1a9381db11..8d55ca9363
Full diff: 1a9381db11..8d55ca9363
Changed dependencies
* src/base: 33bd4113ea..39249a7fe2
* src/build: 04652ffae5..3b075157b4
* src/ios: 8400f7ed73..1fa5b61040
* src/third_party: afb2cae9e4..dd3857ca4d
* src/tools: ed1420200f..dc8f3b2879
DEPS diff: 1a9381db11..8d55ca9363
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I1649a5fcddf68aa0014843add8d404262262217c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133011
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#27614}
2019-04-15 11:36:15 +00:00
1bc995a1cb
WebRtcSpl AffineTransform: make input const
...
Bug: webrtc:10548
Change-Id: I4241dfe7ba282270422f8f8e90a8e5a439d3031c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132787
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27613}
2019-04-15 10:27:55 +00:00
0046697841
AEC3: Remove unused parameter from GetGain
...
Bug: webrtc:8671
Change-Id: Id227d3d5ddfe3b2d08509215e082e3c759f8212b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132794
Reviewed-by: Per Åhgren <peah@webrtc.org >
Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27612}
2019-04-15 10:23:50 +00:00
98da0bd54a
AEC3: Remove unused code from residual echo estimator
...
Bug: webrtc:8671
Change-Id: Id2f711223826e71072dda343fc22ee996532a33a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132793
Reviewed-by: Per Åhgren <peah@webrtc.org >
Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27611}
2019-04-15 10:22:45 +00:00
d3ba236686
Stop using GlobalTaskQueueFactory in video unittests
...
instead use DefaultTaskQueueFactory directly
Bug: webrtc:10284
Change-Id: I58ae120cf185553d0145d7feb365deca90a93bc5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132401
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27610}
2019-04-15 09:24:18 +00:00
6a0aad9260
Temporary switch back to generated audio to fix test flakes
...
Wav file capturer won't repeat file or produce silence after file end and
WebRTC pipeline will crash in such case. In future we need to make it
possible to continue audio after file was ended to behalf in the same
way as video files capturer.
Bug: webrtc:10138
Change-Id: I35f5bd33790cd430a56002a44af0abb894a96d29
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132795
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27609}
2019-04-15 09:22:28 +00:00
9466b66ed9
AEC3: No update of filter delay when linear filter is disabled
...
Bug: b/130016532
Change-Id: I535013521e87097df6dae772770666ac0631b777
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132790
Reviewed-by: Per Åhgren <peah@webrtc.org >
Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27608}
2019-04-15 09:04:58 +00:00
8607f843a7
Change unittests to use AEC3 instead of AEC2
...
This CL changes the APM unittests to use AEC3 instead of
AEC2.
Bug: webrtc:8671
Change-Id: I80f88dbafb7c31696abd8b7efb5a187a9fb30d1c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/129420
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org >
Commit-Queue: Per Åhgren <peah@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27607}
2019-04-15 07:33:52 +00:00
30f36af455
Roll chromium_revision 8b06d91a08..1a9381db11 (650536:650638)
...
Change log: 8b06d91a08..1a9381db11
Full diff: 8b06d91a08..1a9381db11
Changed dependencies
* src/base: e43924518f..33bd4113ea
* src/build: 9afb652e66..04652ffae5
* src/third_party: 70e17dbf65..afb2cae9e4
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/5b353de6da..b614c567e8
* src/third_party/icu: 4ae7482a0e..35f7e139f3
* src/tools: 376cc4e548..ed1420200f
DEPS diff: 8b06d91a08..1a9381db11
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I390bdf28e5ba5c47eaff008b7887102c4a3e13c9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132981
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#27606}
2019-04-14 04:18:03 +00:00
79e9f4b9c1
Replace test::Statistics by webrtc::RunningStatistics.
...
The former became redundant and didn't guarantee
numerical stability for variance computation.
Bug: webrtc:10412
Change-Id: Idc291abe9add41bde9e7734f179e5d6c65f2630b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132460
Commit-Queue: Yves Gerey <yvesg@google.com >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27605}
2019-04-13 17:55:27 +00:00
0006a625b1
Remove HKDF implementation from WebRTC.
...
We no longer have a need for a HKDF implementation in WebRTC. To keep
code quality high it makes sense to delete this dead code path.
Bug: webrtc:9600
Change-Id: Ibe6ee9150acd9dbf59452372242d857c5ffa65c4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132802
Reviewed-by: Peter Slatala <psla@webrtc.org >
Reviewed-by: Qingsi Wang <qingsi@webrtc.org >
Reviewed-by: Seth Hampson <shampson@webrtc.org >
Commit-Queue: Benjamin Wright <benwright@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27604}
2019-04-13 00:53:44 +00:00