Commit Graph

10380 Commits

Author SHA1 Message Date
66679dcc04 Update WARN_UNUSED_RESULT macro to match Chromium's version.
It also matches the one in webrtc/base/common.h

BUG=None
R=tommi@webrtc.org

Review URL: https://codereview.webrtc.org/1516423004

Cr-Commit-Position: refs/heads/master@{#10998}
2015-12-12 13:47:24 +00:00
be26c07cb5 Roll gtest-parallel.
BUG=
R=kwiberg@webrtc.org

Review URL: https://codereview.webrtc.org/1519153002

Cr-Commit-Position: refs/heads/master@{#10997}
2015-12-12 09:45:28 +00:00
b798f3883c Roll chromium_revision 710285b..7de03ed (364599:364770)
Change log: 710285b..7de03ed
Full diff: 710285b..7de03ed

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1520583007

Cr-Commit-Position: refs/heads/master@{#10996}
2015-12-12 08:24:09 +00:00
f888bb58da Support for unmixed remote audio into tracks.
BUG=chromium:121673
R=solenberg@webrtc.org

Review URL: https://codereview.webrtc.org/1505253004 .

Cr-Commit-Position: refs/heads/master@{#10995}
2015-12-12 00:37:14 +00:00
f67c548576 Handle Turn error response to RefreshRequest, CreatePermissionRequest, and ChanelBindRequest
BUG=webrtc:5116
R=pthatcher@webrtc.org

Review URL: https://codereview.webrtc.org/1453823004 .

Cr-Commit-Position: refs/heads/master@{#10994}
2015-12-11 23:16:58 +00:00
04e9146e58 Discard old-generation candidates when ICE restarts
The existing code only do so on the controlled side.

BUG=webrtc:5291
R=pthatcher@webrtc.org

Review URL: https://codereview.webrtc.org/1496693002 .

Cr-Commit-Position: refs/heads/master@{#10993}
2015-12-11 22:26:43 +00:00
43e4e23eeb Remove thread-id wraparounds in event tracing.
Prints tid as a DWORD on Windows and an int on other systems.

BUG=
R=thakis@chromium.org, tommi@webrtc.org

Review URL: https://codereview.webrtc.org/1522483002 .

Cr-Commit-Position: refs/heads/master@{#10992}
2015-12-11 19:29:47 +00:00
822bdf9784 Remove cricket::VideoEncoderConfig.
BUG=webrtc:5332
R=noahric@chromium.org, pthatcher@webrtc.org

Review URL: https://codereview.webrtc.org/1512853007 .

Cr-Commit-Position: refs/heads/master@{#10991}
2015-12-11 18:54:46 +00:00
4c1093b86f Add FEC producer fuzzing and a unittest for one of the issues found.
BUG=webrtc:4800
R=pbos@webrtc.org

Review URL: https://codereview.webrtc.org/1522463002 .

Cr-Commit-Position: refs/heads/master@{#10990}
2015-12-11 17:25:56 +00:00
5b659c0d10 Special-case android-arm64 in codec bitexactness tests
We already had a special case for android, but it only worked for arm32.

BUG=webrtc:4198, webrtc:4199

Review URL: https://codereview.webrtc.org/1512833003

Cr-Commit-Position: refs/heads/master@{#10989}
2015-12-11 15:34:05 +00:00
b562c33f15 Remove ancient VoE suppressions.
BUG=webrtc:332

Review URL: https://codereview.webrtc.org/1511413007

Cr-Commit-Position: refs/heads/master@{#10988}
2015-12-11 13:32:42 +00:00
cb23c0d984 Adding Opus to RTPencode.
As a step toward fixing webrtc:3987, here we update the RTPencode to allow Opus RTP payloads.

BUG=webrtc:3987, webrtc:2692

Review URL: https://codereview.webrtc.org/1516653003

Cr-Commit-Position: refs/heads/master@{#10987}
2015-12-11 09:58:31 +00:00
Per
71f5a9a377 This cl change VideoCaptureAndroid to handle CVO the same way when capturing to texture as when using ordinary byte buffers.
Ie, rotation is applied in C++ in the VideoFrameFactory is  apply_rotation_ is set. If not, rotation is sent in RTP.

BUG=webrtc:4993
R=nisse@chromium.org

Review URL: https://codereview.webrtc.org/1493913007 .

Cr-Commit-Position: refs/heads/master@{#10986}
2015-12-11 08:32:50 +00:00
0b0a88b918 Add aecdump support to AppRTCDemo
Review URL: https://codereview.webrtc.org/1514473008

Cr-Commit-Position: refs/heads/master@{#10985}
2015-12-11 07:28:50 +00:00
4dfe332d19 Roll chromium_revision 026b937..710285b (364421:364599)
Change log: 026b937..710285b
Full diff: 026b937..710285b

Changed dependencies:
* src/buildtools: b747a9e..68e3c23
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/6d9e5a7..afd565f
DEPS diff: 026b937..710285b/DEPS

No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1516963003

Cr-Commit-Position: refs/heads/master@{#10984}
2015-12-11 04:22:24 +00:00
55bcf0f087 Fix -Wformat error in Win-Clang build (take 2)
I managed to cast the wrong parameter in #10982 :-(

BUG=82385

Review URL: https://codereview.webrtc.org/1520493003

Cr-Commit-Position: refs/heads/master@{#10983}
2015-12-11 03:49:30 +00:00
013e83b31c Fix -Wformat error in Win-Clang build
rtc::PlatformThreadId is pid_t (32-bit signed int) on Linux and Mac,
but DWORD (32-bit unsigned int) on Windows.

Using the %d printf specifier is therefore not correct on Windows,
and Clang would warn about it:

..\..\third_party\webrtc\base\event_tracer.cc(124,46) :  error: format specifies
type 'int' but the argument has type 'rtc::PlatformThreadId' (aka 'unsigned
long') [-Werror,-Wformat]
                e.phase, e.timestamp, e.pid, e.tid);
                                             ^~~~~

This commit fixes the problem by explicitly casting to int before printing.

BUG=82385

Review URL: https://codereview.webrtc.org/1514253002 .

Cr-Commit-Position: refs/heads/master@{#10982}
2015-12-11 00:17:03 +00:00
cf846ad60a Adding stub files needed for https://codereview.webrtc.org/1507973003/
TBR=pthatcher@webrtc.org

Review URL: https://codereview.webrtc.org/1519683002 .

Cr-Commit-Position: refs/heads/master@{#10981}
2015-12-10 23:52:12 +00:00
7c73bdbd82 Renaming JsepPeerConnectionP2PTestClient back to P2PTestConductor.
Updating blacklists as well.

Review URL: https://codereview.webrtc.org/1508683004

Cr-Commit-Position: refs/heads/master@{#10980}
2015-12-10 23:10:52 +00:00
ed83edc9e5 Roll chromium_revision 2e451bf..026b937 (364330:364421)
Change log: 2e451bf..026b937
Full diff: 2e451bf..026b937

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1517793002

Cr-Commit-Position: refs/heads/master@{#10979}
2015-12-10 21:45:55 +00:00
6a6f0893dd in rtp_rtcp module:
fixed build/namespaces lint errors
  fixed readability/namespace lint errors

BUG=webrtc:5277
R=mflodman,stefan@webrtc.org

Review URL: https://codereview.webrtc.org/1506823002

Cr-Commit-Position: refs/heads/master@{#10978}
2015-12-10 20:39:16 +00:00
a1f567ae90 Revert of Free SCTP data channels asynchronously in PeerConnection. (patchset #3 id:40001 of https://codereview.webrtc.org/1492383002/ )
Reason for revert:
Breaks WebrtcTransportTest.DataStream, due to different rtc::Thread implementation on Chromium.

Original issue's description:
> Free SCTP data channels asynchronously in PeerConnection.
>
> This is needed so that the data channel isn't deleted while one of its
> own methods is on the call stack.
>
> BUG=565048
>
> Committed: https://crrev.com/386869247f28e72a00307a1b5c92465eea343ad2
> Cr-Commit-Position: refs/heads/master@{#10923}

TBR=pthatcher@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=565048

Review URL: https://codereview.webrtc.org/1513143003

Cr-Commit-Position: refs/heads/master@{#10977}
2015-12-10 19:17:47 +00:00
61a90f94b6 clang/win: Fix -Wextra warnings in webrtc.
Fixes one sign mismatch warning, and one "const has no effect and is
ignored" warning.

BUG=chromium:567877

Review URL: https://codereview.webrtc.org/1510233002

Cr-Commit-Position: refs/heads/master@{#10976}
2015-12-10 18:50:36 +00:00
5c1def8892 modules/rtp_rtcp/include folder cleared of lint warnings
Functions that do not follow lint are marked deprecated, including function in the interface.

BUG=webrtc:5308
R=mflodman@webrtc.org

Review URL: https://codereview.webrtc.org/1493403003

Cr-Commit-Position: refs/heads/master@{#10975}
2015-12-10 17:52:01 +00:00
796cfaf7f7 Add VideoCodec::PreferDecodeLate
The purpose is so that a decoder (Android) that only have a limited number of output buffers can make sure that decoding is done just before the frame is needed.

Removed unused iSupportsRenderTiming and the settings structs since it was not used.
Added VCMReceiver::FrameForDecoding unit test for the case when PreferDecodeLate is set.

Note that this does not change the current behaviour. We actually currently always decode frames late. This cl is to make sure the behaviour is kept for Android, if the default behaviour is changed.

Review URL: https://codereview.webrtc.org/1428293003

Cr-Commit-Position: refs/heads/master@{#10974}
2015-12-10 17:27:45 +00:00
4d68208a20 Reduce the runtime of some ACM tests in modules_tests
By reducing the length of the audio input, the total runtime of
$ out/Debug/modules_tests --gtest_filter=AudioCodingModuleTest.*
is reduced by more than 10x, when run single-threaded.

The PCMFile helper class is extended with a FastForward method (to
skip initial silence in the test files) and a limiter on how much to
read.

BUG=webrtc:2463
R=ivoc@webrtc.org

Review URL: https://codereview.webrtc.org/1513223002 .

Cr-Commit-Position: refs/heads/master@{#10973}
2015-12-10 15:24:50 +00:00
c490e01bd1 Implement NativeToI420Buffer in C++, calling java SurfaceTextureHelper, new method .textureToYUV, to
do the conversion using an opengl fragment shader.

BUG=webrtc:4993

Review URL: https://codereview.webrtc.org/1460703002

Cr-Commit-Position: refs/heads/master@{#10972}
2015-12-10 14:23:42 +00:00
b8b6fbb7a5 lint build/include errors fixed in rtp_rtcp module
BUG=webrtc:5277
R=mflodman

Review URL: https://codereview.webrtc.org/1505993003

Cr-Commit-Position: refs/heads/master@{#10971}
2015-12-10 13:05:35 +00:00
90b9fc9214 Roll chromium_revision a02d286..2e451bf (364268:364330)
Change log: a02d286..2e451bf
Full diff: a02d286..2e451bf

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1511743005

Cr-Commit-Position: refs/heads/master@{#10970}
2015-12-10 12:30:37 +00:00
866df6602c Typo fix: Enable a bunch of tests that were accidentally disabled
They were meant to be run if we have either iSAC float or fix, but the
typo made them run for just float.

BUG=webrtc:4198, webrtc:4199

Review URL: https://codereview.webrtc.org/1513483005

Cr-Commit-Position: refs/heads/master@{#10969}
2015-12-10 12:20:06 +00:00
5811a39f14 Replace EventWrapper in video/, test/ and call/.
Makes use of rtc::Event which is simpler and can be used without
allocating additional objects on the heap.

Does not modify test/channel_transport/.

BUG=
R=mflodman@webrtc.org

Review URL: https://codereview.webrtc.org/1487893004 .

Cr-Commit-Position: refs/heads/master@{#10968}
2015-12-10 12:03:00 +00:00
0f2e939a92 Enable cpplint for more webrtc subfolders and fix all uncovered cpplint errors.
This CL enableds cpplint for webrtc/common_video, webrtc/sound and webrtc/tools.

BUG=webrtc:5273

TESTED=Fixed issues reported by:
find webrtc/common_video webrtc/sound webrtc/tools -type f -name *.cc -o -name *.h | xargs cpplint.py
followed by 'git cl presubmit'.

Review URL: https://codereview.webrtc.org/1511603004

Cr-Commit-Position: refs/heads/master@{#10967}
2015-12-10 11:11:48 +00:00
162abd3562 lint whitespace warning removed from most rtp_rtcp/source/ files
rtcp_utility, rtp_utility, tmmbr_help, rtcp_receiver, rtcp_receiver_help are explicetly excluded from the cleanup becaues there are short plans (or cls) to do a deeper cleaning there.

BUG=webrtc:5277
R=pbos@webrtc.org, mflodman@webrtc.org

Review URL: https://codereview.webrtc.org/1512493002

Cr-Commit-Position: refs/heads/master@{#10966}
2015-12-10 10:39:45 +00:00
84e78f9102 Rewrote the PRNG using an xorshift* algorithm and moved the files from test/ to base/.
Created a simple unit test for the new random number generator. (It mostly tests
that the generated numbers are consistent with the intended distribution, e.g. uniform.
It is not a comprehensive test of the quality of the random numbers.)

Several assertions in OveruseDetectorTest seem to depend on the exact sequence of random numbers. I updated those numbers to work with the new PRNG.

Compute the standard deviation of the expected result in TestReorderFilter instead of passing an uncertainty parameter.

BUG=webrtc:5177

Review URL: https://codereview.webrtc.org/1457023002

Cr-Commit-Position: refs/heads/master@{#10965}
2015-12-10 09:51:02 +00:00
0b3d7eec07 Prevent RTCP SR to be sent with bogus timestamp.
This CL makes sure no RTCP SR is sent before there is a valid timestamp
to set in the SR, based on the first sent media packet.

BUG=webrtc:1600
R=stefan@webrtc.org

Review URL: https://codereview.webrtc.org/1506103006 .

Cr-Commit-Position: refs/heads/master@{#10964}
2015-12-10 09:10:54 +00:00
48bf2382d9 Some further minor bitexact APM echo suppressor refactoring
-Moved memsets to where their variables are used.
-Removed redundant.
-Changed a pointer scalar to be accessed in pointer notation rather than
 in array notation.

The change has been tested for bitexactness.

BUG=webrtc:5201

Review URL: https://codereview.webrtc.org/1494473006

Cr-Commit-Position: refs/heads/master@{#10963}
2015-12-10 05:24:56 +00:00
5ba58c6735 Roll chromium_revision dad6346..a02d286 (363782:364268)
Change log: dad6346..a02d286
Full diff: dad6346..a02d286

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1509323004

Cr-Commit-Position: refs/heads/master@{#10962}
2015-12-10 05:23:10 +00:00
a6e4328680 Remove unnecessary test code on Windows.
BUG=chromium:568266,chromium:567264
R=niklas.enbom@webrtc.org

Review URL: https://codereview.webrtc.org/1506203006 .

Cr-Commit-Position: refs/heads/master@{#10961}
2015-12-09 22:28:08 +00:00
70625e5bf3 Enable cpplint for webrtc/examples and fix all uncovered cpplint errors.
BUG=webrtc:5273
TESTED=Fixed issues reported by:
find webrtc/examples/ -type f -name *.cc -o -name *.h | grep -v objc | xargs cpplint.py
followed by 'git cl presubmit'.

NOTRY=True

Review URL: https://codereview.webrtc.org/1504283004

Cr-Commit-Position: refs/heads/master@{#10960}
2015-12-09 22:18:20 +00:00
2e5fe31cf6 Remove myself from root_files watchlist.
TBR=kjellander@webrtc.org
NOTRY=true

Review URL: https://codereview.webrtc.org/1512083002

Cr-Commit-Position: refs/heads/master@{#10959}
2015-12-09 20:45:36 +00:00
1387149ad1 Adding reduced size RTCP configuration down to the video stream level.
Still waiting to turn on negotiation (in mediasession.cc)
until we verify it's working as expected.

BUG=webrtc:4868

Review URL: https://codereview.webrtc.org/1418123003

Cr-Commit-Position: refs/heads/master@{#10958}
2015-12-09 20:37:59 +00:00
ee4082137b WebRTC: Update set of known root certificates
Also included the script which generates this file.

TBR=juberti@webrtc.org
BUG=526258

Review URL: https://codereview.webrtc.org/1503473002 .

Cr-Commit-Position: refs/heads/master@{#10957}
2015-12-09 19:25:44 +00:00
b14f00113e Some minor (bitexact) AEC echo suppressor refactoring
-Moved filter reset from the echo suppression
 into the echo subtraction code where it belongs
 (the echo subtractor should own its filter reset).
-Moved the selection between using the microphone sinal and
 the echo subtractor output down to the lowest level in the
 EchoSuppression function. This makes sense as that selection
 was very hidden in an unrelated sub-sub-function call and
 as the selection is critical for what the AEC outputs.

The changes have been tested for bitexactness.

BUG=webrtc:5201

Review URL: https://codereview.webrtc.org/1499573003

Cr-Commit-Position: refs/heads/master@{#10956}
2015-12-09 19:07:27 +00:00
434aca8d86 Add empty placeholder files for remote audio tracks.
This is needed for Chromium so that we can roll, update libjingle.gyp and then continue.

BUG=chromium:121673

Review URL: https://codereview.webrtc.org/1514573003

Cr-Commit-Position: refs/heads/master@{#10955}
2015-12-09 17:42:03 +00:00
afeb43897a Moved code into the lowest level of EchoSuppression
to simplify future refactoring and development.

In more detail:
1) Moved the updating of eBuf from the EchoSubtraction method
   to the EchoSuppression method as it is only used in the latter.
2) Moved the computation of efw and dfw from the SubbandCoherence method
   as those are actually the analysis filterbank computation that is not
   directly related to the coherence.
3) As a consequence of 2) 3 functions needed to be replaced by the
   generic function pointer scheme used in WebRTCAec as they have
   optimized versions for SSE2 and NEON (which before were local to each
   of the aec_core*.c files.

Motivation:
Apart from making sense from a logical point of view, the changes will
a) Allow eBuf stored in half the size on the state.
b) Allow simpler switching between using the the microphone signal
   and echo subtractor output in the echo suppressor.
c) Allow further refactoring that move all the changes to eBuf to one method
   (currently those are happening in at least 4 different methods.

Drawbacks:
i) dfw is moved to EchoSuppression which increases the stack usage for that
 method. This will, however, be improved once further refactoring can be done.

The changes have been tested for bitexactness on Linux using a quite extensive dataset.

BUG=webrtc:5201

Review URL: https://codereview.webrtc.org/1494563002

Cr-Commit-Position: refs/heads/master@{#10954}
2015-12-09 16:50:29 +00:00
d1590b2571 Lint clean video/ and add lint presubmit check.
BUG=webrtc:5316

Review URL: https://codereview.webrtc.org/1507643004

Cr-Commit-Position: refs/heads/master@{#10953}
2015-12-09 15:08:05 +00:00
4cf61dd116 NetEq: Add codec name and RTP timestamp rate to DecoderInfo
The new fields are default-populated for built-in decoders, but for
external decoders, the name can now be given when registering the
decoder.

BUG=webrtc:3520

Review URL: https://codereview.webrtc.org/1484343003

Cr-Commit-Position: refs/heads/master@{#10952}
2015-12-09 14:21:02 +00:00
3980d46960 RTCCertificate::Expires() and ::HasExpired() implemented using SSLCertificate::CertificateExpirationTime().
This is a re-upload of https://codereview.webrtc.org/1494103003 which was reverted and now re-landing.

BUG=chromium:544894

Review URL: https://codereview.webrtc.org/1511753003

Cr-Commit-Position: refs/heads/master@{#10951}
2015-12-09 13:26:54 +00:00
af3b9cb4d3 Removing DrMemory suppresssion on PushResampler.
BUG=webrtc:2321
R=kjellander@webrtc.org

Review URL: https://codereview.webrtc.org/1502183006 .

Cr-Commit-Position: refs/heads/master@{#10950}
2015-12-09 12:52:09 +00:00
5eb4988c0a [rtp_rtcp] Lint build/header_guard errors fixed
BUG=webrtc:5277
R=mflodman

Review URL: https://codereview.webrtc.org/1506043003

Cr-Commit-Position: refs/heads/master@{#10949}
2015-12-09 11:32:45 +00:00